October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-msc[master]: libvlr: fix tab/space issue
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38109?usp=email ) Change subject: libvlr: fix tab/space issue ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7f831e7ee0014a2241a69f7c75f2c6404bbb7087 Gerrit-Change-Number: 38109 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Oct 2024 14:05:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: Move vlr.h & vlr_sgs.h into osmocom/vlr/
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38111?usp=email ) Change subject: Move vlr.h & vlr_sgs.h into osmocom/vlr/ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8b18b05091b35e744b3234d1ce0d537f56bccf07 Gerrit-Change-Number: 38111 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Oct 2024 14:04:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email ) Change subject: Use %d instead of %i ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Oct 2024 13:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: Release BSS connection when SS message is rejected
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: fixeria, jolly, neels, pespin. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email ) Change subject: Release BSS connection when SS message is rejected ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic6765e5d480735e67d97f0f560da24653b26d487 Gerrit-Change-Number: 38305 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Oct 2024 13:43:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: tag 0.0.5 for osmocom.construct.Asn1DerInteger
by dexter 01 Oct '24

01 Oct '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email ) Change subject: tag 0.0.5 for osmocom.construct.Asn1DerInteger ...................................................................... tag 0.0.5 for osmocom.construct.Asn1DerInteger Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 --- M debian/changelog M pyproject.toml 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index eaa9715..0b15a26 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,18 @@ +pyosmocom (0.0.5) unstable; urgency=medium + + [ Oliver Smith ] + * contrib/jenkins: run pysim tests too + * gitignore: add dirs generated with jenkins.sh + + [ Philipp Maier ] + * test_construct: move testvectors inside unittest class + * construct: move __bytes_required to utils and finish the implementation + + [ Harald Welte ] + * osmocom.construct.Asn1DerInteger + + -- Harald Welte <laforge(a)osmocom.org> Tue, 01 Oct 2024 11:24:56 +0200 + pyosmocom (0.0.4) unstable; urgency=medium * initial release diff --git a/pyproject.toml b/pyproject.toml index 863c28e..8d81d3e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ [project] name = "pyosmocom" -version = "0.0.4" +version = "0.0.5" dependencies = [ "gsm0338", "construct >= 2.9.51" -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 Gerrit-Change-Number: 38273 Gerrit-PatchSet: 10 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: tag 0.0.5 for osmocom.construct.Asn1DerInteger
by osmith 01 Oct '24

01 Oct '24

Attention is currently required from: dexter, fixeria, laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email ) Change subject: tag 0.0.5 for osmocom.construct.Asn1DerInteger ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 Gerrit-Change-Number: 38273 Gerrit-PatchSet: 10 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Oct 2024 10:19:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: tests: sanitize all cards before running tests
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: fixeria, laforge, osmith. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email ) Change subject: tests: sanitize all cards before running tests ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > actually, even the tests could probably run in parallel for each of the cards? There's no need to e […] Restoring the cards in parallel should be possible. I see no problem there. For the testsuite things are more difficult. First of all we would need to figure out how we can run python tests in parallel. Then we would need some semaphore mechanism so that only one testcase can access one card at a time. Or do you mean the classic pySim-prog tests? I think for those it should be easy. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I42eaf61280968518164f2280245136fd30a603ce Gerrit-Change-Number: 38254 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Oct 2024 09:52:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: tag 0.0.5 for osmocom.construct.Asn1DerInteger
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: fixeria, laforge, osmith. dexter has uploaded a new patch set (#10) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email ) The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: tag 0.0.5 for osmocom.construct.Asn1DerInteger ...................................................................... tag 0.0.5 for osmocom.construct.Asn1DerInteger Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 --- M debian/changelog M pyproject.toml 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/73/38273/10 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 Gerrit-Change-Number: 38273 Gerrit-PatchSet: 10 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: tag 0.0.5 for osmocom.construct.Asn1DerInteger
by dexter 01 Oct '24

01 Oct '24

Attention is currently required from: fixeria, laforge, osmith. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email ) Change subject: tag 0.0.5 for osmocom.construct.Asn1DerInteger ...................................................................... Patch Set 10: (1 comment) File debian/changelog: https://gerrit.osmocom.org/c/python/pyosmocom/+/38273/comment/1f792c28_c926… : PS7, Line 3: * osmocom.construct.Asn1DerInteger > "gbp dch" can be used for that Thanks for the hint. I have tried it and it seems to work. The patches "gitreview: new file" and "Add debian packaging for pyosmocom" are not on the list, but I guess that is because we had no changelog before "Add debian packaging for pyosmocom". -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 Gerrit-Change-Number: 38273 Gerrit-PatchSet: 10 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Oct 2024 09:34:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman: disable send_redirects
by osmith 01 Oct '24

01 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38299?usp=email ) Change subject: testenv: podman: disable send_redirects ...................................................................... testenv: podman: disable send_redirects When starting podman, set the following sysctls to avoid ICMP redirects. ICMP redirects lead to test failures (TC_pdp4_clients_interact in the GGSN testsuite), and should not be sent in the test environment in general. net.ipv4.conf.all.send_redirects=0 net.ipv4.conf.default.send_redirects=0 It is really needed to set both "all" and "default", or otherwise ICMP redirects still show up. I've seen setting both in this patch: https://patchwork.kernel.org/project/linux-kselftest/patch/1570719055-25110… Fixes: OS#6575 Change-Id: Ie27668f38b80c52ffef4e17b3fe64f0c9109bdea --- M _testenv/testenv/podman.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 0ecf12d..60aecca 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -209,6 +209,10 @@ f"{apt_dir_var_cache}:/var/cache/apt", "--volume", f"{apt_dir_var_lib}:/var/lib/apt", + "--sysctl", + "net.ipv4.conf.all.send_redirects=0", # OS#6575 + "--sysctl", + "net.ipv4.conf.default.send_redirects=0", # OS#6575 ] if not testenv.args.binary_repo: -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie27668f38b80c52ffef4e17b3fe64f0c9109bdea Gerrit-Change-Number: 38299 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0