October 2024 - gerrit-log - lists.osmocom.org

[L] Change in upf-benchmark[master]: Introduce osmo-udp-responder
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email ) Change subject: Introduce osmo-udp-responder ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7 Gerrit-Change-Number: 38328 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:57:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in upf-benchmark[master]: Introduce osmo-udp-responder
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email ) Change subject: Introduce osmo-udp-responder ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7 Gerrit-Change-Number: 38328 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:57:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_initial_ctx_setup_failure
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38280?usp=email ) Change subject: s1gw: add TC_initial_ctx_setup_failure ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I969ea6813c9b805d116a974c70ab5f6e6e721e48 Gerrit-Change-Number: 38280 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:57:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau: detect 8k AMR 7.40k frames correctly for decoding
by laforge 07 Oct '24

07 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email ) Change subject: trau: detect 8k AMR 7.40k frames correctly for decoding ...................................................................... trau: detect 8k AMR 7.40k frames correctly for decoding osmo_trau_frame_decode_8k() detects different possible frame structures by their sync pattern bits. The distinctive sync pattern of AMR 7.40k format was checked incorrectly, thereby precluding decoding of such frames. Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 966c794..8347303 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1454,7 +1454,7 @@ /*!< check sync pattern for AMR 7.4kBit/s */ static bool is_amr_74(const ubit_t *bits) { - if (bits[0] != 0 || bits[1] != 0 || bits[2] != 0) + if (bits[0] != 0 || bits[1] != 0 || bits[2] != 1) return false; if (bits[8] != 0) return false; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 Gerrit-Change-Number: 38331 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: trau 8k decode: set fr->type correctly
by laforge 07 Oct '24

07 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email ) Change subject: trau 8k decode: set fr->type correctly ...................................................................... trau 8k decode: set fr->type correctly osmo_trau_frame_decode_16k() sets fr->type to the correct OSMO_TRAU* frame type before tail-calling the respective decoding function; osmo_trau_frame_decode_8k() was failing to do likewise, resulting in fr->type not being set correctly. Fix it. Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 --- M src/trau/trau_frame.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 8347303..21e4f00 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1484,28 +1484,37 @@ if (dir == OSMO_TRAU_DIR_UL) { switch (cbits5) { /* Section 5.2.4.1.1 */ case 0x02: + fr->type = OSMO_TRAU8_SPEECH; return decode8_hr(fr, bits, dir); case 0x07: + fr->type = OSMO_TRAU8_DATA; return decode8_data(fr, bits, dir); case 0x0B: + fr->type = OSMO_TRAU8_OAM; return decode8_oam(fr, bits, dir); } } else { /* Downlink */ switch (cbits5 >> 2) { /* Section 5.2.4.1.2 */ case 0: + fr->type = OSMO_TRAU8_SPEECH; return decode8_hr(fr, bits, dir); case 1: + fr->type = OSMO_TRAU8_DATA; return decode8_data(fr, bits, dir); case 2: + fr->type = OSMO_TRAU8_OAM; return decode8_oam(fr, bits, dir); } } } else if (is_amr_low(bits)) { + fr->type = OSMO_TRAU8_AMR_LOW; return decode8_amr_low(fr, bits, dir); } else if (is_amr_67(bits)) { + fr->type = OSMO_TRAU8_AMR_6k7; return decode8_amr_67(fr, bits, dir); } else if (is_amr_74(bits)) { + fr->type = OSMO_TRAU8_AMR_7k4; return decode8_amr_74(fr, bits, dir); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 Gerrit-Change-Number: 38332 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: trau 8k decode: set fr->type correctly
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email ) Change subject: trau 8k decode: set fr->type correctly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 Gerrit-Change-Number: 38332 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:55:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau: detect 8k AMR 7.40k frames correctly for decoding
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email ) Change subject: trau: detect 8k AMR 7.40k frames correctly for decoding ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 Gerrit-Change-Number: 38331 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:55:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-iuh[master]: fix memleak in ran_decode: free after aper_decode() on error
by laforge 07 Oct '24

07 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email ) Change subject: fix memleak in ran_decode: free after aper_decode() on error ...................................................................... fix memleak in ran_decode: free after aper_decode() on error Same fix as recently [1] applied to ranap_cn_rx_co_decode() now also applied to ranap_ran_rx_co_decode() [1] 48e1f1833ff06088c875157cc912dc25c5a01c29 I03ed2376e520ec6dbcc2bae22f9291e211c7cca9 Change-Id: Idd1d10c523eddcf6d0c1d54346982d6ef6fc3799 --- M src/ranap_common_ran.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/ranap_common_ran.c b/src/ranap_common_ran.c index 048a5df..828587e 100644 --- a/src/ranap_common_ran.c +++ b/src/ranap_common_ran.c @@ -300,13 +300,15 @@ dec_ret = aper_decode(NULL, &asn_DEF_RANAP_RANAP_PDU, (void **)&pdu, data, len, 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRANAP, LOGL_ERROR, "Error in RANAP ASN.1 decode\n"); - return -1; + rc = -1; + goto error_free; } message->direction = pdu->present; rc = _ran_ranap_rx_co(ctx, pdu, message); +error_free: ASN_STRUCT_FREE(asn_DEF_RANAP_RANAP_PDU, pdu); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Idd1d10c523eddcf6d0c1d54346982d6ef6fc3799 Gerrit-Change-Number: 38333 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-iuh[master]: fix memleak in ran_decode: free after aper_decode() on error
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email ) Change subject: fix memleak in ran_decode: free after aper_decode() on error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Idd1d10c523eddcf6d0c1d54346982d6ef6fc3799 Gerrit-Change-Number: 38333 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:55:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-iuh[master]: support RAB Assignment Response 'unsuccessfulOutcome'
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: daniel, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email ) Change subject: support RAB Assignment Response 'unsuccessfulOutcome' ...................................................................... Patch Set 3: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/37393/comment/1f44bf0f_167c07b2?usp… : PS2, Line 20: Procedure", but doesn't > The way how its specified in the ASN.1 syntax: […] Context where that syntax for the PDUs of each procedure is defined, using ASN.1 information object classes: ``` WITH SYNTAX { INITIATING MESSAGE &InitiatingMessage [SUCCESSFUL OUTCOME &SuccessfulOutcome] [UNSUCCESSFUL OUTCOME &UnsuccessfulOutcome] [OUTCOME &Outcome] PROCEDURE CODE &procedureCode [CRITICALITY &criticality] } ``` so if there's no SUCCESSFUL OUTCOME and no UNSUCCESSFUL OUTCOME present in the definition of a given PROCEDURE, then it may never occur on the wire. Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/37393/comment/82d97a2b_f39707d2?usp… : PS3, Line 18: A RAB Assignment response is indicated as : 'successfulOutcome' or 'unsuccessfulOutcome' or 'outcome'. : 3GPP TS 25.413 specifies RAB Assignment as a "Class 3 Elementary : Procedure", but doesn't seem to specify which of these three 'outcome' : types to use for Class 3. In the field we've seen 'successfulOutcome' : and 'outcome'. I beg to differ. it is very clearly specified: ``` rAB-Assignment RANAP-ELEMENTARY-PROCEDURE ::= { INITIATING MESSAGE RAB-AssignmentRequest OUTCOME RAB-AssignmentResponse PROCEDURE CODE id-RAB-Assignment CRITICALITY reject } ``` no `SUCCESSFUL OTUCOME` and no `UNSUCCESSFUL OUTCOME` are possible here. If you want to do anything, then we should print an error and reject those. The fact that our code may even exercise such a path is only because we're using improper asn1 tooling that doesn't fully understand ASN.1 object information classes. A proper ASN.1 decoder would never even call the user code when receiving messages with a clear syntax error. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ifec566a98cb6141d27b9e5e33d5a78f8b1530658 Gerrit-Change-Number: 37393 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:55:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0