October 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: on RUA Connect failure, respond with RUA Disconnect
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email ) Change subject: on RUA Connect failure, respond with RUA Disconnect ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping? It's almost 4 weeks since we're waiting for feedback (incorporate or strongly argue against) some trivial review comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c Gerrit-Change-Number: 37807 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom spec...
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email ) Change subject: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: ... and this is even stuck for two minor cosmetic changes for more than three weeks. @lynxis@fe80.eu -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb Gerrit-Change-Number: 38125 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:07:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsm_04_08: define missing reject info causes
by laforge 07 Oct '24

07 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38124?usp=email ) Change subject: gsm_04_08: define missing reject info causes ...................................................................... gsm_04_08: define missing reject info causes The reject info cause is shared between CS and PS. Add the missing cause code according to TS 24.008 release 17 annex G Those should be already present in earlier release. Change-Id: I04439b76a0a50c03af4463c62027ce3b263d6e63 --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 075b6ca..f919c2b 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -2019,9 +2019,13 @@ GSM48_REJECT_PLMN_NOT_ALLOWED = 11, GSM48_REJECT_LOC_NOT_ALLOWED = 12, GSM48_REJECT_ROAMING_NOT_ALLOWED = 13, + GSM48_REJECT_NO_SUIT_CELL_IN_LA = 15, GSM48_REJECT_NETWORK_FAILURE = 17, + GSM48_REJECT_MAC_FAILURE = 20, GSM48_REJECT_SYNCH_FAILURE = 21, GSM48_REJECT_CONGESTION = 22, + GSM48_REJECT_GSM_AUTH_UNACCEPTABLE = 23, + GSM48_REJECT_NOT_AUTH_FOR_CSG = 25, GSM48_REJECT_SRV_OPT_NOT_SUPPORTED = 32, GSM48_REJECT_RQD_SRV_OPT_NOT_SUPPORTED = 33, GSM48_REJECT_SRV_OPT_TMP_OUT_OF_ORDER = 34, @@ -2042,6 +2046,8 @@ GSM48_REJECT_IMPLICITLY_DETACHED = 10, GSM48_REJECT_GPRS_NOT_ALLOWED_IN_PLMN = 14, GSM48_REJECT_MSC_TMP_NOT_REACHABLE = 16, + GSM48_REJECT_SMS_PROV_VIA_GPRS_IN_RA = 28, + GSM48_REJECT_NO_PDP_CONTEXT_ACTIVATED = 40, }; extern const struct value_string gsm48_reject_value_names[]; diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 1201595..71e0186 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -1854,9 +1854,13 @@ { GSM48_REJECT_PLMN_NOT_ALLOWED, "PLMN_NOT_ALLOWED" }, { GSM48_REJECT_LOC_NOT_ALLOWED, "LOC_NOT_ALLOWED" }, { GSM48_REJECT_ROAMING_NOT_ALLOWED, "ROAMING_NOT_ALLOWED" }, + { GSM48_REJECT_NO_SUIT_CELL_IN_LA, "NO_SUIT_CELL_IN_LA" }, { GSM48_REJECT_NETWORK_FAILURE, "NETWORK_FAILURE" }, + { GSM48_REJECT_MAC_FAILURE, "MAC_FAILURE" }, { GSM48_REJECT_SYNCH_FAILURE, "SYNCH_FAILURE" }, { GSM48_REJECT_CONGESTION, "CONGESTION" }, + { GSM48_REJECT_GSM_AUTH_UNACCEPTABLE, "GSM_AUTH_UNACCEPTABLE" }, + { GSM48_REJECT_NOT_AUTH_FOR_CSG, "NOT_AUTH_FOR_CSG" }, { GSM48_REJECT_SRV_OPT_NOT_SUPPORTED, "SRV_OPT_NOT_SUPPORTED" }, { GSM48_REJECT_RQD_SRV_OPT_NOT_SUPPORTED, "RQD_SRV_OPT_NOT_SUPPORTED" }, { GSM48_REJECT_SRV_OPT_TMP_OUT_OF_ORDER, "SRV_OPT_TMP_OUT_OF_ORDER" }, @@ -1875,6 +1879,8 @@ { GSM48_REJECT_IMPLICITLY_DETACHED, "IMPLICITLY_DETACHED" }, { GSM48_REJECT_GPRS_NOT_ALLOWED_IN_PLMN, "GPRS_NOT_ALLOWED_IN_PLMN" }, { GSM48_REJECT_MSC_TMP_NOT_REACHABLE, "MSC_TMP_NOT_REACHABLE" }, + { GSM48_REJECT_SMS_PROV_VIA_GPRS_IN_RA, "SMS_PROV_VIA_GPRS_IN_RA" }, + { GSM48_REJECT_NO_PDP_CONTEXT_ACTIVATED, "NO_PDP_CONTEXT_ACTIVATED" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I04439b76a0a50c03af4463c62027ce3b263d6e63 Gerrit-Change-Number: 38124 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsm_04_08: define missing reject info causes
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38124?usp=email ) Change subject: gsm_04_08: define missing reject info causes ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I04439b76a0a50c03af4463c62027ce3b263d6e63 Gerrit-Change-Number: 38124 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:06:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: libvlr: replace direct call of paging_expired() into a callback
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email ) Change subject: libvlr: replace direct call of paging_expired() into a callback ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping? this also seems stuck on a small naming aspect for three weeks now... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7a3d15e8f0fb51c6b32add2de5024fc4d599ecf0 Gerrit-Change-Number: 38107 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-upf[master]: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email ) Change subject: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @pespin what is your strategy about those pending patches as you now moved the tools to a new repo? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iec164a222782d382aefe8d0342f398ebba1eac05 Gerrit-Change-Number: 37757 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-sgsn[master]: Add Routing Areas
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email ) Change subject: Add Routing Areas ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: this patch has been stuck with a linter error (likely trivial to resolve) for two weeks now. I've probably opened it 5+ times during that time just to see again that its still stuck at the linker error. I'd expect such trivial fixes to happen more quickly, unless somebody is on sick leave or on holidays? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in upf-benchmark[master]: Introduce osmo-udp-responder
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email ) Change subject: Introduce osmo-udp-responder ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: a File src/osmo-udp-responder/udp_responder.c: https://gerrit.osmocom.org/c/upf-benchmark/+/38328/comment/ba3595cb_6584a16… : PS1, Line 55: st > if we implement our own cmdline parser rather than using glibc getopt_long, I would expect at least […] also, as we are about to introduce more tools here: why is that parser not in a separate .c/.h file? Is it only needed here? -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7 Gerrit-Change-Number: 38328 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:01:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[L] Change in upf-benchmark[master]: Introduce osmo-udp-responder
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email ) Change subject: Introduce osmo-udp-responder ...................................................................... Patch Set 1: (1 comment) File src/osmo-udp-responder/udp_responder.c: https://gerrit.osmocom.org/c/upf-benchmark/+/38328/comment/381455a3_1a221c1… : PS1, Line 55: st if we implement our own cmdline parser rather than using glibc getopt_long, I would expect at least some kind of comment on why this is required. So let's please add a comment that explains what this parser does different from getopt_long and why we need it to achieve our goal. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7 Gerrit-Change-Number: 38328 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in upf-benchmark[master]: Introduce osmo-udp-simpleflood
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38329?usp=email ) Change subject: Introduce osmo-udp-simpleflood ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I389c75054f769b7ca93a56f7085b1694e999aa04 Gerrit-Change-Number: 38329 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0