October 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[pespin/2.0.0]: Bump version: 2.0.0.6-d201 → 2.0.1
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38365?usp=email ) Change subject: Bump version: 2.0.0.6-d201 → 2.0.1 ...................................................................... Bump version: 2.0.0.6-d201 → 2.0.1 Change-Id: I7a76cdbd8b4d757ba2bd7d894dada1972830b180 --- M debian/changelog M src/Makefile.am 2 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/65/38365/1 diff --git a/debian/changelog b/debian/changelog index c791cd0..23a3eed 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,17 @@ +libosmo-sigtran (2.0.1) unstable; urgency=medium + + [ Neels Hofmeyr ] + * coverity CID#216830 + + [ Pau Espin Pedrol ] + * tests/vty: Add vty-transcript-test for osmo-stp + * Fix 'update route' vty command + * tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd + * src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd + * vty: Fix 'update route' parameter comment descriptions + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Tue, 08 Oct 2024 13:45:18 +0200 + libosmo-sigtran (2.0.0) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/src/Makefile.am b/src/Makefile.am index 90b791b..090c293 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -23,7 +23,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=10:1:0 +LIBVERSION=10:2:0 libosmo_sigtran_la_SOURCES = \ ipa.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I7a76cdbd8b4d757ba2bd7d894dada1972830b180 Gerrit-Change-Number: 38365 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[pespin/2.0.0]: Fix 'update route' vty command
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38361?usp=email ) Change subject: Fix 'update route' vty command ...................................................................... Fix 'update route' vty command Optional param marks in VTY command descriptions are only supported per token, spanning a list of params is not supported and fails matching. Related: SYS#7112 (cherry picked from commit 5361f273e1cad25505e490d89d4b12d990cba557) Change-Id: I91aa6031ca64841e63eb034fd2be2b3b2818fb53 --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 37 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/61/38361/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 9d58fb6..97c06fe 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -325,7 +325,7 @@ } DEFUN_ATTR(cs7_rt_upd, cs7_rt_upd_cmd, - "update route POINT_CODE MASK linkset LS_NAME [priority PRIO] [qos-class (CLASS|default)]", + "update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)]", "Update the Route\n" "Update the Route\n" "Destination Point Code\n" @@ -364,6 +364,23 @@ return CMD_WARNING; } + switch (argc) { + case 3: + return CMD_SUCCESS; + case 5: + if (strcmp(argv[3], "priority") != 0 && + strcmp(argv[3], "qos-class") != 0) + return CMD_WARNING; + break; /* Parse values below */ + case 7: + if (strcmp(argv[3], "priority") != 0 && + strcmp(argv[5], "qos-class") != 0) + return CMD_WARNING; + break; /* Parse values below */ + default: + return CMD_WARNING; + } + argind = 3; if (argc > argind && !strcmp(argv[argind], "priority")) { argind++; diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 69a0ab7..c5e82f7 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -568,7 +568,24 @@ OsmoSTP(config-cs7)# route-table system OsmoSTP(config-cs7-rt)# list ... - update route POINT_CODE MASK linkset LS_NAME [priority PRIO] [qos-class (CLASS|default)] + update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)] remove route POINT_CODE MASK OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 -% Unknown command. +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass priority 5 +... +cs7 instance 1 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I91aa6031ca64841e63eb034fd2be2b3b2818fb53 Gerrit-Change-Number: 38361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: coverity CID#216830
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38359?usp=email ) Change subject: coverity CID#216830 ...................................................................... coverity CID#216830 sanity-check par->len received on the wire. (cherry picked from commit 0285323c2bbe8efdcc7215179f890ac727ca7cac) Change-Id: I1dcc3cb724c9644191de675cac0670ca292a75ba --- M src/sua.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/59/38359/1 diff --git a/src/sua.c b/src/sua.c index 9e281e0..3d9d7ec 100644 --- a/src/sua.c +++ b/src/sua.c @@ -436,6 +436,10 @@ par = (struct xua_parameter_hdr *) &param->dat[pos]; par_tag = ntohs(par->tag); par_len = ntohs(par->len); + + /* sanity: check par->len received on the wire, make sure the subtraction does not wrap past zero. */ + if (par_len < sizeof(*par)) + goto subpar_fail; par_datalen = par_len - sizeof(*par); LOGP(DLSUA, LOGL_DEBUG, "SUA IEI 0x%04x pos %hu/%hu: subpart tag 0x%04x, len %hu\n", -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I1dcc3cb724c9644191de675cac0670ca292a75ba Gerrit-Change-Number: 38359 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[pespin/2.0.0]: tests/vty: Add vty-transcript-test for osmo-stp
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38360?usp=email ) Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... tests/vty: Add vty-transcript-test for osmo-stp So far we were only testing vty transcript for libosmo-sccp in ASP mode (osmo_ss7_vty_init_asp()). Let's also test in SG mode (osmo_ss7_vty_init_sg()), the one used in osmo-stp. Last command in SG-only node "route-table system" shows a current bug in command "update route", returning "% Unknown command.". Related: SYS#7112 (cherry picked from commit d3e69b874971441071663a2457773dac77b579ae) Change-Id: Ib8654181072af4119826bd5ec13d862147cd9b31 --- M tests/vty/Makefile.am A tests/vty/osmo_stp_test.vty 2 files changed, 589 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/38360/1 diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 7f67d75..3d35c25 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) EXTRA_DIST = \ + osmo_stp_test.vty \ ss7_asp_test.vty \ vty_test_runner.py \ $(NULL) @@ -27,15 +28,25 @@ vty-python-test: $(top_builddir)/stp/osmo-stp $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v -# To update the VTY script from current application behavior, -# pass -u to osmo_verify_transcript_vty.py by doing: -# make vty-test U=-u -vty-transcript-test: ss7_asp_vty_test +vty-transcript-test-stp: $(top_builddir)/stp/osmo-stp + osmo_verify_transcript_vty.py -v \ + -n OsmoSTP -p 4239 \ + -r "$(top_builddir)/stp/osmo-stp -c $(top_srcdir)/doc/examples/osmo-stp-multihome.cfg" \ + $(U) $(srcdir)/osmo_stp_*.vty + +vty-transcript-test-asp: ss7_asp_vty_test osmo_verify_transcript_vty.py -v \ -p 42043 \ -r "$(builddir)/ss7_asp_vty_test" \ $(U) $(srcdir)/ss7_asp_*.vty +# To update the VTY script from current application behavior, +# pass -u to osmo_verify_transcript_vty.py by doing: +# make vty-test U=-u +vty-transcript-test: + $(MAKE) vty-transcript-test-stp +# $(MAKE) vty-transcript-test-asp + # don't run multiple tests concurrently so that the ports don't conflict vty-test: $(MAKE) vty-python-test diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty new file mode 100644 index 0000000..69a0ab7 --- /dev/null +++ b/tests/vty/osmo_stp_test.vty @@ -0,0 +1,574 @@ +OsmoSTP> list +... !show cs7 + show cs7 instance <0-15> users + show cs7 (sua|m3ua|ipa) [<0-65534>] + show cs7 (sua|m3ua|ipa) (sctp|tcp) [<0-65534>] + show cs7 config + show cs7 instance <0-15> asp + show cs7 instance <0-15> asp name ASP_NAME + show cs7 instance <0-15> asp-remaddr + show cs7 instance <0-15> asp-remaddr name ASP_NAME + show cs7 instance <0-15> asp-assoc-status + show cs7 instance <0-15> asp-assoc-status name ASP_NAME + show cs7 instance <0-15> as (active|all|m3ua|sua) + show cs7 instance <0-15> route + show cs7 instance <0-15> sccp addressbook + show cs7 instance <0-15> sccp users + show cs7 instance <0-15> sccp ssn <0-65535> + show cs7 instance <0-15> sccp connections + show cs7 instance <0-15> sccp timers +... !show cs7 + +OsmoSTP> enable +OsmoSTP# list +... !show cs7 + show cs7 instance <0-15> users + show cs7 (sua|m3ua|ipa) [<0-65534>] + show cs7 (sua|m3ua|ipa) (sctp|tcp) [<0-65534>] + show cs7 config + cs7 instance <0-15> asp NAME disconnect + show cs7 instance <0-15> asp + show cs7 instance <0-15> asp name ASP_NAME + show cs7 instance <0-15> asp-remaddr + show cs7 instance <0-15> asp-remaddr name ASP_NAME + show cs7 instance <0-15> asp-assoc-status + show cs7 instance <0-15> asp-assoc-status name ASP_NAME + show cs7 instance <0-15> as (active|all|m3ua|sua) + show cs7 instance <0-15> route + show cs7 instance <0-15> sccp addressbook + show cs7 instance <0-15> sccp users + show cs7 instance <0-15> sccp ssn <0-65535> + show cs7 instance <0-15> sccp connections + show cs7 instance <0-15> sccp timers +... !show cs7 + +OsmoSTP# show ? +... + cs7 ITU-T Signaling System 7 +... + +OsmoSTP# show cs7 ? + instance An instance of the SS7 stack + sua SCCP User Adaptation + m3ua MTP3 User Adaptation + ipa IPA Multiplex (SCCP Lite) + config Currently running cs7 configuration + +OsmoSTP# show cs7 m3ua ? + [<0-65534>] Local Port Number + sctp SCTP (Stream Control Transmission Protocol) + tcp TCP (Transmission Control Protocol) + +OsmoSTP# show cs7 m3ua 2905 ? + <cr> + +OsmoSTP# show cs7 m3ua sctp ? + [<0-65534>] Local Port Number + +OsmoSTP# show cs7 m3ua sctp 2905 ? + <cr> + +OsmoSTP# show cs7 instance ? + <0-15> An instance of the SS7 stack + +OsmoSTP# show cs7 instance 0 ? + users User Table + asp Application Server Process (ASP) + asp-remaddr Application Server Process (ASP) remote addresses information + asp-assoc-status Application Server Process (ASP) SCTP association status + as Application Server (AS) + route Routing Table + sccp Signalling Connection Control Part + +OsmoSTP# show cs7 instance 0 as ? + active Display all active ASs + all Display all ASs (default) + m3ua Display all m3ua ASs + sua Display all SUA ASs + +OsmoSTP# show cs7 instance 0 sccp ? + addressbook List all SCCP addressbook entries + users Show List of SCCP Users registered + ssn Find an SCCP User registered for the given SSN + connections Show List of active SCCP connections + timers Show List of SCCP timers + +OsmoSTP# show cs7 instance 0 sccp ssn ? + <0-65535> Subsystem Number (SSN) + +OsmoSTP# configure terminal +OsmoSTP(config)# cs7 instance 0 + +OsmoSTP(config-cs7)# list +... + description .TEXT + network-indicator (international | national | reserved | spare) + point-code POINT_CODE + point-code format <1-24> [<1-23>] [<1-22>] + point-code format default + point-code delimiter (default|dash) + xua rkm routing-key-allocation (static-only|dynamic-permitted) + asp NAME <0-65535> <0-65535> (sua|m3ua|ipa) + asp NAME <0-65535> <0-65535> (sua|m3ua|ipa) (sctp|tcp) + no asp NAME + as NAME (sua|m3ua|ipa) + no as NAME + sccp-address NAME + no sccp-address NAME + route-table system + listen (sua|m3ua|ipa) <0-65534> [(sctp|tcp)] + no listen (sua|m3ua|ipa) <0-65534> [(sctp|tcp)] + sccp-timer (conn_est|ias|iar|rel|repeat_rel|int|guard|reset|reassembly) <1-999999> + sccp max-optional-data (<0-999999>|standard) + +OsmoSTP(config-cs7)# ? +... + description Save human-readable description of the object + network-indicator Configure the Network Indicator + point-code Configure the local Point Code + xua SIGTRAN xxxUA related + asp Configure Application Server Process + no Negate a command or set its defaults + as Configure an Application Server + sccp-address Create/Modify an SCCP addressbook entry + route-table Specify the name of the route table + listen Configure/Enable xUA Listener + sccp-timer Configure SCCP timer values, see ITU-T Q.714 + sccp Configure SCCP behavior + +OsmoSTP(config-cs7)# description ? + TEXT Text until the end of the line + +OsmoSTP(config-cs7)# network-indicator ? + international International Network + national National Network + reserved Reserved Network + spare Spare Network + +OsmoSTP(config-cs7)# point-code ? + POINT_CODE Point Code + format Configure Point Code Format + delimiter Configure Point Code Delimiter + +OsmoSTP(config-cs7)# point-code format ? + <1-24> Length of first PC component + default Default Point Code Format (3.8.3) +OsmoSTP(config-cs7)# point-code format 1 ? + [<1-23>] Length of second PC component +OsmoSTP(config-cs7)# point-code format 1 1 ? + [<1-22>] Length of third PC component + +OsmoSTP(config-cs7)# point-code delimiter ? + default Use dot as delimiter + dash User dash as delimiter + +OsmoSTP(config-cs7)# xua ? + rkm Routing Key Management +OsmoSTP(config-cs7)# xua rkm ? + routing-key-allocation Routing Key Management Allocation Policy +OsmoSTP(config-cs7)# xua rkm routing-key-allocation ? + static-only Only static (pre-configured) Routing Keys permitted + dynamic-permitted Dynamically allocate Routing Keys for what ASPs request + +OsmoSTP(config-cs7)# asp ? + NAME Name of ASP +OsmoSTP(config-cs7)# asp foo ? + <0-65535> Remote port number +OsmoSTP(config-cs7)# asp foo 0 ? + <0-65535> Local port number +OsmoSTP(config-cs7)# asp foo 0 0 ? + sua SCCP User Adaptation + m3ua MTP3 User Adaptation + ipa IPA Multiplex (SCCP Lite) +OsmoSTP(config-cs7)# asp foo 0 0 m3ua ? + sctp SCTP (Stream Control Transmission Protocol) + tcp TCP (Transmission Control Protocol) + <cr> + +OsmoSTP(config-cs7)# as ? + NAME Name of the Application Server +OsmoSTP(config-cs7)# as foo ? + sua SCCP User Adaptation + m3ua MTP3 User Adaptation + ipa IPA Multiplex (SCCP Lite) + +OsmoSTP(config-cs7)# sccp-address ? + NAME Name of the SCCP Address + +OsmoSTP(config-cs7)# no ? + asp Disable Application Server Process + as Disable Application Server + sccp-address Delete an SCCP addressbook entry + listen Disable xUA Listener on given port +OsmoSTP(config-cs7)# no asp ? + NAME Name of ASP +OsmoSTP(config-cs7)# no as ? + NAME Name of AS +OsmoSTP(config-cs7)# no sccp-address ? + NAME Name of the SCCP Address + +OsmoSTP(config-cs7)# sccp-address foo +OsmoSTP(config-cs7-sccpaddr)# list +... + no point-code + no subsystem-number + no global-title + routing-indicator (GT|PC|IP) + point-code POINT_CODE + subsystem-number <0-4294967295> + global-title +OsmoSTP(config-cs7-sccpaddr)# ? +... + no Negate a command or set its defaults + routing-indicator Add Routing Indicator + point-code Add point-code Number + subsystem-number Add Subsystem Number + global-title Add/Modify Global Title + +OsmoSTP(config-cs7-sccpaddr)# point-code 1.2.3 + +OsmoSTP(config-cs7-sccpaddr)# do show cs7 instance 0 sccp addressbook + +Name RI: PC: SSN: GT: +------------ --- --------- ---------- --------------------------------------- +foo PC 1.2.3 (none) (none) + +OsmoSTP(config-cs7-sccpaddr)# exit + +OsmoSTP(config-cs7)# sccp-address foobarfoobarfoobarfoobarfoobarfoobar +Error: SCCP address name too long: 'foobarfoobarfoobarfoobarfoobarfoobar' +% Command incomplete. + +OsmoSTP(config-cs7)# exit +OsmoSTP(config)# cs7 instance 1 +OsmoSTP(config-cs7)# sccp-address foo +Error: SCCP address name already used in cs7 instance 0: 'foo' +% Command incomplete. +OsmoSTP(config-cs7)# sccp-address bar +OsmoSTP(config-cs7-sccpaddr)# point-code 1.2.3 +OsmoSTP(config-cs7-sccpaddr)# exit +OsmoSTP(config-cs7)# exit +OsmoSTP(config)# no cs7 instance 1 +% Unknown command. + +OsmoSTP(config)# cs7 instance 0 + +OsmoSTP(config-cs7)# asp my-asp 12345 54321 m3ua +OsmoSTP(config-cs7-asp)# list +... + description .TEXT + remote-ip (A.B.C.D|X:X::X:X) [primary] + no remote-ip (A.B.C.D|X:X::X:X) + local-ip (A.B.C.D|X:X::X:X) [primary] + no local-ip (A.B.C.D|X:X::X:X) + qos-class <0-255> + role (sg|asp|ipsp) + transport-role (client|server) + sctp-param init (num-ostreams|max-instreams|max-attempts|timeout) <0-65535> + no sctp-param init (num-ostreams|max-instreams|max-attempts|timeout) + block + shutdown +... + +OsmoSTP(config-cs7-asp)# ? +... + description Save human-readable description of the object + remote-ip Specify Remote IP Address of ASP + no Negate a command or set its defaults + local-ip Specify Local IP Address from which to contact ASP + qos-class Specify QoS Class of ASP + role Specify the xUA role for this ASP + transport-role Specify the transport layer role for this ASP + sctp-param Configure SCTP parameters + block Allows a SCTP Association with ASP, but doesn't let it become active + shutdown Terminates SCTP association; New associations will be rejected +... + +OsmoSTP(config-cs7-asp)# no ? +... + sctp-param Configure SCTP parameters + quirk Disable quirk to work around interop issues +... + +OsmoSTP(config-cs7-asp)# remote-ip 127.0.0.200 +OsmoSTP(config-cs7-asp)# local-ip 127.0.0.100 +OsmoSTP(config-cs7-asp)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp ? uninitialized m3ua sg server 127.0.0.100:54321 127.0.0.200:12345 +OsmoSTP(config-cs7-asp)# remote-ip 127.0.0.201 +OsmoSTP(config-cs7-asp)# local-ip 127.0.0.101 +OsmoSTP(config-cs7-asp)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp ? uninitialized m3ua sg server (127.0.0.100|127.0.0.101):54321 (127.0.0.200|127.0.0.201):12345 +OsmoSTP(config-cs7-asp)# ! Mark as primary: +OsmoSTP(config-cs7-asp)# remote-ip 127.0.0.201 primary +OsmoSTP(config-cs7-asp)# ! 'local-ip 127.0.0.101 primary' cannot be tested here since output may be different based on sysctl available +OsmoSTP(config-cs7-asp)# local-ip 127.0.0.101 +... +OsmoSTP(config-cs7-asp)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp ? uninitialized m3ua sg server (127.0.0.100|127.0.0.101):54321 (127.0.0.200|127.0.0.201*):12345 +OsmoSTP(config-cs7-asp)# show running-config +... + local-ip 127.0.0.100 + local-ip 127.0.0.101 + remote-ip 127.0.0.200 + remote-ip 127.0.0.201 primary +... +end +OsmoSTP(config-cs7-asp)# ! Mark as non-primary: +OsmoSTP(config-cs7-asp)# remote-ip 127.0.0.201 +OsmoSTP(config-cs7-asp)# local-ip 127.0.0.101 +OsmoSTP(config-cs7-asp)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp ? uninitialized m3ua sg server (127.0.0.100|127.0.0.101):54321 (127.0.0.200|127.0.0.201):12345 +OsmoSTP(config-cs7-asp)# show running-config +... + local-ip 127.0.0.100 + local-ip 127.0.0.101 + remote-ip 127.0.0.200 + remote-ip 127.0.0.201 +... +end +OsmoSTP(config-cs7-asp)# exit + +OsmoSTP(config-cs7)# as my-ass m3ua +OsmoSTP(config-cs7-as)# list +... + description .TEXT + asp NAME + no asp NAME + traffic-mode (broadcast | loadshare | roundrobin | override) + no traffic-mode + recovery-timeout <1-2000> + qos-class <0-255> + routing-key RCONTEXT DPC + routing-key RCONTEXT DPC si (aal2|bicc|b-isup|h248|isup|sat-isup|sccp|tup) + routing-key RCONTEXT DPC ssn SSN + routing-key RCONTEXT DPC si (aal2|bicc|b-isup|h248|isup|sat-isup|sccp|tup) ssn SSN + point-code override dpc PC + point-code override patch-sccp (disabled|both) + +OsmoSTP(config-cs7-as)# ? +... + description Save human-readable description of the object + asp Specify that a given ASP is part of this AS + no Negate a command or set its defaults + traffic-mode Specifies traffic mode of operation of the ASP within the AS + recovery-timeout Specifies the recovery timeout value in milliseconds + qos-class Specity QoS Class of AS + routing-key Define a routing key + point-code Point Code Specific Features + +OsmoSTP(config-cs7-as)# no ? + asp Specify ASP to be removed from this AS + traffic-mode Remove explicit traffic mode of operation of this AS + +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as all + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- +my-ass AS_DOWN 0 0.0.0 override + +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as active + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- + +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as sua + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- + +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as m3ua + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- +my-ass AS_DOWN 0 0.0.0 override + +OsmoSTP(config-cs7-as)# asp my-asp +OsmoSTP(config-cs7-as)# routing-key 0 3.2.1 + +OsmoSTP(config-cs7-as)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp my-ass ASP_DOWN m3ua sg server (127.0.0.100|127.0.0.101):54321 (127.0.0.200|127.0.0.201):12345 + +OsmoSTP(config-cs7-as)# exit +OsmoSTP(config-cs7)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp my-ass ASP_DOWN m3ua sg server (127.0.0.100|127.0.0.101):54321 (127.0.0.200|127.0.0.201):12345 + +OsmoSTP(config-cs7)# exit + + +OsmoSTP(config)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- +my-asp my-ass ASP_DOWN m3ua sg server (127.0.0.100|127.0.0.101):54321 (127.0.0.200|127.0.0.201):12345 + +OsmoSTP(config)# do show cs7 instance 0 as all + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- +my-ass AS_DOWN 0 3.2.1 override + + + +OsmoSTP(config)# show running-config +... +cs7 instance 0 + xua rkm routing-key-allocation dynamic-permitted + asp my-asp 12345 54321 m3ua + local-ip 127.0.0.100 + local-ip 127.0.0.101 + remote-ip 127.0.0.200 + remote-ip 127.0.0.201 + role sg + sctp-role server + as my-ass m3ua + asp my-asp + routing-key 0 3.2.1 + route-table system + listen m3ua 2905 + local-ip 127.0.0.2 + local-ip 127.0.0.1 + local-ip ::1 + accept-asp-connections dynamic-permitted + sccp-address foo + routing-indicator PC + point-code 1.2.3 +cs7 instance 1 + route-table system + sccp-address bar + routing-indicator PC + point-code 1.2.3 +end + +OsmoSTP(config)# do show cs7 instance 0 users + +OsmoSTP(config)# do show cs7 m3ua +xUA server for m3ua/sctp on (::ffff:127.0.0.2|::ffff:127.0.0.1|::1):2905 is listening + +OsmoSTP(config)# cs7 instance 0 +OsmoSTP(config-cs7)# no asp unknown-asp +No ASP named 'unknown-asp' found + +OsmoSTP(config-cs7)# no asp my-asp + +OsmoSTP(config-cs7)# do show cs7 instance 0 asp +ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses +------------ ------------ ------------- ---- ---- --------- ----------------------- ----------------------- + +OsmoSTP(config-cs7)# do show cs7 instance 0 as all + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- +my-ass AS_DOWN 0 3.2.1 override + + +OsmoSTP(config-cs7)# do show cs7 instance 0 sccp timers +SS7 instance 0 has no SCCP initialized + +OsmoSTP(config-cs7)# show running-config +... !sccp-timer + +OsmoSTP(config-cs7)# sccp-timer ias 5 +OsmoSTP(config-cs7)# do show cs7 instance 0 sccp timers +sccp-timer conn_est 60 +sccp-timer ias 5 +sccp-timer iar 900 +sccp-timer rel 10 +sccp-timer repeat_rel 10 +sccp-timer int 60 +sccp-timer guard 1380 +sccp-timer reset 10 +sccp-timer reassembly 10 +OsmoSTP(config-cs7)# show running-config +... !sccp-timer + sccp-timer ias 5 +... !sccp-timer + +OsmoSTP(config-cs7)# sccp-timer ias 420 +OsmoSTP(config-cs7)# do show cs7 instance 0 sccp timers +sccp-timer conn_est 60 +sccp-timer ias 420 +sccp-timer iar 900 +sccp-timer rel 10 +sccp-timer repeat_rel 10 +sccp-timer int 60 +sccp-timer guard 1380 +sccp-timer reset 10 +sccp-timer reassembly 10 +OsmoSTP(config-cs7)# show running-config +... !sccp-timer + +OsmoSTP(config-cs7)# sccp-timer? + sccp-timer Configure SCCP timer values, see ITU-T Q.714 + +OsmoSTP(config-cs7)# sccp-timer ? + conn_est Waiting for connection confirm message, 1 to 2 minutes (default: 60) + ias Send keep-alive: on an idle connection, delay before sending an Idle Timer message, 5 to 10 minutes (default: 420) + iar Receive keep-alive: on an idle connection, delay until considering a connection as stale, 11 to 21 minutes (default: 900) + rel Waiting for release complete message, 10 to 20 seconds (default: 10) + repeat_rel Waiting for release complete message; or to repeat sending released message after the initial expiry, 10 to 20 seconds (default: 10) + int Waiting for release complete message; or to release connection resources, freeze the LRN and alert a maintenance function after the initial expiry, extending to 1 minute (default: 60) + guard Waiting to resume normal procedure for temporary connection sections during the restart procedure, 23 to 25 minutes (default: 1380) + reset Waiting to release temporary connection section or alert maintenance function after reset request message is sent, 10 to 20 seconds (default: 10) + reassembly Waiting to receive all the segments of the remaining segments, single segmented message after receiving the first segment, 10 to 20 seconds (default: 10) + +OsmoSTP(config-cs7)# sccp-timer conn_est ? + <1-999999> Timer value, in seconds + +OsmoSTP(config-cs7)# sccp ? + max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. + +OsmoSTP(config-cs7)# sccp max-optional-data ? + <0-999999> Set a non-standard maximum allowed number of bytes + standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 130 + +OsmoSTP(config-cs7)# show running-config +... !sccp max-optional-data + +OsmoSTP(config-cs7)# sccp max-optional-data 0 +OsmoSTP(config-cs7)# show running-config +... + sccp max-optional-data 0 +... + +OsmoSTP(config-cs7)# sccp max-optional-data 123 +OsmoSTP(config-cs7)# show running-config +... + sccp max-optional-data 123 +... + +OsmoSTP(config-cs7)# sccp max-optional-data 999999 +OsmoSTP(config-cs7)# show running-config +... +cs7 instance 0 +... + sccp max-optional-data 999999 +... +cs7 instance 1 +... !sccp max-optional-data + +OsmoSTP(config-cs7)# sccp max-optional-data standard +OsmoSTP(config-cs7)# show running-config +... !sccp max-optional-data + +OsmoSTP(config-cs7)# sccp max-optional-data 130 +OsmoSTP(config-cs7)# show running-config +... !sccp max-optional-data + +OsmoSTP(config-cs7)# route-table system +OsmoSTP(config-cs7-rt)# list +... + update route POINT_CODE MASK linkset LS_NAME [priority PRIO] [qos-class (CLASS|default)] + remove route POINT_CODE MASK +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 +% Unknown command. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: Ib8654181072af4119826bd5ec13d862147cd9b31 Gerrit-Change-Number: 38360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/build-kernels-testenv: notify-every-unstable-build: true
by osmith 08 Oct '24

08 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38357?usp=email ) Change subject: jobs/build-kernels-testenv: notify-every-unstable-build: true ...................................................................... jobs/build-kernels-testenv: notify-every-unstable-build: true Fix that this wasn't set to true (copy paste error). Change-Id: Icf2127e34caa40675fd8e24bc3e061325eb6c0b0 --- M jobs/build-kernels-testenv.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml index 3e9ad75..20dfc0f 100644 --- a/jobs/build-kernels-testenv.yml +++ b/jobs/build-kernels-testenv.yml @@ -65,7 +65,7 @@ - timed: "H 23 * * *" publishers: - email: - notify-every-unstable-build: false + notify-every-unstable-build: true recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: false - archive: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf2127e34caa40675fd8e24bc3e061325eb6c0b0 Gerrit-Change-Number: 38357 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Remove sync() after writing VTY config
by jolly 08 Oct '24

08 Oct '24

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: Remove sync() after writing VTY config ...................................................................... Remove sync() after writing VTY config Running sync() after writing VTY config causes the process to stop for a fraction of a second. This may result in delayed processing that causes buffer underruns, overflows and delay. This is a problem with applications that do real-time signal processing such as osmo-trx and osmo-bts. After some discussions, I decided to simply remove the sync() commands from the VTY's write function. There is still a backup file created of the previously saved configuration before writing the current configurtion. Loosing current configuration caused by a system crash afterwards is very unlikely with modern file systems. Related: OS#6438 Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 --- M src/vty/command.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/37798/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by jolly 08 Oct '24

08 Oct '24

Attention is currently required from: laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 6: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/f63290cf_d4fe5d24?… : PS6, Line 7: After writing VTY config, run sync() in a different thread I forgot to change the subject. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:37:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: move ggsn testsuite
by pespin 08 Oct '24

08 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: move ggsn testsuite ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b70944bd1fa9c90c5ad51b9026fdcd969bfc8a8 Gerrit-Change-Number: 38346 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:25:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/build-kernels-testenv: add build-kernel-none
by pespin 08 Oct '24

08 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email ) Change subject: jobs/build-kernels-testenv: add build-kernel-none ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002 Gerrit-Change-Number: 38358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/build-kernels-testenv: notify-every-unstable-build: true
by pespin 08 Oct '24

08 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38357?usp=email ) Change subject: jobs/build-kernels-testenv: notify-every-unstable-build: true ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf2127e34caa40675fd8e24bc3e061325eb6c0b0 Gerrit-Change-Number: 38357 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:22:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0