Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email )
Change subject: ggsn: testenv: run SUT on bridge instead of lo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I didn't like the complexity and overhead of a dockerized setup.
Me neither, especially with having lots of docker containers that need to be built and having duplicated configs that get out of sync. That's why I wrote the testenv script (OS#6494).
> I'm not sure if the testenv basis will change much in that regard.
It is much simpler in several ways:
* only one container instead of several
* using the container is optional
* no duplicate configs that get out of sync (like https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021)
* for most Osmocom programs, we only need a simple testenv.cfg and osmo-$program.cfg file, for example: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38267
> All this overhead with qeum virtual machines still seems like a work-around to understanding the real problem to me...
This is not a workaround. QEMU is required to test the kernel GTP-U feature of osmo-ggsn with different kernels as it was previously implemented in docker-playground (OS#3208).
The configs for the GGSN testsuite are by far the most complex, because we run it in all of these combinations (already in docker-playground, I just ported it to testenv here and made it more generic in the process by using osmo-config-merge etc.):
* osmo-ggsn + {all,v4_only,v4_only,v4v6_only} APNs
* osmo-ggsn with kernel GTP-U (needs QEMU) + {v4_only,v4_only,v4v6_only} APNs
* open5gs
> When I develop a patch for any of our osmocom projcets, I'm always end up running all tests suites locally / natively / directly on my machine.
OK, that seems to answer that my assumption was wrong: "I'm assuming that people aren't really running osmo-ggsn directly with the testsuite with these configs".
I'll change the patch so the configs have 127.0.0.x again, so this still works as expected.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a
Gerrit-Change-Number: 38341
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:45:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email )
Change subject: Rename osmo-pfcp-tool to osmo-upf-genload
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> loadgen (for load generator) would be more natural to me, given that in english, "load generator" is […]
I was thinking more in the sense of "generate load", but I have no strong opinion, I can change it.
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Ie36379b5dcf4ab86276dfda9e25410fe41db1d93
Gerrit-Change-Number: 38354
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email )
Change subject: Rename osmo-pfcp-tool to osmo-upf-genload
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
loadgen (for load generator) would be more natural to me, given that in english, "load generator" is a well-known phrase, but "generator of load" sounds awkward. But well...
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Ie36379b5dcf4ab86276dfda9e25410fe41db1d93
Gerrit-Change-Number: 38354
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38353?usp=email )
Change subject: Initial tunend and tunmap testsuites for osmo-upf
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38353?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Iffe344975fa16621959f7306e095451e4421de26
Gerrit-Change-Number: 38353
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:16:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: neels, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email )
Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1
Gerrit-Change-Number: 38327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:15:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email )
Change subject: ggsn: testenv: run SUT on bridge instead of lo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> It is still possible to run it without docker/podman when using `./testenv. […]
When I develop a patch for any of our osmocom projcets, I'm always end up running all tests suites locally / natively / directly on my machine. I didn't like the complexity and overhead of a dockerized setup. I'm not sure if the testenv basis will change much in that regard. All this overhead with qeum virtual machines still seems like a work-around to understanding the real problem to me...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a
Gerrit-Change-Number: 38341
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email )
Change subject: jobs/build-kernels-testenv: add build-kernel-none
......................................................................
jobs/build-kernels-testenv: add build-kernel-none
Create a dummy output/linux file, that the jobs generated by
ttcn3-testsuites-testenv can copy (via copyartifact) when setting the
kernel to "none".
Without this, the ttcn3-testsuites-testenv.yml would need to become more
complex, as it is not possible in jenkins job builder templates to only
do the copyartifact block conditionally if kernel != "none".
Another solution would be using shell logic like the following:
if [ "$KERNEL" != "none" ]; then
wget -q -O .linux "https://jenkins.osmocom.org/..."
fi
But this has the disadvantage that jenkins is not aware of the file and
therefore we cannot track easily which linux kernel build was used in
the job. With the copyartifact method, we can click on "See
Fingerprints" and find which job built the kernel. Example:
https://jenkins.osmocom.org/jenkins/job/ttcn3-ggsn-test-kernel-net-next/147…
Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002
---
M jobs/build-kernels-testenv.yml
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml
index 20dfc0f..cde1706 100644
--- a/jobs/build-kernels-testenv.yml
+++ b/jobs/build-kernels-testenv.yml
@@ -81,3 +81,27 @@
wrappers:
- ansicolor:
colormap: xterm
+
+- job:
+ name: 'build-kernel-none'
+ project-type: freestyle
+ defaults: global
+ description: |
+ Dummy job to allow specifying "none" as kernel in
+ <a href="https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/jobs/ttcn3-test…">ttcn3-testsuites-testenv.yml</a>.
+ node: "osmocom-master"
+ builders:
+ - shell: |-
+ mkdir output
+ echo "dummy from build-kernel-none jenkins job" > output/linux
+ publishers:
+ - archive:
+ allow-empty: false
+ artifacts: output/**/*
+ case-sensitive: true
+ default-excludes: true
+ fingerprint: false
+ only-if-success: false
+ properties:
+ - build-discarder:
+ num-to-keep: 10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002
Gerrit-Change-Number: 38358
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>