October 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[pespin/2.0.0]: Bump version: 2.0.0.6-d201 → 2.0.1
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38365?usp=email ) Change subject: Bump version: 2.0.0.6-d201 → 2.0.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I7a76cdbd8b4d757ba2bd7d894dada1972830b180 Gerrit-Change-Number: 38365 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:56:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: vty: Fix 'update route' parameter comment descriptions
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38364?usp=email ) Change subject: vty: Fix 'update route' parameter comment descriptions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I9b48fe9072f613c18c82965ef5aabd239b576a07 Gerrit-Change-Number: 38364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:54:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38363?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: Ib9cccc508ce158e9e738e9ba4da69b819b41832d Gerrit-Change-Number: 38363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:54:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[pespin/2.0.0]: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update rout...
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38362?usp=email ) Change subject: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I16b80558fd1da8228f4ae63bb1036f3315cf5e45 Gerrit-Change-Number: 38362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:53:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[pespin/2.0.0]: Fix 'update route' vty command
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38361?usp=email ) Change subject: Fix 'update route' vty command ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I91aa6031ca64841e63eb034fd2be2b3b2818fb53 Gerrit-Change-Number: 38361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:51:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[pespin/2.0.0]: tests/vty: Add vty-transcript-test for osmo-stp
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38360?usp=email ) Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: Ib8654181072af4119826bd5ec13d862147cd9b31 Gerrit-Change-Number: 38360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:50:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: coverity CID#216830
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38359?usp=email ) Change subject: coverity CID#216830 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I1dcc3cb724c9644191de675cac0670ca292a75ba Gerrit-Change-Number: 38359 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[pespin/2.0.0]: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update rout...
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38362?usp=email ) Change subject: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd ...................................................................... tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd (cherry picked from commit 35b721103f9935bcc077cbdf16ffdc0172a2ada6) Change-Id: I16b80558fd1da8228f4ae63bb1036f3315cf5e45 --- M tests/vty/osmo_stp_test.vty 1 file changed, 34 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/62/38362/1 diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index c5e82f7..c983305 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -570,6 +570,21 @@ ... update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)] remove route POINT_CODE MASK +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass +... +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 OsmoSTP(config-cs7-rt)# show running-config ... @@ -578,10 +593,6 @@ route-table system update route 3.2.1 7.255.7 linkset my-ass priority 5 ... -cs7 instance 1 -... - route-table system -... !update route 3.2.1 7.255.7 linkset my-ass priority 5 OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 OsmoSTP(config-cs7-rt)# show running-config ... @@ -589,3 +600,22 @@ ... route-table system ... !update route 3.2.1 7.255.7 linkset my-ass priority 5 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +... +cs7 instance 1 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I16b80558fd1da8228f4ae63bb1036f3315cf5e45 Gerrit-Change-Number: 38362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38363?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd (cherry picked from commit 250fe1c248e91f722f9734c146f510f79865d89a) Change-Id: Ib9cccc508ce158e9e738e9ba4da69b819b41832d --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/63/38363/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 97c06fe..b1ae66d 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -348,18 +348,18 @@ unsigned int argind; if (dpc < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[0], VTY_NEWLINE); + vty_out(vty, "%% Invalid point code (%s)%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } if (mask < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[1], VTY_NEWLINE); + vty_out(vty, "%% Invalid point code (%s)%s", argv[1], VTY_NEWLINE); return CMD_WARNING; } rt = osmo_ss7_route_create(rtable, dpc, mask, ls_name); if (!rt) { - vty_out(vty, "cannot create route %s/%s to %s%s", + vty_out(vty, "%% Cannot create route %s/%s to %s%s", argv[0], argv[1], argv[2], VTY_NEWLINE); return CMD_WARNING; } @@ -378,6 +378,7 @@ return CMD_WARNING; break; /* Parse values below */ default: + vty_out(vty, "%% Incomplete command (missing an argument?)%s", VTY_NEWLINE); return CMD_WARNING; } diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index c983305..64337f6 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -619,3 +619,5 @@ ... route-table system ... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority +% Incomplete command (missing an argument?) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: Ib9cccc508ce158e9e738e9ba4da69b819b41832d Gerrit-Change-Number: 38363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: vty: Fix 'update route' parameter comment descriptions
by pespin 08 Oct '24

08 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38364?usp=email ) Change subject: vty: Fix 'update route' parameter comment descriptions ...................................................................... vty: Fix 'update route' parameter comment descriptions There was one string which was not mapping to any actual param, making subsequent param descriptions show up incorrectly during VTY operation. Related: SYS#7112 (cherry picked from commit bfd6d20376c5ea0d1f9e87ca32a9ff5c6fe99c98) Change-Id: I9b48fe9072f613c18c82965ef5aabd239b576a07 --- M src/osmo_ss7_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/64/38364/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index b1ae66d..d55dc17 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -330,7 +330,6 @@ "Update the Route\n" "Destination Point Code\n" "Point Code Mask\n" - "Point Code Length\n" "Specify Destination Linkset\n" "Linkset Name\n" "Specify Priority\n" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I9b48fe9072f613c18c82965ef5aabd239b576a07 Gerrit-Change-Number: 38364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0