October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-dev[master]: Add support to build upf-benchmark
by pespin 08 Oct '24

08 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/38352?usp=email ) Change subject: Add support to build upf-benchmark ...................................................................... Add support to build upf-benchmark Change-Id: I8a1d817d3255643e0ad3bfa634143fc71038d113 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Verified diff --git a/all.deps b/all.deps index 9aa4f71..99086f2 100644 --- a/all.deps +++ b/all.deps @@ -58,3 +58,5 @@ osmo-gsm-shark libosmo-pfcp osmo-mgw libosmo-sigtran osmo-iuh strongswan-epdg libosmocore + +upf-benchmark libosmocore libosmo-pfcp diff --git a/sanitize.opts b/sanitize.opts index 2918e80..72a1d69 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -23,3 +23,4 @@ osmo-cbc --enable-sanitize osmo-hnbgw --enable-sanitize osmo-gsm-shark --enable-sanitize +upf-benchmark --enable-sanitize diff --git a/werror.opts b/werror.opts index 7b0e487..165bff1 100644 --- a/werror.opts +++ b/werror.opts @@ -23,3 +23,4 @@ simtrace2_host --enable-werror osmo-remsim --enable-werror osmo-gsm-shark --enable-werror +upf-benchmark --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/38352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8a1d817d3255643e0ad3bfa634143fc71038d113 Gerrit-Change-Number: 38352 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-dev[master]: Add support to build upf-benchmark
by pespin 08 Oct '24

08 Oct '24

Attention is currently required from: neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/38352?usp=email ) Change subject: Add support to build upf-benchmark ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/38352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8a1d817d3255643e0ad3bfa634143fc71038d113 Gerrit-Change-Number: 38352 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 11:15:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs: gerrit-verifications.yml: Add job for upf-benchmark.git
by pespin 08 Oct '24

08 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38330?usp=email ) Change subject: jobs: gerrit-verifications.yml: Add job for upf-benchmark.git ...................................................................... jobs: gerrit-verifications.yml: Add job for upf-benchmark.git Change-Id: I7212e8f88c731993af01e0e42ddaad6dd7291c37 --- M jobs/gerrit-verifications.yml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 956cea6..c91eb95 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -483,6 +483,9 @@ pipeline_lint: false pipeline_binpkgs: "" + - upf-benchmark: + pipeline_binpkgs: "" + jobs: - 'gerrit-{repos}' - 'gerrit-{repos}-build' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7212e8f88c731993af01e0e42ddaad6dd7291c37 Gerrit-Change-Number: 38330 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: move ggsn testsuite
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: move ggsn testsuite ...................................................................... Patch Set 3: (1 comment) File jobs/ttcn3-testsuites-testenv.yml: https://gerrit.osmocom.org/c/osmo-ci/+/38346/comment/c84fe370_1761cf5d?usp=… : PS2, Line 284: wget -q -O .linux "https://jenkins.osmocom.org/jenkins/job/build-kernel-$KERNEL/lastSuccessful…" > Why not getting this file using jenkins infrastructure? […] Good point, this is better as it shows nicely which kernel was used in which job: https://jenkins.osmocom.org/jenkins/job/ttcn3-ggsn-test-kernel-net-next/147… Done. This requires this patch now too: https://gerrit.osmocom.org/c/osmo-ci/+/38358/1 (part of this patchset) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b70944bd1fa9c90c5ad51b9026fdcd969bfc8a8 Gerrit-Change-Number: 38346 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 10:53:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/build-kernels-testenv: add build-kernel-none
by osmith 08 Oct '24

08 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email ) Change subject: jobs/build-kernels-testenv: add build-kernel-none ...................................................................... jobs/build-kernels-testenv: add build-kernel-none Create a dummy output/linux file, that the jobs generated by ttcn3-testsuites-testenv can copy (via copyartifact) when setting the kernel to "none". Without this, the ttcn3-testsuites-testenv.yml would need to become more complex, as it is not possible in jenkins job builder templates to only do the copyartifact block conditionally if kernel != "none". Another solution would be using shell logic like the following: if [ "$KERNEL" != "none" ]; then wget -q -O .linux "https://jenkins.osmocom.org/..." fi But this has the disadvantage that jenkins is not aware of the file and therefore we cannot track easily which linux kernel build was used in the job. With the copyartifact method, we can click on "See Fingerprints" and find which job built the kernel. Example: https://jenkins.osmocom.org/jenkins/job/ttcn3-ggsn-test-kernel-net-next/147… Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002 --- M jobs/build-kernels-testenv.yml 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/38358/1 diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml index 20dfc0f..cde1706 100644 --- a/jobs/build-kernels-testenv.yml +++ b/jobs/build-kernels-testenv.yml @@ -81,3 +81,27 @@ wrappers: - ansicolor: colormap: xterm + +- job: + name: 'build-kernel-none' + project-type: freestyle + defaults: global + description: | + Dummy job to allow specifying "none" as kernel in + <a href="https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/jobs/ttcn3-test…">ttcn3-testsuites-testenv.yml</a>. + node: "osmocom-master" + builders: + - shell: |- + mkdir output + echo "dummy from build-kernel-none jenkins job" > output/linux + publishers: + - archive: + allow-empty: false + artifacts: output/**/* + case-sensitive: true + default-excludes: true + fingerprint: false + only-if-success: false + properties: + - build-discarder: + num-to-keep: 10 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002 Gerrit-Change-Number: 38358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: move ggsn testsuite
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: jobs/ttcn3-testsuites-testenv: move ggsn testsuite ...................................................................... jobs/ttcn3-testsuites-testenv: move ggsn testsuite Run the GGSN testsuite in all combinations (osmo-ggsn, osmo-ggsn with various kernels and kernel gtp-u, open5gs) with testenv. Depends: osmo-ttcn3-hacks I3f9db4325d5928c809cc99bc82d9cb82bf9e71eb Change-Id: I5b70944bd1fa9c90c5ad51b9026fdcd969bfc8a8 --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 75 insertions(+), 105 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/46/38346/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b70944bd1fa9c90c5ad51b9026fdcd969bfc8a8 Gerrit-Change-Number: 38346 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/build-kernels-testenv: notify-every-unstable-build: true
by osmith 08 Oct '24

08 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38357?usp=email ) Change subject: jobs/build-kernels-testenv: notify-every-unstable-build: true ...................................................................... jobs/build-kernels-testenv: notify-every-unstable-build: true Fix that this wasn't set to true (copy paste error). Change-Id: Icf2127e34caa40675fd8e24bc3e061325eb6c0b0 --- M jobs/build-kernels-testenv.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/57/38357/1 diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml index 3e9ad75..20dfc0f 100644 --- a/jobs/build-kernels-testenv.yml +++ b/jobs/build-kernels-testenv.yml @@ -65,7 +65,7 @@ - timed: "H 23 * * *" publishers: - email: - notify-every-unstable-build: false + notify-every-unstable-build: true recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: false - archive: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf2127e34caa40675fd8e24bc3e061325eb6c0b0 Gerrit-Change-Number: 38357 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: ggsn: testenv: run SUT on bridge instead of lo
by osmith 08 Oct '24

08 Oct '24

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email ) Change subject: ggsn: testenv: run SUT on bridge instead of lo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > IIUC, it will no more be possible to run the GGSN testsuite locally without docker/podman? It is still possible to run it without docker/podman when using `./testenv.py run ggsn` without the `--podman` parameter. In that case the bridge will get created directly on the host instead of inside a podman container. I also try to make the testsuite + SUT configurations in osmo-ttcn3-hacks so that they could still be used without testenv. However here this isn't possible without further complexity that I would rather avoid. Given that the GGSN_Tests.cfg was out-of-sync with docker-playground until I fixed it very recently (https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38263) I'm assuming that people aren't really running osmo-ggsn directly with the testsuite with these configs. The open5gs configs also were added only very recently by me in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38266/3. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a Gerrit-Change-Number: 38341 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 09:34:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by pespin 08 Oct '24

08 Oct '24

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 08 Oct 2024 09:08:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom spec...
by pespin 08 Oct '24

08 Oct '24

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email ) Change subject: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb Gerrit-Change-Number: 38125 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 08 Oct 2024 09:06:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0