Attention is currently required from: laforge, neels, pespin.
Hello laforge, neels,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge
Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git
......................................................................
Initial version of improved osmo-pfcp-tool from osmo-upf.git
Import version of osmo-pfcp-tool initially developed in master branch of
osmo-upf.git (6859de09d2ae0e363070e152489d9f8579085aa8),
and later on improved on a WIP branch there for a while.
Related: SYS#7096
Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1
---
A .gitignore
A .gitreview
A AUTHORS
A COPYING
A Makefile.am
A README.md
A TODO-RELEASE
A configure.ac
A contrib/jenkins.sh
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/postinst
A debian/rules
A debian/source/format
A debian/upf-benchmark.install
A doc/Makefile.am
A doc/manuals/Makefile.am
A doc/manuals/chapters/overview.adoc
A doc/manuals/upfbenchmark-usermanual-docinfo.xml
A doc/manuals/upfbenchmark-usermanual.adoc
A git-version-gen
A include/Makefile.am
A include/osmocom/Makefile.am
A include/osmocom/pfcptool/Makefile.am
A include/osmocom/pfcptool/checksum.h
A include/osmocom/pfcptool/gtp_flood.h
A include/osmocom/pfcptool/pfcp_tool.h
A include/osmocom/pfcptool/range.h
A src/Makefile.am
A src/osmo-pfcp-tool/Makefile.am
A src/osmo-pfcp-tool/checksum.c
A src/osmo-pfcp-tool/gtp_flood.c
A src/osmo-pfcp-tool/osmo_pfcp_tool_main.c
A src/osmo-pfcp-tool/pfcp_tool.c
A src/osmo-pfcp-tool/pfcp_tool_vty.c
A src/osmo-pfcp-tool/range.c
38 files changed, 5,272 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/27/38327/2
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1
Gerrit-Change-Number: 38327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email )
Change subject: update osmo-stp.cfg to make STP_Tests work at all again
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78
Gerrit-Change-Number: 38021
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 07 Oct 2024 17:11:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email )
Change subject: update osmo-stp.cfg to make STP_Tests work at all again
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021/comment/942e0a19_47b4… :
PS1, Line 12: I'm really getting tired at fixing up those kind of issues. It's
: well-known that config changes must be made first here and then in
: docker-playground.
> Done
Adding @osmith@sysmocom.de for him to review sinceas mentioned he's doing some movement of teststuites, so there's no race condition between his work and this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78
Gerrit-Change-Number: 38021
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 17:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email )
Change subject: update osmo-stp.cfg to make STP_Tests work at all again
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021/comment/290feb23_614d… :
PS1, Line 12: I'm really getting tired at fixing up those kind of issues. It's
: well-known that config changes must be made first here and then in
: docker-playground.
> The good side of things is that we are already moving several of those testsuites from docker-playgr […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78
Gerrit-Change-Number: 38021
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 17:08:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: update osmo-stp.cfg to make STP_Tests work at all again
......................................................................
update osmo-stp.cfg to make STP_Tests work at all again
This syncs osmo-stp.cfg with changes introduced to docker-playground
in Change-Id I210b7d62845075dcfe147f2f77603625cc1e64f9 on March 4th.
I'm really getting tired at fixing up those kind of issues. It's
well-known that config changes must be made first here and then in
docker-playground.
Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78
---
D stp/osmo-stp-tcp.confmerge
M stp/osmo-stp.cfg
2 files changed, 22 insertions(+), 22 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/38021/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78
Gerrit-Change-Number: 38021
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, jolly, keith, neels, pespin.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email )
Change subject: sip.c: permit early media with both 183 and 180
......................................................................
Patch Set 3:
(1 comment)
File src/sip.c:
https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039/comment/11498459_26… :
PS3, Line 88: sdp_extract_sdp(leg, sip, false);
> 183 without SDP was handled before already and should not be modified here. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Gerrit-Change-Number: 38039
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: keith <keith(a)rhizomatica.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Mon, 07 Oct 2024 17:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>
Attention is currently required from: fixeria, jolly, keith, neels, pespin.
Hello Jenkins Builder, fixeria, jolly, lynxis lazus, neels, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by jolly, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: sip.c: permit early media with both 183 and 180
......................................................................
sip.c: permit early media with both 183 and 180
So far we only attempted to extract SDP (and hence enable early media)
when receiving a status code 183. However, SDP can also be provided
with 180, see for example https://developer.signalwire.com/freeswitch/FreeSWITCH-Explained/Codecs-and…
Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Closes: OS#6559
---
M src/sip.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/39/38039/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Gerrit-Change-Number: 38039
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: keith <keith(a)rhizomatica.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Attention is currently required from: laforge, neels.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email )
Change subject: Introduce osmo-udp-responder
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-udp-responder/udp_responder.c:
https://gerrit.osmocom.org/c/upf-benchmark/+/38328/comment/e430da67_190f415… :
PS1, Line 55: st
> I did not write that part, this was done by Neels so he may want to provide some insight. […]
Btw, anyway I plan to end up using a vty cfg file for osmo-udp-responder too, so I'll be reworking this cmdline stuff anyway.
With regular osmocom vty cfg I can do fine granning cpu-afinitty pinning configuration based on thread names.
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7
Gerrit-Change-Number: 38328
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 07 Oct 2024 17:04:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>