October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by laforge

Attention is currently required from: fixeria, keith, neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email ) Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... Patch Set 3: (1 comment) File src/sip.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039/comment/728673da_27… : PS3, Line 88: sdp_extract_sdp(leg, sip, false); > 183 without SDP is apparently also legal. 183 without SDP was handled before already and should not be modified here. We're adding "180 with SDP" here. Or did you want to say "180 without SDP is apparently also legal", i.e. we should accept both 183 and 180 without SDP? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 07 Oct 2024 17:01:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd Change-Id: I4fd5b30093425f1831348282d3563467c889e27f --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index fb224d1..6d78c2e 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -364,18 +364,18 @@ unsigned int argind; if (dpc < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[0], VTY_NEWLINE); + vty_out(vty, "%% Invalid point code (%s)%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } if (mask < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[1], VTY_NEWLINE); + vty_out(vty, "%% Invalid point code (%s)%s", argv[1], VTY_NEWLINE); return CMD_WARNING; } rt = osmo_ss7_route_create(rtable, dpc, mask, ls_name); if (!rt) { - vty_out(vty, "cannot create route %s/%s to %s%s", + vty_out(vty, "%% Cannot create route %s/%s to %s%s", argv[0], argv[1], argv[2], VTY_NEWLINE); return CMD_WARNING; } @@ -394,6 +394,7 @@ return CMD_WARNING; break; /* Parse values below */ default: + vty_out(vty, "%% Incomplete command (missing an argument?)%s", VTY_NEWLINE); return CMD_WARNING; } diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 8aac9c1..b2f5270 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -621,3 +621,5 @@ ... route-table system ... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority +% Incomplete command (missing an argument?) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4fd5b30093425f1831348282d3563467c889e27f Gerrit-Change-Number: 38350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update rout...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38349?usp=email ) Change subject: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd ...................................................................... tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd Change-Id: Ie3632da3949eeafd234634849249c4d7c8a332d1 --- M tests/vty/osmo_stp_test.vty 1 file changed, 34 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 6205e50..8aac9c1 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -572,6 +572,21 @@ ... update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)] remove route POINT_CODE MASK +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass +... +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 OsmoSTP(config-cs7-rt)# show running-config ... @@ -580,10 +595,6 @@ route-table system update route 3.2.1 7.255.7 linkset my-ass priority 5 ... -cs7 instance 1 -... - route-table system -... !update route 3.2.1 7.255.7 linkset my-ass priority 5 OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 OsmoSTP(config-cs7-rt)# show running-config ... @@ -591,3 +602,22 @@ ... route-table system ... !update route 3.2.1 7.255.7 linkset my-ass priority 5 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +... +cs7 instance 1 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie3632da3949eeafd234634849249c4d7c8a332d1 Gerrit-Change-Number: 38349 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: vty: Fix 'update route' parameter comment descriptions

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38351?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: vty: Fix 'update route' parameter comment descriptions ...................................................................... vty: Fix 'update route' parameter comment descriptions There was one string which was not mapping to any actual param, making subsequent param descriptions show up incorrectly during VTY operation. Related: SYS#7112 Change-Id: Idb9d7d1b0eb260f6dea916287472c088d9719d8a --- M src/osmo_ss7_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 6d78c2e..0dd8a58 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -346,7 +346,6 @@ "Update the Route\n" "Destination Point Code\n" "Point Code Mask\n" - "Point Code Length\n" "Specify Destination Linkset\n" "Linkset Name\n" "Specify Priority\n" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idb9d7d1b0eb260f6dea916287472c088d9719d8a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4fd5b30093425f1831348282d3563467c889e27f Gerrit-Change-Number: 38350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 17:00:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update rout...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38349?usp=email ) Change subject: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie3632da3949eeafd234634849249c4d7c8a332d1 Gerrit-Change-Number: 38349 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 07 Oct 2024 17:00:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4fd5b30093425f1831348282d3563467c889e27f Gerrit-Change-Number: 38350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 16:59:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... Patch Set 1: (1 comment) File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350/comment/e96c7d8f_c2ad2… : PS1, Line 399: Invalid arg count %d > I find this message over-complicated a bit, maybe say `Incomplete command (missing an argument?)`? N […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4fd5b30093425f1831348282d3563467c889e27f Gerrit-Change-Number: 38350 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 16:58:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd

by pespin

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd Change-Id: I4fd5b30093425f1831348282d3563467c889e27f --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/50/38350/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4fd5b30093425f1831348282d3563467c889e27f Gerrit-Change-Number: 38350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: vty: Fix 'update route' parameter comment descriptions

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38351?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: vty: Fix 'update route' parameter comment descriptions ...................................................................... vty: Fix 'update route' parameter comment descriptions There was one string which was not mapping to any actual param, making subsequent param descriptions show up incorrectly during VTY operation. Related: SYS#7112 Change-Id: Idb9d7d1b0eb260f6dea916287472c088d9719d8a --- M src/osmo_ss7_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/51/38351/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idb9d7d1b0eb260f6dea916287472c088d9719d8a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2024