October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: publish-manuals-for-tags: fix build deps install
by osmith 09 Oct '24

09 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38368?usp=email ) Change subject: publish-manuals-for-tags: fix build deps install ...................................................................... publish-manuals-for-tags: fix build deps install Use the absolute path when checking for debian/control in build_publish_manuals(), as we aren't in the /build directory at that point. Fixes: 072b1eae88 ("manuals: publish pyosmocom manuals for releases") Change-Id: I8749107b974a4a8d57da868829a8f548404f3fa3 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/38368/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 50b7a3b..610457a 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -368,7 +368,7 @@ # Install dependencies case $repo in *) - if [ -e debian/control ]; then + if [ -e /build/debian/control ]; then apt-get -y build-dep /build fi ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8749107b974a4a8d57da868829a8f548404f3fa3 Gerrit-Change-Number: 38368 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: tag 0.0.6 for osmocom.construct.Asn1DerInteger
by osmith 09 Oct '24

09 Oct '24

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email ) Change subject: tag 0.0.6 for osmocom.construct.Asn1DerInteger ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/python/pyosmocom/+/38366/comment/2f31ea43_3790… : PS1, Line 7: tag 0.0.6 for osmocom.construct.Asn1DerInteger The "osmocom.construct.Asn1DerInteger" patch was in 0.0.5. How about: `Bump version: 0.0.6` This is similar to what we use in other Osmocom projects for release commits (which are generated with `make release`). Or alternatively: `Release 0.0.6` File debian/changelog: https://gerrit.osmocom.org/c/python/pyosmocom/+/38366/comment/2054a423_287c… : PS1, Line 5: -- Harald Welte <laforge(a)osmocom.org> Tue, 08 Oct 2024 17:09:43 +0200 It should say your name in the ` -- ` line. When running `gbp dch` (and manually adjusting the first line), I get: ``` pyosmocom (0.0.6) unstable; urgency=medium [ Harald Welte ] * tlv/cosmetic: improve import of osmocom functions -- Oliver Smith <osmith(a)sysmocom.de> Wed, 09 Oct 2024 09:47:40 +0200 ``` -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da Gerrit-Change-Number: 38366 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2024 07:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-msc[master]: libvlr: replace direct call of paging_expired() into a callback
by lynxis lazus 09 Oct '24

09 Oct '24

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email ) Change subject: libvlr: replace direct call of paging_expired() into a callback ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > ping? this also seems stuck on a small naming aspect for three weeks now... I'm sorry it took so long. I got stuck in finding a related memory issue and was in the meantime not sure if this was the best way to go to. But eventual I found the memory issue and I'm back convinced this is the best way we should go for. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7a3d15e8f0fb51c6b32add2de5024fc4d599ecf0 Gerrit-Change-Number: 38107 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 22:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-msc[master]: libvlr: replace direct call of paging_expired() into a callback
by lynxis lazus 09 Oct '24

09 Oct '24

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email ) Change subject: libvlr: replace direct call of paging_expired() into a callback ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: The build should succeed as soon the libosmocore commit hits the docker images. File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/c/osmo-msc/+/38107/comment/be689812_45e34c52?usp… : PS2, Line 473: int sgs_iface_tx_paging(struct vlr_subscr *vsub, enum sgsap_service_ind serv_ind) > yeah, it's mostly the name which is misleading, if it's doing more than transmit. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7a3d15e8f0fb51c6b32add2de5024fc4d599ecf0 Gerrit-Change-Number: 38107 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 22:54:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-hlr[master]: gsupclient: Introduce gsup_client_mux
by lynxis lazus 08 Oct '24

08 Oct '24

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email to look at the new patch set (#4). Change subject: gsupclient: Introduce gsup_client_mux ...................................................................... gsupclient: Introduce gsup_client_mux GSUP supports different message classes (e.g. SMS, USSD, Subscriber management), within a daemon, the messages are usually handled in different parts of it. The gsup client mux allow to place callbacks for the different message class. This code original comes from the osmo-msc code and is here re-licensed under the GPLv2. Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f --- M include/Makefile.am A include/osmocom/gsupclient/gsup_client_mux.h M src/gsupclient/Makefile.am A src/gsupclient/gsup_client_mux.c 4 files changed, 252 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/12/38112/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f Gerrit-Change-Number: 38112 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[L] Change in osmo-hlr[master]: gsupclient: Introduce gsup_client_mux
by lynxis lazus 08 Oct '24

08 Oct '24

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email ) Change subject: gsupclient: Introduce gsup_client_mux ...................................................................... Patch Set 3: (1 comment) This change is ready for review. Patchset: PS3: @laforge@gnumonks.org is a re-licensing GPL-v2.0+ fine? Or how should this work? Should this stay under AGPL? Or LGPL? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f Gerrit-Change-Number: 38112 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 08 Oct 2024 20:56:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom spec...
by lynxis lazus 08 Oct '24

08 Oct '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email ) Change subject: protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific) ...................................................................... protocol: gsm 29.118: add SGSAP_SERV_IND_PAGING_TIMEOUT (osmocom specific) To simplify the code, extend the service indication to also indicate a paging timeout. The VLR is using this type to indicate paging timeouts or aborting paging in case the SGs state has been terminated. Related: OS#6547 Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb --- M include/osmocom/gsm/protocol/gsm_29_118.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_29_118.h b/include/osmocom/gsm/protocol/gsm_29_118.h index 1583588..0e5842f 100644 --- a/include/osmocom/gsm/protocol/gsm_29_118.h +++ b/include/osmocom/gsm/protocol/gsm_29_118.h @@ -116,6 +116,7 @@ enum sgsap_service_ind { SGSAP_SERV_IND_CS_CALL = 0x01, SGSAP_SERV_IND_SMS = 0x02, + SGSAP_SERV_IND_PAGING_TIMEOUT = 0xfe, /* Osmocom specific to drop the paging */ }; extern const struct value_string sgsap_service_ind_names[]; static inline const char *sgsap_service_ind_name(enum sgsap_service_ind si) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58bfba50cb9c8aff2cd1cfe88d6467d4d2bd17cb Gerrit-Change-Number: 38125 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by lynxis lazus 08 Oct '24

08 Oct '24

Attention is currently required from: dexter, lynxis lazus. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Use %d instead of %i ...................................................................... Use %d instead of %i %d and %i has the same meaning when used in format string for printf. The linter will warn when using %i. %i was only added to provide symmetry between scanf() and printf(). Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf --- M src/sgsn/gprs_ranap.c M src/sgsn/slhc.c M tests/slhc/slhc_test.c M tests/sndcp_xid/sndcp_xid_test.c M tests/v42bis/v42bis_test.c M tests/xid/xid_test.c 6 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by Jenkins Builder 08 Oct '24

08 Oct '24

Attention is currently required from: dexter, lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email ) Change subject: Use %d instead of %i ...................................................................... Patch Set 2: (2 comments) File src/sgsn/slhc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19065): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/dfe448fc_82bf174c?us… : PS2, Line 542: DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %d\n",hlen); space required after that ',' (ctx:VxV) File tests/xid/xid_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19065): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/ae007978_40a2cfea?us… : PS2, Line 115: printf("Result length=%d\n",rc); space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 18:48:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by lynxis lazus 08 Oct '24

08 Oct '24

Attention is currently required from: dexter, lynxis lazus. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by dexter, Verified-1 by Jenkins Builder Change subject: Use %d instead of %i ...................................................................... Use %d instead of %i %d and %i has the same meaning when used in format string for printf. The linter will warn when using %i. %i was only added to provide symmetry between scanf() and printf(). Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf --- M src/sgsn/gprs_ranap.c M src/sgsn/slhc.c M tests/slhc/slhc_test.c M tests/sndcp_xid/sndcp_xid_test.c M tests/v42bis/v42bis_test.c M tests/xid/xid_test.c 6 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0