October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email ) Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 15: (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/e9381c4f_10a4ea44?us… : PS15, Line 54: * \param[in] msg l3 pointers must point to gmm. Return 0 on success or GMM cause this documentation looks broken. It starts using proper formatting, but then it's missing 1 param, and return should use proper syntax. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 12:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: move gsm48_gmm_att_tlvdef into gprs_gmm_util
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email ) Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ...................................................................... Patch Set 14: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/8121d138_7b6dd2bd?us… : PS14, Line 9: The gprs_gmm.c is huge. Move message parsing into gprS_gmm_util.c. gprs_ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d Gerrit-Change-Number: 37868 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 12:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: Refactor diffing same GMM messages
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email ) Change subject: Refactor diffing same GMM messages ...................................................................... Patch Set 14: Code-Review+1 (2 comments) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/7d7653ab_0647a475?us… : PS5, Line 1445: return -1; > is this an error? shouldn't it be 1? (see description above). Done File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/99e7d650_71e5921c?us… : PS14, Line 1434: * return 1 if length unequal So it's not clear what happened when it returns 1. We may want to change this case to "2". -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 Gerrit-Change-Number: 37867 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 12:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: Implement correct Routing Area based paging
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email ) Change subject: Implement correct Routing Area based paging ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f Gerrit-Change-Number: 37866 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 12:11:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-sgsn[master]: Add Routing Areas
by pespin 09 Oct '24

09 Oct '24

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email ) Change subject: Add Routing Areas ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 12:09:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.6
by dexter 09 Oct '24

09 Oct '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email ) Change subject: Bump version to 0.0.6 ...................................................................... Bump version to 0.0.6 Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da --- M debian/changelog M pyproject.toml 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index 0b15a26..479f8f6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +pyosmocom (0.0.6) unstable; urgency=medium + + * tlv/cosmetic: improve import of osmocom functions + + -- Philipp Maier <pmaier(a)sysmocom.de> Tue, 08 Oct 2024 17:09:43 +0200 + pyosmocom (0.0.5) unstable; urgency=medium [ Oliver Smith ] diff --git a/pyproject.toml b/pyproject.toml index 8d81d3e..16ac663 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ [project] name = "pyosmocom" -version = "0.0.5" +version = "0.0.6" dependencies = [ "gsm0338", "construct >= 2.9.51" -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da Gerrit-Change-Number: 38366 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.6
by osmith 09 Oct '24

09 Oct '24

Attention is currently required from: dexter, laforge. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email ) Change subject: Bump version to 0.0.6 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Thanks! Not sure if obvious: please make sure to re-tag 0.0.6 after merge, and then push the 0.0.6 tag. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da Gerrit-Change-Number: 38366 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2024 09:04:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.6
by dexter 09 Oct '24

09 Oct '24

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Bump version to 0.0.6 ...................................................................... Bump version to 0.0.6 Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da --- M debian/changelog M pyproject.toml 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/66/38366/2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da Gerrit-Change-Number: 38366 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.6
by dexter 09 Oct '24

09 Oct '24

Attention is currently required from: laforge, osmith. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email ) Change subject: Bump version to 0.0.6 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/python/pyosmocom/+/38366/comment/b79ad56d_57af… : PS1, Line 7: tag 0.0.6 for osmocom.construct.Asn1DerInteger > The "osmocom.construct.Asn1DerInteger" patch was in 0.0.5. […] Actually it seems to be "Bump version to x.x.x", I don't know why we did it differently last time. File debian/changelog: https://gerrit.osmocom.org/c/python/pyosmocom/+/38366/comment/29fed49f_3b3b… : PS1, Line 5: -- Harald Welte <laforge(a)osmocom.org> Tue, 08 Oct 2024 17:09:43 +0200 > It should say your name in the ` -- ` line. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da Gerrit-Change-Number: 38366 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Oct 2024 09:00:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: osmo-dev: build with gtp_linux.opts
by osmith 09 Oct '24

09 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38342?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: testenv: osmo-dev: build with gtp_linux.opts ...................................................................... testenv: osmo-dev: build with gtp_linux.opts Run the osmo-ggsn ./configure with --enable-gtp-linux, in preparation for testing kernel gtp-u with testenv too. Related: https://gitea.osmocom.org/osmocom/osmo-dev/src/branch/master/gtp_linux.opts Change-Id: Ia8ea5494597e0fedae93f501c8bc7d6115543f36 --- M _testenv/testenv/osmo_dev.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 00782cd..d3f7a1c 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -82,6 +82,7 @@ testenv.src_dir, "default.opts", "ccache.opts", + "gtp_linux.opts", "iu.opts", "no_dahdi.opts", "no_doxygen.opts", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8ea5494597e0fedae93f501c8bc7d6115543f36 Gerrit-Change-Number: 38342 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0