Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email ) Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 15: (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/e9381c4f_10a4ea44?usp... : PS15, Line 54: * \param[in] msg l3 pointers must point to gmm. Return 0 on success or GMM cause this documentation looks broken. It starts using proper formatting, but then it's missing 1 param, and return should use proper syntax. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 12:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No