Attention is currently required from: daniel, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email
to look at the new patch set (#14).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add Routing Areas
......................................................................
Add Routing Areas
Add a routing area layer which tracks routing area and
cells within a routing area.
Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa
---
M configure.ac
M include/osmocom/sgsn/Makefile.am
M include/osmocom/sgsn/debug.h
A include/osmocom/sgsn/gprs_routing_area.h
M include/osmocom/sgsn/sgsn.h
M src/sgsn/Makefile.am
M src/sgsn/gprs_bssgp.c
M src/sgsn/gprs_ns.c
A src/sgsn/gprs_routing_area.c
M src/sgsn/sgsn.c
M src/sgsn/sgsn_main.c
M tests/Makefile.am
A tests/gprs_routing_area/Makefile.am
A tests/gprs_routing_area/gprs_routing_area_test.c
A tests/gprs_routing_area/gprs_routing_area_test.ok
M tests/sgsn/Makefile.am
M tests/testsuite.at
17 files changed, 972 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/37864/14
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa
Gerrit-Change-Number: 37864
Gerrit-PatchSet: 14
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file
......................................................................
Patch Set 14:
(5 comments)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/f1d2e37d_b88af41b?us… :
PS5, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type);
> > Use %d instead of %i […]
Done
File src/sgsn/gprs_gmm_util.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/8f549f47_0ebfdf30?us… :
PS5, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg))))
> > that open brace { should be on the previous line […]
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/6058083d_eeb9e0dc?us… :
PS5, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) {
> > braces {} are not necessary for single statement blocks […]
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/534fce5d_a6eb4867?us… :
PS5, Line 115: if (ret < 0) {
> > braces {} are not necessary for single statement blocks […]
Done
File src/sgsn/gprs_gmm_util.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/6067b7e3_bf612e8a?us… :
PS8, Line 31: /* 9.4.14 RAU Request */
> This is already present in gprs_gmm_util. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
Gerrit-Change-Number: 37869
Gerrit-PatchSet: 14
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 18:45:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email )
Change subject: Implement correct Routing Area based paging
......................................................................
Patch Set 12:
(1 comment)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/ffe0cf8d_4c73cd7c?us… :
PS5, Line 319: }
> no the function is only called for geran.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f
Gerrit-Change-Number: 37866
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 18:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email )
Change subject: sip.c: permit early media with both 183 and 180
......................................................................
sip.c: permit early media with both 183 and 180
So far we only attempted to extract SDP (and hence enable early media)
when receiving a status code 183. However, SDP can also be provided
with 180, see for example https://developer.signalwire.com/freeswitch/FreeSWITCH-Explained/Codecs-and…
Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Closes: OS#6559
---
M src/sip.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
diff --git a/src/sip.c b/src/sip.c
index 99bab9f..3e262f9 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -82,7 +82,7 @@
return;
/* Extract SDP for session in progress with matching codec */
- if (status == 183)
+ if ((status == 180 || status == 183) && sip->sip_payload && sip->sip_payload->pl_data)
sdp_extract_sdp(leg, sip, false);
LOGP(DSIP, LOGL_INFO, "leg(%p) is now progressing.\n", leg);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Gerrit-Change-Number: 38039
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: keith <keith(a)rhizomatica.org>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email )
Change subject: tag 0.0.6 for osmocom.construct.Asn1DerInteger
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da
Gerrit-Change-Number: 38366
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 17:09:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38367?usp=email )
Change subject: fix typos in README + doc
......................................................................
fix typos in README + doc
Change-Id: I8329bc1a2876551e26a50ca86f788f0d2d3144a6
---
M README.md
M doc/manuals/chapters/overview.adoc
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/README.md b/README.md
index 98588aa..e7b4841 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-upf-bencharmk - Tools and configs to set up UPF benchmarking
+upf-benchmark - Tools and configs to set up UPF benchmarking
============================================================
Homepage
diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc
index 157c6dc..8ed2194 100644
--- a/doc/manuals/chapters/overview.adoc
+++ b/doc/manuals/chapters/overview.adoc
@@ -4,9 +4,9 @@
== Overview
This manual should help you getting started with the several tools and
-testsuites available in up-benchmark.
+testsuites available in upf-benchmark.
[[intro_overview]]
=== About upf-benchmark
- TODO
\ No newline at end of file
+ TODO
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38367?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I8329bc1a2876551e26a50ca86f788f0d2d3144a6
Gerrit-Change-Number: 38367
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38367?usp=email )
Change subject: fix typos in README + doc
......................................................................
fix typos in README + doc
Change-Id: I8329bc1a2876551e26a50ca86f788f0d2d3144a6
---
M README.md
M doc/manuals/chapters/overview.adoc
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/67/38367/1
diff --git a/README.md b/README.md
index 98588aa..e7b4841 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-upf-bencharmk - Tools and configs to set up UPF benchmarking
+upf-benchmark - Tools and configs to set up UPF benchmarking
============================================================
Homepage
diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc
index 157c6dc..8ed2194 100644
--- a/doc/manuals/chapters/overview.adoc
+++ b/doc/manuals/chapters/overview.adoc
@@ -4,9 +4,9 @@
== Overview
This manual should help you getting started with the several tools and
-testsuites available in up-benchmark.
+testsuites available in upf-benchmark.
[[intro_overview]]
=== About upf-benchmark
- TODO
\ No newline at end of file
+ TODO
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38367?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I8329bc1a2876551e26a50ca86f788f0d2d3144a6
Gerrit-Change-Number: 38367
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>