Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email )
Change subject: ttcn3-epdg: Run osmo-epdg as root
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/791244c2_d07…
PS1, Line 11: requires
CAP_NET_ADMIN should be sufficient both for using the gtp kernel module as well as adding/setting interface addresses. So at least in theory something like "--cap-add NET_ADMIN" should be sufficient. In case the gtp kernel module is auto-loaded, not sure if SYS_MODULE might also be required (I'd hope not).
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474
Gerrit-Change-Number: 35607
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 07:20:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35606?usp=email )
Change subject: osmo-epdg-master: Remove rebar.lock to force build against updated dependencies
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35606?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia9112d641e80d1eddcddea1e54e4c135d6efcc5b
Gerrit-Change-Number: 35606
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 07:16:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email )
Change subject: mobile: init/deinit GAPK I/O based on CC transaction events
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/include/osmocom/bb/mobile/tch.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/35579/comment/7a9c7e62_c2b3dcb9
PS3, Line 8: bool voice_or_data; /* voice (true) or data (false) */
> it is totally misleading because when reading code "if (voice_or_data)" it clearly seems to (wrongly […]
Done.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b
Gerrit-Change-Number: 35579
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jan 2024 21:52:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment