January 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-e1d[master]: Add functions to events from server to client
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: jolly, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email ) Change subject: Add functions to events from server to client ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/e1d.h: https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/a886cb93_14e1c058 PS1, Line 199: void *srv; > Yeah I saw later, but you can still use `struct osmo_e1dp_server *srv` (with appropriate pre-declara […] I agree with tnt here. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e Gerrit-Change-Number: 35558 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:55:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

1 0

[M] Change in osmo-e1d[master]: Add new protocol command and events for Sa bits and line states
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email ) Change subject: Add new protocol command and events for Sa bits and line states ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File include/osmocom/e1d/proto.h: https://gerrit.osmocom.org/c/osmo-e1d/+/35557/comment/59763f80_a4f85c06 PS1, Line 83: E1DP_EVT_SABITS = 0x7f, > If new line events are added in the future, I don't want to have Sa-bits event between line events. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4c20ec19fa3d9cce82c8199b38d173aa272fb07d Gerrit-Change-Number: 35557 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: gsup_server: Improve log line when listening on gsup
by laforge 18 Jan '24

18 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35590?usp=email ) Change subject: gsup_server: Improve log line when listening on gsup ...................................................................... gsup_server: Improve log line when listening on gsup Change-Id: I7dccc20b6c2c0f58cdd3a43469053624927c9acd --- M src/gsup_server.erl 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsup_server.erl b/src/gsup_server.erl index fcb19a0..030a328 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -92,7 +92,7 @@ }, case ipa_proto:start_listen(Port, 1, Options) of {ok, LSocket, Port} -> - lager:info("connected!~n", []), + lager:info("GSUP server listen socket ~p~n", [LSocket]), {ok, #gsups_state{lsocket = LSocket, lport = Port, ccm_options = CcmOptions}}; {error, econnrefused} -> timer:sleep(5000), @@ -135,7 +135,6 @@ ipa_proto:set_ccm_options(Socket, S#gsups_state.ccm_options), true = ipa_proto:register_stream(Socket, ?IPAC_PROTO_EXT_GSUP, {process_id, self()}), ipa_proto:unblock(Socket), - lager:info("connected!~n", []), {noreply, S#gsups_state{socket=Socket}}; % send auth info / requesting authentication tuples -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7dccc20b6c2c0f58cdd3a43469053624927c9acd Gerrit-Change-Number: 35590 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in ...osmo-epdg[master]: diameter: Allow configuring (re)connect timer in s6b and swx
by laforge 18 Jan '24

18 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35588?usp=email ) Change subject: diameter: Allow configuring (re)connect timer in s6b and swx ...................................................................... diameter: Allow configuring (re)connect timer in s6b and swx TTCN3 tests will require lower values to avoid timing out. Change-Id: I7d280f83f4f375eaf34ea3b69a421372af54ffdb --- M config/sys.config M src/aaa_diameter_s6b.erl M src/epdg_diameter_swx.erl 3 files changed, 40 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/config/sys.config b/config/sys.config index 630a057..35e1492 100755 --- a/config/sys.config +++ b/config/sys.config @@ -9,6 +9,8 @@ {diameter_remote_ip, "127.0.0.1"}, {diameter_remote_port, 3868}, {diameter_proto, sctp}, + {diameter_connect_timer, 30000}, + {diameter_watchdog_timer, 30000}, {vendor_id, 0}, {origin_host, "epdg.localdomain"}, {origin_realm, "localdomain"}, @@ -17,6 +19,8 @@ {dia_s6b_local_ip, "127.0.0.10"}, {dia_s6b_local_port, 3868}, {dia_s6b_proto, sctp}, + {dia_s6b_connect_timer, 30000}, + {dia_s6b_watchdog_timer, 30000}, {dia_s6b_vendor_id, 0}, {dia_s6b_origin_host, "aaa.localdomain"}, {dia_s6b_origin_realm, "localdomain"}, diff --git a/src/aaa_diameter_s6b.erl b/src/aaa_diameter_s6b.erl index 4ee0219..e4fff31 100644 --- a/src/aaa_diameter_s6b.erl +++ b/src/aaa_diameter_s6b.erl @@ -67,6 +67,8 @@ -define(ENV_DEFAULT_DIAMETER_PROTO, sctp). -define(ENV_DEFAULT_DIAMETER_REMOTE_IP, "127.0.0.10"). -define(ENV_DEFAULT_DIAMETER_REMOTE_PORT, 3868). +-define(ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS, 30000). +-define(ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS, 30000). -define(VENDOR_ID_3GPP, 10415). -define(VENDOR_ID_3GPP2, 5535). @@ -121,9 +123,11 @@ Proto = application:get_env(?ENV_APP_NAME, dia_s6b_proto, ?ENV_DEFAULT_DIAMETER_PROTO), Ip = application:get_env(?ENV_APP_NAME, dia_s6b_local_ip, ?ENV_DEFAULT_DIAMETER_REMOTE_IP), Port = application:get_env(?ENV_APP_NAME, dia_s6b_local_port, ?ENV_DEFAULT_DIAMETER_REMOTE_PORT), + ConnectTimer = application:get_env(?ENV_APP_NAME, dia_s6b_connect_timer, ?ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS), + WatchdogTimer = application:get_env(?ENV_APP_NAME, dia_s6b_watchdog_timer, ?ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS), ok = diameter:start_service(?MODULE, ?SERVICE), % lager:info("DiaServices is ~p~n", [DiaServ]), - {ok, _} = listen({address, Proto, Ip, Port}), + {ok, _} = listen({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer}), {ok, State}. test() -> @@ -176,8 +180,7 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -%% connect/2 -listen(Name, {address, Protocol, IPAddr, Port}) -> +listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer, WatchdogTimer}) -> lager:notice("~s Listening on IP ~s port ~p~n", [Name, IPAddr, Port]), {ok, IP} = inet_parse:address(IPAddr), TransportOpts = @@ -188,11 +191,13 @@ {port, Port} %%{raddr, IP}, %%{rport, Port} - ]}], - diameter:add_transport(Name, {listen, [{reconnect_timer, 1000} | TransportOpts]}). + ]}, + {connect_timer, ConnectTimer}, + {watchdog_timer, WatchdogTimer}], + diameter:add_transport(Name, {listen, TransportOpts}). -listen(Address) -> - listen(?SVC_NAME, Address). +listen(Address, Timers) -> + listen(?SVC_NAME, Address, Timers). %% Convert connection type tmod(tcp) -> diff --git a/src/epdg_diameter_swx.erl b/src/epdg_diameter_swx.erl index c278206..ada8555 100644 --- a/src/epdg_diameter_swx.erl +++ b/src/epdg_diameter_swx.erl @@ -67,6 +67,8 @@ -define(ENV_DEFAULT_DIAMETER_PROTO, sctp). -define(ENV_DEFAULT_DIAMETER_REMOTE_IP, "127.0.0.1"). -define(ENV_DEFAULT_DIAMETER_REMOTE_PORT, 3868). +-define(ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS, 30000). +-define(ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS, 30000). -define(VENDOR_ID_3GPP, 10415). -define(VENDOR_ID_3GPP2, 5535). @@ -121,9 +123,11 @@ Proto = application:get_env(?ENV_APP_NAME, diameter_proto, ?ENV_DEFAULT_DIAMETER_PROTO), Ip = application:get_env(?ENV_APP_NAME, diameter_remote_ip, ?ENV_DEFAULT_DIAMETER_REMOTE_IP), Port = application:get_env(?ENV_APP_NAME, diameter_remote_port, ?ENV_DEFAULT_DIAMETER_REMOTE_PORT), + ConnectTimer = application:get_env(?ENV_APP_NAME, diameter_connect_timer, ?ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS), + WatchdogTimer = application:get_env(?ENV_APP_NAME, diameter_watchdog_timer, ?ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS), ok = diameter:start_service(?MODULE, ?SERVICE), % lager:info("DiaServices is ~p~n", [DiaServ]), - {ok, _} = connect({address, Proto, Ip, Port}), + {ok, _} = connect({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer}), {ok, State}. test() -> @@ -256,8 +260,8 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -%% connect/2 -connect(Name, {address, Protocol, IPAddr, Port}) -> +%% connect/3 +connect(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer, WatchdogTimer}) -> lager:notice("~s connecting to IP ~s port ~p~n", [Name, IPAddr, Port]), {ok, IP} = inet_parse:address(IPAddr), TransportOpts = @@ -265,11 +269,13 @@ {transport_config, [{reuseaddr, true}, {raddr, IP}, - {rport, Port}]}], - diameter:add_transport(Name, {connect, [{reconnect_timer, 1000} | TransportOpts]}). + {rport, Port}]}, + {connect_timer, ConnectTimer}, + {watchdog_timer, WatchdogTimer}], + diameter:add_transport(Name, {connect, TransportOpts}). -connect(Address) -> - connect(?SVC_NAME, Address). +connect(Address, Timers) -> + connect(?SVC_NAME, Address, Timers). %% Convert connection type tmod(tcp) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7d280f83f4f375eaf34ea3b69a421372af54ffdb Gerrit-Change-Number: 35588 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: gsup_server: Remove incorrect log about reconnecting
by laforge 18 Jan '24

18 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35589?usp=email ) Change subject: gsup_server: Remove incorrect log about reconnecting ...................................................................... gsup_server: Remove incorrect log about reconnecting osmo-epdg is a GSUP server, so if conn goes down it won't reconnect. That's the duty of the client. Change-Id: Ib5a8f1eb6d873f85d526222f76768d2b81f08d90 --- M src/gsup_server.erl 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve diff --git a/src/gsup_server.erl b/src/gsup_server.erl index 14d2364..fcb19a0 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -124,7 +124,7 @@ % When the IPA connection is closed. handle_info({ipa_closed, _}, S) -> - lager:error("GSUP connection has been closed, supervisor should reconnect us"), + lager:error("GSUP connection has been closed"), {noreply, S}; % FIXME: handle multiple concurrent connection well -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ib5a8f1eb6d873f85d526222f76768d2b81f08d90 Gerrit-Change-Number: 35589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: diameter: Make diameter_watchdog_config configurable
by laforge 18 Jan '24

18 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35591?usp=email ) Change subject: diameter: Make diameter_watchdog_config configurable ...................................................................... diameter: Make diameter_watchdog_config configurable This allows tweaking values in config file of TTCN3 tests to speed up test setup. Change-Id: I99b5e02264c2c35a3fbfcd2d6083a07e2cfea566 --- M config/sys.config M src/aaa_diameter_s6b.erl M src/epdg_diameter_swx.erl 3 files changed, 30 insertions(+), 6 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/config/sys.config b/config/sys.config index 35e1492..b3ce69f 100755 --- a/config/sys.config +++ b/config/sys.config @@ -11,6 +11,9 @@ {diameter_proto, sctp}, {diameter_connect_timer, 30000}, {diameter_watchdog_timer, 30000}, + {diameter_watchdog_config, + [{okay, 3}, + {suspect, 1}]}, {vendor_id, 0}, {origin_host, "epdg.localdomain"}, {origin_realm, "localdomain"}, @@ -21,6 +24,9 @@ {dia_s6b_proto, sctp}, {dia_s6b_connect_timer, 30000}, {dia_s6b_watchdog_timer, 30000}, + {dia_s6b_watchdog_config, + [{okay, 3}, + {suspect, 1}]}, {dia_s6b_vendor_id, 0}, {dia_s6b_origin_host, "aaa.localdomain"}, {dia_s6b_origin_realm, "localdomain"}, diff --git a/src/aaa_diameter_s6b.erl b/src/aaa_diameter_s6b.erl index e4fff31..59b9679 100644 --- a/src/aaa_diameter_s6b.erl +++ b/src/aaa_diameter_s6b.erl @@ -69,6 +69,7 @@ -define(ENV_DEFAULT_DIAMETER_REMOTE_PORT, 3868). -define(ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS, 30000). -define(ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS, 30000). +-define(ENV_DEFAULT_DIAMETER_WATCHDOG_CFG, [{okay, 3}, {suspect, 1}]). -define(VENDOR_ID_3GPP, 10415). -define(VENDOR_ID_3GPP2, 5535). @@ -125,9 +126,10 @@ Port = application:get_env(?ENV_APP_NAME, dia_s6b_local_port, ?ENV_DEFAULT_DIAMETER_REMOTE_PORT), ConnectTimer = application:get_env(?ENV_APP_NAME, dia_s6b_connect_timer, ?ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS), WatchdogTimer = application:get_env(?ENV_APP_NAME, dia_s6b_watchdog_timer, ?ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS), + WatchdogConfig = application:get_env(?ENV_APP_NAME, diameter_watchdog_config, ?ENV_DEFAULT_DIAMETER_WATCHDOG_CFG), ok = diameter:start_service(?MODULE, ?SERVICE), % lager:info("DiaServices is ~p~n", [DiaServ]), - {ok, _} = listen({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer}), + {ok, _} = listen({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer, WatchdogConfig}), {ok, State}. test() -> @@ -180,7 +182,7 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer, WatchdogTimer}) -> +listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer, WatchdogTimer, WatchdogConfig}) -> lager:notice("~s Listening on IP ~s port ~p~n", [Name, IPAddr, Port]), {ok, IP} = inet_parse:address(IPAddr), TransportOpts = @@ -193,7 +195,8 @@ %%{rport, Port} ]}, {connect_timer, ConnectTimer}, - {watchdog_timer, WatchdogTimer}], + {watchdog_timer, WatchdogTimer}, + {watchdog_config, WatchdogConfig}], diameter:add_transport(Name, {listen, TransportOpts}). listen(Address, Timers) -> diff --git a/src/epdg_diameter_swx.erl b/src/epdg_diameter_swx.erl index ada8555..a2a040c 100644 --- a/src/epdg_diameter_swx.erl +++ b/src/epdg_diameter_swx.erl @@ -69,6 +69,7 @@ -define(ENV_DEFAULT_DIAMETER_REMOTE_PORT, 3868). -define(ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS, 30000). -define(ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS, 30000). +-define(ENV_DEFAULT_DIAMETER_WATCHDOG_CFG, [{okay, 3}, {suspect, 1}]). -define(VENDOR_ID_3GPP, 10415). -define(VENDOR_ID_3GPP2, 5535). @@ -125,9 +126,10 @@ Port = application:get_env(?ENV_APP_NAME, diameter_remote_port, ?ENV_DEFAULT_DIAMETER_REMOTE_PORT), ConnectTimer = application:get_env(?ENV_APP_NAME, diameter_connect_timer, ?ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS), WatchdogTimer = application:get_env(?ENV_APP_NAME, diameter_watchdog_timer, ?ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS), + WatchdogConfig = application:get_env(?ENV_APP_NAME, diameter_watchdog_config, ?ENV_DEFAULT_DIAMETER_WATCHDOG_CFG), ok = diameter:start_service(?MODULE, ?SERVICE), % lager:info("DiaServices is ~p~n", [DiaServ]), - {ok, _} = connect({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer}), + {ok, _} = connect({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer, WatchdogConfig}), {ok, State}. test() -> @@ -261,7 +263,7 @@ %% ------------------------------------------------------------------ %% connect/3 -connect(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer, WatchdogTimer}) -> +connect(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer, WatchdogTimer, WatchdogConfig}) -> lager:notice("~s connecting to IP ~s port ~p~n", [Name, IPAddr, Port]), {ok, IP} = inet_parse:address(IPAddr), TransportOpts = @@ -271,7 +273,8 @@ {raddr, IP}, {rport, Port}]}, {connect_timer, ConnectTimer}, - {watchdog_timer, WatchdogTimer}], + {watchdog_timer, WatchdogTimer}, + {watchdog_config, WatchdogConfig}], diameter:add_transport(Name, {connect, TransportOpts}). connect(Address, Timers) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I99b5e02264c2c35a3fbfcd2d6083a07e2cfea566 Gerrit-Change-Number: 35591 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in ...osmo-epdg[master]: cosmetic: sys.config: Clean up formatting of logging section
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35605?usp=email ) Change subject: cosmetic: sys.config: Clean up formatting of logging section ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6a992ddef6f9807f360f770d6d5e9185f36559d1 Gerrit-Change-Number: 35605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:50:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: swx: Rename diameter related parameters
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email ) Change subject: swx: Rename diameter related parameters ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598/comment/326d7a86_f872… PS1, Line 7: swx: Rena I gues what's missing here in the commit log is *why*. I see this every so often that the commit log summarizes what the patch does, but not the rationale. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f Gerrit-Change-Number: 35598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:49:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: diameter: Make diameter_watchdog_config configurable
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35591?usp=email ) Change subject: diameter: Make diameter_watchdog_config configurable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I99b5e02264c2c35a3fbfcd2d6083a07e2cfea566 Gerrit-Change-Number: 35591 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:49:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: diameter: Allow configuring (re)connect timer in s6b and swx
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35588?usp=email ) Change subject: diameter: Allow configuring (re)connect timer in s6b and swx ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7d280f83f4f375eaf34ea3b69a421372af54ffdb Gerrit-Change-Number: 35588 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:49:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0