lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2024

  • 1 participants
  • 1559 discussions
[M] Change in ...osmo-epdg[master]: cosmetic: sys.config: Clean up formatting of logging section
by pespin 18 Jan '24

18 Jan '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35605?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cosmetic: sys.config: Clean up formatting of logging section ...................................................................... cosmetic: sys.config: Clean up formatting of logging section Content is not changed, simply rearranged. Change-Id: I6a992ddef6f9807f360f770d6d5e9185f36559d1 --- M config/sys.config 1 file changed, 34 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/config/sys.config b/config/sys.config index bffa289..3f9d607 100755 --- a/config/sys.config +++ b/config/sys.config @@ -51,23 +51,26 @@ % %% =========================================== %% Lager logging config %% =========================================== - {lager, - [{log_root, "log"}, - {colored, true}, - {handlers, - [{lager_console_backend, [{level, info}]}, - {lager_file_backend, - [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, - {lager_file_backend, - [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, - {crash_log, "crash.log"}, - {crash_log_msg_size, 65536}, - {crash_log_size, 104857600}, - {crash_log_date, "$D0"}, - {crash_log_count, 10}, - {error_logger_redirect, true}]}, - {kernel, - [{logger, - [{handler, debug, logger_std_h, % {handler, HandlerId, Module, - #{config => #{file => "log/erlang.log"}}} % Config} - ]}]}]. + {lager, [ + {log_root, "log"}, + {colored, true}, + {handlers, + [{lager_console_backend, [{level, debug}]}, + {lager_file_backend, + [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, + {lager_file_backend, + [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, + {crash_log, "crash.log"}, + {crash_log_msg_size, 65536}, + {crash_log_size, 104857600}, + {crash_log_date, "$D0"}, + {crash_log_count, 10}, + {error_logger_redirect, true} + ]}, + {kernel, [ + {logger, [{handler, debug, logger_std_h, % {handler, HandlerId, Module, + #{config => #{file => "log/erlang.log"}} + }] + } + ]} +]. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6a992ddef6f9807f360f770d6d5e9185f36559d1 Gerrit-Change-Number: 35605 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in ...osmo-epdg[master]: swx: Rename diameter related parameters
by pespin 18 Jan '24

18 Jan '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email ) Change subject: swx: Rename diameter related parameters ...................................................................... swx: Rename diameter related parameters This allows easily identifying and differntiating the config parameters from other diameter interfaces present such as s6b. Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f --- M config/sys.config M src/epdg_diameter_swx.erl 2 files changed, 31 insertions(+), 19 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/config/sys.config b/config/sys.config index b3ce69f..bffa289 100755 --- a/config/sys.config +++ b/config/sys.config @@ -6,18 +6,18 @@ {gsup_local_ip, "0.0.0.0"}, {gsup_local_port, 4222}, % Diameter SWx Connection parameters - {diameter_remote_ip, "127.0.0.1"}, - {diameter_remote_port, 3868}, - {diameter_proto, sctp}, - {diameter_connect_timer, 30000}, - {diameter_watchdog_timer, 30000}, - {diameter_watchdog_config, + {dia_swx_remote_ip, "127.0.0.1"}, + {dia_swx_remote_port, 3868}, + {dia_swx_proto, sctp}, + {dia_swx_connect_timer, 30000}, + {dia_swx_watchdog_timer, 30000}, + {dia_swx_watchdog_config, [{okay, 3}, {suspect, 1}]}, - {vendor_id, 0}, - {origin_host, "epdg.localdomain"}, - {origin_realm, "localdomain"}, - {context_id, "epdg@localdomain"}, + {dia_swx_vendor_id, 0}, + {dia_swx_origin_host, "epdg.localdomain"}, + {dia_swx_origin_realm, "localdomain"}, + {dia_swx_context_id, "epdg@localdomain"}, % Diameter s6b Connection parameters {dia_s6b_local_ip, "127.0.0.10"}, {dia_s6b_local_port, 3868}, diff --git a/src/epdg_diameter_swx.erl b/src/epdg_diameter_swx.erl index a2a040c..5c2ebca 100644 --- a/src/epdg_diameter_swx.erl +++ b/src/epdg_diameter_swx.erl @@ -79,9 +79,9 @@ %% supporting multiple Diameter applications may or may not want to %% configure a common callback module on all applications. -define(SERVICE, - [{'Origin-Host', application:get_env(?ENV_APP_NAME, origin_host, ?ENV_DEFAULT_ORIG_HOST)}, - {'Origin-Realm', application:get_env(?ENV_APP_NAME, origin_realm, ?ENV_DEFAULT_ORIG_REALM)}, - {'Vendor-Id', application:get_env(?ENV_APP_NAME, vendor_id, ?ENV_DEFAULT_VENDOR_ID)}, + [{'Origin-Host', application:get_env(?ENV_APP_NAME, dia_swx_origin_host, ?ENV_DEFAULT_ORIG_HOST)}, + {'Origin-Realm', application:get_env(?ENV_APP_NAME, dia_swx_origin_realm, ?ENV_DEFAULT_ORIG_REALM)}, + {'Vendor-Id', application:get_env(?ENV_APP_NAME, dia_swx_vendor_id, ?ENV_DEFAULT_VENDOR_ID)}, {'Vendor-Specific-Application-Id', [#'diameter_base_Vendor-Specific-Application-Id'{ 'Vendor-Id' = ?VENDOR_ID_3GPP, @@ -121,12 +121,12 @@ ok. init(State) -> - Proto = application:get_env(?ENV_APP_NAME, diameter_proto, ?ENV_DEFAULT_DIAMETER_PROTO), - Ip = application:get_env(?ENV_APP_NAME, diameter_remote_ip, ?ENV_DEFAULT_DIAMETER_REMOTE_IP), - Port = application:get_env(?ENV_APP_NAME, diameter_remote_port, ?ENV_DEFAULT_DIAMETER_REMOTE_PORT), - ConnectTimer = application:get_env(?ENV_APP_NAME, diameter_connect_timer, ?ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS), - WatchdogTimer = application:get_env(?ENV_APP_NAME, diameter_watchdog_timer, ?ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS), - WatchdogConfig = application:get_env(?ENV_APP_NAME, diameter_watchdog_config, ?ENV_DEFAULT_DIAMETER_WATCHDOG_CFG), + Proto = application:get_env(?ENV_APP_NAME, dia_swx_proto, ?ENV_DEFAULT_DIAMETER_PROTO), + Ip = application:get_env(?ENV_APP_NAME, dia_swx_remote_ip, ?ENV_DEFAULT_DIAMETER_REMOTE_IP), + Port = application:get_env(?ENV_APP_NAME, dia_swx_remote_port, ?ENV_DEFAULT_DIAMETER_REMOTE_PORT), + ConnectTimer = application:get_env(?ENV_APP_NAME, dia_swx_connect_timer, ?ENV_DEFAULT_DIAMETER_CONNECT_TIMER_MS), + WatchdogTimer = application:get_env(?ENV_APP_NAME, dia_swx_watchdog_timer, ?ENV_DEFAULT_DIAMETER_WATCHDOG_TIMER_MS), + WatchdogConfig = application:get_env(?ENV_APP_NAME, dia_swx_watchdog_config, ?ENV_DEFAULT_DIAMETER_WATCHDOG_CFG), ok = diameter:start_service(?MODULE, ?SERVICE), % lager:info("DiaServices is ~p~n", [DiaServ]), {ok, _} = connect({address, Proto, Ip, Port}, {timer, ConnectTimer, WatchdogTimer, WatchdogConfig}), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f Gerrit-Change-Number: 35598 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in ...osmo-epdg[master]: swx: Rename diameter related parameters
by pespin 18 Jan '24

18 Jan '24
Attention is currently required from: daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email ) Change subject: swx: Rename diameter related parameters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f Gerrit-Change-Number: 35598 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 13:04:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in ...osmo-epdg[master]: swx: Rename diameter related parameters
by pespin 18 Jan '24

18 Jan '24
Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by laforge Change subject: swx: Rename diameter related parameters ...................................................................... swx: Rename diameter related parameters This allows easily identifying and differntiating the config parameters from other diameter interfaces present such as s6b. Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f --- M config/sys.config M src/epdg_diameter_swx.erl 2 files changed, 31 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/98/35598/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f Gerrit-Change-Number: 35598 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[M] Change in ...osmo-epdg[master]: WIP: Initial gtp tunnel implementation
by pespin 18 Jan '24

18 Jan '24
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35610?usp=email ) Change subject: WIP: Initial gtp tunnel implementation ...................................................................... WIP: Initial gtp tunnel implementation Change-Id: I1cb5a88b714242d579aac22cc13a2474abb195c6 --- M Makefile M config/sys.config M debian/osmo-epdg.install M rebar.config M rebar.lock M src/osmo_epdg.app.src 6 files changed, 59 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/10/35610/1 diff --git a/Makefile b/Makefile index 0470458..346ea91 100644 --- a/Makefile +++ b/Makefile @@ -23,3 +23,9 @@ else rm -f src/diameter_*.erl endif + +NETDEV=gtp0 + +pespin-test: + sudo ip link del $(NETDEV) || true + sudo rebar3 shell --config ./config/sys.config diff --git a/config/sys.config b/config/sys.config index 3f9d607..ce033ca 100755 --- a/config/sys.config +++ b/config/sys.config @@ -38,6 +38,27 @@ {gtpc_remote_port, 2123} ]}, %% =========================================== + %% gtp_u_kmod config + %% =========================================== + {gtp_u_kmod, [ + {sockets, [{grx, [{ip, {192,0,2,16}}, + %%{netdev, "grx"}, + freebind, + {vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%, + %%{netdev, "upstream"} + ] + } + ] + }] + } + ]}, + %% =========================================== + %% gen_socket config + %% =========================================== + {gen_socket, [ + {libdir, "_build/default/lib/gen_socket/priv/lib"} +]}, + %% =========================================== %% SASL config %% =========================================== {sasl, [{sasl_error_logger, false}]}, diff --git a/debian/osmo-epdg.install b/debian/osmo-epdg.install index 0840d06..62aec37 100644 --- a/debian/osmo-epdg.install +++ b/debian/osmo-epdg.install @@ -1,2 +1,3 @@ /contrib/systemd/osmo-epdg.service /lib/systemd/system/ /_build/default/bin/osmo-epdg /usr/bin/ +/_build/default/lib/gen_socket/priv/lib/gen_socket*.so /usr/lib/${DEB_HOST_MULTIARCH}/ diff --git a/rebar.config b/rebar.config index d834c32..35f17e3 100644 --- a/rebar.config +++ b/rebar.config @@ -5,6 +5,7 @@ {deps, [ {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.2"}}}, {gtplib, "3.2.0"}, + {gtp_u_kmod, {git, "https://github.com/osmocom/gtp_u_kmod", {branch, "pespin/master"}}}, {osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7", {ref, "9f294d3612f998860004820d1d85b4264721577b"}}}, {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {ref, "07672d8ab1608aa9c9e50ca035521876558fcd42"}}} ]}. diff --git a/rebar.lock b/rebar.lock index 8f00ea6..d63ebd5 100644 --- a/rebar.lock +++ b/rebar.lock @@ -2,9 +2,25 @@ [{<<"cut">>,{pkg,<<"cut">>,<<"1.0.3">>},1}, {<<"epcap">>, {git,"https://github.com/msantos/epcap", - {ref,"d5c03caf608c1369e68cfed0a606d3eb82ddfd21"}}, + {ref,"b98edbfbb0392101cd874b098caa5180f2f44b2e"}}, 1}, + {<<"erlando">>, + {git,"https://github.com/travelping/erlando.git", + {ref,"2cb56e06308beb4d65ae2217a02dc60bafc99b9d"}}, + 1}, + {<<"gen_netlink">>, + {git,"https://github.com/osmocom/gen_netlink", + {ref,"b6a450f0f79df7d74814a031bc1b8f99f573979f"}}, + 1}, + {<<"gen_socket">>, + {git,"https://github.com/osmocom/gen_socket", + {ref,"35e11d6e2f6d87b02dcfc7507a9500bf7ca7329e"}}, + 2}, {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, + {<<"gtp_u_kmod">>, + {git,"https://github.com/osmocom/gtp_u_kmod", + {ref,"5a4974b9f26985a0a0e5cb5423f8921f7a48083b"}}, + 0}, {<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0}, {<<"lager">>, {git,"https://github.com/erlang-lager/lager", @@ -12,7 +28,7 @@ 0}, {<<"osmo_gsup">>, {git,"https://gitea.osmocom.org/erlang/osmo_gsup", - {ref,"e23f118e6e8f7ee1247db34e4cb79e4cecdb0947"}}, + {ref,"07672d8ab1608aa9c9e50ca035521876558fcd42"}}, 0}, {<<"osmo_ss7">>, {git,"https://gitea.osmocom.org/erlang/osmo_ss7", @@ -20,7 +36,7 @@ 0}, {<<"parse_trans">>, {git,"https://github.com/uwiger/parse_trans", - {ref,"cdb01ba260ba9a00b2aafa17affead0f6fac081c"}}, + {ref,"d99fb36755c813a5db23e6f93741aa58323ef911"}}, 1}, {<<"pkt">>, {git,"https://github.com/msantos/pkt", diff --git a/src/osmo_epdg.app.src b/src/osmo_epdg.app.src index ec60bd2..4481df5 100644 --- a/src/osmo_epdg.app.src +++ b/src/osmo_epdg.app.src @@ -11,7 +11,8 @@ gtplib, diameter, osmo_gsup, - osmo_ss7 + osmo_ss7, + gtp_u_kmod ]}, {mod, {osmo_epdg_app, []}}, {env, []} -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35610?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1cb5a88b714242d579aac22cc13a2474abb195c6 Gerrit-Change-Number: 35610 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in ...osmo-epdg[master]: swx: Rename diameter related parameters
by pespin 18 Jan '24

18 Jan '24
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email ) Change subject: swx: Rename diameter related parameters ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Sorry I thought it was more or less obvious since one can see the other diameter interface properly named just after it. I'll add it to the commit description. This is done to easily identify config parameters for each interface. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I63fe4c7acc7460575a921b254adf066134c0527f Gerrit-Change-Number: 35598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Jan 2024 13:02:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: epdg: Add module param to configure initial diameter watchdog time
by pespin 18 Jan '24

18 Jan '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35592?usp=email ) Change subject: epdg: Add module param to configure initial diameter watchdog time ...................................................................... epdg: Add module param to configure initial diameter watchdog time Change-Id: I9eb42d7664d8e607b913e23c87477388f70662b9 --- M epdg/EPDG_Tests.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index f58cf96..60e0d1c 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -43,6 +43,7 @@ integer mp_s2b_remote_port := GTP2C_PORT; charstring mp_diam_realm := "localdomain"; + integer mp_diam_watchdog_initial_wait_sec := 6*3; } @@ -250,7 +251,7 @@ * RFC3539 sec 3.4.1 [5] * https://github.com/freeDiameter/freeDiameter/blob/master/libfdcore/p_psm.c#… */ - f_sleep(1.0); + f_sleep(int2float(mp_diam_watchdog_initial_wait_sec)); } private function f_init_gtp(charstring id) runs on MTC_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9eb42d7664d8e607b913e23c87477388f70662b9 Gerrit-Change-Number: 35592 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: epdg: Remove unneeded register by message
by pespin 18 Jan '24

18 Jan '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35593?usp=email ) Change subject: epdg: Remove unneeded register by message ...................................................................... epdg: Remove unneeded register by message Since recently GTP2 Emulation got improved routing, and it should simply match by the already registered imsi. Change-Id: I410242d6597db10b97edf72b92e749db28520c39 --- M epdg/EPDG_Tests.ttcn 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 60e0d1c..353c738 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -440,7 +440,6 @@ } } private function f_GTP2C_CreateSession_success() runs on EPDG_ConnHdlr { - f_gtp2_register_udmsg('20'O); as_GTP2C_CreateSession_success(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I410242d6597db10b97edf72b92e749db28520c39 Gerrit-Change-Number: 35593 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in osmo-e1d[master]: Add command and client function to change transmitted Sa bits
by tnt 18 Jan '24

18 Jan '24
Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35562?usp=email ) Change subject: Add command and client function to change transmitted Sa bits ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2608af7bbb8092fddd68d4f3bb36b10a1100ce0f Gerrit-Change-Number: 35562 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 18 Jan 2024 12:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-e1d[master]: Indicate framing alignment error as loss of framing signal
by tnt 18 Jan '24

18 Jan '24
Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35559?usp=email ) Change subject: Indicate framing alignment error as loss of framing signal ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaad3adb6afb9e1d8a002fa4a04ba4ab8e51671a3 Gerrit-Change-Number: 35559 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 18 Jan 2024 12:38:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 79
  • 80
  • 81
  • 82
  • 83
  • 84
  • 85
  • ...
  • 156
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.