January 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: gsup_server: Improve log line when listening on gsup
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35590?usp=email ) Change subject: gsup_server: Improve log line when listening on gsup ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7dccc20b6c2c0f58cdd3a43469053624927c9acd Gerrit-Change-Number: 35590 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: gsup_server: Remove incorrect log about reconnecting
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35589?usp=email ) Change subject: gsup_server: Remove incorrect log about reconnecting ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ib5a8f1eb6d873f85d526222f76768d2b81f08d90 Gerrit-Change-Number: 35589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: mobile: implement sending CSD data over UNIX socket
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email ) Change subject: mobile: implement sending CSD data over UNIX socket ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id054af7b3d9d0a41715f7981deb420f6e09bf30c Gerrit-Change-Number: 35583 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:47:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: mobile: integrate V.110 TA & soft-UART from libosmocore
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email ) Change subject: mobile: integrate V.110 TA & soft-UART from libosmocore ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7ac9c0e5010730fa4d8bc7a7a3c7ff85e11731c0 Gerrit-Change-Number: 35582 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:45:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: isdn: add a lookup table with E1/E2/E3 bits from Table 5/V.110
by laforge 18 Jan '24

18 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35587?usp=email ) Change subject: isdn: add a lookup table with E1/E2/E3 bits from Table 5/V.110 ...................................................................... isdn: add a lookup table with E1/E2/E3 bits from Table 5/V.110 Let's make those E1/E2/E3 bit combinations publicly available in form of a lookup table (key is enum osmo_v100_sync_ra1_rate). Add convenience macros for setting and comparing these bits. This lookup table will be used by osmocom-bb.git. Change-Id: I6d2f8e250df31c233a2741163113dc07515409ae Related: OS#4396 --- M include/osmocom/isdn/v110.h M src/isdn/libosmoisdn.map M src/isdn/v110.c 3 files changed, 57 insertions(+), 27 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/isdn/v110.h b/include/osmocom/isdn/v110.h index 4c1214c..9555932 100644 --- a/include/osmocom/isdn/v110.h +++ b/include/osmocom/isdn/v110.h @@ -39,6 +39,13 @@ _NUM_OSMO_V110_SYNC_RA1 }; +extern const ubit_t osmo_v110_e1e2e3[_NUM_OSMO_V110_SYNC_RA1][3]; + +#define osmo_v110_e1e2e3_set(e_bits, rate) \ + memcpy(e_bits, osmo_v110_e1e2e3[rate], 3) +#define osmo_v110_e1e2e3_cmp(e_bits, rate) \ + memcmp(e_bits, osmo_v110_e1e2e3[rate], 3) + int osmo_v110_sync_ra1_get_user_data_chunk_bitlen(enum osmo_v100_sync_ra1_rate rate); int osmo_v110_sync_ra1_get_user_data_rate(enum osmo_v100_sync_ra1_rate rate); int osmo_v110_sync_ra1_get_intermediate_rate(enum osmo_v100_sync_ra1_rate rate); diff --git a/src/isdn/libosmoisdn.map b/src/isdn/libosmoisdn.map index fe6628b..8f34f0d 100644 --- a/src/isdn/libosmoisdn.map +++ b/src/isdn/libosmoisdn.map @@ -27,6 +27,7 @@ osmo_v110_decode_frame; osmo_v110_encode_frame; osmo_v110_ubit_dump; +osmo_v110_e1e2e3; osmo_v110_sync_ra1_get_user_data_chunk_bitlen; osmo_v110_sync_ra1_get_user_data_rate; osmo_v110_sync_ra1_get_intermediate_rate; diff --git a/src/isdn/v110.c b/src/isdn/v110.c index 46962bf..b4bc4e3 100644 --- a/src/isdn/v110.c +++ b/src/isdn/v110.c @@ -143,6 +143,22 @@ /* I actually couldn't find any reference as to the value of F(ill) bits */ #define F 1 +/*! E1/E2/E3 bit values as per Table 5/V.110 */ +const ubit_t osmo_v110_e1e2e3[_NUM_OSMO_V110_SYNC_RA1][3] = { + [OSMO_V110_SYNC_RA1_600] = { 1, 0, 0 }, + [OSMO_V110_SYNC_RA1_1200] = { 0, 1, 0 }, + [OSMO_V110_SYNC_RA1_2400] = { 1, 1, 0 }, + [OSMO_V110_SYNC_RA1_4800] = { 0, 1, 1 }, + [OSMO_V110_SYNC_RA1_7200] = { 1, 0, 1 }, + [OSMO_V110_SYNC_RA1_9600] = { 0, 1, 1 }, + [OSMO_V110_SYNC_RA1_12000] = { 0, 0, 1 }, + [OSMO_V110_SYNC_RA1_14400] = { 1, 0, 1 }, + [OSMO_V110_SYNC_RA1_19200] = { 0, 1, 1 }, + [OSMO_V110_SYNC_RA1_24000] = { 0, 0, 1 }, + [OSMO_V110_SYNC_RA1_28800] = { 1, 0, 1 }, + [OSMO_V110_SYNC_RA1_38400] = { 0, 1, 1 }, +}; + /*! Adapt from 6 synchronous 600bit/s input bits to a decoded V.110 frame. * \param[out] fr caller-allocated output frame to which E+D bits are stored * \param[in] d_in input user bits @@ -154,9 +170,7 @@ return -EINVAL; /* Table 6a / V.110 */ - fr->e_bits[0] = 1; - fr->e_bits[1] = 0; - fr->e_bits[2] = 0; + osmo_v110_e1e2e3_set(fr->e_bits, OSMO_V110_SYNC_RA1_600); for (int i = 0; i < 6; i++) memset(fr->d_bits + i*8, d_in[i], 8); @@ -168,7 +182,7 @@ if (out_len < 6) return -ENOSPC; - if (fr->e_bits[0] != 1 || fr->e_bits[1] != 0 || fr->e_bits[2] != 0) + if (osmo_v110_e1e2e3_cmp(fr->e_bits, OSMO_V110_SYNC_RA1_600)) return -EINVAL; for (int i = 0; i < 6; i++) { @@ -190,9 +204,7 @@ return -EINVAL; /* Table 6b / V.110 */ - fr->e_bits[0] = 0; - fr->e_bits[1] = 1; - fr->e_bits[2] = 0; + osmo_v110_e1e2e3_set(fr->e_bits, OSMO_V110_SYNC_RA1_1200); for (int i = 0; i < 12; i++) memset(fr->d_bits + i*4, d_in[i], 4); @@ -204,7 +216,7 @@ if (out_len < 12) return -ENOSPC; - if (fr->e_bits[0] != 0 || fr->e_bits[1] != 1 || fr->e_bits[2] != 0) + if (osmo_v110_e1e2e3_cmp(fr->e_bits, OSMO_V110_SYNC_RA1_1200)) return -EINVAL; for (int i = 0; i < 12; i++) { @@ -226,9 +238,7 @@ return -EINVAL; /* Table 6c / V.110 */ - fr->e_bits[0] = 1; - fr->e_bits[1] = 1; - fr->e_bits[2] = 0; + osmo_v110_e1e2e3_set(fr->e_bits, OSMO_V110_SYNC_RA1_2400); for (int i = 0; i < 24; i++) { fr->d_bits[i*2 + 0] = d_in[i]; fr->d_bits[i*2 + 1] = d_in[i]; @@ -243,7 +253,7 @@ return -ENOSPC; /* Table 6c / V.110 */ - if (fr->e_bits[0] != 1 || fr->e_bits[1] != 1 || fr->e_bits[2] != 0) + if (osmo_v110_e1e2e3_cmp(fr->e_bits, OSMO_V110_SYNC_RA1_2400)) return -EINVAL; for (int i = 0; i < 24; i++) { @@ -266,10 +276,8 @@ if (in_len != 36) return -EINVAL; - /* Table 6d / V.110 */ - fr->e_bits[0] = 1; - fr->e_bits[1] = 0; - fr->e_bits[2] = 1; + /* Table 6d / V.110 (7200 is one of Nx3600) */ + osmo_v110_e1e2e3_set(fr->e_bits, OSMO_V110_SYNC_RA1_7200); memcpy(fr->d_bits + d_idx, d_in + 0, 10); d_idx += 10; /* D1..D10 */ memset(fr->d_bits + d_idx, F, 2); d_idx += 2; @@ -297,7 +305,8 @@ if (out_len < 36) return -ENOSPC; - if (fr->e_bits[0] != 1 || fr->e_bits[1] != 0 || fr->e_bits[2] != 1) + /* Table 6d / V.110 (7200 is one of Nx3600) */ + if (osmo_v110_e1e2e3_cmp(fr->e_bits, OSMO_V110_SYNC_RA1_7200)) return -EINVAL; memcpy(d_out + 0, fr->d_bits + d_idx, 10); d_idx += 10; /* D1..D10 */ @@ -330,10 +339,8 @@ if (in_len != 48) return -EINVAL; - /* Table 6e / V.110 */ - fr->e_bits[0] = 0; - fr->e_bits[1] = 1; - fr->e_bits[2] = 1; + /* Table 6e / V.110 (4800 is one of Nx4800) */ + osmo_v110_e1e2e3_set(fr->e_bits, OSMO_V110_SYNC_RA1_4800); memcpy(fr->d_bits, d_in, 48); @@ -345,7 +352,8 @@ if (out_len < 48) return -ENOSPC; - if (fr->e_bits[0] != 0 || fr->e_bits[1] != 1 || fr->e_bits[2] != 1) + /* Table 6e / V.110 (4800 is one of Nx4800) */ + if (osmo_v110_e1e2e3_cmp(fr->e_bits, OSMO_V110_SYNC_RA1_4800)) return -EINVAL; memcpy(d_out, fr->d_bits, 48); @@ -365,10 +373,8 @@ if (in_len != 30) return -EINVAL; - /* Table 6f / V.110 */ - fr->e_bits[0] = 0; - fr->e_bits[1] = 0; - fr->e_bits[2] = 1; + /* Table 6f / V.110 (12000 is one of Nx12000) */ + osmo_v110_e1e2e3_set(fr->e_bits, OSMO_V110_SYNC_RA1_12000); memcpy(fr->d_bits + d_idx, d_in + 0, 10); d_idx += 10; /* D1..D10 */ memset(fr->d_bits + d_idx, F, 2); d_idx += 2; @@ -399,7 +405,8 @@ if (out_len < 30) return -ENOSPC; - if (fr->e_bits[0] != 0 || fr->e_bits[1] != 0 || fr->e_bits[2] != 1) + /* Table 6f / V.110 (12000 is one of Nx12000) */ + if (osmo_v110_e1e2e3_cmp(fr->e_bits, OSMO_V110_SYNC_RA1_12000)) return -EINVAL; memcpy(d_out + 0, fr->d_bits + d_idx, 10); d_idx += 10; /* D1..D10 */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d2f8e250df31c233a2741163113dc07515409ae Gerrit-Change-Number: 35587 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmocore[master]: isdn: add a lookup table with E1/E2/E3 bits from Table 5/V.110
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35587?usp=email ) Change subject: isdn: add a lookup table with E1/E2/E3 bits from Table 5/V.110 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d2f8e250df31c233a2741163113dc07515409ae Gerrit-Change-Number: 35587 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:44:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: mobile: split voice specific TCH handling into its own file
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35581?usp=email ) Change subject: mobile: split voice specific TCH handling into its own file ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib917d95fe77da3e60bc932cce56714d81095c7d4 Gerrit-Change-Number: 35581 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:43:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: rename tch_send_voice_{msg,frame}() functions
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35580?usp=email ) Change subject: mobile: rename tch_send_voice_{msg,frame}() functions ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib55b4405847f2efb583f3a379ff4b6929d6d6c5b Gerrit-Change-Number: 35580 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:42:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: mobile: init/deinit GAPK I/O based on CC transaction events
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email ) Change subject: mobile: init/deinit GAPK I/O based on CC transaction events ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b Gerrit-Change-Number: 35579 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:42:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: cosmetic: use consistent naming for gapk_io_state
by laforge 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35600?usp=email ) Change subject: mobile: cosmetic: use consistent naming for gapk_io_state ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I96a995bdf20c95a15271de68fbf434e101047313 Gerrit-Change-Number: 35600 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 08:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0