January 2024 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-epdg: Run osmo-epdg as root
by pespin 17 Jan '24

17 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email ) Change subject: ttcn3-epdg: Run osmo-epdg as root ...................................................................... ttcn3-epdg: Run osmo-epdg as root This will be needed since soon osmo-epdg will start creating tunnel devices througth gtp_u_kmod, which requires CAP_NET_ADMIN, plus it will need probably need to set up local IP addresses, which requires root. Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474 --- M ttcn3-epdg-test/jenkins.sh 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/07/35607/1 diff --git a/ttcn3-epdg-test/jenkins.sh b/ttcn3-epdg-test/jenkins.sh index df445fc..bee9e77 100755 --- a/ttcn3-epdg-test/jenkins.sh +++ b/ttcn3-epdg-test/jenkins.sh @@ -23,6 +23,9 @@ docker run --rm \ $(docker_network_params $SUBNET 20) \ --ulimit core=-1 \ + --privileged --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun \ + -u root \ + -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ -v $VOL_BASE_DIR/epdg:/data \ --name ${BUILD_TAG}-epdg -d \ $DOCKER_ARGS \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474 Gerrit-Change-Number: 35607 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: osmo-epdg-master: Remove rebar.lock to force build against updated de...
by pespin 17 Jan '24

17 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35606?usp=email ) Change subject: osmo-epdg-master: Remove rebar.lock to force build against updated dependencies ...................................................................... osmo-epdg-master: Remove rebar.lock to force build against updated dependencies This way we notice when some dependency update breaks build, and prevents running against old dependencies if developer forgot to update rebar.lock. Change-Id: Ia9112d641e80d1eddcddea1e54e4c135d6efcc5b --- M osmo-epdg-master/Dockerfile 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/06/35606/1 diff --git a/osmo-epdg-master/Dockerfile b/osmo-epdg-master/Dockerfile index 58ccf9a..a5e9b14 100644 --- a/osmo-epdg-master/Dockerfile +++ b/osmo-epdg-master/Dockerfile @@ -15,6 +15,7 @@ git fetch && git checkout $OSMO_EPDG_BRANCH && \ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_EPDG_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + rm -f rebar.lock && \ rebar3 compile && \ rebar3 escriptize -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia9112d641e80d1eddcddea1e54e4c135d6efcc5b Gerrit-Change-Number: 35606 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo-epdg[master]: cosmetic: sys.config: Clean up formatting of logging section
by pespin 17 Jan '24

17 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35605?usp=email ) Change subject: cosmetic: sys.config: Clean up formatting of logging section ...................................................................... cosmetic: sys.config: Clean up formatting of logging section Content is not changed, simply rearranged. Change-Id: I6a992ddef6f9807f360f770d6d5e9185f36559d1 --- M config/sys.config 1 file changed, 34 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/05/35605/1 diff --git a/config/sys.config b/config/sys.config index bffa289..3f9d607 100755 --- a/config/sys.config +++ b/config/sys.config @@ -51,23 +51,26 @@ % %% =========================================== %% Lager logging config %% =========================================== - {lager, - [{log_root, "log"}, - {colored, true}, - {handlers, - [{lager_console_backend, [{level, info}]}, - {lager_file_backend, - [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, - {lager_file_backend, - [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, - {crash_log, "crash.log"}, - {crash_log_msg_size, 65536}, - {crash_log_size, 104857600}, - {crash_log_date, "$D0"}, - {crash_log_count, 10}, - {error_logger_redirect, true}]}, - {kernel, - [{logger, - [{handler, debug, logger_std_h, % {handler, HandlerId, Module, - #{config => #{file => "log/erlang.log"}}} % Config} - ]}]}]. + {lager, [ + {log_root, "log"}, + {colored, true}, + {handlers, + [{lager_console_backend, [{level, debug}]}, + {lager_file_backend, + [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, + {lager_file_backend, + [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, + {crash_log, "crash.log"}, + {crash_log_msg_size, 65536}, + {crash_log_size, 104857600}, + {crash_log_date, "$D0"}, + {crash_log_count, 10}, + {error_logger_redirect, true} + ]}, + {kernel, [ + {logger, [{handler, debug, logger_std_h, % {handler, HandlerId, Module, + #{config => #{file => "log/erlang.log"}} + }] + } + ]} +]. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6a992ddef6f9807f360f770d6d5e9185f36559d1 Gerrit-Change-Number: 35605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add missing message_class to EPDGTunnel* messages
by pespin 17 Jan '24

17 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604?usp=email ) Change subject: GSUP_Types: Add missing message_class to EPDGTunnel* messages ...................................................................... GSUP_Types: Add missing message_class to EPDGTunnel* messages Related: OS#6091 Change-Id: Ib7d6156402645867cadc8d3e0ffdd07247a1abd2 --- M library/GSUP_Types.ttcn 1 file changed, 69 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/35604/1 diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index dbf3fd4..e938c65 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -693,29 +693,57 @@ /* EPDG Tunnel */ -template (value) GSUP_PDU ts_GSUP_EPDGTunnel_REQ(hexstring imsi, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, - template (omit) octetstring source_name := omit) := - ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, f_gen_ts_ies(imsi, dom := dom, - source_name := source_name));//HERE +template (value) GSUP_PDU ts_GSUP_EPDGTunnel_REQ(hexstring imsi, + GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, + GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, + template (omit) octetstring source_name := omit) := + ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, f_gen_ts_ies(imsi, + message_class := message_class, + dom := dom, + source_name := source_name)); -template (present) GSUP_PDU tr_GSUP_EPDGTunnel_REQ(template (present) hexstring imsi := ?) := - tr_GSUP_IMSI(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, imsi); +template (present) GSUP_PDU tr_GSUP_EPDGTunnel_REQ(template (present) hexstring imsi := ?, + template (present) GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG) := + tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, + f_gen_tr_ies(imsi, + message_class := message_class)); -template (value) GSUP_PDU ts_GSUP_EPDGTunnel_RES(hexstring imsi, octetstring destination_name := ''O) := - ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), - valueof(ts_GSUP_IE_Destination_Name(destination_name))}); -template (present) GSUP_PDU tr_GSUP_EPDGTunnel_RES(template (present) hexstring imsi, template octetstring destination_name := omit) := - tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, f_gen_tr_ies(imsi, destination_name := destination_name)); +template (value) GSUP_PDU ts_GSUP_EPDGTunnel_RES(hexstring imsi, + GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, + octetstring destination_name := ''O) := + ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, { + valueof(ts_GSUP_IE_IMSI(imsi)), + valueof(ts_GSUP_IE_Message_Class(message_class)), + valueof(ts_GSUP_IE_Destination_Name(destination_name)) + }); -template (value) GSUP_PDU ts_GSUP_EPDGTunnel_ERR(hexstring imsi, integer cause) := +template (present) GSUP_PDU tr_GSUP_EPDGTunnel_RES(template (present) hexstring imsi, + template (present) GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, + template octetstring destination_name := omit) := + tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, + f_gen_tr_ies(imsi, + message_class := message_class, + destination_name := destination_name)); + +template (value) GSUP_PDU ts_GSUP_EPDGTunnel_ERR(hexstring imsi, + GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, + integer cause := 0) := ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR, { - valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_Cause(cause)) }); + valueof(ts_GSUP_IE_IMSI(imsi)), + valueof(ts_GSUP_IE_Message_Class(message_class)), + valueof(ts_GSUP_IE_Cause(cause)) + }); -template (present) GSUP_PDU tr_GSUP_EPDGTunnel_ERR(template (present) hexstring imsi, template (present) integer cause := ?, - template octetstring destination_name := omit) := +template (present) GSUP_PDU tr_GSUP_EPDGTunnel_ERR(template (present) hexstring imsi, + template (present) GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, + template (present) integer cause := ?, + template octetstring destination_name := omit) := tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR, - f_gen_tr_ies(imsi, cause := cause, destination_name := destination_name)); + f_gen_tr_ies(imsi, + message_class := message_class, + cause := cause, + destination_name := destination_name)); template (value) GSUP_IE ts_GSUP_IE_CancelType(GSUP_CancelType ctype) := { @@ -1391,15 +1419,20 @@ } private function f_gen_ts_ies(hexstring imsi, - template hexstring imei := omit, - template GSUP_CnDomain dom := omit, - template octetstring source_name := omit, - template octetstring destination_name := omit + template (omit) GSUP_Message_Class message_class := omit, + template (omit) hexstring imei := omit, + template (omit) GSUP_CnDomain dom := omit, + template (omit) octetstring source_name := omit, + template (omit) octetstring destination_name := omit ) return GSUP_IEs { var GSUP_IEs ies := { valueof(ts_GSUP_IE_IMSI(imsi)) }; + if (isvalue(message_class)) { + ies := ies & { valueof(ts_GSUP_IE_Message_Class(valueof(message_class))) }; + } + if (isvalue(dom)) { ies := ies & { valueof(ts_GSUP_IE_CnDomain(dom)) }; } @@ -1420,6 +1453,7 @@ } private function f_gen_tr_ies(template hexstring imsi, + template GSUP_Message_Class message_class := omit, template integer cause := omit, template hexstring msisdn := omit, template GSUP_IMEIResult imei_result := omit, @@ -1431,6 +1465,11 @@ }; var integer idx := 1; + if (isvalue(message_class)) { + ies[idx] := tr_GSUP_IE_Message_Class(message_class); + idx := idx + 1; + } + if (isvalue(cause)) { ies[idx] := tr_GSUP_IE_Cause(cause); idx := idx + 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7d6156402645867cadc8d3e0ffdd07247a1abd2 Gerrit-Change-Number: 35604 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: add message type for osmo-epdg CEAI interface
by pespin 17 Jan '24

17 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35603?usp=email ) Change subject: GSUP_Types: add message type for osmo-epdg CEAI interface ...................................................................... GSUP_Types: add message type for osmo-epdg CEAI interface The CEIA interface is an interface between osmo-epdg and strongswan. It is used by the osmo-epdg to synchronize state. Related: OS#6091 Related: libosmocore.git Change-Id I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3 Change-Id: I3da4f731597eee3736a9aab513f5257a78e8d8eb --- M library/GSUP_Types.ttcn 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/35603/1 diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index b3154ac..dbf3fd4 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -172,7 +172,8 @@ OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT (1), OSMO_GSUP_MESSAGE_CLASS_SMS (2), OSMO_GSUP_MESSAGE_CLASS_USSD (3), - OSMO_GSUP_MESSAGE_CLASS_INTER_MSC (4) + OSMO_GSUP_MESSAGE_CLASS_INTER_MSC (4), + OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG (5) } with { variant "FIELDLENGTH(8)" }; type record GSUP_MSISDN { @@ -695,7 +696,7 @@ template (value) GSUP_PDU ts_GSUP_EPDGTunnel_REQ(hexstring imsi, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, template (omit) octetstring source_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, f_gen_ts_ies(imsi, dom := dom, - source_name := source_name)); + source_name := source_name));//HERE template (present) GSUP_PDU tr_GSUP_EPDGTunnel_REQ(template (present) hexstring imsi := ?) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3da4f731597eee3736a9aab513f5257a78e8d8eb Gerrit-Change-Number: 35603 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Update renamed config fields
by pespin 17 Jan '24

17 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35599?usp=email ) Change subject: ttcn3-epdg: Update renamed config fields ...................................................................... ttcn3-epdg: Update renamed config fields The config file fields have been renamed recently, update them. Depends: osmo-epdg.git Change-Id I63fe4c7acc7460575a921b254adf066134c0527f Change-Id: Ic9f2f33b8ffae7b4273e6fac8a42b6e9e1e38ed8 --- M ttcn3-epdg-test/osmo-epdg.config 1 file changed, 22 insertions(+), 10 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config index 8acdc4f..63a2f26 100644 --- a/ttcn3-epdg-test/osmo-epdg.config +++ b/ttcn3-epdg-test/osmo-epdg.config @@ -7,18 +7,18 @@ {gsup_local_ip, "172.18.10.20"}, {gsup_local_port, 4222}, % Diameter Connection parameters - {diameter_remote_ip, "172.18.10.103"}, - {diameter_remote_port, 3868}, - {diameter_proto, sctp}, - {diameter_connect_timer, 200}, - {diameter_watchdog_timer, 6000}, - {diameter_watchdog_config, + {dia_swx_remote_ip, "172.18.10.103"}, + {dia_swx_remote_port, 3868}, + {dia_swx_proto, sctp}, + {dia_swx_connect_timer, 200}, + {dia_swx_watchdog_timer, 6000}, + {dia_swx_watchdog_config, [{okay, 1}, {suspect, 1}]}, - {vendor_id, 0}, - {origin_host, "epdg.localdomain"}, - {origin_realm, "localdomain"}, - {context_id, "epdg@localdomain"}, + {dia_swx_vendor_id, 0}, + {dia_swx_origin_host, "epdg.localdomain"}, + {dia_swx_origin_realm, "localdomain"}, + {dia_swx_context_id, "epdg@localdomain"}, % Diameter s6b Connection parameters {dia_s6b_local_ip, "172.18.10.20"}, {dia_s6b_local_port, 3869}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic9f2f33b8ffae7b4273e6fac8a42b6e9e1e38ed8 Gerrit-Change-Number: 35599 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Set new osmo-epdg diameter connect/wathdog configs
by pespin 17 Jan '24

17 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35594?usp=email ) Change subject: ttcn3-epdg: Set new osmo-epdg diameter connect/wathdog configs ...................................................................... ttcn3-epdg: Set new osmo-epdg diameter connect/wathdog configs Depends: osmo-epdg.git Change-Id I99b5e02264c2c35a3fbfcd2d6083a07e2cfea566 Change-Id: I3632abb8b33d5f2636f443573196d73ea8d3c818 --- M ttcn3-epdg-test/EPDG_Tests.cfg M ttcn3-epdg-test/osmo-epdg.config 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-epdg-test/EPDG_Tests.cfg b/ttcn3-epdg-test/EPDG_Tests.cfg index 2a39b67..5dbcb4c 100644 --- a/ttcn3-epdg-test/EPDG_Tests.cfg +++ b/ttcn3-epdg-test/EPDG_Tests.cfg @@ -16,6 +16,9 @@ EPDG_Tests.mp_s6b_remote_ip := "172.18.10.20" EPDG_Tests.mp_s2b_remote_ip := "172.18.10.20" +# Match (diameter_watchdog_timer/1000)*diameter_watchdog_config["okay"] in osmo-epdg.config: +EPDG_Tests.mp_diam_watchdog_initial_wait_sec := 6; + [MAIN_CONTROLLER] [EXECUTE] diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config index 0aa9807..8acdc4f 100644 --- a/ttcn3-epdg-test/osmo-epdg.config +++ b/ttcn3-epdg-test/osmo-epdg.config @@ -10,6 +10,11 @@ {diameter_remote_ip, "172.18.10.103"}, {diameter_remote_port, 3868}, {diameter_proto, sctp}, + {diameter_connect_timer, 200}, + {diameter_watchdog_timer, 6000}, + {diameter_watchdog_config, + [{okay, 1}, + {suspect, 1}]}, {vendor_id, 0}, {origin_host, "epdg.localdomain"}, {origin_realm, "localdomain"}, @@ -18,6 +23,11 @@ {dia_s6b_local_ip, "172.18.10.20"}, {dia_s6b_local_port, 3869}, {dia_s6b_proto, sctp}, + {dia_s6b_connect_timer, 200}, + {dia_s6b_watchdog_timer, 6000}, + {dia_s6b_watchdog_config, + [{okay, 1}, + {suspect, 1}]}, {dia_s6b_vendor_id, 0}, {dia_s6b_origin_host, "aaa.localdomain"}, {dia_s6b_origin_realm, "localdomain"}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3632abb8b33d5f2636f443573196d73ea8d3c818 Gerrit-Change-Number: 35594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Set new osmo-epdg diameter connect/wathdog configs
by pespin 17 Jan '24

17 Jan '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35594?usp=email ) Change subject: ttcn3-epdg: Set new osmo-epdg diameter connect/wathdog configs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3632abb8b33d5f2636f443573196d73ea8d3c818 Gerrit-Change-Number: 35594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 17 Jan 2024 15:51:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Update renamed config fields
by pespin 17 Jan '24

17 Jan '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35599?usp=email ) Change subject: ttcn3-epdg: Update renamed config fields ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic9f2f33b8ffae7b4273e6fac8a42b6e9e1e38ed8 Gerrit-Change-Number: 35599 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jan 2024 15:51:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq
by pespin 17 Jan '24

17 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35573?usp=email ) Change subject: mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq ...................................................................... mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq Change-Id: I9a1a2dbceb4c4f30a8408c6f58bf645656e900bc --- M mme/MME_Tests.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 50b89b3..2194e8a 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -890,6 +890,7 @@ var OCT3 ptmsi_sig; var Gtp1cUnitdata gtpc_pdu; var OCT4 old_mme_local_teid; + var uint16_t gtpc_seq_nr := f_rnd_int(65535); /* Derive NAS Token (and post-increment ul_count): */ var OCT32 nas_token := f_s1apem_derive_nas_token(g_pars.ue_pars.kasme); @@ -899,7 +900,7 @@ SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, new_sgsn_local_teid, f_inet_addr(mp_gn_local_ip), ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig)); - GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, 0, SGSNContextReqPDU)); + GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, gtpc_seq_nr, SGSNContextReqPDU)); timer T := 5.0; T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a1a2dbceb4c4f30a8408c6f58bf645656e900bc Gerrit-Change-Number: 35573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0