September 2023 - gerrit-log - lists.osmocom.org

[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls

by Jenkins Builder

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/include/osmocom/bb/mobile/transaction.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11211): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/4c564705_f5ac7ed5 PS3, Line 74: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */ 'seperate' may be misspelled - perhaps 'separate'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 11:05:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: HACK, DON'T MERGE! strncasecmp for firmware

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34473?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: HACK, DON'T MERGE! strncasecmp for firmware ...................................................................... HACK, DON'T MERGE! strncasecmp for firmware Change-Id: Ia8c201fcfcc6ad1766dcff032f0cac76f53f2fb3 --- M src/target/firmware/include/string.h M src/target/firmware/lib/Makefile A src/target/firmware/lib/strcasecmp.c 3 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/73/34473/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8c201fcfcc6ad1766dcff032f0cac76f53f2fb3 Gerrit-Change-Number: 34473 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add group receive and transmit mode support to MM layer ...................................................................... ASCI: Add group receive and transmit mode support to MM layer Related: OS#5364 Change-Id: I05957182a57423ad947ab200b52f65fde859e110 --- M src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h M src/host/layer23/src/mobile/gsm48_mm.c 2 files changed, 704 insertions(+), 110 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/34492/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to RR layer

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add group receive and transmit mode support to RR layer ...................................................................... ASCI: Add group receive and transmit mode support to RR layer Related: OS#5364 Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h M src/host/layer23/src/mobile/gsm48_rr.c 3 files changed, 1,385 insertions(+), 84 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/91/34491/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb Gerrit-Change-Number: 34491 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[S] Change in libosmo-sccp[master]: cosmetic: sccp_types.h: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34497?usp=email ) Change subject: cosmetic: sccp_types.h: Fix typo in comment ...................................................................... cosmetic: sccp_types.h: Fix typo in comment Change-Id: Ia75502874e3a07dbd6b685a6721adaedb429e904 --- M include/osmocom/sccp/sccp_types.h 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/97/34497/1 diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 277a3b2..1618d60 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -482,7 +482,7 @@ #if OPTIONAL segmentation - importancd + importance #endif uint8_t data[0]; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia75502874e3a07dbd6b685a6721adaedb429e904 Gerrit-Change-Number: 34497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp2sua: Produce smaller output if msg contains no optional section

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email ) Change subject: sccp2sua: Produce smaller output if msg contains no optional section ...................................................................... sccp2sua: Produce smaller output if msg contains no optional section Change-Id: I5c8fcb30b76ac7bafd4a99bc3004049644e7e3f9 --- M src/sccp2sua.c M tests/xua/xua_test.c M tests/xua/xua_test.ok 3 files changed, 28 insertions(+), 6 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/sccp2sua.c b/src/sccp2sua.c index 9bad528..cdab771 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -987,18 +987,26 @@ enum sccp_message_types type, const struct xua_msg *xua) { const struct xua_msg_part *part; - - /* store relative pointer to start of optional part */ - *ptr_opt = msg->tail - ptr_opt; + bool any_added = false; + uint8_t *old_tail = msg->tail; llist_for_each_entry(part, &xua->headers, entry) { /* make sure we don't add a SCCP option for information * that is already present in mandatory fixed or * mandatory variable parts of the header */ - if (!sccp_is_mandatory(type, part) && sccp_option_permitted(type, part)) + if (!sccp_is_mandatory(type, part) && sccp_option_permitted(type, part)) { sccp_msg_add_sua_opt(type, msg, part); + any_added = true; + } } - msgb_put_u8(msg, SCCP_PNC_END_OF_OPTIONAL); + if (any_added) { + msgb_put_u8(msg, SCCP_PNC_END_OF_OPTIONAL); + /* store relative pointer to start of optional part */ + *ptr_opt = old_tail - ptr_opt; + } else { + /* If nothing was added, simply update the pointer to 0 to signal the optional part is omitted. */ + ptr_opt[0] = 0; + } return 0; } diff --git a/tests/xua/xua_test.c b/tests/xua/xua_test.c index 6b4eef5..628d860 100644 --- a/tests/xua/xua_test.c +++ b/tests/xua/xua_test.c @@ -439,6 +439,10 @@ }, }, }, { + /* This case expectedly prints "Input != re-encoded output!" because input has + * (struct sccp_connection_confirm).optional_start=1 pointing to SCCP_PNC_END_OF_OPTIONAL, + * while our (re-)encoder uses optional_start=0 which means entire msg is 1 byte + * lower (hence better). Both are valid. */ .name = "BSSMAP-CC", .sccp = PANDSIZ(bssmap_cc), .sua = { diff --git a/tests/xua/xua_test.ok b/tests/xua/xua_test.ok index 6738cc0..cb6aab1 100644 --- a/tests/xua/xua_test.ok +++ b/tests/xua/xua_test.ok @@ -55,7 +55,8 @@ Transcoding message SCCP -> XUA Decoded SUA: HDR=(CO:COAK,V=0,LEN=0), PART(T=Protocol Class,L=4,D=00000002), PART(T=Destination Reference,L=4,D=00010203), PART(T=Source Reference,L=4,D=00000003) Re-Encoding decoded SUA to SCCP -SCCP Output: [L2]> 02 01 02 03 00 00 03 02 01 00 +SCCP Output: [L2]> 02 01 02 03 00 00 03 02 00 +Input != re-encoded output! => BSSMAP-DTAP SCCP Input: [L2]> 06 00 00 03 00 01 0f 01 00 0c 03 05 5c 08 11 81 33 66 02 13 45 f4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5c8fcb30b76ac7bafd4a99bc3004049644e7e3f9 Gerrit-Change-Number: 34466 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

[M] Change in libosmo-sccp[master]: sscp2sua: Constify several more parameters

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34465?usp=email ) Change subject: sscp2sua: Constify several more parameters ...................................................................... sscp2sua: Constify several more parameters Change-Id: I0d0997a137f65bccdf8eeda70d95f3f908d2d91a --- M src/sccp2sua.c 1 file changed, 62 insertions(+), 53 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sccp2sua.c b/src/sccp2sua.c index ed224cf..9bad528 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -338,9 +338,9 @@ } /*! \brief convenience wrapper around sccp_addr_to_sua() for variable mandatory addresses */ -static int sccp_addr_to_sua_ptr(struct xua_msg *xua, uint16_t iei, uint8_t *ptr_addr) +static int sccp_addr_to_sua_ptr(struct xua_msg *xua, uint16_t iei, const uint8_t *ptr_addr) { - uint8_t *addr = ptr_addr + *ptr_addr + 1; + const uint8_t *addr = ptr_addr + *ptr_addr + 1; unsigned int addrlen = *(ptr_addr + *ptr_addr); return sccp_addr_to_sua(xua, iei, addr, addrlen); @@ -350,7 +350,7 @@ * \param msg user-provided message buffer to which address shall be * appended * \param[in] part SUA wire format binary address * \returns 0 in case of success; negative on error */ -static int sua_addr_to_sccp(struct msgb *msg, struct xua_msg_part *part) +static int sua_addr_to_sccp(struct msgb *msg, const struct xua_msg_part *part) { struct osmo_sccp_addr osa; int rc; @@ -370,7 +370,7 @@ * \param[out] var_ptr pointer to relative pointer in SCCP header * \param[in] xua xUA message from which to use address * \param[in] iei xUA information element identifier of address */ -static int sccp_add_var_addr(struct msgb *msg, uint8_t *var_ptr, struct xua_msg *xua, uint16_t iei) +static int sccp_add_var_addr(struct msgb *msg, uint8_t *var_ptr, const struct xua_msg *xua, uint16_t iei) { struct xua_msg_part *part = xua_msg_find_tag(xua, iei); uint8_t *lenbyte; @@ -401,7 +401,7 @@ * \param[out] var_ptr pointer to relative pointer in SCCP header * \param[in] xua xUA message from which to use source data * \param[in] iei xUA information element identifier of source data */ -static int sccp_add_variable_part(struct msgb *msg, uint8_t *var_ptr, struct xua_msg *xua, uint16_t iei) +static int sccp_add_variable_part(struct msgb *msg, uint8_t *var_ptr, const struct xua_msg *xua, uint16_t iei) { struct xua_msg_part *part = xua_msg_find_tag(xua, iei); uint8_t *lenbyte; @@ -456,9 +456,9 @@ } /*! \brief convenience wrapper around xua_msg_add_data() for variable mandatory data */ -static int sccp_data_to_sua_ptr(struct xua_msg *xua, uint16_t iei, uint8_t *ptr_addr) +static int sccp_data_to_sua_ptr(struct xua_msg *xua, uint16_t iei, const uint8_t *ptr_addr) { - uint8_t *addr = ptr_addr + *ptr_addr + 1; + const uint8_t *addr = ptr_addr + *ptr_addr + 1; unsigned int addrlen = *(ptr_addr + *ptr_addr); return xua_msg_add_data(xua, iei, addrlen, addr); @@ -471,7 +471,7 @@ * \param[in] opt pointer to wire-format encoded SCCP option data * \returns 0 in case of success; negative on error */ static int xua_msg_add_sccp_opt(struct xua_msg *xua, uint8_t sccp_opt_type, - uint16_t opt_len, uint8_t *opt) + uint16_t opt_len, const uint8_t *opt) { switch (sccp_opt_type) { case SCCP_PNC_DESTINATION_LOCAL_REFERENCE: @@ -587,7 +587,7 @@ * \param msg caller-provided message buffer to which option is to be appended * \param[in] opt xUA option/IE (messge part) to be converted+added * \returns 0 in case of success; negative on error */ -static int sccp_msg_add_sua_opt(enum sccp_message_types type, struct msgb *msg, struct xua_msg_part *opt) +static int sccp_msg_add_sua_opt(enum sccp_message_types type, struct msgb *msg, const struct xua_msg_part *opt) { uint32_t tmp32; uint8_t pnc, *lenptr; @@ -699,9 +699,9 @@ * \param[in] ptr_opt address of relative pointer to optional part * \param xua caller-provided xUA message to which options are added * \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_opt(struct msgb *msg, uint8_t *ptr_opt, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_opt(const struct msgb *msg, const uint8_t *ptr_opt, struct xua_msg *xua) { - uint8_t *opt_start, *oneopt; + const uint8_t *opt_start, *oneopt; /* some bounds checking */ if (ptr_opt < msg->data || ptr_opt > msg->tail) @@ -984,9 +984,9 @@ } static int xua_ies_to_sccp_opts(struct msgb *msg, uint8_t *ptr_opt, - enum sccp_message_types type, struct xua_msg *xua) + enum sccp_message_types type, const struct xua_msg *xua) { - struct xua_msg_part *part; + const struct xua_msg_part *part; /* store relative pointer to start of optional part */ *ptr_opt = msg->tail - ptr_opt; @@ -1004,7 +1004,7 @@ } /* store a 'local reference' as big-endian 24bit value at local_ref */ -static int store_local_ref(struct sccp_source_reference *local_ref, struct xua_msg *xua, uint16_t iei) +static int store_local_ref(struct sccp_source_reference *local_ref, const struct xua_msg *xua, uint16_t iei) { uint32_t tmp32 = xua_msg_get_u32(xua, iei); if (tmp32 > 0x00fffffe) { @@ -1018,7 +1018,7 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_cr(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_cr(const struct msgb *msg, struct xua_msg *xua) { struct sccp_connection_request *req = (struct sccp_connection_request *)msg->l2h; @@ -1034,7 +1034,7 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static int sua_to_sccp_cr(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_cr(struct msgb *msg, const struct xua_msg *xua) { struct sccp_connection_request *req; int rc; @@ -1054,7 +1054,7 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_cc(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_cc(const struct msgb *msg, struct xua_msg *xua) { struct sccp_connection_confirm *cnf = (struct sccp_connection_confirm *)msg->l2h; @@ -1067,7 +1067,7 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static int sua_to_sccp_cc(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_cc(struct msgb *msg, const struct xua_msg *xua) { struct sccp_connection_confirm *cnf; int rc; @@ -1087,9 +1087,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_cref(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_cref(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_connection_refused *ref = (struct sccp_connection_refused *)msg->l2h; + const struct sccp_connection_refused *ref = (const struct sccp_connection_refused *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_DEST_REF, load_24be(&ref->destination_local_reference)); @@ -1099,7 +1099,7 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static int sua_to_sccp_cref(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_cref(struct msgb *msg, const struct xua_msg *xua) { struct sccp_connection_refused *ref; int rc; @@ -1116,9 +1116,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_rlsd(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_rlsd(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_connection_released *rlsd = (struct sccp_connection_released *)msg->l2h; + const struct sccp_connection_released *rlsd = (const struct sccp_connection_released *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_DEST_REF, load_24be(&rlsd->destination_local_reference)); @@ -1128,7 +1128,7 @@ return sccp_to_xua_opt(msg, &rlsd->optional_start, xua); } -static int sua_to_sccp_rlsd(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_rlsd(struct msgb *msg, const struct xua_msg *xua) { struct sccp_connection_released *rlsd; int rc; @@ -1149,10 +1149,10 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_rlc(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_rlc(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_connection_release_complete *rlc; - rlc = (struct sccp_connection_release_complete *) msg->l2h; + const struct sccp_connection_release_complete *rlc; + rlc = (const struct sccp_connection_release_complete *) msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_DEST_REF, load_24be(&rlc->destination_local_reference)); @@ -1160,7 +1160,7 @@ return xua; } -static int sua_to_sccp_rlc(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_rlc(struct msgb *msg, const struct xua_msg *xua) { struct sccp_connection_release_complete *rlc; int rc; @@ -1178,9 +1178,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_dt1(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_dt1(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_data_form1 *dt1 = (struct sccp_data_form1 *) msg->l2h; + const struct sccp_data_form1 *dt1 = (const struct sccp_data_form1 *) msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_DEST_REF, load_24be(&dt1->destination_local_reference)); @@ -1192,7 +1192,7 @@ return xua; } -static int sua_to_sccp_dt1(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_dt1(struct msgb *msg, const struct xua_msg *xua) { struct sccp_data_form1 *dt1; int rc; @@ -1210,9 +1210,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_udt(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_udt(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_data_unitdata *udt = (struct sccp_data_unitdata *)msg->l2h; + const struct sccp_data_unitdata *udt = (const struct sccp_data_unitdata *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_PROTO_CLASS, udt->proto_class); @@ -1230,9 +1230,9 @@ } -static int sua_to_sccp_xudt(struct msgb *msg, struct xua_msg *xua); +static int sua_to_sccp_xudt(struct msgb *msg, const struct xua_msg *xua); -static int sua_to_sccp_udt(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_udt(struct msgb *msg, const struct xua_msg *xua) { struct sccp_data_unitdata *udt; @@ -1253,9 +1253,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_xudt(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_xudt(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_data_ext_unitdata *xudt = (struct sccp_data_ext_unitdata *)msg->l2h; + const struct sccp_data_ext_unitdata *xudt = (const struct sccp_data_ext_unitdata *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_PROTO_CLASS, xudt->proto_class); @@ -1275,7 +1275,7 @@ } -static int sua_to_sccp_xudt(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_xudt(struct msgb *msg, const struct xua_msg *xua) { struct sccp_data_ext_unitdata *xudt; xudt = (struct sccp_data_ext_unitdata *) msgb_put(msg, sizeof(*xudt)); @@ -1293,10 +1293,10 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_udts(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_udts(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_data_unitdata_service *udts; - udts =(struct sccp_data_unitdata_service *)msg->l2h; + const struct sccp_data_unitdata_service *udts; + udts = (const struct sccp_data_unitdata_service *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_CAUSE, SUA_CAUSE_T_RETURN | udts->return_cause); @@ -1314,9 +1314,9 @@ } -static int sua_to_sccp_xudts(struct msgb *msg, struct xua_msg *xua); +static int sua_to_sccp_xudts(struct msgb *msg, const struct xua_msg *xua); -static int sua_to_sccp_udts(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_udts(struct msgb *msg, const struct xua_msg *xua) { struct sccp_data_unitdata_service *udts; @@ -1337,10 +1337,10 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_xudts(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_xudts(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_data_ext_unitdata_service *xudts; - xudts = (struct sccp_data_ext_unitdata_service *)msg->l2h; + const struct sccp_data_ext_unitdata_service *xudts; + xudts = (const struct sccp_data_ext_unitdata_service *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_CAUSE, SUA_CAUSE_T_RETURN | xudts->return_cause); @@ -1359,7 +1359,7 @@ return sccp_to_xua_opt(msg, &xudts->optional_start, xua); } -static int sua_to_sccp_xudts(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_xudts(struct msgb *msg, const struct xua_msg *xua) { struct sccp_data_ext_unitdata_service *xudts; xudts = (struct sccp_data_ext_unitdata_service *) msgb_put(msg, sizeof(*xudts)); @@ -1377,9 +1377,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_it(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_it(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_data_it *it = (struct sccp_data_it *)msg->l2h; + const struct sccp_data_it *it = (const struct sccp_data_it *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_PROTO_CLASS, it->proto_class); @@ -1392,7 +1392,7 @@ return xua; } -static int sua_to_sccp_it(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_it(struct msgb *msg, const struct xua_msg *xua) { struct sccp_data_it *it; int rc; @@ -1416,9 +1416,9 @@ } /*! \returns \ref xua in case of success, NULL on error (xua not freed!) */ -static struct xua_msg *sccp_to_xua_err(struct msgb *msg, struct xua_msg *xua) +static struct xua_msg *sccp_to_xua_err(const struct msgb *msg, struct xua_msg *xua) { - struct sccp_proto_err *err = (struct sccp_proto_err *)msg->l2h; + const struct sccp_proto_err *err = (const struct sccp_proto_err *)msg->l2h; /* Fixed Part */ xua_msg_add_u32(xua, SUA_IEI_DEST_REF, load_24be(&err->destination_local_reference)); @@ -1426,7 +1426,7 @@ return xua; } -static int sua_to_sccp_err(struct msgb *msg, struct xua_msg *xua) +static int sua_to_sccp_err(struct msgb *msg, const struct xua_msg *xua) { struct sccp_proto_err *err; int rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d0997a137f65bccdf8eeda70d95f3f908d2d91a Gerrit-Change-Number: 34465 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp2sua: Produce smaller output if msg contains no optional section

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email ) Change subject: sccp2sua: Produce smaller output if msg contains no optional section ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5c8fcb30b76ac7bafd4a99bc3004049644e7e3f9 Gerrit-Change-Number: 34466 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:41:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp2sua: Produce smaller output if msg contains no optional section

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email ) Change subject: sccp2sua: Produce smaller output if msg contains no optional section ...................................................................... Patch Set 2: (1 comment) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34466/comment/1d72802d_a0783c3d PS2, Line 1008: ptr_opt[0] > A bit of inconsistency here: `*ptr_opt` vs `ptr_opt[0]`. Not really critical. See next patches on why I did it this way. Later on ptr_opt[1] is also filled. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5c8fcb30b76ac7bafd4a99bc3004049644e7e3f9 Gerrit-Change-Number: 34466 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:41:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp2sua: Produce smaller output if msg contains no optional section

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email ) Change subject: sccp2sua: Produce smaller output if msg contains no optional section ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34466/comment/0a9daf8a_81b3a760 PS2, Line 1008: ptr_opt[0] A bit of inconsistency here: `*ptr_opt` vs `ptr_opt[0]`. Not really critical. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5c8fcb30b76ac7bafd4a99bc3004049644e7e3f9 Gerrit-Change-Number: 34466 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023