September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: [WIP] HO: Transmit access bursts on DCCH of TCH channels

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email ) Change subject: [WIP] HO: Transmit access bursts on DCCH of TCH channels ...................................................................... Patch Set 5: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34481/comment/f12e4431_25a0366c PS5, Line 7: [WIP] HO: Transmit access bursts on DCCH of TCH channels WIP? https://gerrit.osmocom.org/c/osmocom-bb/+/34481/comment/5fe1b8d9_a8fe5314 PS5, Line 8: missing description on why is this needed. File src/target/firmware/layer1/prim_rach.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34481/comment/60f40c93_8227ee84 PS5, Line 161: fn_sched %= 2715648; what's this number? I bet we have a define for it. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a972d9bac5749c67c1b139825400854f7cf1490 Gerrit-Change-Number: 34481 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:37:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Add two logging categories for group and broadcast call control

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34480?usp=email ) Change subject: ASCI: Add two logging categories for group and broadcast call control ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77f634c7098137a5412ea56ddc0e794e629d1982 Gerrit-Change-Number: 34480 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:36:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmocom-bb[master]: ASCI: Add a flag to turn transmitter off or on

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email ) Change subject: ASCI: Add a flag to turn transmitter off or on ...................................................................... Patch Set 5: (2 comments) File include/l1ctl_proto.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/4e84bd6c_f5eaf139 PS5, Line 217: uint8_t tch_flags; this means we probably need to update the L1CTL implementations everywhere, eg TTCN3. Do we have some versioning of the proto? maybe move it to the end? File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/9b358913_e98ba6f4 PS5, Line 3042: LOGP(DRR, LOGL_INFO, " Channel type %d, subch %d, ts %d, mode %d, audio-mode %d, flags %d, cipher %d\n", you most probably want to print flags with 0x02%x here -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:36:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmocom-bb[master]: ASCI: MM connections are defined by 'ref' and 'protocol' tuple

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email ) Change subject: ASCI: MM connections are defined by 'ref' and 'protocol' tuple ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34478/comment/7a8ea8ed_4e39e87d PS5, Line 1427: uint32_t ref, uint16_t class) using "class" as param name is asking for trouble eg. when compiling with a C++ compiler due to being a reserved keyword. It is even rendered differently in here in gerrit. Maybe call it "klass". https://gerrit.osmocom.org/c/osmocom-bb/+/34478/comment/884a8d02_6eb3874c PS5, Line 1449: LOGP(DMM, LOGL_ERROR, "Invalid message class 0x%x. Please fix!", class); 0x02%x? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic280cd8c666660077bb2c2ef641f4cddd3b36eee Gerrit-Change-Number: 34478 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:31:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmocom-bb[master]: ASCI: Get timing advance and TX power only when included

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email ) Change subject: ASCI: Get timing advance and TX power only when included ...................................................................... Patch Set 4: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34477/comment/af821c23_fc345356 PS4, Line 4982: msg->cb[0] = rllh->link_id; why are you adding this? I don't see it being used in gsm48_rr_rx_acch? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88 Gerrit-Change-Number: 34477 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:28:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in osmocom-bb[master]: ASCI: Add GCC/BCC (call control) to mobility management

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email ) Change subject: ASCI: Add GCC/BCC (call control) to mobility management ...................................................................... Patch Set 3: (3 comments) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/2f157f65_9ab36e21 PS3, Line 789: case GSM48_MMGCC_CLASS: Maybe some explanation why is this added here ad does nothing? https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/7fd209d7_6af18d9d PS3, Line 4096: mm_conn_new_ref++); wrong indentation. You can actually put it in the same line. https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/3ef173dd_0f012d4a PS3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { wrong indentation. I personally prefer: if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { while some other people prefer: if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If6f3cea4b2ca839559596a6ee5a3d169c6d85dbe Gerrit-Change-Number: 34476 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in libosmo-sccp[master]: sccp: Introduce initial support for SCCP LUDT + LUDTS messages

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages ...................................................................... sccp: Introduce initial support for SCCP LUDT + LUDTS messages * LUDT/LUDTS is now properly received and passed along to the app. * LUDT/LUDTS is now used if the data to transmit spans more than 255 bytes. Related: SYS#6566 Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6 --- M include/osmocom/sccp/sccp_types.h M include/osmocom/sigtran/xua_msg.h M src/sccp2sua.c M src/xua_msg.c M tests/xua/sccp_test_data.c M tests/xua/sccp_test_data.h M tests/xua/xua_test.c M tests/xua/xua_test.ok 8 files changed, 447 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/67/34467/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6 Gerrit-Change-Number: 34467 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: HACK, DON'T MERGE!: remove calloc from libosmocore

by jolly

jolly has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34475?usp=email ) Change subject: HACK, DON'T MERGE!: remove calloc from libosmocore ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifd0560df0b8a9765c0a0b8939bec917b323382d7 Gerrit-Change-Number: 34475 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: HACK, DON'T MERGE!: make firmware compile with write/flash support

by jolly

jolly has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34474?usp=email ) Change subject: HACK, DON'T MERGE!: make firmware compile with write/flash support ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34474?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibc83a0beb9c716026f681232abe98a85bfa5ab5c Gerrit-Change-Number: 34474 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: HACK, DON'T MERGE! strncasecmp for firmware

by jolly

jolly has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34473?usp=email ) Change subject: HACK, DON'T MERGE! strncasecmp for firmware ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8c201fcfcc6ad1766dcff032f0cac76f53f2fb3 Gerrit-Change-Number: 34473 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023