September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: ASCI: Add protocol type to trans_find_by_callref() function

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34493?usp=email ) Change subject: ASCI: Add protocol type to trans_find_by_callref() function ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifea3a81aae3b4ae897851f867b13fa987c8cbe11 Gerrit-Change-Number: 34493 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:26:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to MM layer ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/c8d068b1_989bd67a PS5, Line 262: /* VGCS additional states */ struct vcgs? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GPRS_Components: fix comment

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500?usp=email ) Change subject: GPRS_Components: fix comment ...................................................................... Patch Set 1: (1 comment) File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500/comment/7bdd9bab_9644… PS1, Line 1073: /* Send DATA.cnf back to the IUT */ AFAIU this should nowadays only be sent if the msg containg a .confirm=true field? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2 Gerrit-Change-Number: 34500 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:19:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use imsi record member

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34499?usp=email ) Change subject: GPRS_Components: use imsi record member ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c7c6a31cbf7ed533e665728c157de0ac9e0fe8d Gerrit-Change-Number: 34499 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:18:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: ensure clean IMSI string

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email ) Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Using a regexp to trim this looks a bit overkill for me, but ok. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: ensure clean IMSI string

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email ) Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to RR layer

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to RR layer ...................................................................... Patch Set 5: (8 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/9a764c4b_b77e84b1 PS5, Line 89: #define GSM48_RR_GST_OFF 0 can we have this as an enum? https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/67d7d1bf_7e586990 PS5, Line 220: /* group call */ what about putting all this inside "gc" substruct? https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/ea586a2e_80cfb3c9 PS5, Line 222: int group_state; /* extension to RR state for group transmit/receive modes */ can we have this as an enum? https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/911c9204_ca1db00e PS5, Line 230: int uplink_tries; /* Counts number of tries to access the uplink. */ if it's a counter, do we need negative values (int)? File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/6933043e_360022c8 PS5, Line 73: * GSM48_MM_EVENT_UPLINK_BUSY: Notify MM layer about uplink becoming busy. I think you added these a few commits before. They should probably be in this commit instead since this is where you are using them. https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/65122fac_c72b8f4e PS5, Line 134: static int gsm48_rr_render_ma(struct osmocom_ms *ms, struct gsm48_rr_cd *cd, uint16_t *ma, uint8_t *ma_len); I bet some of this pointers can be const. https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/e5bc763e_f1826eea PS5, Line 414: if (rr->state == state && state != GSM48_RR_ST_IDLE) { are you sure this is correct' this should be == iiuc, not !=. https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/8da2ae0f_633b05ad PS5, Line 7080: we should start thinking about splitting this file into smaller pieces ;) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb Gerrit-Change-Number: 34491 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:15:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GPRS_Components: fix comment

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500?usp=email ) Change subject: GPRS_Components: fix comment ...................................................................... GPRS_Components: fix comment The confirmation is sent in both cases, PCH and AGCH Related: OS#5927 Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2 --- M pcu/GPRS_Components.ttcn 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/34500/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index aaec6d3..6d1562e 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -1070,7 +1070,7 @@ t_imm_ass)) -> value data_msg { rr_imm_ass := data_msg.rr_msg; log("Rx Immediate Assignment: ", rr_imm_ass); - /* Send DATA.cnf back to the IUT (only needed for PCH) */ + /* Send DATA.cnf back to the IUT */ f_pcuif_tx_data_cnf(data_msg); setverdict(pass); } @@ -1187,7 +1187,7 @@ f_shutdown(__BFILE__, __LINE__); } - /* Send DATA.cnf back to the IUT (only needed for PCH) */ + /* Send DATA.cnf back to the IUT */ f_pcuif_tx_data_cnf(data_msg); return rr_pag_req1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2 Gerrit-Change-Number: 34500 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use imsi record member

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34499?usp=email ) Change subject: GPRS_Components: use imsi record member ...................................................................... GPRS_Components: use imsi record member The function f_pcuif_rx_pch_pag_req1 tries to read the IMSI suffix from the raw data that was exchanged on the PCUIF interface. This is no longer the appropriate way in PCUIF v.11. There is now a dedicated imsi member in type record BTS_CCCH_Block, which is used for that purpose. Related: OS#5927 Change-Id: I0c7c6a31cbf7ed533e665728c157de0ac9e0fe8d --- M pcu/GPRS_Components.ttcn 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/34499/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 983ae8f..aaec6d3 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -1175,9 +1175,8 @@ rr_pag_req1 := data_msg.rr_msg; log("Rx Paging Request Type1: ", rr_pag_req1); - - /* First 3 bytes contain IMSI suffix to calculate paging group: */ - imsi_suff_octstr := substr(data_msg.raw.data, 0, 3); + /* The last 3 digits of the IMSI are used to calculate paging group: */ + imsi_suff_octstr := substr(char2oct(data_msg.imsi), lengthof(data_msg.imsi) - 3, 3); pag_group_rx := str2int(oct2char(imsi_suff_octstr[0])) * 100 + str2int(oct2char(imsi_suff_octstr[1])) * 10 + str2int(oct2char(imsi_suff_octstr[2])); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c7c6a31cbf7ed533e665728c157de0ac9e0fe8d Gerrit-Change-Number: 34499 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: ensure clean IMSI string

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email ) Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... PCUIF_Components: ensure clean IMSI string When receiving an IMSI from PCUIF (see type record PCUIF_pch), it is represented as a null terminated string. The field is set to be 17 characters wide with a pdding of zeros at the end (as it ought to be for a null terminated string). Unfortunately TTCN3 will not chop off the trailing zeros, and also include them when the string length is determined using lengthof(). This means we must take care of this ourselves. Let's use a regular expression to make sure any non numerical digits are trimmed off before passing the IMSI string on to higher layers. Related: OS#5927 Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 --- M pcu/PCUIF_Components.ttcn 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/34498/1 diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn index 01638b1..b297de6 100644 --- a/pcu/PCUIF_Components.ttcn +++ b/pcu/PCUIF_Components.ttcn @@ -542,6 +542,8 @@ var octetstring data; var PCUIF_pch pch; var PCUIF_agch agch; + var charstring imsi_filter_regexp := "(\d*)" /* numbers only */ + /* On PCH the payload is prefixed with paging group (3 octets): skip it. * TODO: add an additional template parameter, so we can match it. */ if (pcu_msg.u.data_req.sapi == PCU_IF_SAPI_PCH) { @@ -555,7 +557,7 @@ if (pcu_msg_rr.raw.sapi == PCU_IF_SAPI_PCH_2) { pch := dec_PCUIF_pch(pcu_msg_rr.raw.data); pcu_msg_rr.msg_id := pch.msg_id; - pcu_msg_rr.imsi := pch.imsi; + pcu_msg_rr.imsi := regexp(pch.imsi, imsi_filter_regexp, 0); pcu_msg_rr.rr_msg := dec_GsmRrMessage(pch.data); pcu_msg_rr.confirm := pch.confirm; } else if (pcu_msg_rr.raw.sapi == PCU_IF_SAPI_AGCH_2) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023