September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: ASCI: Add channel description to messages from MM to RR layer

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34490?usp=email ) Change subject: ASCI: Add channel description to messages from MM to RR layer ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34490/comment/b425430c_24dfd339 PS5, Line 65: struct gsm48_chan_desc ch_desc; did you check all users of this struct to make sure eveyrthing is updated? Is this field always present in all contexts where this struct is used? File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34490/comment/534f1b8e_c5e20d13 PS5, Line 882: memcpy(&rrh->ch_desc, ch_desc, sizeof(rrh->ch_desc)); you may want to memzero the rrh_ch_desc here if ch_desc=NULL -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I154f1f0e49ffa508d01a026da8e73faa7fdbab40 Gerrit-Change-Number: 34490 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:58:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Add uplink free/busy event to MM events

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34489?usp=email ) Change subject: ASCI: Add uplink free/busy event to MM events ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: why are these added if they are not used anywhere? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3f8d97a0359ea9560d6d6bfd8238ddc6492c56e8 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Add channel notification event to MM events

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email ) Change subject: ASCI: Add channel notification event to MM events ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/0b53aacc_b9d2ef6f PS5, Line 170: uint8_t sres[4]; the sres is used with all events? or with some specific event only? https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/f9f6dde3_99ee7a05 PS5, Line 171: struct { Mention the related type somehow, example: struct { /* GSM48_MM_EVENT_NOTIFICATION */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342 Gerrit-Change-Number: 34488 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:56:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: Fix unset sapi in gsm48_rr_data_ind()

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34487?usp=email ) Change subject: Fix unset sapi in gsm48_rr_data_ind() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8345a562050d52d491f3b7192c979d455a63931c Gerrit-Change-Number: 34487 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:54:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: Fix request reference value in gsm48_match_ra()

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email ) Change subject: Fix request reference value in gsm48_match_ra() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iec636d368e20030beac2861bff61b1a06e7b4821 Gerrit-Change-Number: 34486 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:53:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: Fix request reference value in gsm48_match_ra()

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email ) Change subject: Fix request reference value in gsm48_match_ra() ...................................................................... Patch Set 5: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34486/comment/d9ac23f1_9a12a431 PS5, Line 2377: ia_t1 = ref->t1; why is gerrit marking the first 3 lines as changed? I don't see any change :/ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iec636d368e20030beac2861bff61b1a06e7b4821 Gerrit-Change-Number: 34486 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:53:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Increase channel request history to 5 entries

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email ) Change subject: ASCI: Increase channel request history to 5 entries ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34485/comment/f41098d1_4522ba1b PS5, Line 2367: static int gsm48_match_ra(struct osmocom_ms *ms, struct gsm48_req_ref *ref, int hist_num) unsigned. uint8_t probably? https://gerrit.osmocom.org/c/osmocom-bb/+/34485/comment/409eae4e_6704c29f PS5, Line 2495: if (gsm48_match_ra(ms, &ia->req_ref, 3)) { sounds like we want to have defined for magic numbers 3 and 5 ;) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I62f18685bf05663f3ee6e94f6884ffb9a6b07ea4 Gerrit-Change-Number: 34485 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmocom-bb[master]: Refactoring encoding of mobile identity at mobile application

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email ) Change subject: Refactoring encoding of mobile identity at mobile application ...................................................................... Patch Set 5: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/d318655e_786fbc18 PS5, Line 9: Deprecated functions gsm48_generate_mid_from_*() are replaced by yay! \o/ Patchset: PS5: Just to make sure, did you test a bit this? This kind of patches can easily add regressions. laforge already submitted a similar once a few weeks/months ago and I think it is still in gerrit because I spotted some possible regressions. File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/1f598f90_00b0d62c PS5, Line 276: int gsm48_encode_mi(struct osmocom_ms *ms, struct msgb *msg, bool tlv, uint8_t mi_type, bool emergency_imsi) Did you think about having 2 functions gsm48_encode_mi_tlv() and gsm48_encode_mi_lv()? Then have: gsm48_encode_mi_tlv(..) { msgb_put_u8(msg, GSM48_IE_MOBILE_ID); return gsm48_encode_mi_lv(...) } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ff429bd50d718530fdad64a276053a35c8928f2 Gerrit-Change-Number: 34484 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email ) Change subject: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/include/osmocom/bb/common/settings.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/f09958e4_144f9dd2 PS5, Line 165: uint8_t vgcs; /* support of VGCS */ bool I know others use uint8_t, but let's at least use bool for the new ones. The old ones should be moved to bool at some point. File src/host/layer23/src/common/support.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/37c4dda6_097915dc PS5, Line 37: sup->vgcs = 1; /* yes */ = true -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia23eb190e533660cce4ba4c856a83b5f3d534202 Gerrit-Change-Number: 34483 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:41:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Add UIC support to random access burst

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email ) Change subject: ASCI: Add UIC support to random access burst ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed Gerrit-Change-Number: 34482 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:40:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023