September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: ensure clean IMSI string

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email ) Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Now I get: "262420000000423" & char(0, 0, 0, 0) & char(0, 0, 0, 241), which causes even more odd beh […] Sorry to hear that. I am not going to block, but still think it's worth investigating how to eliminate this `char(0, 0, 0, 0)` and where the `char(0, 0, 0, 241)` is coming from (garbage in the buffer maybe?). From what I can see, `PCUIF_Text` seems to work as expected: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-pcu-test/1719/cons… ``` BTS(9)@0b8d19f58d3f: Rx TXT.ind from the PCU, version is "1.3.1.1-c1b0" ``` File pcu/PCUIF_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498/comment/9c02d36e_d5a5… PS1, Line 545: var charstring imsi_filter_regexp := "(\d*)" /* numbers only */ missing `;` at the end of line, btw -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 20:11:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: ensure clean IMSI string

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email ) Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think a better solution would be changing the definition of `record PCUIF_pch` and letting the RAW […] Now I get: "262420000000423" & char(0, 0, 0, 0) & char(0, 0, 0, 241), which causes even more odd behavior. I also have no clue where the char(0, 0, 0, 241) comes from. Before it was at least "262420000000423" & char(0, 0, 0, 0) & char(0, 0, 0, 0) The definition is currently as follows: type record PCUIF_pch { OCT4 msg_id, charstring imsi length(17), octetstring data length(23), boolean confirm } with { variant (msg_id) "BYTEORDER(last)" variant (imsi) "FIELDLENGTH(null_terminated)" variant (data) "FIELDLENGTH(23)" }; I will try it again tomorrow and experiment a bit. Unfortunately the Regex was the best I could come up with. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 17:45:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-mme: Fix missing IP/port config for S11 interface

by dexter

Attention is currently required from: osmith, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34501?usp=email ) Change subject: ttcn3-mme: Fix missing IP/port config for S11 interface ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I941da52a4d9e10d954a44f32680cf8e8f7a8086a Gerrit-Change-Number: 34501 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 16:24:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix local port passed as remote port in Gn interface

by dexter

Attention is currently required from: osmith, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34502?usp=email ) Change subject: mme: Fix local port passed as remote port in Gn interface ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94f50a11292a83dcbd2da8d6df608ef71842b50 Gerrit-Change-Number: 34502 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 16:23:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-mme: Fix missing IP/port config for S11 interface

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/34501?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ttcn3-mme: Fix missing IP/port config for S11 interface ...................................................................... ttcn3-mme: Fix missing IP/port config for S11 interface This fixes failure when running MME_Tests.TC_s1ap_attach Depends: osmo-ttcn3-hacks.git Change-Id Ia94f50a11292a83dcbd2da8d6df608ef71842b50 Change-Id: I941da52a4d9e10d954a44f32680cf8e8f7a8086a --- M ttcn3-mme-test-ogs/ogs/MME_Tests.cfg M ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/01/34501/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I941da52a4d9e10d954a44f32680cf8e8f7a8086a Gerrit-Change-Number: 34501 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix local port passed as remote port in Gn interface

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34502?usp=email ) Change subject: mme: Fix local port passed as remote port in Gn interface ...................................................................... mme: Fix local port passed as remote port in Gn interface Change-Id: Ia94f50a11292a83dcbd2da8d6df608ef71842b50 --- M mme/MME_Tests.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/34502/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 3af72bc..ce30279 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -128,7 +128,7 @@ var ConnHdlrPars g_pars; timer g_Tguard := 30.0; - var GtpPeer g_gn_iface_peer := { connId := 1, remName := mp_gn_remote_ip, remPort := mp_gn_local_port }; + var GtpPeer g_gn_iface_peer := { connId := 1, remName := mp_gn_remote_ip, remPort := mp_gn_remote_port }; } type record ConnHdlrPars { @@ -161,6 +161,7 @@ charstring mp_gn_local_ip := "127.0.0.22"; integer mp_gn_local_port := 2123; charstring mp_gn_remote_ip := "127.0.0.2"; + integer mp_gn_remote_port := 2123; /* S11 interface (GTPv2C, interface between MME and SGW) */ charstring mp_s11_local_ip := "127.0.0.3"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94f50a11292a83dcbd2da8d6df608ef71842b50 Gerrit-Change-Number: 34502 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-mme: Fix missing IP/port config for S11 interface

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34501?usp=email ) Change subject: ttcn3-mme: Fix missing IP/port config for S11 interface ...................................................................... ttcn3-mme: Fix missing IP/port config for S11 interface This fixes failure when running MME_Tests.TC_s1ap_attach Change-Id: I941da52a4d9e10d954a44f32680cf8e8f7a8086a --- M ttcn3-mme-test-ogs/ogs/MME_Tests.cfg M ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml 2 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/01/34501/1 diff --git a/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg b/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg index 6f873f2..f725f22 100644 --- a/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg +++ b/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg @@ -29,9 +29,15 @@ # Gn interface mp_gn_local_ip := "172.18.3.202"; -mp_gn_local_port := 2123; +mp_gn_local_port := 2124; mp_gn_remote_ip := "172.18.3.201"; +# S11 interface (GTPv2C, interface between MME and SGW) +mp_s11_local_ip := "172.18.3.202"; +mp_s11_local_port := 2123; +mp_s11_remote_ip := "172.18.3.201"; +mp_s11_remote_port := 2123; + [MAIN_CONTROLLER] [EXECUTE] diff --git a/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml b/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml index ac72335..74229ea 100644 --- a/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml +++ b/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml @@ -515,6 +515,7 @@ - gtpc: addr: - 172.18.3.202 + port: 2124 routes: - rai: lai: -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I941da52a4d9e10d954a44f32680cf8e8f7a8086a Gerrit-Change-Number: 34501 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use imsi record member

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34499?usp=email ) Change subject: GPRS_Components: use imsi record member ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c7c6a31cbf7ed533e665728c157de0ac9e0fe8d Gerrit-Change-Number: 34499 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:54:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: ensure clean IMSI string

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email ) Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think a better solution would be changing the definition of `record PCUIF_pch` and letting the RAW encoder do the magic for us. Can you try changing `variant (imsi) "FIELDLENGTH(17)"` to `variant (imsi) "FIELDLENGTH(null_terminated)"`, like it's already done for the `PCUIF_Text`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_process_rx_ludt

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34469?usp=email ) Change subject: sccp: Introduce test TC_process_rx_ludt ...................................................................... sccp: Introduce test TC_process_rx_ludt Related: SYS#6566 Change-Id: I0880ccce872e79f057e17e29e09a566645365e96 --- M library/SCCP_Templates.ttcn M sccp/SCCP_Tests_RAW.ttcn 2 files changed, 82 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/library/SCCP_Templates.ttcn b/library/SCCP_Templates.ttcn index 74f1a20..a87ef5c 100644 --- a/library/SCCP_Templates.ttcn +++ b/library/SCCP_Templates.ttcn @@ -217,6 +217,52 @@ } } +template (value) PDU_SCCP ts_SCCP_LUDT(SCCP_PAR_Address calling, SCCP_PAR_Address called, + template (value) octetstring data, + template (value) BIT4 msg_hdl := '0000'B, + template (value) integer hop_ctr := 16) := { + longudata := { + messageType := ludt, + protClass := {'0000'B, msg_hdl}, + hopCounter := hop_ctr, + pointer1 := 0, /* overwritten */ + pointer2 := 0, /* overwritten */ + pointer3 := 0, /* overwritten */ + pointer4 := 0, /* overwritten */ + calledPAddress := ConvertASPAddressToEncodedAddress_itu(called), + callingPAddress := ConvertASPAddressToEncodedAddress_itu(calling), + longData := { + paramLength := 0, + data := data + }, + optionalPart := omit, + eop := omit + } +} + +template PDU_SCCP tr_SCCP_LUDT(template (present) SCCP_PAR_Address calling, template (present) SCCP_PAR_Address called, + template octetstring data := ?, + template BIT4 msg_hdl := '0000'B, + template integer hop_ctr := ?) := { + longudata := { + messageType := ludt, + protClass := {'0000'B, msg_hdl}, + hopCounter := hop_ctr, + pointer1 := ?, + pointer2 := ?, + pointer3 := ?, + pointer4 := ?, + calledPAddress := tr_Addr(called), + callingPAddress := tr_Addr(calling), + longData := { + paramLength := ?, + data := data + }, + optionalPart := { segmentation:= omit, importance := * } ifpresent, + eop := { paramName:= con_SCCP_eop } ifpresent + } +} + template PDU_SCCP tr_SCCP_IT(template (present) OCT3 source_lref := ?, template (present) OCT3 dest_lref := ?) := { diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index 505deb6..1c81d98 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -340,6 +340,31 @@ setverdict(pass); } +private function f_tx_ludt_exp(SCCP_PAR_Address calling, SCCP_PAR_Address called, octetstring data) runs on SCCP_Test_RAW_CT { + var template PDU_SCCP exp_rx; + f_send_sccp(ts_SCCP_LUDT(calling, called, data)); + exp_rx := tr_SCCP_LUDT(called, calling, data); + f_exp_sccp(exp_rx); +} + +/* Test if the IUT SCCP code processes a LUDT [treat it like UDT] and answers back. */ +testcase TC_process_rx_ludt() runs on SCCP_Test_RAW_CT { + var SCCP_PAR_Address calling, called; + var octetstring data := f_rnd_octstring(1000); + + f_init_raw(mp_sccp_cfg[0]); + f_sleep(1.0); + + called := valueof(ts_SccpAddr_PC_SSN(mp_sccp_cfg[0].peer_pc, mp_sccp_cfg[0].peer_ssn, + mp_sccp_cfg[0].sio, mp_sccp_cfg[0].sccp_service_type)); + calling := valueof(ts_SccpAddr_PC_SSN(mp_sccp_cfg[0].own_pc, mp_sccp_cfg[0].own_ssn, + mp_sccp_cfg[0].sio, mp_sccp_cfg[0].sccp_service_type)); + + /* Make sure an LUDT is echoed back just like an UDT */ + f_tx_ludt_exp(calling, called, data); + setverdict(pass); +} + function f_scmg_xceive(SCCP_PAR_Address calling, SCCP_PAR_Address called, template (value) PDU_SCMG_message tx, template (omit) PDU_SCMG_message rx_exp, @@ -464,6 +489,7 @@ execute( TC_tiar_timeout() ); execute( TC_it_avoids_tiar() ); execute( TC_process_rx_xudt() ); + execute( TC_process_rx_ludt() ); execute( TC_scmg_sst_ssn1() ); execute( TC_scmg_sst_ssn_valid() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0880ccce872e79f057e17e29e09a566645365e96 Gerrit-Change-Number: 34469 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023