September 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: sscp2sua: Constify several more parameters

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34465?usp=email ) Change subject: sscp2sua: Constify several more parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d0997a137f65bccdf8eeda70d95f3f908d2d91a Gerrit-Change-Number: 34465 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:38:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmocom-bb[master]: ASCI: Add UIC support to random access burst

by Jenkins Builder

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email ) Change subject: ASCI: Add UIC support to random access burst ...................................................................... Patch Set 2: (1 comment) File src/target/firmware/layer1/prim_rach.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11196): https://gerrit.osmocom.org/c/osmocom-bb/+/34482/comment/96d29b49_008d778f PS2, Line 64: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed Gerrit-Change-Number: 34482 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:35:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls

by Jenkins Builder

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/include/osmocom/bb/mobile/transaction.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11192): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ce16c824_c2806631 PS2, Line 74: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */ 'seperate' may be misspelled - perhaps 'separate'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:35:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to RR layer

by Jenkins Builder

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to RR layer ...................................................................... Patch Set 2: (5 comments) File src/host/layer23/src/mobile/gsm48_rr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/3c4cbcfc_3896902e PS2, Line 510: while((msg = msgb_dequeue(&rr->downqueue))) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/a70ff070_d9203d79 PS2, Line 1529: if (bitvec_get_bit_high(&bv) == H) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/7e4c8b7a_3a849f2a PS2, Line 1963: /* Note: Other informations are not used. */ 'informations' may be misspelled - perhaps 'information'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/55485bd5_cac4ac8e PS2, Line 5501: reject: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/286eef42_178bfe11 PS2, Line 6389: /* Leave uplink, wait for uplink beeing free, channel release or channel/link failure. */ 'beeing' may be misspelled - perhaps 'being'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb Gerrit-Change-Number: 34491 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmocom-bb[master]: ASCI: Add a flag to turn transmitter off or on

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add a flag to turn transmitter off or on ...................................................................... ASCI: Add a flag to turn transmitter off or on This flag can be used to turn transmitter off for "group receive mode" or for handover procedure. The flag is stored in the channel description of the mobile application. It is sent to layer 1 when switching to dedicated channel or when changing TCH mode. At the layer 1 the transmitter is turned off while the receiver is still active. This is done by: * scheduling a TX dummy task for TCH bursts * scheduling no TX task for SACCH bursts * not enabling the transmit window Related: OS#5364 Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 --- M include/l1ctl_proto.h M src/host/layer23/include/osmocom/bb/common/l1ctl.h M src/host/layer23/include/osmocom/bb/common/osmocom_data.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/mobile/gsm414.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/modem/grr.c M src/target/firmware/include/layer1/async.h M src/target/firmware/include/layer1/sync.h M src/target/firmware/layer1/async.c M src/target/firmware/layer1/l23_api.c M src/target/firmware/layer1/prim_tch.c 14 files changed, 92 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/79/34479/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[M] Change in osmocom-bb[master]: ASCI: Get timing advance and TX power only when included

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Get timing advance and TX power only when included ...................................................................... ASCI: Get timing advance and TX power only when included Instead of assuming that there are TX power and timing advance IEs included in RSL message, check for existence. gsm48_rr_rx_acch() may receive frames from FACCH that do not have these IEs included in the message. These frames are UI frames on DCCH and Bter frames. E.g. these frames are used on voice group channel to control uplink. Related: OS#5364 Change-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 40 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/77/34477/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88 Gerrit-Change-Number: 34477 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add group receive and transmit mode support to MM layer ...................................................................... ASCI: Add group receive and transmit mode support to MM layer Related: OS#5364 Change-Id: I05957182a57423ad947ab200b52f65fde859e110 --- M src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h M src/host/layer23/src/mobile/gsm48_mm.c 2 files changed, 700 insertions(+), 110 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/34492/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to RR layer

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add group receive and transmit mode support to RR layer ...................................................................... ASCI: Add group receive and transmit mode support to RR layer Related: OS#5364 Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h M src/host/layer23/src/mobile/gsm48_rr.c 3 files changed, 1,386 insertions(+), 84 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/91/34491/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb Gerrit-Change-Number: 34491 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls ...................................................................... ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 11 files changed, 2,072 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls ...................................................................... Patch Set 1: (29 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/bd9081a1_6a2e5fb0 PS1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE, GSM44068_ALLOC_HEADROOM, name); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/da7d76ca_023201c4 PS1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE, GSM44068_ALLOC_HEADROOM, name); please, no spaces at the start of a line File src/host/layer23/include/osmocom/bb/mobile/transaction.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b77e959c_d23480de PS1, Line 75: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */ 'seperate' may be misspelled - perhaps 'separate'? File src/host/layer23/src/mobile/gsm411_sms.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5b0fda21_e73c440d PS1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/68a1ede4_e07fd5cb PS1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) { please, no spaces at the start of a line File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/793eab65_fca6b0b5 PS1, Line 31: * If it comes avaiable, the establishment is performed and the U4 is entered. 'avaiable' may be misspelled - perhaps 'available'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/293fbff0_2a0edf29 PS1, Line 545: struct gsm48_uplink_release *ur = (struct gsm48_uplink_release *) msgb_put(msg, sizeof(*ur)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/4eaf8fe2_9d4b2b9f PS1, Line 545: struct gsm48_uplink_release *ur = (struct gsm48_uplink_release *) msgb_put(msg, sizeof(*ur)); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/0b6c939a_ae98a37c PS1, Line 549: gh->proto_discr = GSM48_PDISC_RR; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/68779e83_d9c3ce5b PS1, Line 549: gh->proto_discr = GSM48_PDISC_RR; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/02fe4002_39714356 PS1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/54f8e44c_086c229c PS1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ebbbc15c_c45ccc08 PS1, Line 551: ur->rr_cause = cause; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ad95be92_82937a54 PS1, Line 551: ur->rr_cause = cause; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b7d10ada_814a4bbd PS1, Line 691: /* Change to GROUP CALL ACTIVE (seperate link) state. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/6a758d03_9d6fefc2 PS1, Line 780: /* Set flag that we change to group receive mode after seperate link. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5d26883b_e9a84ed8 PS1, Line 821: /* Reset flag after we changed to group receive mode after seperate link. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b837f8b0_d1919a03 PS1, Line 832: LOG_GCC(trans, LOGL_INFO, "Ignoring release, because we released seperate link.\n"); 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/899b246f_13c4693e PS1, Line 859: /* Reset flag after we changed to group receive mode after seperate link. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/df60528b_ddf7d4c3 PS1, Line 862: LOG_GCC(trans, LOGL_INFO, "Joined group call after releasing seperate link.\n"); 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/937aadb4_3b325086 PS1, Line 1208: vgcs_vty_notify(trans, "Answer\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/32ee0eb7_117cf96d PS1, Line 1208: vgcs_vty_notify(trans, "Answer\n"); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/daecb788_8f25125f PS1, Line 1234: vgcs_vty_notify(trans, "Timeout\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/99b2ecb8_f6aeeef1 PS1, Line 1234: vgcs_vty_notify(trans, "Timeout\n"); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/dcf45341_fadf2150 PS1, Line 1301: vgcs_vty_notify(trans, "Timeout\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/2b5d41f3_f7268dc2 PS1, Line 1301: vgcs_vty_notify(trans, "Timeout\n"); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/f5acf32f_160bd58f PS1, Line 1352: .name = "GROUP CALL ACTIVE seperate link (U2sl)", 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5d4005f5_1ef71632 PS1, Line 1496: /* Create transaction together with state machine and set inital states. */ 'inital' may be misspelled - perhaps 'initial'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/f6a82d22_b14cd1d6 PS1, Line 1873: } else { else is not generally useful after a break or return -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 21 Sep 2023 09:40:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023