June 2023 - gerrit-log - lists.osmocom.org

[XS] Change in sandbox[master]: d: new file
by osmith 12 Jun '23

12 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/sandbox/+/33266 ) Change subject: d: new file ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/33266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: I5b74711fab851c328fd5abbeda622f20c627d478 Gerrit-Change-Number: 33266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in sandbox[master]: d: new file
by osmith 12 Jun '23

12 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/sandbox/+/33266 ) Change subject: d: new file ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: LGTM -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/33266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: I5b74711fab851c328fd5abbeda622f20c627d478 Gerrit-Change-Number: 33266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in sandbox[master]: d: new file
by osmith 12 Jun '23

12 Jun '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/sandbox/+/33266 ) Change subject: d: new file ...................................................................... d: new file Change-Id: I5b74711fab851c328fd5abbeda622f20c627d478 --- A d 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/sandbox refs/changes/66/33266/1 diff --git a/d b/d new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/d -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/33266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: I5b74711fab851c328fd5abbeda622f20c627d478 Gerrit-Change-Number: 33266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-ttcn3-hacks[master]: Added BSC tests for terminating voice group calls
by laforge 12 Jun '23

12 Jun '23

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 ) Change subject: Added BSC tests for terminating voice group calls ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:37:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fix the BTS_Tests_LAPDm.TC_t200_n200 test
by laforge 12 Jun '23

12 Jun '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33265 ) Change subject: Fix the BTS_Tests_LAPDm.TC_t200_n200 test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c328219b1a37d0f4623c5728143cd91976000a0 Gerrit-Change-Number: 33265 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:37:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: tests: $(BUILT_SOURCES) is not defined
by laforge 12 Jun '23

12 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 ) Change subject: tests: $(BUILT_SOURCES) is not defined ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf Gerrit-Change-Number: 32121 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:36:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates for UPLINK REQUEST
by laforge 12 Jun '23

12 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33148 ) Change subject: BSSMAP_Templates: Add templates for UPLINK REQUEST ...................................................................... BSSMAP_Templates: Add templates for UPLINK REQUEST Change-Id: I0b02be6a87899d5c9a2ef92011e09a8897328a05 --- M library/BSSMAP_Templates.ttcn 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 0810bd3..89efeb8 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -2468,6 +2468,34 @@ } /* Section 3.2.1.57 */ +template (value) PDU_BSSAP ts_BSSMAP_UplinkReq +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := omit, + cellIdentifier := omit, + layer3Information := omit, + mobileIdentity := omit + } + } + } +} +template (present) PDU_BSSAP tr_BSSMAP_UplinkReq +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := *, + cellIdentifier := *, + layer3Information := *, + mobileIdentity := * + } + } + } +} template (value) PDU_BSSAP ts_BSSMAP_UplinkReq_L3(template (value) BIT2 priority, template (omit) BSSMAP_IE_CellIdentifier cell_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0b02be6a87899d5c9a2ef92011e09a8897328a05 Gerrit-Change-Number: 33148 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add codec list to *VGCS_VBS_AssignmentReq templates
by laforge 12 Jun '23

12 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33146 ) Change subject: Add codec list to *VGCS_VBS_AssignmentReq templates ...................................................................... Add codec list to *VGCS_VBS_AssignmentReq templates AoIP, call ID and codec list must be included, if user plane is IP based. If not, the fields must not be included. Change-Id: Id3ce78ad795c418650ca924a953294c3380b8198 --- M library/BSSMAP_Templates.ttcn 1 file changed, 22 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index f8cb395..0810bd3 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -2301,7 +2301,8 @@ template (value) GroupCallRef group_call_ref, template (omit) BSSMAP_IE_CircuitIdentityCode cic := omit, template (omit) BSSMAP_IE_AoIP_TransportLayerAddress aoip := omit, - template (omit) OCT4 call_id := omit) + template (omit) OCT4 call_id := omit, + template (omit) BSSMAP_IE_SpeechCodecList codecList := omit) modifies ts_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -2320,7 +2321,7 @@ cellIdentifierListSegment := omit, aoIPTransportLayer := aoip, callIdentifier := ts_BSSMAP_IE_CallIdentifier(call_id), - codecList := omit + codecList := codecList } } } @@ -2331,8 +2332,9 @@ template (present) BSSMAP_IE_CellIdentifier cell_id, template (present) GroupCallRef group_call_ref, template BSSMAP_IE_CircuitIdentityCode cic := *, - template BSSMAP_IE_AoIP_TransportLayerAddress aoip := ?, - template OCT4 call_id := ?) + template BSSMAP_IE_AoIP_TransportLayerAddress aoip := *, + template OCT4 call_id := *, + template BSSMAP_IE_SpeechCodecList codecList := *) modifies tr_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -2351,7 +2353,7 @@ cellIdentifierListSegment := omit, aoIPTransportLayer := aoip, callIdentifier := tr_BSSMAP_IE_CallIdentifier(call_id), - codecList := omit + codecList := codecList } } } @@ -2388,9 +2390,9 @@ template (present) BSSMAP_IE_CellIdentifier cell_id, template BSSMAP_IE_ChosenChannel chosen_ch := *, template BSSMAP_IE_CircuitIdentityCode cic := omit, - template BSSMAP_IE_AoIP_TransportLayerAddress aoip := ?, - template BSSMAP_IE_SpeechCodec speech_codec := ?, - template OCT4 call_id := ?) + template BSSMAP_IE_AoIP_TransportLayerAddress aoip := *, + template BSSMAP_IE_SpeechCodec speech_codec := *, + template OCT4 call_id := *) modifies tr_BSSAP_BSSMAP := { pdu := { bssmap := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ce78ad795c418650ca924a953294c3380b8198 Gerrit-Change-Number: 33146 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add codec list to *VGCS_VBS_AssignmentReq templates
by laforge 12 Jun '23

12 Jun '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33146 ) Change subject: Add codec list to *VGCS_VBS_AssignmentReq templates ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ce78ad795c418650ca924a953294c3380b8198 Gerrit-Change-Number: 33146 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:27:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates for UPLINK REQUEST
by laforge 12 Jun '23

12 Jun '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33148 ) Change subject: BSSMAP_Templates: Add templates for UPLINK REQUEST ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0b02be6a87899d5c9a2ef92011e09a8897328a05 Gerrit-Change-Number: 33148 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 12 Jun 2023 11:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0