June 2023 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-netif[master]: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
by daniel 12 Jun '23

12 Jun '23

Attention is currently required from: arehbein, laforge, daniel. daniel has uploaded a new patch set (#11) to the change originally created by arehbein. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 ) Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ...................................................................... Add osmo_io support to osmo_stream_cli and osmo_stream_srv Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 305 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/93/33193/11 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c Gerrit-Change-Number: 33193 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmo-netif[master]: stream: Factor out reconnection handling
by daniel 12 Jun '23

12 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33253 to look at the new patch set (#2). Change subject: stream: Factor out reconnection handling ...................................................................... stream: Factor out reconnection handling Change-Id: I418377eabd465ee4ffce9b4440e96287c7734924 --- M src/stream.c 1 file changed, 53 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/53/33253/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I418377eabd465ee4ffce9b4440e96287c7734924 Gerrit-Change-Number: 33253 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmo-netif[master]: stream: Factor out reconnection handling
by daniel 12 Jun '23

12 Jun '23

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33253 ) Change subject: stream: Factor out reconnection handling ...................................................................... Patch Set 2: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33253/comment/04392488_03077a33 PS1, Line 472: osmo_fd_write_disable(&cli->ofd); > what if connect_cb() freed the cli object? you'd be accessing it here. […] Please look at osmo_iofd_free() and osmo_iofd_close() iofd->in_callback guards these -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I418377eabd465ee4ffce9b4440e96287c7734924 Gerrit-Change-Number: 33253 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 13:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: contrib/jenkins.sh: build with --enable-external-tests
by fixeria 12 Jun '23

12 Jun '23

Attention is currently required from: laforge, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32127 ) Change subject: contrib/jenkins.sh: build with --enable-external-tests ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: So the problem here is that `osmotestconfig.py` fails to establish a VTY connection when running `osmo-pcap-server` with a config file generated by `write file` command. The generated file contains line `tls dh generate`, which blocks the main thread for a few seconds. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic9d37b231510e592198a9de707dfe8f5f2703dce Gerrit-Change-Number: 32127 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 13:22:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: tests: $(BUILT_SOURCES) is not defined
by fixeria 12 Jun '23

12 Jun '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 ) Change subject: tests: $(BUILT_SOURCES) is not defined ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS2: > can we agree that this patch is a step in the right direction and should b e merged? […] Done, re-applying your CR+2. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf Gerrit-Change-Number: 32121 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 12 Jun 2023 12:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: tests: $(BUILT_SOURCES) is not defined
by pespin 12 Jun '23

12 Jun '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 ) Change subject: tests: $(BUILT_SOURCES) is not defined ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf Gerrit-Change-Number: 32121 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 12:46:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: tests: $(BUILT_SOURCES) is not defined
by fixeria 12 Jun '23

12 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 ) Change subject: tests: $(BUILT_SOURCES) is not defined ...................................................................... Patch Set 3: (1 comment) File tests/Makefile.am: https://gerrit.osmocom.org/c/osmo-pcap/+/32121/comment/2af63edf_9a88e98f PS1, Line 24: python-tests: > Idk, it needs to be checked which of the programs is being tested here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf Gerrit-Change-Number: 32121 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 12:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: tests: $(BUILT_SOURCES) is not defined
by fixeria 12 Jun '23

12 Jun '23

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 to look at the new patch set (#3). Change subject: tests: $(BUILT_SOURCES) is not defined ...................................................................... tests: $(BUILT_SOURCES) is not defined Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf --- M tests/Makefile.am 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/21/32121/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf Gerrit-Change-Number: 32121 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fix the BTS_Tests_LAPDm.TC_t200_n200 test
by pespin 12 Jun '23

12 Jun '23

Attention is currently required from: jolly, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33265 ) Change subject: Fix the BTS_Tests_LAPDm.TC_t200_n200 test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c328219b1a37d0f4623c5728143cd91976000a0 Gerrit-Change-Number: 33265 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 12:10:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in sandbox[master]: d: new file
by osmith 12 Jun '23

12 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/sandbox/+/33266 ) Change subject: d: new file ...................................................................... d: new file Change-Id: I5b74711fab851c328fd5abbeda622f20c627d478 --- A d 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/d b/d new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/d -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/33266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: I5b74711fab851c328fd5abbeda622f20c627d478 Gerrit-Change-Number: 33266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0