June 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_ma...
by fixeria 12 Jun '23

12 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269 ) Change subject: pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max to base it on T3168 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269/comment/7b7fff29_4c6b… PS1, Line 7129: TC_ul_tbf_reestablish_with_pkt_resource_req_t3168 please also update `expected-results.xml` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdfa9879cc56f5e2090cee0d3d70ee5df7c90454 Gerrit-Change-Number: 33269 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 20:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-netif[master]: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
by arehbein 12 Jun '23

12 Jun '23

Attention is currently required from: laforge, pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 ) Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ...................................................................... Patch Set 12: (1 comment) Patchset: PS10: > Right now we have the callback passed in _srv_create() but we have them in separate APIs in _cli_create(), which looks even more confusing. I agree, I'm generally in favor of having more similarity between `*_cli_*` and `*_srv_*` whenever possible. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c Gerrit-Change-Number: 33193 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 17:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: cosmetic: tbf_dl_fsm: Fix a couple comment typos
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33279 ) Change subject: cosmetic: tbf_dl_fsm: Fix a couple comment typos ...................................................................... cosmetic: tbf_dl_fsm: Fix a couple comment typos Change-Id: I1bcb199f3ba9564870b82ab67218ffbf72da4824 --- M src/tbf_dl_fsm.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/33279/1 diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index ce9bee3..a977507 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -160,13 +160,13 @@ * have to wait for X2002 to trigger (meaning MS is already * listening on PDCH) in order to move to FLOW state and start * transmitting data to it. When X2002 triggers (see cb timer - * end of the file) it will send TBF_EV_ASSIGN_READY_CCCH back + * end of the file) it will send TBF_EV_ASSIGN_READY_CCCH back * to us here. */ if (!(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH))) { /* This can happen if we initiated a CCCH DlAss from an * older TBF object (same TLLI) towards BTS, and the DL-TBF - * was recreated and is now trying to be assigned throguh + * was recreated and is now trying to be assigned through * PACCH. */ LOGPTBFDL(ctx->dl_tbf, LOGL_INFO, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1bcb199f3ba9564870b82ab67218ffbf72da4824 Gerrit-Change-Number: 33279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: Move call to bts_snd_dl_ass() from tbf_dl.cpp to tbf_dl_fsm.c
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33280 ) Change subject: Move call to bts_snd_dl_ass() from tbf_dl.cpp to tbf_dl_fsm.c ...................................................................... Move call to bts_snd_dl_ass() from tbf_dl.cpp to tbf_dl_fsm.c It makes more sense to have it there, where it is transmitted with more control depending on current state. Furthermore, it's counterpart/continuation TBF_EV_ASSIGN_PCUIF_CNF logic is already there, so it makes sense to have the whole logic together. Change-Id: I8af39d3087ccf197321f0c71cb29b67adbe1f36e --- M src/tbf_dl.cpp M src/tbf_dl_fsm.c 2 files changed, 26 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/33280/1 diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 05959cc..72de4d2 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -483,9 +483,6 @@ /* change state */ osmo_fsm_inst_dispatch(tbf->state_fi, TBF_EV_ASSIGN_ADD_CCCH, NULL); - - /* send immediate assignment */ - bts_snd_dl_ass(ms->bts, tbf); } int dl_tbf_upgrade_to_multislot(struct gprs_rlcmac_dl_tbf *dl_tbf) diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index a977507..02e1ff5 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -104,6 +104,7 @@ static void st_assign_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct tbf_dl_fsm_ctx *ctx = (struct tbf_dl_fsm_ctx *)fi->priv; + struct GprsMs *ms = tbf_ms(ctx->tbf); unsigned long val; unsigned int sec, micro; @@ -125,20 +126,29 @@ sec, micro); osmo_timer_schedule(&fi->timer, sec, micro); } else { - /* GPRS_RLCMAC_FLAG_CCCH is set, so here we submitted an DL Ass + /* GPRS_RLCMAC_FLAG_CCCH is set, so here we submit a DL Ass * through PCUIF on CCCH */ + OSMO_ASSERT(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)); + /* Send CCCH (PCH) Immediate Assignment over PCUIF: */ + bts_snd_dl_ass(ms->bts, ctx->dl_tbf); } } static void st_assign(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct tbf_dl_fsm_ctx *ctx = (struct tbf_dl_fsm_ctx *)fi->priv; + struct GprsMs *ms; unsigned long val; unsigned int sec, micro; switch (event) { case TBF_EV_ASSIGN_ADD_CCCH: + /* Note: This code path is not really used nowadays, since ADD_CCCH is + * only dispatched during dl_tbf allocation (st=NEW) */ + ms = tbf_ms(ctx->tbf); mod_ass_type(ctx, GPRS_RLCMAC_FLAG_CCCH, true); + /* Re-send CCCH (PCH) Immediate Assignment over PCUIF: */ + bts_snd_dl_ass(ms->bts, ctx->dl_tbf); break; case TBF_EV_ASSIGN_ADD_PACCH: mod_ass_type(ctx, GPRS_RLCMAC_FLAG_PACCH, true); @@ -210,13 +220,8 @@ * from continuing and start assignment on CCCH again */ if ((ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)) && !dl_tbf_first_dl_ack_rcvd(ctx->dl_tbf)) { - struct GprsMs *ms = tbf_ms(ctx->tbf); - LOGPTBFDL(ctx->dl_tbf, LOGL_DEBUG, - "Re-send downlink assignment on PCH (IMSI=%s)\n", - ms_imsi_is_valid(ms) ? ms_imsi(ms) : ""); + LOGPTBFDL(ctx->dl_tbf, LOGL_DEBUG, "Retransmit ImmAss[PktDlAss] on PCH\n"); tbf_dl_fsm_state_chg(fi, TBF_ST_ASSIGN); - /* send immediate assignment */ - bts_snd_dl_ass(ms->bts, ctx->dl_tbf); } break; case TBF_EV_LAST_DL_DATA_SENT: -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8af39d3087ccf197321f0c71cb29b67adbe1f36e Gerrit-Change-Number: 33280 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-pcu[master]: tests/tbf: Drop unneeded line re-setting CCCH ass type
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33278 ) Change subject: tests/tbf: Drop unneeded line re-setting CCCH ass type ...................................................................... tests/tbf: Drop unneeded line re-setting CCCH ass type Change-Id: I384753234651657c890faf1a4bdc1342e23e462b --- M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err 2 files changed, 9 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/33278/1 diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index bb36f9e..9a4b846 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -219,7 +219,6 @@ /* "Establish" the DL TBF */ osmo_fsm_inst_dispatch(dl_tbf->dl_ass_fsm.fi, TBF_DL_ASS_EV_SCHED_ASS, NULL); - osmo_fsm_inst_dispatch(dl_tbf->state_fi, TBF_EV_ASSIGN_ADD_CCCH, NULL); osmo_fsm_inst_dispatch(dl_tbf->state_fi, TBF_EV_ASSIGN_ACK_PACCH, NULL); check_tbf(dl_tbf); diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index a4b94cf..442f298 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -98,9 +98,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:G){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -224,9 +221,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:G){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -350,9 +344,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:G){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -629,9 +620,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:G){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -668,9 +656,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-1:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-1:G){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-1:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-1:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-1:G){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-1:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-1:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-1:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -4619,9 +4604,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -4938,9 +4920,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5204,9 +5183,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5430,9 +5406,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5640,9 +5613,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5834,9 +5804,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6004,9 +5971,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6183,9 +6147,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6353,9 +6314,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6515,9 +6473,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6594,9 +6549,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6672,9 +6624,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6750,9 +6699,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6853,9 +6799,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6955,9 +6898,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7057,9 +6997,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7162,9 +7099,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7247,9 +7181,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7332,9 +7263,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7417,9 +7345,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7863,9 +7788,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -9470,9 +9392,6 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 0 DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS -DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] -TBF(DL:TFI-0-0-0:E){ASSIGN} Attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I384753234651657c890faf1a4bdc1342e23e462b Gerrit-Change-Number: 33278 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: Move GPRS_RLCMAC_FLAG_DL_ACK from state_fsm to dl_tbf
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33277 ) Change subject: Move GPRS_RLCMAC_FLAG_DL_ACK from state_fsm to dl_tbf ...................................................................... Move GPRS_RLCMAC_FLAG_DL_ACK from state_fsm to dl_tbf That flag was still in state_fsm for historical reasons (refactoring steps), but it's not really the best place for it, since it's really specific to dl_tbf and to transmit of data and DL ACK/NACK not the overall state of the TBF. Change-Id: I12c28c1a52f363f2d17a8bc24bbdf379543fc7a6 --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h M src/tbf_dl_fsm.c 5 files changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/33277/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 8981615..279efcd 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -885,7 +885,7 @@ OSMO_STRBUF_PRINTF(sb, "Assignment was on CCCH|"); if (dl_tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH)) OSMO_STRBUF_PRINTF(sb, "Assignment was on PACCH|"); - if (dl_tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_DL_ACK)) + if (dl_tbf->m_first_dl_ack_rcvd) OSMO_STRBUF_PRINTF(sb, "Downlink ACK was received|"); else OSMO_STRBUF_PRINTF(sb, "No downlink ACK received yet|"); diff --git a/src/tbf.h b/src/tbf.h index 941e350..124a2e6 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -109,7 +109,6 @@ #define GPRS_RLCMAC_FLAG_CCCH 0 /* assignment on CCCH */ #define GPRS_RLCMAC_FLAG_PACCH 1 /* assignment on PACCH */ -#define GPRS_RLCMAC_FLAG_DL_ACK 2 /* DL TBF: At least one DL ACK/NACK was recieved since it was assigned */ #define TBF_TFI_UNSET 0xff #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 737b978..05959cc 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -1079,7 +1079,7 @@ int rc; LOGPTBFDL(this, LOGL_DEBUG, "downlink acknowledge\n"); - state_fsm.state_flags |= (1 << GPRS_RLCMAC_FLAG_DL_ACK); + m_first_dl_ack_rcvd = true; m_last_dl_poll_ack_lost = false; /* reset N3105 */ @@ -1113,6 +1113,11 @@ dl_tbf->request_dl_ack(); } +bool dl_tbf_first_dl_ack_rcvd(const struct gprs_rlcmac_dl_tbf *tbf) +{ + return tbf->m_first_dl_ack_rcvd; +} + /* Does this DL TBF require to poll the MS for DL ACK/NACK? */ bool gprs_rlcmac_dl_tbf::need_poll_for_dl_ack_nack() const { diff --git a/src/tbf_dl.h b/src/tbf_dl.h index ec75e32..dabe9a9 100644 --- a/src/tbf_dl.h +++ b/src/tbf_dl.h @@ -75,6 +75,8 @@ * MS polled during DL ACK/NACK with RRBP set in "m_last_dl_poll_fn": */ bool m_last_dl_poll_ack_lost; int32_t m_last_dl_drained_fn; + /* Whether we receive at least one PKT DL ACK/NACK from MS since this DL TBF was assigned: */ + bool m_first_dl_ack_rcvd; struct BandWidth { struct timespec dl_bw_tv; /* timestamp for dl bw calculation */ @@ -156,6 +158,7 @@ void dl_tbf_trigger_ass_on_pacch(struct gprs_rlcmac_dl_tbf *tbf, struct gprs_rlcmac_tbf *old_tbf); void dl_tbf_trigger_ass_on_pch(struct gprs_rlcmac_dl_tbf *tbf); void dl_tbf_request_dl_ack(struct gprs_rlcmac_dl_tbf *tbf); +bool dl_tbf_first_dl_ack_rcvd(const struct gprs_rlcmac_dl_tbf *tbf); int dl_tbf_upgrade_to_multislot(struct gprs_rlcmac_dl_tbf *tbf); static inline struct gprs_rlcmac_tbf *dl_tbf_as_tbf(struct gprs_rlcmac_dl_tbf *dl_tbf) diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index 6c3f4f1..ce9bee3 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -208,8 +208,8 @@ * don't even know if the MS successfully received the Imm Ass on * CCCH and hence is listening on PDCH. Let's better refrain * from continuing and start assignment on CCCH again */ - if ((ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)) - && !(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_DL_ACK))) { + if ((ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)) && + !dl_tbf_first_dl_ack_rcvd(ctx->dl_tbf)) { struct GprsMs *ms = tbf_ms(ctx->tbf); LOGPTBFDL(ctx->dl_tbf, LOGL_DEBUG, "Re-send downlink assignment on PCH (IMSI=%s)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I12c28c1a52f363f2d17a8bc24bbdf379543fc7a6 Gerrit-Change-Number: 33277 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33276 ) Change subject: Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf ...................................................................... Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf That flag was still in state_fsm for historical reasons (refactoring steps), but it's not really the best place for it, since it's really specific to dl_tbf and to transmit of data and DL ACK/NACK not the overall state of the TBF. Change-Id: I6b44121bbe185b58f3a77be8c12b4ef1f3180a30 --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h 4 files changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/33276/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 885c602..8981615 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -560,11 +560,11 @@ dl_tbf = tbf_as_dl_tbf(this); /* POLL Timeout expecting DL ACK/NACK: implies direction == GPRS_RLCMAC_DL_TBF */ OSMO_ASSERT(dl_tbf); - if (!(dl_tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_TO_DL_ACK))) { + if (!dl_tbf->m_last_dl_poll_ack_lost) { LOGPTBF(this, LOGL_NOTICE, "Timeout for polling PACKET DOWNLINK ACK: %s\n", tbf_rlcmac_diag(dl_tbf)); - dl_tbf->state_fsm.state_flags |= (1 << GPRS_RLCMAC_FLAG_TO_DL_ACK); + dl_tbf->m_last_dl_poll_ack_lost = true; } if (dl_tbf->state_is(TBF_ST_RELEASING)) bts_do_rate_ctr_inc(bts, CTR_RLC_REL_TIMEDOUT); diff --git a/src/tbf.h b/src/tbf.h index 37756b0..941e350 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -110,8 +110,6 @@ #define GPRS_RLCMAC_FLAG_CCCH 0 /* assignment on CCCH */ #define GPRS_RLCMAC_FLAG_PACCH 1 /* assignment on PACCH */ #define GPRS_RLCMAC_FLAG_DL_ACK 2 /* DL TBF: At least one DL ACK/NACK was recieved since it was assigned */ -#define GPRS_RLCMAC_FLAG_TO_DL_ACK 3 /* DL TBF: Failed to receive last polled DL ACK/NACK */ - #define TBF_TFI_UNSET 0xff #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 3ffafbf..737b978 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -858,7 +858,7 @@ LOGPTBFDL(this, LOGL_DEBUG, "Scheduling Ack/Nack polling, because it was requested explicitly " "(e.g. first final block sent).\n"); - } else if (state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_TO_DL_ACK)) { + } else if (m_last_dl_poll_ack_lost) { LOGPTBFDL(this, LOGL_DEBUG, "Scheduling Ack/Nack polling, because polling timed out.\n"); } else { @@ -879,10 +879,10 @@ if (is_final) T_START(this, T3191, 3191, "final block (DL-TBF)", true); - state_fsm.state_flags &= ~(1 << GPRS_RLCMAC_FLAG_TO_DL_ACK); /* clear poll timeout flag */ - /* Clear request flag */ m_dl_ack_requested = false; + /* clear poll timeout flag */ + m_last_dl_poll_ack_lost = false; /* set polling in header */ rlc.rrbp = rrbp; @@ -1080,7 +1080,7 @@ LOGPTBFDL(this, LOGL_DEBUG, "downlink acknowledge\n"); state_fsm.state_flags |= (1 << GPRS_RLCMAC_FLAG_DL_ACK); - state_fsm.state_flags &= ~(1 << GPRS_RLCMAC_FLAG_TO_DL_ACK); + m_last_dl_poll_ack_lost = false; /* reset N3105 */ n_reset(N3105); @@ -1118,7 +1118,7 @@ { /* poll after POLL_ACK_AFTER_FRAMES frames, or when final block is tx or * when last polled DL ACK/NACK was lost. */ - return state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_TO_DL_ACK) || + return m_last_dl_poll_ack_lost || m_tx_counter >= POLL_ACK_AFTER_FRAMES || m_dl_ack_requested; } diff --git a/src/tbf_dl.h b/src/tbf_dl.h index 6718c13..ec75e32 100644 --- a/src/tbf_dl.h +++ b/src/tbf_dl.h @@ -71,6 +71,9 @@ int32_t m_tx_counter; /* count all transmitted blocks */ bool m_dl_ack_requested; int32_t m_last_dl_poll_fn; + /* Whether we failed to receive ("poll timeout") last PKT CTRL ACK from + * MS polled during DL ACK/NACK with RRBP set in "m_last_dl_poll_fn": */ + bool m_last_dl_poll_ack_lost; int32_t m_last_dl_drained_fn; struct BandWidth { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6b44121bbe185b58f3a77be8c12b4ef1f3180a30 Gerrit-Change-Number: 33276 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type()
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/33275 ) Change subject: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() ...................................................................... tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() First print what is going to be attempted, later alarm about the possible error, finally early return. Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd --- M src/tbf_dl_fsm.c M src/tbf_ul_fsm.c M tests/tbf/TbfTest.err 3 files changed, 81 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/33275/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd Gerrit-Change-Number: 33275 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm: Abort on unexpected path
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33274 ) Change subject: tbf_{ul,dl}_fsm: Abort on unexpected path ...................................................................... tbf_{ul,dl}_fsm: Abort on unexpected path That path hsould not really. It happening would mean a totally wrong code being used. Hence, just abort() to simplify the code. Change-Id: Iaf65e909e45cc279e5be4b045c15174f910ffc12 --- M src/tbf_dl_fsm.c M src/tbf_ul_fsm.c 2 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/74/33274/1 diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index 9cc2007..abcd0c4 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -60,10 +60,7 @@ ch = "PACCH"; break; default: - LOGPTBFDL(ctx->dl_tbf, LOGL_ERROR, - "attempted to %sset unexpected ass. type %d - FIXME!\n", - set ? "" : "un", t); - return; + OSMO_ASSERT(0); } if (set && prev_set) diff --git a/src/tbf_ul_fsm.c b/src/tbf_ul_fsm.c index f6615a8..5d02032 100644 --- a/src/tbf_ul_fsm.c +++ b/src/tbf_ul_fsm.c @@ -59,10 +59,7 @@ ch = "PACCH"; break; default: - LOGPTBFUL(ctx->ul_tbf, LOGL_ERROR, - "attempted to %sset unexpected ass. type %d - FIXME!\n", - set ? "" : "un", t); - return; + OSMO_ASSERT(0); } if (set && prev_set) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iaf65e909e45cc279e5be4b045c15174f910ffc12 Gerrit-Change-Number: 33274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type()
by pespin 12 Jun '23

12 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33275 ) Change subject: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() ...................................................................... tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() First print what is going to be attempted, later alarm about the possible error, finally early return. Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd --- M src/tbf_dl_fsm.c M src/tbf_ul_fsm.c M tests/tbf/TbfTest.err 3 files changed, 81 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/33275/1 diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index abcd0c4..9f0211a 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -63,17 +63,20 @@ OSMO_ASSERT(0); } - if (set && prev_set) - LOGPTBFDL(ctx->dl_tbf, LOGL_ERROR, - "attempted to set ass. type %s which is already set.\n", ch); - else if (!set && !prev_set) - return; - LOGPTBFDL(ctx->dl_tbf, LOGL_INFO, "%sset ass. type %s [prev CCCH:%u, PACCH:%u]\n", set ? "" : "un", ch, !!(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)), !!(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH))); + if (set && prev_set) { + LOGPTBFDL(ctx->dl_tbf, LOGL_ERROR, + "attempted to set ass. type %s which is already set\n", ch); + return; + } + + if (!set && !prev_set) + return; + if (set) ctx->state_flags |= (1 << t); else diff --git a/src/tbf_ul_fsm.c b/src/tbf_ul_fsm.c index 5d02032..b08a5e1 100644 --- a/src/tbf_ul_fsm.c +++ b/src/tbf_ul_fsm.c @@ -62,17 +62,20 @@ OSMO_ASSERT(0); } - if (set && prev_set) - LOGPTBFUL(ctx->ul_tbf, LOGL_ERROR, - "attempted to set ass. type %s which is already set.\n", ch); - else if (!set && !prev_set) - return; - LOGPTBFUL(ctx->ul_tbf, LOGL_INFO, "%sset ass. type %s [prev CCCH:%u, PACCH:%u]\n", set ? "" : "un", ch, !!(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)), !!(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH))); + if (set && prev_set) { + LOGPTBFUL(ctx->ul_tbf, LOGL_ERROR, + "attempted to set ass. type %s which is already set\n", ch); + return; + } + + if (!set && !prev_set) + return; + if (set) ctx->state_flags |= (1 << t); else diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 0c9aa58..26063f3 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -99,8 +99,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -143,6 +143,7 @@ TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:G){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -224,8 +225,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -268,6 +269,7 @@ TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:G){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -349,8 +351,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -583,6 +585,7 @@ TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){FINISHED} Final ACK received. DL_TBF(DL:TFI-0-0-0:G){FINISHED}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G){FINISHED}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-45-0:DL) Detaching TBF: TBF(DL:G:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -627,8 +630,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:G){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:G){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -666,8 +669,8 @@ DL_ASS_TBF(DL:TFI-0-0-1:G){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-1:G){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-1:G){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-1:G){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-1:G){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-1:G){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-1:G){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-1:G){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-1:G){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -3820,6 +3823,7 @@ TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} Final ACK received. DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -4616,8 +4620,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -4888,6 +4892,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -4934,8 +4939,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5153,6 +5158,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5199,8 +5205,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5378,6 +5384,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5424,8 +5431,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5587,6 +5594,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5633,8 +5641,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5780,6 +5788,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5826,8 +5835,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -5949,6 +5958,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5995,8 +6005,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6127,6 +6137,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6173,8 +6184,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6296,6 +6307,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6342,8 +6354,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6454,6 +6466,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6503,8 +6516,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6535,6 +6548,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6581,8 +6595,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6612,6 +6626,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6658,8 +6673,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6689,6 +6704,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6735,8 +6751,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6791,6 +6807,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6837,8 +6854,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6892,6 +6909,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6938,8 +6956,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -6993,6 +7011,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7039,8 +7058,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7094,6 +7113,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7143,8 +7163,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7181,6 +7201,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7227,8 +7248,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7265,6 +7286,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7311,8 +7333,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7349,6 +7371,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7395,8 +7418,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -7440,6 +7463,7 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE +TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} unset ass. type CCCH [prev CCCH:0, PACCH:1] TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7840,8 +7864,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] @@ -9447,8 +9471,8 @@ DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL:TFI-0-0-0:E){NONE}: state_chg to SEND_ASS DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ADD_CCCH -TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set. TBF(DL:TFI-0-0-0:E){ASSIGN} set ass. type CCCH [prev CCCH:1, PACCH:0] +TBF(DL:TFI-0-0-0:E){ASSIGN} attempted to set ass. type CCCH which is already set DL_TBF(DL:TFI-0-0-0:E){ASSIGN}: Received Event ASSIGN_ACK_PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} The TBF has been confirmed on the PACCH, changed type from CCCH to PACCH TBF(DL:TFI-0-0-0:E){ASSIGN} unset ass. type CCCH [prev CCCH:1, PACCH:0] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd Gerrit-Change-Number: 33275 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0