June 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: cfg: add 'hnbgw' / 'plmn MCC MNC'
by laforge 13 Jun '23

13 Jun '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 ) Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ...................................................................... Patch Set 5: (1 comment) File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/ca8fbd9e_ebe2e5be PS5, Line 285: <1-999> <0-999> does this work with 2-digit and 3-digit MNC? i.e. does this syntax preserve trailing zeros in the VTY? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a Gerrit-Change-Number: 33178 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 10:05:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_ma...
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269 to look at the new patch set (#2). Change subject: pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max to base it on T3168 ...................................................................... pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max to base it on T3168 N3105 is used for DL TBFs only (as tested by TC_n3105_max_t3195). The test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max is hence wrongly written and should be based on T3168. Since recently, osmo-pcu also moved to using T3168 in the scenario triggered by this test, hence move to using it. Related: osmo-pcu.git Change-Id I87dff68dedd06b60501e7586d20faf02bb1f0c93 Change-Id: Ibdfa9879cc56f5e2090cee0d3d70ee5df7c90454 --- M pcu/PCU_Tests.ttcn M pcu/expected-results.xml 2 files changed, 45 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/33269/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdfa9879cc56f5e2090cee0d3d70ee5df7c90454 Gerrit-Change-Number: 33269 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-hnbgw[master]: cfg: add 'hnbgw' / 'plmn MCC MNC'
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 ) Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ...................................................................... Patch Set 5: (1 comment) File src/osmo-hnbgw/hnbgw_l3.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/8fa81c9d_50f62987 PS3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn); > The two RESET related patches after this patch have been tweaked in the meantime: osmo-hnbgw will ou […] so, even if the behavior changes are minimal based on whether the PLMN is configured or not, and given you are already thinking on rejecting message indicating a mismatching local PLMN, don't you think it makes sense to log some message informing the user that as of nowadays he should be configuring the PLMN in the config file? (so that he doesn't run into problems later, preparing him) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a Gerrit-Change-Number: 33178 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 09:10:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau_sync: Add sync pattern for FA protocol of 3GPP TS 43.045
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/33282 ) Change subject: trau_sync: Add sync pattern for FA protocol of 3GPP TS 43.045 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/33282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie2206e120f456d10b4f98d8aeb34fd8a499cb22c Gerrit-Change-Number: 33282 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Jun 2023 09:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: cnpool: add context_map_cnlink_lost() handling
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 ) Change subject: cnpool: add context_map_cnlink_lost() handling ...................................................................... Patch Set 5: (1 comment) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173/comment/6f88e2ea_cda4bf15 PS3, Line 70: MAP_SCCP_EV_CN_LINK_LOST, > I've just explained to you in detail why "RX [RANAP] RESET" is not a good name. The main problem here is that "LINK_LOST" is too generic and difficult to understand from reader point of view. Is it RANAP RESET? is it SCTP association being ABORTED? If this event is used for both cases, then you can keep the "LINK_LOST" but update the comment to mention is used for all kind of issues, from SCTP abort to rx RANAP RESET. If it is only really (expècted to be) sent due to RANAP messages as current comment above it suggest, then it should contain the RANAP word. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c Gerrit-Change-Number: 33173 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Jun 2023 09:01:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau_sync: Add sync pattern for FA protocol of 3GPP TS 43.045
by laforge 13 Jun '23

13 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/33282 ) Change subject: trau_sync: Add sync pattern for FA protocol of 3GPP TS 43.045 ...................................................................... trau_sync: Add sync pattern for FA protocol of 3GPP TS 43.045 The FA protocol is used to carry (modified) T.30 protocol (Fax G3) information over synchronous CSD bearers in GSM. It uses 64bit framing with a well-known sync pattern. Let's use the trau_sync infrastructure to synchronize to that framing. Change-Id: Ie2206e120f456d10b4f98d8aeb34fd8a499cb22c --- M include/osmocom/trau/trau_sync.h M src/trau/trau_sync.c 2 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/82/33282/1 diff --git a/include/osmocom/trau/trau_sync.h b/include/osmocom/trau/trau_sync.h index 36388eb..542a329 100644 --- a/include/osmocom/trau/trau_sync.h +++ b/include/osmocom/trau/trau_sync.h @@ -15,6 +15,7 @@ OSMO_TRAU_SYNCP_16_ER_CCU, OSMO_TRAU_SYNCP_64_ER_CCU, OSMO_TRAU_SYNCP_64_ER_CCU_MCS9, + OSMO_TRAU_SYNCP_FA, /* TS 43.045 FA (Fax Adaptation) sync frame */ }; typedef void (*frame_out_cb_t)(void *user_data, const ubit_t *bits, unsigned int num_bits); diff --git a/src/trau/trau_sync.c b/src/trau/trau_sync.c index 60bfad7..e3b458a 100644 --- a/src/trau/trau_sync.c +++ b/src/trau/trau_sync.c @@ -274,6 +274,19 @@ }, .byte_len = 160, }, + [OSMO_TRAU_SYNCP_FA] = { + /* See Section 5.2.2.1 of 3GPP TS 43.045 */ + .name = "FA", + .byte_pattern = { + 0x3E, 0x37, 0x50, 0x96, + 0xC1, 0xC8, 0xAF, 0x69, + }, + .byte_mask = { + 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + }, + .byte_len = 8, + }, }; static void expand_sync_pattern(struct sync_pattern *pat) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/33282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie2206e120f456d10b4f98d8aeb34fd8a499cb22c Gerrit-Change-Number: 33282 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-hnbgw[master]: cfg: add 'hnbgw' / 'plmn MCC MNC'
by neels 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 ) Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ...................................................................... Patch Set 5: (1 comment) File src/osmo-hnbgw/hnbgw_l3.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/12824e54_5c4e4246 PS3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn); > I didn't write the details because I expected you to know them better 😄 […] The two RESET related patches after this patch have been tweaked in the meantime: osmo-hnbgw will output ERROR logs during every RANAP RESET attempt asking the user to add a PLMN to its config file. I think that's loud enough and we don't need to warn on this marginal case. FYI, why this is pretty marginal: We're not adopting some PLMN for good, this is just relevant to classify a particular incoming message. The only effect this has is changing which CN link will pick up the new subscriber. When the UE indicates a TMSI that it got from a different PLMN, and if we used the TMSI, we would select a specific CN based on that. Instead we should not use the TMSI, and just select any CN by round-robin. There is not actually any proper difference, only that there is no way to skip the round robin. The foreign TMSI might even have indicated the same CN that round robin happens to select. Any CN that is selected will then first ask the UE for its IMSI anyway; AFAIK it shouldn't even carry a TMSI to another PLMN in the first place? This InitialUE message normally contains both the local PLMN a couple times over, as well as the previous PLMN the USIM camped on. So far things worked well by just comparing the PLMNs within one message, to classify the message itself as "has previously been in another PLMN". In the meantime, some other reason has shown up to require an actual local PLMN to be configured in the cfg file. We could happily continue to classify each individual message by the PLMNs contained in it, we trusted it enough until now. But instead, we now have first-hand info on the PLMN from the user via the cfg file, so rather use that. (and ideally also reject messages that indicate a mismatching local PLMN, to help the user find misconfigured HNBs; not implemented yet). So it's a pretty marginal aspect and not critical for successful operation. The code is here mainly because this is what osmo-bsc does -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a Gerrit-Change-Number: 33178 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 02:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: cnpool: add context_map_cnlink_lost() handling
by neels 13 Jun '23

13 Jun '23

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 ) Change subject: cnpool: add context_map_cnlink_lost() handling ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: just now i set out to rename the event, but... File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173/comment/f04f1b33_9eba932c PS3, Line 44: MAP_RUA_EV_HNB_LINK_LOST, This event has identical semantics to below CN_LINK_LOST event being discussed: we have some or other knowledge that all the RUA connections towards a specific HNB can no longer work. It has only recently been accepted by code review. The new event in question below does the same, for the other side: we have some or other knowledge that all the RANAP/SCCP connections towards a specific MSC,SGSN can no longer work. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c Gerrit-Change-Number: 33173 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 01:20:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: cnpool: add context_map_cnlink_lost() handling
by neels 13 Jun '23

13 Jun '23

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 ) Change subject: cnpool: add context_map_cnlink_lost() handling ...................................................................... Patch Set 5: (1 comment) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173/comment/c3bb28f1_101a6874 PS3, Line 70: MAP_SCCP_EV_CN_LINK_LOST, > IMHO LINK_LOST seems to indicate that lower layer connection (eg. […] I've just explained to you in detail why "RX [RANAP] RESET" is not a good name. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c Gerrit-Change-Number: 33173 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 01:12:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: tweak lots of logging
by neels 13 Jun '23

13 Jun '23

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 ) Change subject: tweak lots of logging ...................................................................... Patch Set 5: (2 comments) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/b4ea5e0a_a59e6401 PS3, Line 583: hnbgw_cnlink_log_self(cnlink); > what do I mean with extra log line? see here for instance, you end printing twice, in line 581 and i […] the reason are the distinct log levels. In a live operation i don't want to see whether an SCCP instance existed before, but I might be interested in every new link to be printed once, hence on log level NOTICE. And again, this happens exactly once per program startup, and once per MSC/SGSN. https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/79c1d598_995dccb2 PS3, Line 635: hnbgw_cnlink_log_self(cnlink); > same here with line 612 same reason. DEBUG vs NOTICE -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06 Gerrit-Change-Number: 33171 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 01:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0