June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33276 to look at the new patch set (#2). Change subject: Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf ...................................................................... Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf That flag was still in state_fsm for historical reasons (refactoring steps), but it's not really the best place for it, since it's really specific to dl_tbf and to transmit of data and DL ACK/NACK not the overall state of the TBF. Change-Id: I6b44121bbe185b58f3a77be8c12b4ef1f3180a30 --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h 4 files changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/33276/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6b44121bbe185b58f3a77be8c12b4ef1f3180a30 Gerrit-Change-Number: 33276 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type()
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33275 to look at the new patch set (#3). Change subject: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() ...................................................................... tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() First print what is going to be attempted, later alarm about the possible error, finally early return. Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd --- M src/tbf_dl_fsm.c M src/tbf_ul_fsm.c M tests/tbf/TbfTest.err 3 files changed, 81 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/33275/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd Gerrit-Change-Number: 33275 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm: Abort on unexpected path
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33274 to look at the new patch set (#2). Change subject: tbf_{ul,dl}_fsm: Abort on unexpected path ...................................................................... tbf_{ul,dl}_fsm: Abort on unexpected path That path should not really happen. It happening would mean a totally wrong code being used. Hence, just abort() to simplify the code. Change-Id: Iaf65e909e45cc279e5be4b045c15174f910ffc12 --- M src/tbf_dl_fsm.c M src/tbf_ul_fsm.c 2 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/74/33274/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iaf65e909e45cc279e5be4b045c15174f910ffc12 Gerrit-Change-Number: 33274 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: cosmetic: tbf_dl_fsm: Fix a couple comment typos
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33279 to look at the new patch set (#2). Change subject: cosmetic: tbf_dl_fsm: Fix a couple comment typos ...................................................................... cosmetic: tbf_dl_fsm: Fix a couple comment typos Change-Id: I1bcb199f3ba9564870b82ab67218ffbf72da4824 --- M src/tbf_dl_fsm.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/33279/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1bcb199f3ba9564870b82ab67218ffbf72da4824 Gerrit-Change-Number: 33279 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: tests/tbf: Drop unneeded line re-setting CCCH ass type
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33278 to look at the new patch set (#2). Change subject: tests/tbf: Drop unneeded line re-setting CCCH ass type ...................................................................... tests/tbf: Drop unneeded line re-setting CCCH ass type Change-Id: I384753234651657c890faf1a4bdc1342e23e462b --- M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err 2 files changed, 9 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/33278/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I384753234651657c890faf1a4bdc1342e23e462b Gerrit-Change-Number: 33278 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: Move GPRS_RLCMAC_FLAG_DL_ACK from state_fsm to dl_tbf
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33277 to look at the new patch set (#2). Change subject: Move GPRS_RLCMAC_FLAG_DL_ACK from state_fsm to dl_tbf ...................................................................... Move GPRS_RLCMAC_FLAG_DL_ACK from state_fsm to dl_tbf That flag was still in state_fsm for historical reasons (refactoring steps), but it's not really the best place for it, since it's really specific to dl_tbf and to transmit of data and DL ACK/NACK not the overall state of the TBF. Change-Id: I12c28c1a52f363f2d17a8bc24bbdf379543fc7a6 --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h M src/tbf_dl_fsm.c 5 files changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/33277/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I12c28c1a52f363f2d17a8bc24bbdf379543fc7a6 Gerrit-Change-Number: 33277 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: Move call to bts_snd_dl_ass() from tbf_dl.cpp to tbf_dl_fsm.c
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33280 to look at the new patch set (#2). Change subject: Move call to bts_snd_dl_ass() from tbf_dl.cpp to tbf_dl_fsm.c ...................................................................... Move call to bts_snd_dl_ass() from tbf_dl.cpp to tbf_dl_fsm.c It makes more sense to have it there, where it is transmitted with more control depending on current state. Furthermore, it's counterpart/continuation TBF_EV_ASSIGN_PCUIF_CNF logic is already there, so it makes sense to have the whole logic together. Change-Id: I8af39d3087ccf197321f0c71cb29b67adbe1f36e --- M src/tbf_dl.cpp M src/tbf_dl_fsm.c 2 files changed, 26 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/33280/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8af39d3087ccf197321f0c71cb29b67adbe1f36e Gerrit-Change-Number: 33280 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcap[master]: tests: $(BUILT_SOURCES) is not defined
by fixeria 13 Jun '23

13 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32121 ) Change subject: tests: $(BUILT_SOURCES) is not defined ...................................................................... tests: $(BUILT_SOURCES) is not defined Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf --- M tests/Makefile.am 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index 720d631..5084704 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -21,11 +21,12 @@ TESTSUITE = $(srcdir)/testsuite if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(top_builddir)/src/osmo-pcap-server \ + $(top_builddir)/src/osmo-pcap-client osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I81dc30f6d6e3b25723f00d945c87b9c01c648cbf Gerrit-Change-Number: 32121 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_ma...
by fixeria 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269 ) Change subject: pcu: Rework test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max to base it on T3168 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269/comment/7c3ae800_16cf… PS1, Line 7129: TC_ul_tbf_reestablish_with_pkt_resource_req_t3168 > please also update `expected-results. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdfa9879cc56f5e2090cee0d3d70ee5df7c90454 Gerrit-Change-Number: 33269 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 10:38:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm: Abort on unexpected path
by pespin 13 Jun '23

13 Jun '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33274 ) Change subject: tbf_{ul,dl}_fsm: Abort on unexpected path ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/33274/comment/d614532f_bab06eb4 PS1, Line 9: hsould > typo + missing "exist" or "happen" or "be taken" at the end? "should not really happen". I'll fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iaf65e909e45cc279e5be4b045c15174f910ffc12 Gerrit-Change-Number: 33274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Jun 2023 10:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0