June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33276 ) Change subject: Move GPRS_RLCMAC_FLAG_TO_DL_ACK from state_fsm to dl_tbf ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6b44121bbe185b58f3a77be8c12b4ef1f3180a30 Gerrit-Change-Number: 33276 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type()
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33275 ) Change subject: tbf_{ul,dl}_fsm.c: Rearrange code/logs in mod_ass_type() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I417e9689f60e7f5d3c8ef67543e56fea87c8eebd Gerrit-Change-Number: 33275 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:45:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf_{ul,dl}_fsm: Abort on unexpected path
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33274 ) Change subject: tbf_{ul,dl}_fsm: Abort on unexpected path ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iaf65e909e45cc279e5be4b045c15174f910ffc12 Gerrit-Change-Number: 33274 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf_dl_fsm: Fix wrong lchan specified in log line
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33273 ) Change subject: tbf_dl_fsm: Fix wrong lchan specified in log line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I30111989c85001b0d9b98bf6f19c2247ab144433 Gerrit-Change-Number: 33273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:40:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: Improve logging in bts_snd_dl_ass()
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33272 ) Change subject: Improve logging in bts_snd_dl_ass() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic5e01289f97bc113ba0a376a535e0cce5bccc5d1 Gerrit-Change-Number: 33272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: Remove unused GPRS_RLCMAC_FLAG_TO_MASK
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33271 ) Change subject: Remove unused GPRS_RLCMAC_FLAG_TO_MASK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1402310919578a09669530786296f34bf3b23ef2 Gerrit-Change-Number: 33271 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:35:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: Abort UL TBF PACCH Ass based on T3168
by osmith 13 Jun '23

13 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33270 ) Change subject: Abort UL TBF PACCH Ass based on T3168 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/tbf_ul_ass_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/33270/comment/d07a86f0_43388826 PS1, Line 198: Here it's time where this reads a bit weird, how about: Here we https://gerrit.osmocom.org/c/osmo-pcu/+/33270/comment/dd281c02_ca378032 PS1, Line 210: starting The other message has "Starting" with uppercase S -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I87dff68dedd06b60501e7586d20faf02bb1f0c93 Gerrit-Change-Number: 33270 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 13:34:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Add VGCS UPLINK GRAND message structure to gsm_04_08.h
by Jenkins Builder 13 Jun '23

13 Jun '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33301 ) Change subject: Add VGCS UPLINK GRAND message structure to gsm_04_08.h ...................................................................... Patch Set 1: (6 comments) File include/osmocom/gsm/protocol/gsm_04_08.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/9c6d0fbe_70580ac9 PS1, Line 1207: struct gsm48_hdr hdr; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/9c6959e4_8dbbc282 PS1, Line 1207: struct gsm48_hdr hdr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/778517f4_675c6891 PS1, Line 1208: struct gsm48_req_ref req_ref; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/d09e82c3_b0b2bf26 PS1, Line 1208: struct gsm48_req_ref req_ref; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/f1675fa2_94d68b3c PS1, Line 1209: uint8_t ta; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/03e48773_639d6370 PS1, Line 1209: uint8_t ta; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a16ce4ddc7a36e0db2936227a910b4d53cddfca Gerrit-Change-Number: 33301 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 13 Jun 2023 13:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Add VGCS UPLINK GRAND message structure to gsm_04_08.h
by jolly 13 Jun '23

13 Jun '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33301 ) Change subject: Add VGCS UPLINK GRAND message structure to gsm_04_08.h ...................................................................... Add VGCS UPLINK GRAND message structure to gsm_04_08.h Change-Id: I8a16ce4ddc7a36e0db2936227a910b4d53cddfca --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/33301/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index a4e05d6..548a2e4 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1202,6 +1202,13 @@ #endif } __attribute__ ((packed)); +/* TS 44.018 Section 9.1.49 */ +struct gsm0408_vgcs_ul_grant { + struct gsm48_hdr hdr; + struct gsm48_req_ref req_ref; + uint8_t ta; +} __attribute__ ((packed)); + /* Section 9.1.43a System Information type 13 */ struct gsm48_system_information_type_13 { struct gsm48_system_information_type_header header; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a16ce4ddc7a36e0db2936227a910b4d53cddfca Gerrit-Change-Number: 33301 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-hnbgw[master]: cfg: add 'hnbgw' / 'plmn MCC MNC'
by neels 13 Jun '23

13 Jun '23

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 ) Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Patchset: PS5: combine votes File src/osmo-hnbgw/hnbgw_l3.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/322b5944_ff72e55c PS3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn); > i just told you that we are very loud on the log about a missing PLMN in the config file. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a Gerrit-Change-Number: 33178 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 12:38:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0