Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 ) Change subject: tweak lots of logging ...................................................................... Patch Set 5: (2 comments) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/b4ea5e0a_a59e6401 PS3, Line 583: hnbgw_cnlink_log_self(cnlink);

what do I mean with extra log line? see here for instance, you end printing twice, in line 581 and i […] the reason are the distinct log levels. In a live operation i don't want to see whether an SCCP instance existed before, but I might be interested in every new link to be printed once, hence on log level NOTICE.

And again, this happens exactly once per program startup, and once per MSC/SGSN. https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/79c1d598_995dccb2 PS3, Line 635: hnbgw_cnlink_log_self(cnlink);

same here with line 612 same reason. DEBUG vs NOTICE

-- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06 Gerrit-Change-Number: 33171 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jun 2023 01:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment