June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: another csv example for our usb CCID reader
by laforge 11 Jun '23

11 Jun '23

Attention is currently required from: neels, steviehs. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/32710 ) Change subject: another csv example for our usb CCID reader ...................................................................... Removed Code-Review-1 by neels <nhofmeyr(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/32710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iec17af23ee9c752facb88b4a497b42678af6065d Gerrit-Change-Number: 32710 Gerrit-PatchSet: 2 Gerrit-Owner: steviehs <sskrodzki(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: steviehs <sskrodzki(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

[S] Change in osmo-remsim[master]: another csv example for our usb CCID reader
by laforge 11 Jun '23

11 Jun '23

Attention is currently required from: steviehs. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/32710 ) Change subject: another csv example for our usb CCID reader ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/32710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iec17af23ee9c752facb88b4a497b42678af6065d Gerrit-Change-Number: 32710 Gerrit-PatchSet: 2 Gerrit-Owner: steviehs <sskrodzki(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: steviehs <sskrodzki(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:31:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data
by laforge 11 Jun '23

11 Jun '23

Attention is currently required from: pespin, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 ) Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... Patch Set 6: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/8ec1ca5e_4137… PS6, Line 1037: tr_GSUP_IE_APN('08'O & char2oct("internet")) > Sure I can also write most of your patches, but that's not the point right? ;) lynxis, can you please get that function implemented? It shouldn't be too hard to iterate over the dotted-string and generate the length-prefixed binary format? If there really is an actual problem doing this in TTCN3, I'd love to hear about it (and in the worst case, you can always wrap a C/C++ function, as we do for checksum stuff). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:30:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: mgcp_client.h: also add spec ref to the other 3gpp defined payload types
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32971 ) Change subject: mgcp_client.h: also add spec ref to the other 3gpp defined payload types ...................................................................... mgcp_client.h: also add spec ref to the other 3gpp defined payload types Some payload type numbers are defined in 3GPP TS 48.103, let's put the spec reference between all of those so that it is immediately clear where those numbers come from. Change-Id: Ie9d949ee72286ee4de7590c99acc740011208466 --- M include/osmocom/mgcp_client/mgcp_client.h 1 file changed, 18 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index 0fb5dee..6adaf4b 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -45,12 +45,12 @@ CODEC_GSM_8000_1 = 3, CODEC_PCMA_8000_1 = 8, CODEC_G729_8000_1 = 18, - CODEC_GSMEFR_8000_1 = 110, - CODEC_GSMHR_8000_1 = 111, - CODEC_AMR_8000_1 = 112, - CODEC_AMRWB_16000_1 = 113, + CODEC_GSMEFR_8000_1 = 110, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + CODEC_GSMHR_8000_1 = 111, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + CODEC_AMR_8000_1 = 112, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + CODEC_AMRWB_16000_1 = 113, /* 3GPP TS 48.103 table 5.4.2.2.1 */ CODEC_IUFP = 96, - CODEC_CLEARMODE = 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + CODEC_CLEARMODE = 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ }; /* Note: when new codec types are added, the corresponding value strings * in mgcp_client.c (codec_table) must be updated as well. Enumerations -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie9d949ee72286ee4de7590c99acc740011208466 Gerrit-Change-Number: 32971 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-mgw[master]: mgcp_client.h: also add spec ref to the other 3gpp defined payload types
by laforge 11 Jun '23

11 Jun '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32971 ) Change subject: mgcp_client.h: also add spec ref to the other 3gpp defined payload types ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie9d949ee72286ee4de7590c99acc740011208466 Gerrit-Change-Number: 32971 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:28:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo_dia2gsup[master]: Use GSUP APN as Service-Selection field
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 ) Change subject: Use GSUP APN as Service-Selection field ...................................................................... Use GSUP APN as Service-Selection field Previous the osmo-hlr always sent a wildcard APN as the only APN which violates the spec. Further wildcard APNs aren't support by the current Open5gs. Since I540132ee5dcfd09f4816e02e702927e1074ca50f the osmo-hlr supports multiple APN in the subscriber data. Related: SYS#6391 Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab --- A src/decode_apn.erl M src/server_cb.erl 2 files changed, 69 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/decode_apn.erl b/src/decode_apn.erl new file mode 100644 index 0000000..ea12bc6 --- /dev/null +++ b/src/decode_apn.erl @@ -0,0 +1,51 @@ + +-module(decode_apn). + +% decode APN Name Encoded Format +% TS 23.003 APN +-export([decode_apn/1, encode_apn/1]). + +decode_apn(ApnEnc) -> + decode_apn("", ApnEnc, 0). + +decode_apn(Result, [], 0) -> + Result; + +decode_apn(Result, << >>, 0) -> + Result; + +decode_apn("", ApnEnc, 0) -> + << NewElemLen:8, RemainEnc/bytes >> = ApnEnc, + case NewElemLen of + 0 -> ""; + _ -> decode_apn("", RemainEnc, NewElemLen) + end; + +decode_apn(Result, ApnEnc, 0) -> + << NewElemLen:8, RemainEnc/bytes >> = ApnEnc, + case NewElemLen of + 0 -> Result; + _ -> decode_apn(Result ++ ".", RemainEnc, NewElemLen) + end; + +decode_apn(Result, ApnEnc, RemainLen) when RemainLen > 0 -> + << Char:8, RemainEnc/bytes >> = ApnEnc, + decode_apn(Result ++ [Char], RemainEnc, RemainLen - 1). + +encode_apn(ApnStr) -> + encode_apn(<<>>, ApnStr, "", 0). + +encode_apn(ApnEnc, "", "", 0) -> + ApnEnc; + +encode_apn(ApnEnc, "", CurStr, Len) -> + CurBin = binary:list_to_bin(CurStr), + Result = << ApnEnc/binary, Len, CurBin/binary >>, + Result; + +encode_apn(ApnEnc, [ Char | RemainStr ], CurStr, Len) -> + case Char of + 46 -> CurBin = binary:list_to_bin(CurStr), + encode_apn(<<ApnEnc/binary, Len, CurBin/binary >>, RemainStr, "", 0); + _ -> encode_apn(ApnEnc, RemainStr, CurStr ++ [Char], Len + 1) + end. diff --git a/src/server_cb.erl b/src/server_cb.erl index fc8e397..35dbb63 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -123,7 +123,7 @@ gsup_pdp2dia(GsupPdpInfo) -> #'PDP-Context'{'PDP-Type' = maps:get(pdp_type, GsupPdpInfo, ?PDP_TYPE_DEFAULT), 'Context-Identifier' = maps:get(pdp_context_id, GsupPdpInfo), - 'Service-Selection' = maps:get(access_point_name, GsupPdpInfo), + 'Service-Selection' = decode_apn:decode_apn(maps:get(access_point_name, GsupPdpInfo)), 'QoS-Subscribed' = maps:get(quality_of_service, GsupPdpInfo, ?PDP_QOS_DEFAULT) }. @@ -149,7 +149,7 @@ 'Max-Requested-Bandwidth-DL' = 100000000}, % The default APN Configuration shall not contain the Wildcard APN (see 3GPP TS % 23.003 [3], clause 9.2); the default APN shall always contain an explicit APN - 'Service-Selection' = "internet"%maps:get(access_point_name, GsupPdpInfo) + 'Service-Selection' = decode_apn:decode_apn(maps:get(access_point_name, GsupPdpInfo)) }. % transient (only in Experimental-Result-Code) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab Gerrit-Change-Number: 32514 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in ...osmo_dia2gsup[master]: Use GSUP APN as Service-Selection field
by laforge 11 Jun '23

11 Jun '23

Attention is currently required from: pespin, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 ) Change subject: Use GSUP APN as Service-Selection field ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab Gerrit-Change-Number: 32514 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:27:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 ) Change subject: ctrl: Add getting neighbor list ...................................................................... ctrl: Add getting neighbor list Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved neels: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 3a502b1..59f3ad0 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -514,6 +514,40 @@ CTRL_CMD_DEFINE(bts_c0_power_red, "c0-power-reduction"); +static int get_bts_neighbor_list(struct ctrl_cmd *cmd, const struct bitvec *neigh_list) +{ + int i; + char *pos; + + /* The length of "1 2 3 ... 1023" is 4009, so 4096 is enough */ + cmd->reply = talloc_size(cmd, 4096); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + cmd->reply[0] = '\0'; + + pos = cmd->reply; + + for (i = 0; i < neigh_list->data_len * 8; i++) { + if (!bitvec_get_bit_pos(neigh_list, i)) + continue; + + pos += sprintf(pos, i == 0 ? "%u" : " %u", i); + } + + return CTRL_CMD_REPLY; +} + +static int get_bts_neighbor_list_si2(struct ctrl_cmd *cmd, void *data) +{ + const struct gsm_bts *bts = cmd->node; + return get_bts_neighbor_list(cmd, &bts->si_common.neigh_list); +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2, "neighbor-list si2"); + static int verify_bts_neighbor_list_add_del(struct ctrl_cmd *cmd, const char *value, void *_data) { int arfcn; @@ -976,6 +1010,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_state); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_states); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_c0_power_red); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_add); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_del); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 5 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting SI5 neighbor list
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32645 ) Change subject: ctrl: Add getting SI5 neighbor list ...................................................................... ctrl: Add getting SI5 neighbor list Change-Id: I71f5f23473b94059ac64770ceb256b4df36c0ef7 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 59f3ad0..9d338aa 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -548,6 +548,14 @@ CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2, "neighbor-list si2"); +static int get_bts_neighbor_list_si5(struct ctrl_cmd *cmd, void *data) +{ + const struct gsm_bts *bts = cmd->node; + return get_bts_neighbor_list(cmd, &bts->si_common.si5_neigh_list); +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list_si5, "neighbor-list si5"); + static int verify_bts_neighbor_list_add_del(struct ctrl_cmd *cmd, const char *value, void *_data) { int arfcn; @@ -1011,6 +1019,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_states); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_c0_power_red); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si5); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_add); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_del); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71f5f23473b94059ac64770ceb256b4df36c0ef7 Gerrit-Change-Number: 32645 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list
by laforge 11 Jun '23

11 Jun '23

Attention is currently required from: neels, pespin, fixeria, matanp. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 ) Change subject: ctrl: Add getting neighbor list ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:26:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0