Attention is currently required from: neels, steviehs.
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/32710 )
Change subject: another csv example for our usb CCID reader
......................................................................
Removed Code-Review-1 by neels <nhofmeyr(a)sysmocom.de>
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/32710
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Iec17af23ee9c752facb88b4a497b42678af6065d
Gerrit-Change-Number: 32710
Gerrit-PatchSet: 2
Gerrit-Owner: steviehs <sskrodzki(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: steviehs <sskrodzki(a)sysmocom.de>
Gerrit-MessageType: deleteVote
Attention is currently required from: steviehs.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/32710 )
Change subject: another csv example for our usb CCID reader
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/32710
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Iec17af23ee9c752facb88b4a497b42678af6065d
Gerrit-Change-Number: 32710
Gerrit-PatchSet: 2
Gerrit-Owner: steviehs <sskrodzki(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: steviehs <sskrodzki(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Jun 2023 19:31:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, lynxis lazus.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 )
Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data
......................................................................
Patch Set 6:
(1 comment)
File hlr/HLR_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/8ec1ca5e_4137…
PS6, Line 1037: tr_GSUP_IE_APN('08'O & char2oct("internet"))
> Sure I can also write most of your patches, but that's not the point right? ;)
lynxis, can you please get that function implemented? It shouldn't be too hard to iterate over the dotted-string and generate the length-prefixed binary format? If there really is an actual problem doing this in TTCN3, I'd love to hear about it (and in the worst case, you can always wrap a C/C++ function, as we do for checksum stuff).
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989
Gerrit-Change-Number: 32510
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 11 Jun 2023 19:30:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32971 )
Change subject: mgcp_client.h: also add spec ref to the other 3gpp defined payload types
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32971
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d949ee72286ee4de7590c99acc740011208466
Gerrit-Change-Number: 32971
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Jun 2023 19:28:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment