June 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: Add ".py" suffix to sphinx-argparse generated docs
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33250 ) Change subject: Add ".py" suffix to sphinx-argparse generated docs ...................................................................... Add ".py" suffix to sphinx-argparse generated docs This is important to produce the right command syntax when generating command line reference in the user manual. However, we shouldn't add this kludge to the individual programs, but only to the documentation using the :prog: syntax. Change-Id: I2ec7ab00c63d5d386f187e54755c71ffc2dce429 --- M docs/legacy.rst M docs/shell.rst M pySim-read.py M pySim-shell.py 4 files changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/docs/legacy.rst b/docs/legacy.rst index d93358f..0961d17 100644 --- a/docs/legacy.rst +++ b/docs/legacy.rst @@ -98,3 +98,4 @@ .. argparse:: :module: pySim-read :func: option_parser + :prog: pySim-read.py diff --git a/docs/shell.rst b/docs/shell.rst index e13d054..ef08fcf 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -35,6 +35,7 @@ .. argparse:: :module: pySim-shell :func: option_parser + :prog: pySim-shell.py Usage Examples -------------- diff --git a/pySim-read.py b/pySim-read.py index ddc193a..f80509c 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -40,8 +40,7 @@ from pySim.utils import format_xplmn_w_act, dec_st from pySim.utils import h2s, format_ePDGSelection -option_parser = argparse.ArgumentParser(prog='pySim-read', - description='Legacy tool for reading some parts of a SIM card', +option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) argparse_add_reader_args(option_parser) diff --git a/pySim-shell.py b/pySim-shell.py index 3f0818a..c6782d4 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -949,7 +949,7 @@ -option_parser = argparse.ArgumentParser(prog='pySim-shell', description='interactive SIM card shell', +option_parser = argparse.ArgumentParser(description='interactive SIM card shell', formatter_class=argparse.ArgumentDefaultsHelpFormatter) argparse_add_reader_args(option_parser) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2ec7ab00c63d5d386f187e54755c71ffc2dce429 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: Add ".py" suffix to sphinx-argparse generated docs
by laforge 11 Jun '23

11 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33250 ) Change subject: Add ".py" suffix to sphinx-argparse generated docs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2ec7ab00c63d5d386f187e54755c71ffc2dce429 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:10:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: test_ota: Add one first OTA SMS AES128 unit test
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33235 ) Change subject: test_ota: Add one first OTA SMS AES128 unit test ...................................................................... test_ota: Add one first OTA SMS AES128 unit test Change-Id: Id4a66bbfaec2d8610e8a7a2c72c0dfd08332edcd --- M tests/test_ota.py 1 file changed, 72 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/test_ota.py b/tests/test_ota.py index 277f178..c58a69d 100644 --- a/tests/test_ota.py +++ b/tests/test_ota.py @@ -4,6 +4,69 @@ from pySim.utils import h2b, b2h from pySim.ota import * +# pre-defined SPI values for use in test cases below +SPI_CC_POR_CIPHERED_CC = { + 'counter':'no_counter', + 'ciphering':True, + 'rc_cc_ds': 'cc', + 'por_in_submit':False, + 'por_shall_be_ciphered':True, + 'por_rc_cc_ds': 'cc', + 'por': 'por_required' + } + +SPI_CC_POR_UNCIPHERED_CC = { + 'counter':'no_counter', + 'ciphering':True, + 'rc_cc_ds': 'cc', + 'por_in_submit':False, + 'por_shall_be_ciphered':False, + 'por_rc_cc_ds': 'cc', + 'por': 'por_required' +} + +SPI_CC_POR_UNCIPHERED_NOCC = { + 'counter':'no_counter', + 'ciphering':True, + 'rc_cc_ds': 'cc', + 'por_in_submit':False, + 'por_shall_be_ciphered':False, + 'por_rc_cc_ds': 'no_rc_cc_ds', + 'por': 'por_required' +} + + +class Test_SMS_AES128(unittest.TestCase): + tar = h2b('B00011') + """Test the OtaDialectSms for AES128 algorithms.""" + def __init__(self, foo, **kwargs): + super().__init__(foo, **kwargs) + self.od = OtaKeyset(algo_crypt='aes_cbc', kic_idx=2, + algo_auth='aes_cmac', kid_idx=2, + kic=h2b('200102030405060708090a0b0c0d0e0f'), + kid=h2b('201102030405060708090a0b0c0d0e0f')) + self.dialect = OtaDialectSms() + self.spi_base = SPI_CC_POR_CIPHERED_CC + + def _check_response(self, r, d): + self.assertEqual(d['number_of_commands'], 1) + self.assertEqual(d['last_status_word'], '6132') + self.assertEqual(d['last_response_data'], u'') + self.assertEqual(r['response_status'], 'por_ok') + + def test_resp_aes128_ciphered(self): + spi = self.spi_base + r, d = self.dialect.decode_resp(self.od, spi, '027100002412b00011ebc6b497e2cad7aedf36ace0e3a29b38853f0fe9ccde81913be5702b73abce1f') + self._check_response(r, d) + + def test_cmd_aes128_ciphered(self): + spi = self.spi_base + r = self.dialect.encode_cmd(self.od, self.tar, spi, h2b('00a40004023f00')) + self.assertEqual(b2h(r), '00281506192222b00011e87cceebb2d93083011ce294f93fc4d8de80da1abae8c37ca3e72ec4432e5058') + + + + class Test_SMS_3DES(unittest.TestCase): tar = h2b('b00000') """Test the OtaDialectSms for 3DES algorithms.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id4a66bbfaec2d8610e8a7a2c72c0dfd08332edcd Gerrit-Change-Number: 33235 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: README: rephrase initial section; add HPSIM; programmable vs. standard
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33247 ) Change subject: README: rephrase initial section; add HPSIM; programmable vs. standard ...................................................................... README: rephrase initial section; add HPSIM; programmable vs. standard Change-Id: Ied7bce9fc4ebc9a71093ac41d9c1b8e67fe04d7e --- M README.md 1 file changed, 27 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/README.md b/README.md index db13a52..86dc63d 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,25 @@ -pySim - Read, Write and Browse Programmable SIM/USIM Cards -==================================================== +pySim - Read, Write and Browse Programmable SIM/USIM/ISIM/HPSIM Cards +===================================================================== -This repository contains Python programs that can be used -to read, program (write) and browse certain fields/parameters on so-called programmable -SIM/USIM cards. +This repository contains a number of Python programs that can be used +to read, program (write) and browse all fields/parameters/files on +SIM/USIM/ISIM/HPSIM cards used in 3GPP cellular networks from 2G to 5G. -Such SIM/USIM cards are special cards, which - unlike those issued by -regular commercial operators - come with the kind of keys that allow you -to write the files/fields that normally only an operator can program. +Note that the access control configuration of normal production cards +issue by operators will restrict significantly which files a normal +user can read, and particularly write to. + +The full functionality of pySim hence can only be used with on so-called +programmable SIM/USIM/ISIM/HPSIM cards. + +Such SIM/USIM/ISIM/HPSIM cards are special cards, which - unlike those +issued by regular commercial operators - come with the kind of keys that +allow you to write the files/fields that normally only an operator can +program. This is useful particularly if you are running your own cellular -network, and want to issue your own SIM/USIM cards for that network. +network, and want to configure your own SIM/USIM/ISIM/HPSIM cards for +that network. Homepage and Manual -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied7bce9fc4ebc9a71093ac41d9c1b8e67fe04d7e Gerrit-Change-Number: 33247 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: SJA5: EF.USIM_AUTH_KEY: Display / enforce proper length TUAK K
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33234 ) Change subject: SJA5: EF.USIM_AUTH_KEY: Display / enforce proper length TUAK K ...................................................................... SJA5: EF.USIM_AUTH_KEY: Display / enforce proper length TUAK K The K value in case of TUAK can be 16 or 32 bytes long. We used to permit/parse/display 32 bytes even if only 16 bytes was configured. Let's enforce the correct length of "K". Fixes: OS#6053 Change-Id: Ia0f9a2138f16dce72f3118001e95baa1c80f23ce --- M pySim/sysmocom_sja2.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/pySim/sysmocom_sja2.py b/pySim/sysmocom_sja2.py index 8b1fc04..1bd4a8a 100644 --- a/pySim/sysmocom_sja2.py +++ b/pySim/sysmocom_sja2.py @@ -207,7 +207,7 @@ 'tuak_cfg'/TuakCfgByte, 'num_of_keccak_iterations'/Int8ub, 'op_opc'/HexAdapter(Bytes(32)), - 'k'/HexAdapter(Bytes(32))) + 'k'/HexAdapter(Bytes(this.cfg.key_length//8))) def _decode_bin(self, raw_bin_data: bytearray) -> dict: if raw_bin_data[0] & 0x0F == 0x06: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0f9a2138f16dce72f3118001e95baa1c80f23ce Gerrit-Change-Number: 33234 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in pysim[master]: README: remove redundancy 'Manual' and 'Documentation
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33248 ) Change subject: README: remove redundancy 'Manual' and 'Documentation ...................................................................... README: remove redundancy 'Manual' and 'Documentation Also, re-order sections oriented more towards the user (Docs first) Change-Id: I4fc76222a1c22685131cb6926721ce24f0373046 --- M README.md 1 file changed, 44 insertions(+), 32 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/README.md b/README.md index 86dc63d..2a89c9a 100644 --- a/README.md +++ b/README.md @@ -22,10 +22,40 @@ that network. -Homepage and Manual -------------------- +Homepage +-------- -Please visit the [official homepage](https://osmocom.org/projects/pysim/wiki) for usage instructions, manual and examples. The user manual can also be built locally from this source code by ``cd docs && make html latexpdf`` for HTML and PDF format, respectively. +Please visit the [official homepage](https://osmocom.org/projects/pysim/wiki) +for usage instructions, manual and examples. + + +Documentation +------------- + +The pySim user manual can be built from this very source code by means +of sphinx (with sphinxcontrib-napoleon and sphinx-argparse). See the +Makefile in the 'docs' directory. + +A pre-rendered HTML user manual of the current pySim 'git master' is +available from <https://downloads.osmocom.org/docs/latest/pysim/> and +a downloadable PDF version is published at +<https://downloads.osmocom.org/docs/latest/osmopysim-usermanual.pdf>. + +A slightly dated video presentation about pySim-shell can be found at +<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>. + + +pySim-shell vs. legacy tools +---------------------------- + +While you will find a lot of online resources still describing the use of +pySim-prog.py and pySim-read.py, those tools are considered legacy by +now and have by far been superseded by the much more capable +pySim-shell. We strongly encourage users to adopt pySim-shell, unless +they have very specific requirements like batch programming of large +quantities of cards, which is about the only remaining use case for the +legacy tools. + Git Repository -------------- @@ -111,32 +141,3 @@ We are using a gerrit-based patch review process explained at <https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> - - -Documentation -------------- - -The pySim user manual can be built from this very source code by means -of sphinx (with sphinxcontrib-napoleon and sphinx-argparse). See the -Makefile in the 'docs' directory. - -A pre-rendered HTML user manual of the current pySim 'git master' is -available from <https://downloads.osmocom.org/docs/latest/pysim/> and -a downloadable PDF version is published at -<https://downloads.osmocom.org/docs/latest/osmopysim-usermanual.pdf>. - -A slightly dated video presentation about pySim-shell can be found at -<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>. - - -pySim-shell vs. legacy tools ----------------------------- - -While you will find a lot of online resources still describing the use of -pySim-prog.py and pySim-read.py, those tools are considered legacy by -now and have by far been superseded by the much more capable -pySim-shell. We strongly encourage users to adopt pySim-shell, unless -they have very specific requirements like batch programming of large -quantities of cards, which is about the only remaining use case for the -legacy tools. - -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc76222a1c22685131cb6926721ce24f0373046 Gerrit-Change-Number: 33248 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: 31.102: Fix EF.Routing_Indicator for odd number of digits
by laforge 11 Jun '23

11 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33249 ) Change subject: 31.102: Fix EF.Routing_Indicator for odd number of digits ...................................................................... 31.102: Fix EF.Routing_Indicator for odd number of digits The routing indicator is BCD-encoded but has an arbitrary length of 1, 2, 3 or 4 digits. In order to support the odd lengths of 1 or 3, we must not pad on the byte level, but on the nibble level. This requires a slight extension of the Rpad() Adapter. Change-Id: I6c26dccdd570de7b7a4cd48338068e230340ec7c Fixes: OS#6054 --- M pySim/construct.py M pySim/ts_31_102.py 2 files changed, 28 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/construct.py b/pySim/construct.py index 20a6946..ab44a63 100644 --- a/pySim/construct.py +++ b/pySim/construct.py @@ -66,26 +66,29 @@ class Rpad(Adapter): """ - Encoder appends padding bytes (b'\\xff') up to target size. - Decoder removes trailing padding bytes. + Encoder appends padding bytes (b'\\xff') or characters up to target size. + Decoder removes trailing padding bytes/characters. Parameters: subcon: Subconstruct as defined by construct library pattern: set padding pattern (default: b'\\xff') + num_per_byte: number of 'elements' per byte. E.g. for hex nibbles: 2 """ - def __init__(self, subcon, pattern=b'\xff'): + def __init__(self, subcon, pattern=b'\xff', num_per_byte=1): super().__init__(subcon) self.pattern = pattern + self.num_per_byte = num_per_byte def _decode(self, obj, context, path): return obj.rstrip(self.pattern) def _encode(self, obj, context, path): - if len(obj) > self.sizeof(): + target_size = self.sizeof() * self.num_per_byte + if len(obj) > target_size: raise SizeofError("Input ({}) exceeds target size ({})".format( - len(obj), self.sizeof())) - return obj + self.pattern * (self.sizeof() - len(obj)) + len(obj), target_size)) + return obj + self.pattern * (target_size - len(obj)) class MultiplyAdapter(Adapter): """ diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 81b671e..e7ae8f0 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1089,7 +1089,8 @@ # responsibility of home network operator but BCD coding shall be used. If a network # operator decides to assign less than 4 digits to Routing Indicator, the remaining digits # shall be coded as "1111" to fill the 4 digits coding of Routing Indicator - self._construct = Struct('routing_indicator'/BcdAdapter(Rpad(Bytes(2))), 'rfu'/HexAdapter(Bytes(2))) + self._construct = Struct('routing_indicator'/Rpad(BcdAdapter(Bytes(2)), 'f', 2), + 'rfu'/HexAdapter(Bytes(2))) # TS 31.102 Section 4.4.11.13 class EF_TN3GPPSNN(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6c26dccdd570de7b7a4cd48338068e230340ec7c Gerrit-Change-Number: 33249 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in pysim[master]: test_ota: Add one first OTA SMS AES128 unit test
by laforge 11 Jun '23

11 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33235 ) Change subject: test_ota: Add one first OTA SMS AES128 unit test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id4a66bbfaec2d8610e8a7a2c72c0dfd08332edcd Gerrit-Change-Number: 33235 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:10:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: 31.102: Fix EF.Routing_Indicator for odd number of digits
by laforge 11 Jun '23

11 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33249 ) Change subject: 31.102: Fix EF.Routing_Indicator for odd number of digits ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6c26dccdd570de7b7a4cd48338068e230340ec7c Gerrit-Change-Number: 33249 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 19:10:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: tbf_dl_fsm: Apply T3193 using FSM infrastructure instead of manually
by pespin 09 Jun '23

09 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33257 ) Change subject: tbf_dl_fsm: Apply T3193 using FSM infrastructure instead of manually ...................................................................... tbf_dl_fsm: Apply T3193 using FSM infrastructure instead of manually Change-Id: Ic2a9d4b3c812c1533b2b7f97f27799b28b636c21 --- M src/tbf_dl_fsm.c M tests/tbf/TbfTest.err 2 files changed, 16 insertions(+), 40 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c index a0b1c03..a0e47b7 100644 --- a/src/tbf_dl_fsm.c +++ b/src/tbf_dl_fsm.c @@ -31,20 +31,20 @@ static const struct osmo_tdef_state_timeout tbf_dl_fsm_timeouts[32] = { [TBF_ST_NEW] = {}, - [TBF_ST_ASSIGN] = { }, - [TBF_ST_FLOW] = { }, + [TBF_ST_ASSIGN] = {}, + [TBF_ST_FLOW] = {}, [TBF_ST_FINISHED] = {}, - [TBF_ST_WAIT_RELEASE] = {}, + [TBF_ST_WAIT_RELEASE] = { .T = 3193 }, [TBF_ST_RELEASING] = {}, }; -/* Transition to a state, using the T timer defined in tbf_fsm_timeouts. - * The actual timeout value is in turn obtained from conn->T_defs. - * Assumes local variable fi exists. */ +/* Transition to a state, using the T timer defined in tbf_dl_fsm_timeouts. + * The actual timeout value is in turn obtained from T_defs_bts. + */ #define tbf_dl_fsm_state_chg(fi, NEXT_STATE) \ osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \ tbf_dl_fsm_timeouts, \ - the_pcu->T_defs, \ + tbf_ms(((struct tbf_dl_fsm_ctx *)(fi->priv))->tbf)->bts->T_defs_bts, \ -1) static void mod_ass_type(struct tbf_dl_fsm_ctx *ctx, uint8_t t, bool set) @@ -267,15 +267,6 @@ static void st_wait_release_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct tbf_dl_fsm_ctx *ctx = (struct tbf_dl_fsm_ctx *)fi->priv; - unsigned long val_s, val_ms, val_us; - - fi->T = 3193; - val_ms = osmo_tdef_get(tbf_ms(ctx->tbf)->bts->T_defs_bts, fi->T, OSMO_TDEF_MS, -1); - val_s = val_ms / 1000; - val_us = (val_ms % 1000) * 1000; - LOGPTBFDL(ctx->dl_tbf, LOGL_DEBUG, "starting timer T%u with %lu sec. %lu microsec\n", - fi->T, val_s, val_us); - osmo_timer_schedule(&fi->timer, val_s, val_us); mod_ass_type(ctx, GPRS_RLCMAC_FLAG_CCCH, false); } diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index ee2dc3a..36e1c19 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -145,7 +145,6 @@ TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:G){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -272,7 +271,6 @@ TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:G){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -589,7 +587,6 @@ TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){FINISHED} Final ACK received. DL_TBF(DL:TFI-0-0-0:G){FINISHED}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G){FINISHED}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:G:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-45-0:DL) Detaching TBF: TBF(DL:G:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -3858,7 +3855,6 @@ TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} Final ACK received. DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec [DL] algo A <multi> (suggested TRX: 0): Alloc start - Skipping TS 0, because not enabled - Skipping TS 1, because not enabled @@ -4929,7 +4925,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5196,7 +5191,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5423,7 +5417,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5634,7 +5627,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -5829,7 +5821,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6000,7 +5991,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6180,7 +6170,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6351,7 +6340,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6511,7 +6499,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6594,7 +6581,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6673,7 +6659,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6752,7 +6737,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6856,7 +6840,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -6959,7 +6942,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7062,7 +7044,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7165,7 +7146,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7254,7 +7234,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7340,7 +7319,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7426,7 +7404,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} @@ -7519,7 +7496,6 @@ TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FLOW} Final ACK received. DL_TBF(DL:TFI-0-0-0:E){FLOW}: Received Event FINAL_ACK_RECVD DL_TBF(DL:TFI-0-0-0:E){FLOW}: state_chg to WAIT_RELEASE -TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} starting timer T3193 with 0 sec. 100000 microsec TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=4) Detaching TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_RELEASE}, 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI-0xffeeddcc:TA-0:MSCLS-11-11:DL) Detaching TBF: TBF(DL:E:TLLI-0xffeeddcc){WAIT_RELEASE} -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic2a9d4b3c812c1533b2b7f97f27799b28b636c21 Gerrit-Change-Number: 33257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0