May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: ctrl: Add getting SI5 neighbor list

by neels

Attention is currently required from: matanp. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32645 ) Change subject: ctrl: Add getting SI5 neighbor list ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71f5f23473b94059ac64770ceb256b4df36c0ef7 Gerrit-Change-Number: 32645 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 16 May 2023 12:17:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: vty test: show missing write-back of 'rnc-id'

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32715 to look at the new patch set (#4). Change subject: vty test: show missing write-back of 'rnc-id' ...................................................................... vty test: show missing write-back of 'rnc-id' Change-Id: I9eecda8678c32abbeaf39344ccdb14ed5a0828ce --- M tests/osmo-hnbgw.vty 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/15/32715/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9eecda8678c32abbeaf39344ccdb14ed5a0828ce Gerrit-Change-Number: 32715 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmo-cbc[master]: sbcap: Update asn1c skeleton files

by fixeria

Attention is currently required from: osmith, pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32723 ) Change subject: sbcap: Update asn1c skeleton files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I385d14d4be308b991a48ce1033087f07bd1f47ea Gerrit-Change-Number: 32723 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 11:53:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-cbc[master]: README.md: Document generation of SBcAP code from ASN.1 files

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32730 ) Change subject: README.md: Document generation of SBcAP code from ASN.1 files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6edb2dcbd39ca101110f1ca57fcd67bf08c0ef0 Gerrit-Change-Number: 32730 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 11:52:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-pcu[master]: Fix DL_TBF PACCH ass done on UL_TBF already scheduled to tx last PKT ...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32339 ) Change subject: Fix DL_TBF PACCH ass done on UL_TBF already scheduled to tx last PKT CTRL ACK ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS2: Manual testing also looks good. I plan to get this merged as soon as we fix bug in osmocom-bb modem app appearing once this patch is in place. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I62ae91b494e4fd0ade3f4a3ba3817bcaedbdebf5 Gerrit-Change-Number: 32339 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 16 May 2023 10:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list

by matanp

Attention is currently required from: pespin, fixeria. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 ) Change subject: ctrl: Add getting neighbor list ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/c641a7e7_93b608ac PS3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i); > I'd rather go for 1 allocation of 4096 bytes than potentially doing 1024 allocations, even if used w […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 10:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list

by matanp

Attention is currently required from: fixeria, matanp. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 to look at the new patch set (#4). Change subject: ctrl: Add getting neighbor list ...................................................................... ctrl: Add getting neighbor list Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/32565/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmo-cbc[master]: sbcap: Update asn1c skeleton files

by pespin

Attention is currently required from: osmith, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32723 ) Change subject: sbcap: Update asn1c skeleton files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yeah having that in the README in a follow-up patch would be very useful, thanks! done -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I385d14d4be308b991a48ce1033087f07bd1f47ea Gerrit-Change-Number: 32723 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 10:41:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-cbc[master]: README.md: Document generation of SBcAP code from ASN.1 files

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32730 ) Change subject: README.md: Document generation of SBcAP code from ASN.1 files ...................................................................... Patch Set 2: (2 comments) File README.md: https://gerrit.osmocom.org/c/osmo-cbc/+/32730/comment/adeb132e_295e86cd PS1, Line 75: Upstream master as1nc from [vlm](https://github.com/vlm/asn1c) [doesn't support APER encoding](https://github.com/vlm/asn1c/issues/452). Nevertheless, the upstream fork maintained by a big contributor [mouse07410](https://github.com/mouse07410/asn1c) does support it, and it is used in osmo-cbc to generate the SBc-AP code from ASN.1 files present in src/sbcap/asn1/. > break lines at a similar length as above for consistency (maybe ~80)? Done https://gerrit.osmocom.org/c/osmo-cbc/+/32730/comment/39b95fef_904c88f6 PS1, Line 77: regente > regenerate Done -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6edb2dcbd39ca101110f1ca57fcd67bf08c0ef0 Gerrit-Change-Number: 32730 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 10:36:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023