May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: build/Makefile.docbook: fix INC_DIR for openbsc

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32731 ) Change subject: build/Makefile.docbook: fix INC_DIR for openbsc ...................................................................... build/Makefile.docbook: fix INC_DIR for openbsc When Makefile.docbook.inc gets included by openbsc, the PWD Makefile variable is empty (probably because the including file is not generated by automake). Use the shell pwd command instead. This fixes the master-openbsc jenkins job which has been failing since previous patch dba860c7 ("VTY references: set git version and date") was merged. Related: OS#4063 Change-Id: I6026623ec9a5eef0ca8c47bf46605086e361c2bc --- M build/Makefile.docbook.inc 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/31/32731/1 diff --git a/build/Makefile.docbook.inc b/build/Makefile.docbook.inc index eff6c66..df17646 100644 --- a/build/Makefile.docbook.inc +++ b/build/Makefile.docbook.inc @@ -28,7 +28,7 @@ all: $(DOCBOOKS_PDF) # Allow the users to re-define the include directory -INC_DIR ?= $(PWD)/generated +INC_DIR ?= $(shell pwd)/generated # Lint the file %.xml-lint: %.xml -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I6026623ec9a5eef0ca8c47bf46605086e361c2bc Gerrit-Change-Number: 32731 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: cosmetic: rename all IMM.ASS references to MAC block

by fixeria

Attention is currently required from: jolly, laforge, msuraev, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32687 ) Change subject: paging: cosmetic: rename all IMM.ASS references to MAC block ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad Gerrit-Change-Number: 32687 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 09:40:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: cosmetic: rename all IMM.ASS references to MAC block

by dexter

Attention is currently required from: jolly, laforge, fixeria, msuraev, dexter. Hello Jenkins Builder, jolly, laforge, pespin, fixeria, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 to look at the new patch set (#5). Change subject: paging: cosmetic: rename all IMM.ASS references to MAC block ...................................................................... paging: cosmetic: rename all IMM.ASS references to MAC block The paging interface towards the PCU has a confusing API. In fact what the PCU does when it wants to page or do an immediate assignment is sending a ready formatted MAC block to the BTS. The BTS then puts this MAC block in the paging queue and then eventually it justs sends it without looking at the contents. For the code in paging.c it is not imortant if the MAC block is an immediate assignment, it only cares if the paging record contains a MAC block or paging parameters. Related: OS#5927 Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad --- M include/osmo-bts/paging.h M src/common/paging.c M src/common/pcu_sock.c 3 files changed, 78 insertions(+), 58 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/32687/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad Gerrit-Change-Number: 32687 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list

by pespin

Attention is currently required from: fixeria, matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 ) Change subject: ctrl: Add getting neighbor list ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/afb0ef29_82bbcbf2 PS3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i); > len('1 2 3 ... 1023') == 4009 […] I'd rather go for 1 allocation of 4096 bytes than potentially doing 1024 allocations, even if used with realloc. That would mean looking up for new space and potentially holding an allocation mutex lots of times. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 16 May 2023 09:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list

by matanp

Attention is currently required from: pespin, fixeria. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 ) Change subject: ctrl: Add getting neighbor list ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/0113c514_4b5d0115 PS3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i); > 1- Ok I was unaware of other commands using something other than spaces. […] len('1 2 3 ... 1023') == 4009 It is less readable in my humble opinion so If it's OK I will leave it as is. Waiting for the feedback about the spaces -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 09:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: cosmetic: rename all IMM.ASS references to MAC block

by pespin

Attention is currently required from: jolly, laforge, fixeria, msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32687 ) Change subject: paging: cosmetic: rename all IMM.ASS references to MAC block ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad Gerrit-Change-Number: 32687 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 09:32:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-cbc[master]: README.md: Document generation of SBcAP code from ASN.1 files

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32730 ) Change subject: README.md: Document generation of SBcAP code from ASN.1 files ...................................................................... README.md: Document generation of SBcAP code from ASN.1 files Change-Id: Id6edb2dcbd39ca101110f1ca57fcd67bf08c0ef0 --- M README.md 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/30/32730/1 diff --git a/README.md b/README.md index 6cb375e..19998e7 100644 --- a/README.md +++ b/README.md @@ -67,3 +67,19 @@ The current patch queue for osmo-cbc can be seen at https://gerrit.osmocom.org/#/q/project:osmo-cbc+status:open + + +Generating asn1c code +--------------------- + +Upstream master as1nc from [vlm](https://github.com/vlm/asn1c) [doesn't support APER encoding](https://github.com/vlm/asn1c/issues/452). Nevertheless, the upstream fork maintained by a big contributor [mouse07410](https://github.com/mouse07410/asn1c) does support it, and it is used in osmo-cbc to generate the SBc-AP code from ASN.1 files present in src/sbcap/asn1/. + +In order to regente the code, one shall adjust the ASN1C_SKELETON_PATH and ASN1C_BIN_PATH in configure.ac to point to the built & installed asn1c from mouse07410 (usually `vlm_master` branch). Last generated code was built using commit hash 08b293e8aa342d465d26805d1d66f3595b2ce261. + +Then, do the usual `autoreconf -fi && ./configure`, using a buildir != srcdir (important, in order to avoid ending up with tempotary files in srcdir and making it difficult to stash the relevant changes). + +Finally, run `make -C src/ regen`, which will regenerate the files and copy over the skeletons, with git possibily showing changes in the following paths: +- include/osmocom/sbcap/ +- src/sbcap/gen/ +- src/sbcap/skel/ + -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6edb2dcbd39ca101110f1ca57fcd67bf08c0ef0 Gerrit-Change-Number: 32730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: cosmetic: rename all IMM.ASS references to MAC block

by dexter

Attention is currently required from: jolly, laforge, fixeria, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32687 ) Change subject: paging: cosmetic: rename all IMM.ASS references to MAC block ...................................................................... Patch Set 4: (1 comment) File include/osmo-bts/paging.h: https://gerrit.osmocom.org/c/osmo-bts/+/32687/comment/64421bfc_9152a50e PS3, Line 38: MACBLOCK message > not addressed Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad Gerrit-Change-Number: 32687 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 09:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: cosmetic: rename all IMM.ASS references to MAC block

by dexter

Attention is currently required from: jolly, laforge, fixeria, msuraev. Hello Jenkins Builder, jolly, laforge, fixeria, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 to look at the new patch set (#4). Change subject: paging: cosmetic: rename all IMM.ASS references to MAC block ...................................................................... paging: cosmetic: rename all IMM.ASS references to MAC block The paging interface towards the PCU has a confusing API. In fact what the PCU does when it wants to page or do an immediate assignment is sending a ready formatted MAC block to the BTS. The BTS then puts this MAC block in the paging queue and then eventually it justs sends it without looking at the contents. For the code in paging.c it is not imortant if the MAC block is an immediate assignment, it only cares if the paging record contains a MAC block or paging parameters. Related: OS#5927 Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad --- M include/osmo-bts/paging.h M src/common/paging.c M src/common/pcu_sock.c 3 files changed, 77 insertions(+), 57 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/32687/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad Gerrit-Change-Number: 32687 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: contrib/jenkins.sh: print pylint version before running it

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/32729 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: print pylint version before running it ...................................................................... contrib/jenkins.sh: print pylint version before running it Change-Id: Icc96ff16af482581dc97a387bcff1374fbb620f3 Related: OS#6034 --- M contrib/jenkins.sh 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/32729/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icc96ff16af482581dc97a387bcff1374fbb620f3 Gerrit-Change-Number: 32729 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023