[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list - gerrit-log

16 May 2023


      Attention is currently required from: pespin, fixeria.
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 )
Change subject: ctrl: Add getting neighbor list
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/0113c514_4b5d0115 
PS3, Line 531: 		cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i);
...
1- Ok I was unaware of other commands using something other than spaces. […]
len('1 2 3 ... 1023') == 4009
It is less readable in my humble opinion so If it's OK I will leave it as is.
Waiting for the feedback about the spaces
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7
Gerrit-Change-Number: 32565
Gerrit-PatchSet: 3
Gerrit-Owner: matanp matan1008@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 16 May 2023 09:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: matanp matan1008@gmail.com
Gerrit-MessageType: comment