May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2

by falconia

Attention is currently required from: pespin, dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 to look at the new patch set (#4). Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 Section 5.1.2 of GSM 06.31 & 06.81 (DTX specs for FR & EFR) specifies the expected shape of radio downlink in the presence of SIDs: one SID frame after each talkspurt (after speech frames), and one SID frame in every SACCH-aligned position every 480 ms, or if the actual SACCH- aligned position is taken up by FACCH, then just one SID frame as soon as possible after that FACCH - and no transmitted SID frames in other positions. This just-referenced spec section was written with the assumption that it will only be applied when DTXd is enabled - however, if the RTP stream for call leg B DL comes from call leg A UL (TrFO), then we are going to receive SID frames in the stream intended for our DL even when DTXd is disabled or not supported altogether. The easiest solution is to apply FR/EFR (and in the future HR1 too) DTXd logic whenever the incoming RTP stream contains SID frames, irrespective of physical DTXd enable/disable state. If we apply such "logical DTXd" when physical DTXd is disabled, the BTS model PHY will end up transmitting induced BFIs (dummy FACCH or inverted CRC3) in those frame positions where the "logical DTXd" function says "please transmit nothing". The point remains, however, that the prescribed SID shape on the radio downlink (expected positions of SID frames) won't happen on its own: in the case of TrFO, whichever SID frames are present will be in wrong positions for leg B DL, and even in the case of transcoded calls the responsibility for DL SID shaping cannot be placed on the RTP stream source because that source won't know where SACCH alignment will lie. Therefore, the necessary DL SID reshaping has to be done in the RTP stream receiver in OsmoBTS. Related: OS#5996 Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 --- M include/osmo-bts/lchan.h M src/common/l1sap.c 2 files changed, 228 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/14/32714/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Support setting P-TMSI in test sim

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32739 ) Change subject: layer23: Support setting P-TMSI in test sim ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: follow-up TODO patches: - Patch adding support to store RAI - Patch adding support for real SIM to store P-TMSI + P-TMSI signature + RAI + status to EF.LOCIGPRS (3GPP TS 51.011 10.3.33) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77d28534bd21327fbbec8f1544238703558245cb Gerrit-Change-Number: 32739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 16 May 2023 18:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Support setting P-TMSI in test sim

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32739 ) Change subject: layer23: Support setting P-TMSI in test sim ...................................................................... layer23: Support setting P-TMSI in test sim Change-Id: I77d28534bd21327fbbec8f1544238703558245cb --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/subscriber.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/subscriber.c M src/host/layer23/src/common/vty.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/modem/app_modem.c 7 files changed, 46 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/39/32739/1 diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index 38faa4b..ab85ea1 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -87,6 +87,7 @@ /* test card simulator settings */ char test_imsi[OSMO_IMSI_BUF_SIZE]; uint32_t test_tmsi; + uint32_t test_ptmsi; uint8_t test_ki_type; uint8_t test_ki[16]; /* 128 bit max */ uint8_t test_barr; diff --git a/src/host/layer23/include/osmocom/bb/common/subscriber.h b/src/host/layer23/include/osmocom/bb/common/subscriber.h index 1dd1869..62c2ee8 100644 --- a/src/host/layer23/include/osmocom/bb/common/subscriber.h +++ b/src/host/layer23/include/osmocom/bb/common/subscriber.h @@ -90,7 +90,7 @@ int gsm_subscr_init(struct osmocom_ms *ms); int gsm_subscr_exit(struct osmocom_ms *ms); int gsm_subscr_testcard(struct osmocom_ms *ms, uint16_t mcc, uint16_t mnc, - uint16_t lac, uint32_t tmsi, uint8_t imsi_attached); + uint16_t lac, uint32_t tmsi, uint32_t ptmsi, uint8_t imsi_attached); int gsm_subscr_sap_rsp_cb(struct osmocom_ms *ms, int res_code, uint8_t res_type, uint16_t param_len, const uint8_t *param_val); int gsm_subscr_sapcard(struct osmocom_ms *ms); diff --git a/src/host/layer23/src/common/settings.c b/src/host/layer23/src/common/settings.c index 986d551..89c6881 100644 --- a/src/host/layer23/src/common/settings.c +++ b/src/host/layer23/src/common/settings.c @@ -71,6 +71,7 @@ set->test_rplmn_mcc = set->test_rplmn_mnc = 1; set->test_lac = 0x0000; set->test_tmsi = GSM_RESERVED_TMSI; + set->test_ptmsi = GSM_RESERVED_TMSI; /* set all supported features */ set->sms_ptp = sup->sms_ptp; diff --git a/src/host/layer23/src/common/subscriber.c b/src/host/layer23/src/common/subscriber.c index 0669598..e5b1593 100644 --- a/src/host/layer23/src/common/subscriber.c +++ b/src/host/layer23/src/common/subscriber.c @@ -137,7 +137,7 @@ /* Attach test card, no SIM must be currently attached */ int gsm_subscr_testcard(struct osmocom_ms *ms, uint16_t mcc, uint16_t mnc, - uint16_t lac, uint32_t tmsi, uint8_t imsi_attached) + uint16_t lac, uint32_t tmsi, uint32_t ptmsi, uint8_t imsi_attached) { struct gsm_settings *set = &ms->settings; struct gsm_subscriber *subscr = &ms->subscr; @@ -174,7 +174,7 @@ subscr->mnc = mnc; subscr->lac = lac; subscr->tmsi = tmsi; - subscr->ptmsi = GSM_RESERVED_TMSI; + subscr->ptmsi = ptmsi; subscr->always_search_hplmn = set->test_always; subscr->t6m_hplmn = 1; /* try to find home network every 6 min */ strcpy(subscr->imsi, set->test_imsi); diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index 4f9aa20..331e0f1 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -488,6 +488,7 @@ /* Initial testcard settings */ uint16_t mcc = 0x001, mnc = 0x01f, lac = 0x0000; uint32_t tmsi = GSM_RESERVED_TMSI; + uint32_t ptmsi = GSM_RESERVED_TMSI; ms = l23_vty_get_ms(argv[0], vty); if (!ms) @@ -509,6 +510,9 @@ if (set->test_tmsi != GSM_RESERVED_TMSI) tmsi = set->test_tmsi; + + if (set->test_ptmsi != GSM_RESERVED_TMSI) + ptmsi = set->test_ptmsi; } if (argc == 2) { @@ -534,7 +538,10 @@ if (argc >= 5) tmsi = strtoul(argv[4], NULL, 16); - rc = gsm_subscr_testcard(ms, mcc, mnc, lac, tmsi, attached); + if (argc >= 6) + ptmsi = strtoul(argv[4], NULL, 16); + + rc = gsm_subscr_testcard(ms, mcc, mnc, lac, tmsi, ptmsi, attached); if (rc < 0) { vty_out(vty, "Attach test SIM card failed: %d%s", rc, VTY_NEWLINE); return CMD_WARNING; @@ -544,22 +551,24 @@ } DEFUN(sim_test, sim_test_cmd, - "sim testcard MS_NAME [MCC] [MNC] [LAC] [TMSI]", + "sim testcard MS_NAME [MCC] [MNC] [LAC] [TMSI] [PTMSI]", "SIM actions\nAttach built in test SIM\nName of MS (see \"show ms\")\n" "Optionally set mobile Country Code of RPLMN\n" "Optionally set mobile Network Code of RPLMN\n" "Optionally set location area code of RPLMN\n" - "Optionally set current assigned TMSI") + "Optionally set current assigned TMSI\n" + "Optionally set current assigned P-TMSI") { return _sim_test_cmd(vty, argc, argv, 0); } DEFUN(sim_test_att, sim_test_att_cmd, - "sim testcard MS_NAME MCC MNC LAC TMSI attached", + "sim testcard MS_NAME MCC MNC LAC TMSI PTMSI attached", "SIM actions\nAttach built in test SIM\nName of MS (see \"show ms\")\n" "Set mobile Country Code of RPLMN\nSet mobile Network Code of RPLMN\n" "Set location area code\nSet current assigned TMSI\n" - "Indicate to MM that card is already attached") + "Set current assigned P-TMSI\n" + "Indicate to MM that card is already attached\n") { return _sim_test_cmd(vty, argc, argv, 1); } @@ -1083,6 +1092,11 @@ else set->test_tmsi = GSM_RESERVED_TMSI; + if (argc >= 5) + set->test_ptmsi = strtoul(argv[4], NULL, 16); + else + set->test_ptmsi = GSM_RESERVED_TMSI; + if (attached) set->test_imsi_attached = 1; else @@ -1094,19 +1108,21 @@ } DEFUN(cfg_test_rplmn, cfg_test_rplmn_cmd, - "rplmn MCC MNC [LAC] [TMSI]", + "rplmn MCC MNC [LAC] [TMSI] [PTMSI]", "Set Registered PLMN\nMobile Country Code\nMobile Network Code\n" "Optionally set location area code\n" - "Optionally set current assigned TMSI") + "Optionally set current assigned TMSI\n" + "Optionally set current assigned P-TMSI\n") { return _test_rplmn_cmd(vty, argc, argv, 0); } DEFUN(cfg_test_rplmn_att, cfg_test_rplmn_att_cmd, - "rplmn MCC MNC LAC TMSI attached", + "rplmn MCC MNC LAC TMSI PTMSI attached", "Set Registered PLMN\nMobile Country Code\nMobile Network Code\n" "Set location area code\nSet current assigned TMSI\n" - "Indicate to MM that card is already attached") + "Set current assigned P-TMSI\n" + "Indicate to MM that card is already attached\n") { return _test_rplmn_cmd(vty, argc, argv, 1); } @@ -1211,8 +1227,11 @@ vty_out(vty, " 0x%04x", set->test_lac); if (set->test_tmsi != GSM_RESERVED_TMSI) { vty_out(vty, " 0x%08x", set->test_tmsi); - if (set->test_imsi_attached) - vty_out(vty, " attached"); + if (set->test_ptmsi != GSM_RESERVED_TMSI) { + vty_out(vty, " 0x%08x", set->test_ptmsi); + if (set->test_imsi_attached) + vty_out(vty, " attached"); + } } } vty_out(vty, "%s", VTY_NEWLINE); diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index e7caed2..0eee50d 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -169,7 +169,7 @@ case GSM_SIM_TYPE_TEST: gsm_subscr_testcard(ms, set->test_rplmn_mcc, set->test_rplmn_mnc, set->test_lac, - set->test_tmsi, set->test_imsi_attached); + set->test_tmsi, set->test_ptmsi, set->test_imsi_attached); break; case GSM_SIM_TYPE_SAP: gsm_subscr_sapcard(ms); diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index b657d8c..da677a6 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -215,7 +215,7 @@ case GSM_SIM_TYPE_TEST: gsm_subscr_testcard(ms, set->test_rplmn_mcc, set->test_rplmn_mnc, set->test_lac, - set->test_tmsi, set->test_imsi_attached); + set->test_tmsi, set->test_ptmsi, set->test_imsi_attached); break; case GSM_SIM_TYPE_SAP: gsm_subscr_sapcard(ms); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77d28534bd21327fbbec8f1544238703558245cb Gerrit-Change-Number: 32739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: sm: Provide RAI obtained from network

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32738 to look at the new patch set (#2). Change subject: sm: Provide RAI obtained from network ...................................................................... sm: Provide RAI obtained from network MS needs to store this information, hence the app needs to be provided with it. Change-Id: Icd357d8c7f4848441da011d59a4e520785d64779 --- M include/osmocom/gprs/sm/sm_prim.h M src/sm/sm.c M src/sm/sm_prim.c 3 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/38/32738/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icd357d8c7f4848441da011d59a4e520785d64779 Gerrit-Change-Number: 32738 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmo-pcu[master]: gprs_rlcmac: also use PCU_IF_SAPI_PCH_DT for paging MAC blocks

by pespin

Attention is currently required from: jolly, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use PCU_IF_SAPI_PCH_DT for paging MAC blocks ...................................................................... Patch Set 3: (1 comment) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/d1c72017_876032ff PS3, Line 291: { better document here that TLLI is only really required for IMM ASS since it requires confirmation from BTS. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 17:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Provide RAI obtained from network

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32737 ) Change subject: gmm: Provide RAI obtained from network ...................................................................... gmm: Provide RAI obtained from network MS needs to store this information, hence the app needs to be provided with it. Change-Id: Ifdc4d0ccb8bb5ad145cd749bc83df202e91627a3 --- M include/osmocom/gprs/gmm/gmm_prim.h M src/gmm/gmm.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/37/32737/1 diff --git a/include/osmocom/gprs/gmm/gmm_prim.h b/include/osmocom/gprs/gmm/gmm_prim.h index 665b3df..e5eada0 100644 --- a/include/osmocom/gprs/gmm/gmm_prim.h +++ b/include/osmocom/gprs/gmm/gmm_prim.h @@ -120,6 +120,7 @@ /* PLMNs MT-caps, attach-type. */ uint32_t allocated_ptmsi; uint32_t allocated_tlli; + struct gprs_ra_id rai; } acc; struct { uint8_t cause; /* See enum gsm48_gsm_cause */ @@ -225,6 +226,7 @@ /* PLMNs MT-caps, attach-type. */ uint32_t allocated_ptmsi; uint32_t allocated_tlli; + struct gprs_ra_id rai; } acc; struct { uint8_t cause; diff --git a/src/gmm/gmm.c b/src/gmm/gmm.c index c75a279..385da4f 100644 --- a/src/gmm/gmm.c +++ b/src/gmm/gmm.c @@ -289,6 +289,7 @@ if (accepted) { gmm_prim_tx->gmmreg.attach_cnf.acc.allocated_ptmsi = gmme->ptmsi; gmm_prim_tx->gmmreg.attach_cnf.acc.allocated_tlli = gmme->tlli; + memcpy(&gmm_prim_tx->gmmreg.attach_cnf.acc.rai, &gmme->ra, sizeof(gmme->ra)); } else { gmm_prim_tx->gmmreg.attach_cnf.rej.cause = cause; } @@ -333,6 +334,7 @@ if (accepted) { gmm_prim_tx->gmmsm.establish_cnf.acc.allocated_ptmsi = gmme->ptmsi; gmm_prim_tx->gmmsm.establish_cnf.acc.allocated_tlli = gmme->tlli; + memcpy(&gmm_prim_tx->gmmsm.establish_cnf.acc.rai, &gmme->ra, sizeof(gmme->ra)); } rc = gprs_gmm_prim_call_up_cb(gmm_prim_tx); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifdc4d0ccb8bb5ad145cd749bc83df202e91627a3 Gerrit-Change-Number: 32737 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: sm: Allow passing old RAI during attach

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32738 ) Change subject: sm: Allow passing old RAI during attach ...................................................................... sm: Allow passing old RAI during attach This is stored by the MS and hence shall be passed by the application. Change-Id: Icd357d8c7f4848441da011d59a4e520785d64779 --- M include/osmocom/gprs/sm/sm_prim.h M src/sm/sm.c M src/sm/sm_prim.c 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/38/32738/1 diff --git a/include/osmocom/gprs/sm/sm_prim.h b/include/osmocom/gprs/sm/sm_prim.h index 0cfc5bb..d9be348 100644 --- a/include/osmocom/gprs/sm/sm_prim.h +++ b/include/osmocom/gprs/sm/sm_prim.h @@ -90,6 +90,7 @@ struct { uint32_t allocated_ptmsi; uint32_t allocated_tlli; + struct gprs_ra_id rai; } gmm; } acc; struct { diff --git a/src/sm/sm.c b/src/sm/sm.c index b13559c..c5520bf 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -225,6 +225,7 @@ memcpy(sm_prim_tx->smreg.pdp_act_cnf.acc.qos, &sme->qos, sme->qos_len); sm_prim_tx->smreg.pdp_act_cnf.acc.gmm.allocated_ptmsi = sme->ms->gmm.ptmsi; sm_prim_tx->smreg.pdp_act_cnf.acc.gmm.allocated_tlli = sme->ms->gmm.tlli; + memcpy(&sm_prim_tx->smreg.pdp_act_cnf.acc.gmm.rai, &sme->ms->gmm.ra, sizeof(sme->ms->gmm.ra)); } else { sm_prim_tx->smreg.pdp_act_cnf.rej.cause = cause; } diff --git a/src/sm/sm_prim.c b/src/sm/sm_prim.c index db6b174..ea84d3e 100644 --- a/src/sm/sm_prim.c +++ b/src/sm/sm_prim.c @@ -481,6 +481,8 @@ sme->ms->gmm.ptmsi = gmm_prim->gmmsm.establish_cnf.acc.allocated_ptmsi; /* Set allocated TLLI: */ sme->ms->gmm.tlli = gmm_prim->gmmsm.establish_cnf.acc.allocated_tlli; + /* Set the current RAI: */ + memcpy(&sme->ms->gmm.ra, &gmm_prim->gmmsm.establish_cnf.acc.rai, sizeof(sme->ms->gmm.ra)); rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_RX_GMM_ESTABLISH_CNF, NULL); } else { rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_RX_GMM_ESTABLISH_REJ, NULL); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icd357d8c7f4848441da011d59a4e520785d64779 Gerrit-Change-Number: 32738 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: paging: do not confirm PAGING COMMAND messages

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32734 ) Change subject: paging: do not confirm PAGING COMMAND messages ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d Gerrit-Change-Number: 32734 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 17:33:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: parse PCUIF data indication outside of paging.c

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 ) Change subject: paging: parse PCUIF data indication outside of paging.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9f3799916e8102bf1ce0f21891f2d24f43091f01 Gerrit-Change-Number: 32733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 17:33:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: sm: Allow passing old RAI during attach

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32736 ) Change subject: sm: Allow passing old RAI during attach ...................................................................... sm: Allow passing old RAI during attach This is stored by the MS and hence shall be passed by the application. Change-Id: I13118bed3f7035ff9b4c2c21ed9557f48f5596e6 --- M include/osmocom/gprs/sm/sm_prim.h M include/osmocom/gprs/sm/sm_private.h M src/sm/sm.c M src/sm/sm_prim.c 4 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/36/32736/1 diff --git a/include/osmocom/gprs/sm/sm_prim.h b/include/osmocom/gprs/sm/sm_prim.h index baa85ed..0cfc5bb 100644 --- a/include/osmocom/gprs/sm/sm_prim.h +++ b/include/osmocom/gprs/sm/sm_prim.h @@ -13,6 +13,7 @@ #include <osmocom/core/prim.h> #include <osmocom/core/socket.h> #include <osmocom/gsm/protocol/gsm_23_003.h> +#include <osmocom/gsm/gsm48.h> #include <osmocom/gprs/sm/sm.h> @@ -68,6 +69,7 @@ char imsi[OSMO_IMSI_BUF_SIZE]; char imei[GSM23003_IMEI_NUM_DIGITS + 1]; char imeisv[GSM23003_IMEISV_NUM_DIGITS+1]; + struct gprs_ra_id old_rai; } gmm; } pdp_act_req; diff --git a/include/osmocom/gprs/sm/sm_private.h b/include/osmocom/gprs/sm/sm_private.h index 99beaeb..6bf456f 100644 --- a/include/osmocom/gprs/sm/sm_private.h +++ b/include/osmocom/gprs/sm/sm_private.h @@ -131,6 +131,7 @@ char imsi[OSMO_IMSI_BUF_SIZE]; char imei[GSM23003_IMEI_NUM_DIGITS + 1]; char imeisv[GSM23003_IMEISV_NUM_DIGITS+1]; + struct gprs_ra_id ra; /* TS 24.008 10.5.5.15 (decoded) */ } gmm; }; diff --git a/src/sm/sm.c b/src/sm/sm.c index 3cddb58..b13559c 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -196,6 +196,7 @@ OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imsi, ms->gmm.imsi); OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imei, ms->gmm.imei); OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imeisv, ms->gmm.imeisv); + memcpy(&gmm_prim_tx->gmmsm.establish_req.old_rai, &ms->gmm.ra, sizeof(ms->gmm.ra)); rc = gprs_sm_prim_call_gmm_down_cb(gmm_prim_tx); return rc; diff --git a/src/sm/sm_prim.c b/src/sm/sm_prim.c index bb5653e..db6b174 100644 --- a/src/sm/sm_prim.c +++ b/src/sm/sm_prim.c @@ -276,6 +276,7 @@ OSMO_STRLCPY_ARRAY(ms->gmm.imei, sm_prim->smreg.pdp_act_req.gmm.imei); if (sm_prim->smreg.pdp_act_req.gmm.imeisv[0] != '\0') OSMO_STRLCPY_ARRAY(ms->gmm.imeisv, sm_prim->smreg.pdp_act_req.gmm.imeisv); + memcpy(&ms->gmm.ra, &sm_prim->smreg.pdp_act_req.gmm.old_rai, sizeof(ms->gmm.ra)); rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_TX_ACT_PDP_CTX_REQ, NULL); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I13118bed3f7035ff9b4c2c21ed9557f48f5596e6 Gerrit-Change-Number: 32736 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023