March 2023 - gerrit-log - lists.osmocom.org

[S] Change in openbsc[master]: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd...
by pespin 14 Mar '23

14 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/31890 ) Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I462eea5c44cbffa7fa47121c85fb6ef55394953d --- M openbsc/src/libbsc/pcu_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/openbsc/src/libbsc/pcu_sock.c b/openbsc/src/libbsc/pcu_sock.c index 4411df8..aa794de 100644 --- a/openbsc/src/libbsc/pcu_sock.c +++ b/openbsc/src/libbsc/pcu_sock.c @@ -502,9 +502,9 @@ LOGP(DPCU, LOGL_NOTICE, "PCU socket has LOST connection\n"); + osmo_fd_unregister(bfd); close(bfd->fd); bfd->fd = -1; - osmo_fd_unregister(bfd); /* re-enable the generation of ACCEPT for new connections */ state->listen_bfd.when |= OSMO_FD_READ; -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/31890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I462eea5c44cbffa7fa47121c85fb6ef55394953d Gerrit-Change-Number: 31890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcap[master]: server: Call osmo_fd_unregister() before closing and changing bfd->fd
by pespin 14 Mar '23

14 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31900 ) Change subject: server: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... server: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I44405687dae79a13db5617867c669ee4840485ba --- M src/osmo_server_network.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index 025f560..b566bd2 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -130,10 +130,10 @@ static void close_connection(struct osmo_pcap_conn *conn) { if (conn->rem_wq.bfd.fd >= 0) { + osmo_fd_unregister(&conn->rem_wq.bfd); close(conn->rem_wq.bfd.fd); conn->rem_wq.bfd.fd = -1; osmo_tls_release(&conn->tls_session); - osmo_fd_unregister(&conn->rem_wq.bfd); } osmo_pcap_server_close_trace(conn); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I44405687dae79a13db5617867c669ee4840485ba Gerrit-Change-Number: 31900 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcap[master]: server: Call osmo_fd_unregister() before closing and changing bfd->fd
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31900 ) Change subject: server: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I44405687dae79a13db5617867c669ee4840485ba Gerrit-Change-Number: 31900 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:42:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in openbsc[master]: mgcp: Call osmo_fd_unregister() before closing and changing bfd->fd
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/31898 ) Change subject: mgcp: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/31898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I2227e97b1cffab5ab0138ce95a2523a824ec35f0 Gerrit-Change-Number: 31898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in openbsc[master]: mncc_sock.c: Call osmo_fd_unregister() before closing and changing bf...
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/31897 ) Change subject: mncc_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/31897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ib54a9caaf10293860a2893aab876198b1990045d Gerrit-Change-Number: 31897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:41:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in openbsc[master]: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd...
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/31890 ) Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/31890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I462eea5c44cbffa7fa47121c85fb6ef55394953d Gerrit-Change-Number: 31890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:41:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: Update libosmogsm deprecated include
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31888 ) Change subject: Update libosmogsm deprecated include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I027abbf3ed4c71331000565af1ef4f08f10cfafc Gerrit-Change-Number: 31888 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: osmo_bts_sock.c: Call osmo_fd_unregister() before closing and changin...
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: laforge, pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31887 ) Change subject: osmo_bts_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec0faba781bcb2bc6de8710392655785790b9af4 Gerrit-Change-Number: 31887 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: select.c: Clarify osmo_fd_unregister() can only be called on register...
by pespin 14 Mar '23

14 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31902 ) Change subject: select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds ...................................................................... select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 --- M src/core/select.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/src/core/select.c b/src/core/select.c index 584de24..67b0fd3 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -212,6 +212,7 @@ /*! Unregister a file descriptor from select loop abstraction * \param[in] fd osmocom file descriptor to be unregistered * + * Caller is responsible for ensuring the fd is really registered before calling this API. * This function must be called before changing the value of the fd field in * the struct osmo_fd. */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 Gerrit-Change-Number: 31902 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: select.c: Clarify osmo_fd_(un)register() API expectations of register...
by pespin 14 Mar '23

14 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31901 ) Change subject: select.c: Clarify osmo_fd_(un)register() API expectations of registered fd ...................................................................... select.c: Clarify osmo_fd_(un)register() API expectations of registered fd Those restrictions were implicitly required for a while and most of the users of this API already followed them, but just a few didn't. All known users have now been fixed. Let's explicitly document the restrictions imposed by the API to ease avoiding similar issues in the future. Change-Id: I53d95aad15b33dd66aa5c7dd11745a35c4481f33 --- M src/core/select.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/core/select.c b/src/core/select.c index f983601..584de24 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -151,6 +151,9 @@ /*! Register a new file descriptor with select loop abstraction * \param[in] fd osmocom file descriptor to be registered * \returns 0 on success; negative in case of error + * + * The API expects fd field of the struct osmo_fd to remain unchanged while + * registered, ie until osmo_fd_unregister() is called on it. */ int osmo_fd_register(struct osmo_fd *fd) { @@ -208,6 +211,9 @@ /*! Unregister a file descriptor from select loop abstraction * \param[in] fd osmocom file descriptor to be unregistered + * + * This function must be called before changing the value of the fd field in + * the struct osmo_fd. */ void osmo_fd_unregister(struct osmo_fd *fd) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I53d95aad15b33dd66aa5c7dd11745a35c4481f33 Gerrit-Change-Number: 31901 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0