March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: tests/Makefile.am: Move system libs at the end of list
by pespin 14 Mar '23

14 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31906 ) Change subject: tests/Makefile.am: Move system libs at the end of list ...................................................................... tests/Makefile.am: Move system libs at the end of list Change-Id: Iad6b9e39e3587849ccfd475899cbd610bf7145cd --- M tests/Makefile.am 1 file changed, 24 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/31906/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 275cf5f..2f5eb01 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -198,26 +198,30 @@ $(top_builddir)/src/gsm/libosmogsm.la gb_gprs_bssgp_test_SOURCES = gb/gprs_bssgp_test.c -gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DLSYM) \ +gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la \ $(top_builddir)/src/vty/libosmovty.la \ $(top_builddir)/src/gsm/libosmogsm.la \ - $(top_builddir)/src/gb/libosmogb.la + $(top_builddir)/src/gb/libosmogb.la \ + $(LIBRARY_DLSYM) gb_gprs_bssgp_rim_test_SOURCES = gb/gprs_bssgp_rim_test.c -gb_gprs_bssgp_rim_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DLSYM) \ - $(top_builddir)/src/gb/libosmogb.la +gb_gprs_bssgp_rim_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la \ + $(top_builddir)/src/gb/libosmogb.la \ + $(LIBRARY_DLSYM) gb_gprs_ns_test_SOURCES = gb/gprs_ns_test.c -gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DLSYM) \ +gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la \ $(top_builddir)/src/vty/libosmovty.la \ - $(top_builddir)/src/gsm/libosmogsm.la + $(top_builddir)/src/gsm/libosmogsm.la \ + $(LIBRARY_DLSYM) gb_gprs_ns2_test_SOURCES = gb/gprs_ns2_test.c -gb_gprs_ns2_test_LDADD = $(LDADD) $(LIBRARY_DLSYM) \ +gb_gprs_ns2_test_LDADD = $(LDADD) \ $(top_builddir)/src/vty/libosmovty.la \ $(top_builddir)/src/gsm/libosmogsm.la \ $(top_builddir)/src/core/libosmocore.la \ - $(top_builddir)/src/gb/libosmogb-test.la + $(top_builddir)/src/gb/libosmogb-test.la \ + $(LIBRARY_DLSYM) logging_logging_test_SOURCES = logging/logging_test.c @@ -228,9 +232,10 @@ vty_vty_transcript_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la fr_fr_test_SOURCES = fr/fr_test.c -fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DLSYM) \ +fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la \ $(top_builddir)/src/vty/libosmovty.la \ - $(top_builddir)/src/gsm/libosmogsm.la + $(top_builddir)/src/gsm/libosmogsm.la \ + $(LIBRARY_DLSYM) codec_codec_test_SOURCES = codec/codec_test.c codec_codec_test_LDADD = $(LDADD) $(top_builddir)/src/codec/libosmocodec.la -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iad6b9e39e3587849ccfd475899cbd610bf7145cd Gerrit-Change-Number: 31906 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd...
by fixeria 14 Mar '23

14 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31889 ) Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I4f72f4fa80249ed2caafc87b9fdf9926e0f31976 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 7160210..b6e626d 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -759,9 +759,9 @@ LOGP(DPCU, LOGL_NOTICE, "PCU socket has LOST connection\n"); + osmo_fd_unregister(bfd); close(bfd->fd); bfd->fd = -1; - osmo_fd_unregister(bfd); /* re-enable the generation of ACCEPT for new connections */ osmo_fd_read_enable(&state->listen_bfd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4f72f4fa80249ed2caafc87b9fdf9926e0f31976 Gerrit-Change-Number: 31889 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd...
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31889 ) Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4f72f4fa80249ed2caafc87b9fdf9926e0f31976 Gerrit-Change-Number: 31889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:56:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd...
by fixeria 14 Mar '23

14 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31891 ) Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I692bbb5b7c06b5528a36c09a99a7580cbafa3cc0 --- M src/common/pcu_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 849f3c3..145942b 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -999,9 +999,9 @@ bts->pcu_version[0] = '\0'; + osmo_fd_unregister(bfd); close(bfd->fd); bfd->fd = -1; - osmo_fd_unregister(bfd); /* patch SI3 to remove GPRS indicator */ regenerate_si3_restoctets(bts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I692bbb5b7c06b5528a36c09a99a7580cbafa3cc0 Gerrit-Change-Number: 31891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd...
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31891 ) Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I692bbb5b7c06b5528a36c09a99a7580cbafa3cc0 Gerrit-Change-Number: 31891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:56:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: ipa: Call osmo_fd_unregister() before closing and changing bfd->fd
by fixeria 14 Mar '23

14 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31895 ) Change subject: ipa: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... ipa: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I8bfafe5de3cf194a71fb755c642121cec817aaa3 --- M src/input/ipa.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/input/ipa.c b/src/input/ipa.c index 94e7e5a..2235b39 100644 --- a/src/input/ipa.c +++ b/src/input/ipa.c @@ -561,10 +561,10 @@ * calls again into this destructor */ if (conn->ofd.fd == -1) return; + osmo_fd_unregister(&conn->ofd); close(conn->ofd.fd); conn->ofd.fd = -1; msgb_free(conn->pending_msg); - osmo_fd_unregister(&conn->ofd); if (conn->closed_cb) conn->closed_cb(conn); talloc_free(conn); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8bfafe5de3cf194a71fb755c642121cec817aaa3 Gerrit-Change-Number: 31895 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-abis[master]: ipa: Call osmo_fd_unregister() before closing and changing bfd->fd
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31895 ) Change subject: ipa: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8bfafe5de3cf194a71fb755c642121cec817aaa3 Gerrit-Change-Number: 31895 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:56:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd
by fixeria 14 Mar '23

14 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31894 ) Change subject: mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I26bba0dd092ad5fd6b4959b173fae93b542a93f1 --- M src/mslookup/osmo-mslookup-client.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/mslookup/osmo-mslookup-client.c b/src/mslookup/osmo-mslookup-client.c index d2a629f..37f1256 100644 --- a/src/mslookup/osmo-mslookup-client.c +++ b/src/mslookup/osmo-mslookup-client.c @@ -419,9 +419,9 @@ { struct osmo_fd *ofd = &c->ofd; + osmo_fd_unregister(ofd); close(ofd->fd); ofd->fd = -1; - osmo_fd_unregister(ofd); llist_del(&c->entry); talloc_free(c); @@ -561,9 +561,9 @@ llist_for_each_entry_safe(c, n, &globals.socket_clients, entry) socket_client_close(c); if (osmo_fd_is_registered(&globals.socket_ofd)) { + osmo_fd_unregister(&globals.socket_ofd); close(globals.socket_ofd.fd); globals.socket_ofd.fd = -1; - osmo_fd_unregister(&globals.socket_ofd); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I26bba0dd092ad5fd6b4959b173fae93b542a93f1 Gerrit-Change-Number: 31894 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hlr[master]: mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31894 ) Change subject: mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I26bba0dd092ad5fd6b4959b173fae93b542a93f1 Gerrit-Change-Number: 31894 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:55:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: mncc_sock: Call osmo_fd_unregister() before closing and changing bfd->fd
by pespin 14 Mar '23

14 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31896 ) Change subject: mncc_sock: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... mncc_sock: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I90f840da4cc26c1d970c3f5d18d3185678a1dba9 --- M src/libmsc/mncc_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/libmsc/mncc_sock.c b/src/libmsc/mncc_sock.c index 7c65546..9c75d2c 100644 --- a/src/libmsc/mncc_sock.c +++ b/src/libmsc/mncc_sock.c @@ -71,9 +71,9 @@ LOGP(DMNCC, LOGL_NOTICE, "MNCC Socket has LOST connection\n"); + osmo_fd_unregister(bfd); close(bfd->fd); bfd->fd = -1; - osmo_fd_unregister(bfd); /* re-enable the generation of ACCEPT for new connections */ osmo_fd_read_enable(&state->listen_bfd); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90f840da4cc26c1d970c3f5d18d3185678a1dba9 Gerrit-Change-Number: 31896 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0