March 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmocom-bb[master]: modem: move GRR specific code into its own file
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31654 ) Change subject: modem: move GRR specific code into its own file ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25caa0bd01e3d090803512f5b13cad58439f44f8 Gerrit-Change-Number: 31654 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 14:55:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31914 ) Change subject: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da Gerrit-Change-Number: 31914 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 14:45:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31914 to look at the new patch set (#2). Change subject: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select ...................................................................... {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da --- M src/core/context.c M src/core/select.c 2 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/31914/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da Gerrit-Change-Number: 31914 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31914 ) Change subject: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da Gerrit-Change-Number: 31914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 14:38:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select
by fixeria 14 Mar '23

14 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31914 ) Change subject: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select ...................................................................... {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da --- M src/core/context.c M src/core/select.c 2 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/31914/1 diff --git a/src/core/context.c b/src/core/context.c index 6b58565..125c992 100644 --- a/src/core/context.c +++ b/src/core/context.c @@ -30,8 +30,8 @@ return -ENOMEM; memset(osmo_ctx, 0, sizeof(*osmo_ctx)); osmo_ctx->global = osmo_ctx; - osmo_ctx->select = talloc_named_const(osmo_ctx->global, 0, "select"); - if (!osmo_ctx->select) { + osmo_ctx->select = talloc_named_const(OTC_SELECT, 0, "select"); + if (!OTC_SELECT) { talloc_free(osmo_ctx); return -ENOMEM; } diff --git a/src/core/select.c b/src/core/select.c index c60cd8e..76e9e97 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -451,7 +451,7 @@ if (!_osmo_select_shutdown_requested) osmo_timers_update(); - OSMO_ASSERT(osmo_ctx->select); + OSMO_ASSERT(OTC_SELECT); /* call registered callback functions */ return poll_disp_fds(n_poll); @@ -480,7 +480,7 @@ /* fire timers */ osmo_timers_update(); - OSMO_ASSERT(osmo_ctx->select); + OSMO_ASSERT(OTC_SELECT); /* call registered callback functions */ return osmo_fd_disp_fds(&readset, &writeset, &exceptset); @@ -495,7 +495,7 @@ { int rc = _osmo_select_main(polling); #ifndef EMBEDDED - if (talloc_total_size(osmo_ctx->select) != 0) { + if (talloc_total_size(OTC_SELECT) != 0) { osmo_panic("You cannot use the 'select' volatile " "context if you don't use osmo_select_main_ctx()!\n"); } @@ -512,7 +512,7 @@ { int rc = _osmo_select_main(polling); /* free all the children of the volatile 'select' scope context */ - talloc_free_children(osmo_ctx->select); + talloc_free_children(OTC_SELECT); return rc; } #endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da Gerrit-Change-Number: 31914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: on_dso_load_select: run after on_dso_load_ctx
by osmith 14 Mar '23

14 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31911 to look at the new patch set (#3). Change subject: on_dso_load_select: run after on_dso_load_ctx ...................................................................... on_dso_load_select: run after on_dso_load_ctx Add priorities to ensure on_dso_load_select runs after on_dso_load_ctx. Otherwise osmo_ctx->global (used via define OTC_GLOBAL) points to NULL and causes a segfault in osmo_fd_lookup_table_extend. Use numbers 101 and 102, as "0 to 100 are reserved for the implementation" and cause an error from GCC. Fixes: OS#5946 Fixes: c46a15d8 ("select: Optimize osmo_fd_get_by_fd") Change-Id: Ia2518e82530b93c535f8f5105513e21559b895ba --- M src/core/context.c M src/core/select.c 2 files changed, 22 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/31911/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2518e82530b93c535f8f5105513e21559b895ba Gerrit-Change-Number: 31911 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: tests/llc: local libs must be first in *_LDADD
by fixeria 14 Mar '23

14 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 ) Change subject: tests/llc: local libs must be first in *_LDADD ...................................................................... tests/llc: local libs must be first in *_LDADD Otherwise the linker may pick system-installed libs instead. Change-Id: If5299340ad72407d01e728febf356a07a1d99681 --- M tests/llc/Makefile.am 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/llc/Makefile.am b/tests/llc/Makefile.am index ca0ed1d..341bf00 100644 --- a/tests/llc/Makefile.am +++ b/tests/llc/Makefile.am @@ -32,30 +32,30 @@ llc_test_SOURCES = llc_test.c llc_test_LDADD = \ + $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(NULL) llc_prim_test_SOURCES = llc_prim_test.c llc_prim_test_LDADD = \ + $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(NULL) pdu_codec_test_SOURCES = pdu_codec_test.c # libosmo-gprs-llc.a is used below to access non-exported private symbols used in the test: pdu_codec_test_LDADD = \ + $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(NULL) xid_codec_test_SOURCES = xid_codec_test.c # libosmo-gprs-llc.a is used below to access non-exported private symbols used in the test: xid_codec_test_LDADD = \ + $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If5299340ad72407d01e728febf356a07a1d99681 Gerrit-Change-Number: 31774 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: tests/llc: local libs must be first in *_LDADD
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 ) Change subject: tests/llc: local libs must be first in *_LDADD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If5299340ad72407d01e728febf356a07a1d99681 Gerrit-Change-Number: 31774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 14:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: rsl: remove redundant gsm_lchan_name() in rsl_tx_rf_rel_ack()
by fixeria 14 Mar '23

14 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31912 ) Change subject: rsl: remove redundant gsm_lchan_name() in rsl_tx_rf_rel_ack() ...................................................................... rsl: remove redundant gsm_lchan_name() in rsl_tx_rf_rel_ack() Change-Id: I69dc11c66a774ddb7364d6ecd9bdb2e94e6cad66 --- M src/common/rsl.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/31912/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index 2e6e512..c7061b2 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1295,7 +1295,7 @@ } if (!send_rel_ack) { - LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "%s not sending REL ACK\n", gsm_lchan_name(lchan)); + LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "not sending REL ACK\n"); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69dc11c66a774ddb7364d6ecd9bdb2e94e6cad66 Gerrit-Change-Number: 31912 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: rsl: reduce logging verbosity on some messages
by fixeria 14 Mar '23

14 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31913 ) Change subject: rsl: reduce logging verbosity on some messages ...................................................................... rsl: reduce logging verbosity on some messages These two messages indicate that no ACK/NACK message is going to be sent to the BSC because activation/deactivation was requested by the PCU. This is absolutely normal and requires no attention from the user/operator, so better use LOGL_INFO. Change-Id: I6eaf3a6c07fb30b31c045729c935c8ad6735e5c8 --- M src/common/rsl.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/31913/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index c7061b2..c537998 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1295,7 +1295,7 @@ } if (!send_rel_ack) { - LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "not sending REL ACK\n"); + LOGPLCHAN(lchan, DRSL, LOGL_INFO, "not sending REL ACK\n"); return 0; } @@ -1386,7 +1386,7 @@ int rsl_tx_chan_act_acknack(struct gsm_lchan *lchan, uint8_t cause) { if (lchan->rel_act_kind != LCHAN_REL_ACT_RSL) { - LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "not sending CHAN ACT %s\n", + LOGPLCHAN(lchan, DRSL, LOGL_INFO, "not sending CHAN ACT %s\n", cause ? "NACK" : "ACK"); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6eaf3a6c07fb30b31c045729c935c8ad6735e5c8 Gerrit-Change-Number: 31913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0