pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31900 ) Change subject: server: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... server: Call osmo_fd_unregister() before closing and changing bfd->fd Change-Id: I44405687dae79a13db5617867c669ee4840485ba --- M src/osmo_server_network.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index 025f560..b566bd2 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -130,10 +130,10 @@ static void close_connection(struct osmo_pcap_conn *conn) { if (conn->rem_wq.bfd.fd >= 0) { + osmo_fd_unregister(&conn->rem_wq.bfd); close(conn->rem_wq.bfd.fd); conn->rem_wq.bfd.fd = -1; osmo_tls_release(&conn->tls_session); - osmo_fd_unregister(&conn->rem_wq.bfd); } osmo_pcap_server_close_trace(conn); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I44405687dae79a13db5617867c669ee4840485ba Gerrit-Change-Number: 31900 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged