March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: bsc_subscriber: Introduce bsc_subscriber_store object
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31874 ) Change subject: bsc_subscriber: Introduce bsc_subscriber_store object ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I616e8872af4ac63a6985f8900909e324ba889192 Gerrit-Change-Number: 31874 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:42:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: configure.ac: Fix typo in enable flag description
by pespin 14 Mar '23

14 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31905 ) Change subject: configure.ac: Fix typo in enable flag description ...................................................................... configure.ac: Fix typo in enable flag description Change-Id: Ida390c50379a429a4b42434e32954eeb832a11ff --- M configure.ac 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/31905/1 diff --git a/configure.ac b/configure.ac index 478da9b..5e17c7a 100644 --- a/configure.ac +++ b/configure.ac @@ -312,7 +312,7 @@ )], [force_io_select=$enableval], [force_io_select="no"]) AS_IF([test "x$force_io_select" = "xyes"], [ - AC_DEFINE([FORCE_IO_SELECT], [1], [Force the use of select() instaed of poll()]) + AC_DEFINE([FORCE_IO_SELECT], [1], [Force the use of select() instead of poll()]) ]) AC_ARG_ENABLE(msgfile, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida390c50379a429a4b42434e32954eeb832a11ff Gerrit-Change-Number: 31905 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: configure.ac: Fix logic enabling osmo_fd fd checks
by pespin 14 Mar '23

14 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31904 ) Change subject: configure.ac: Fix logic enabling osmo_fd fd checks ...................................................................... configure.ac: Fix logic enabling osmo_fd fd checks The logic testing the and setting the define was inverted, which made it enabled by default. Take the chance to rename the enable flag to be "ofd" instead of "bsc-fd" (since anyway the flag was broken). Change-Id: I81112fa1f6ce1a8e5fe85468241ad385ed8805d3 --- M configure.ac 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/31904/1 diff --git a/configure.ac b/configure.ac index 108c0a1..478da9b 100644 --- a/configure.ac +++ b/configure.ac @@ -296,13 +296,13 @@ AC_ARG_ENABLE(bsc_fd_check, [AS_HELP_STRING( - [--enable-bsc-fd-check], + [--enable-ofd-check], [Instrument osmo_fd_register to check that the fd is registered] )], [fd_check=$enableval], [fd_check="no"]) -if test x"$fd_check" = x"no" +if test x"$fd_check" = x"yes" then - AC_DEFINE([OSMO_FD_CHECK],[1],[Instrument the osmo_fd_register]) + AC_DEFINE([OSMO_FD_CHECK], [1], [Instrument the osmo_fd_register]) fi AC_ARG_ENABLE([force_io_select], -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81112fa1f6ce1a8e5fe85468241ad385ed8805d3 Gerrit-Change-Number: 31904 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: bsc_subscriber: Mark functions used only internally as static
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31870 ) Change subject: bsc_subscriber: Mark functions used only internally as static ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I846af993905aee0be75aa3021460b130362c6d3d Gerrit-Change-Number: 31870 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:39:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bsc[master]: Optimize subscr_conns lookup
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: laforge, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31866 ) Change subject: Optimize subscr_conns lookup ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bsc_sccp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31866/comment/6cb1f1ca_4d43b782 PS2, Line 47: OSMO_ASSERT(conn_id != SCCP_CONN_ID_UNSET); while unlikely, as I understand it can still happen that all IDs are exhausted and we end up with UNSET, right? maybe reject the connection instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I667d3ec1dad0ab7bc0fa4799d9611f3a914d07e5 Gerrit-Change-Number: 31866 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: select.c: Clarify osmo_fd_unregister() can only be called on register...
by pespin 14 Mar '23

14 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31902 ) Change subject: select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds ...................................................................... Patch Set 1: (1 comment) File src/core/select.c: https://gerrit.osmocom.org/c/libosmocore/+/31902/comment/40f85906_874e085a PS1, Line 215: from > for Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 Gerrit-Change-Number: 31902 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: select.c: Clarify osmo_fd_unregister() can only be called on register...
by pespin 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31902 to look at the new patch set (#2). Change subject: select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds ...................................................................... select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 --- M src/core/select.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/31902/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 Gerrit-Change-Number: 31902 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: select.c: osmo_fd_unregister(): Avoid assert hit with old buggy users...
by pespin 14 Mar '23

14 Mar '23

Attention is currently required from: osmith, laforge, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31903 ) Change subject: select.c: osmo_fd_unregister(): Avoid assert hit with old buggy users of the API ...................................................................... Patch Set 2: (1 comment) File src/core/select.c: https://gerrit.osmocom.org/c/libosmocore/+/31903/comment/0d50a809_59f62352 PS2, Line 234: fprintf(stderr, "osmo_fd_unregister(fd=%u) out of expected range (0..%u), fix your code!!!\n", > why printf and not an osmocom error log message? I didn't find any osmocom log function here, only fprintf, so I assumed we want to keep osmo_log outside of all this low level code. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If77b84d603a42a216d550d9708eb62f645634a61 Gerrit-Change-Number: 31903 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: select.c: Clarify osmo_fd_unregister() can only be called on register...
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31902 ) Change subject: select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 Gerrit-Change-Number: 31902 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:25:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: select.c: Clarify osmo_fd_unregister() can only be called on register...
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31902 ) Change subject: select.c: Clarify osmo_fd_unregister() can only be called on registered osmo_fds ...................................................................... Patch Set 1: (1 comment) File src/core/select.c: https://gerrit.osmocom.org/c/libosmocore/+/31902/comment/57de735b_c0b37f83 PS1, Line 215: from for -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e397e121f2fe2254c7f4b474e6eefd7aebe7a83 Gerrit-Change-Number: 31902 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 11:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0