March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: build/graphviz-filter.conf: add config for svgs
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31958 ) Change subject: build/graphviz-filter.conf: add config for svgs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iee54012c41f554608b0915d707f7cf64bfbdc418 Gerrit-Change-Number: 31958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:58:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: build/{diag,mscgen}-filter.conf: png -> svg
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31957 ) Change subject: build/{diag,mscgen}-filter.conf: png -> svg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I24f345a19adbc5abe41737233f89916996569ea8 Gerrit-Change-Number: 31957 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:57:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: Cosmetic: build/Makefile.common.inc: add comments
by osmith 17 Mar '23

17 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31959 ) Change subject: Cosmetic: build/Makefile.common.inc: add comments ...................................................................... Cosmetic: build/Makefile.common.inc: add comments Describe what upload and publish do, it's not clear from the name of these make targets. Related: SYS#6380 Change-Id: Ic2ab9df2192912d20ede0241abe01e8d26a9afcc --- M build/Makefile.common.inc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/59/31959/1 diff --git a/build/Makefile.common.inc b/build/Makefile.common.inc index 2bbd324..a53e26e 100644 --- a/build/Makefile.common.inc +++ b/build/Makefile.common.inc @@ -20,6 +20,7 @@ $(SYMLINKS): ln -s $(OSMO_GSM_MANUALS_DIR)/$@ $@ +# Publish to $UPLOAD_PATH upload: $(UPLOAD_FILES) rsync -avz $(UPLOAD_FILES) $(UPLOAD_PATH)/ @@ -28,6 +29,7 @@ distclean: clean +# Publish to https://ftp.osmocom.org/docs/ publish: $(UPLOAD_FILES) [ -n "$(OSMO_REPOSITORY)" ] || exit 1 rm -rf "$(PUBLISH_TEMPDIR)" -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic2ab9df2192912d20ede0241abe01e8d26a9afcc Gerrit-Change-Number: 31959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-manuals[master]: build/{diag,mscgen}-filter.conf: png -> svg
by osmith 17 Mar '23

17 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31957 ) Change subject: build/{diag,mscgen}-filter.conf: png -> svg ...................................................................... build/{diag,mscgen}-filter.conf: png -> svg Generate svgs instead of pngs. Vector graphics have smaller file size and don't look blurry when zooming into them. Related: SYS#6380 Change-Id: I24f345a19adbc5abe41737233f89916996569ea8 --- M build/diag-filter.conf M build/mscgen-filter.conf 2 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/57/31957/1 diff --git a/build/diag-filter.conf b/build/diag-filter.conf index 0c30db7..cc6b941 100644 --- a/build/diag-filter.conf +++ b/build/diag-filter.conf @@ -3,7 +3,7 @@ # [seqdiag-filter-style] -seqdiag-style=template="seqdiag-block",subs=(),posattrs=("style","target"),filter='seqdiag -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!png}{basebackend-docbook?png}} - && echo " "' +seqdiag-style=template="seqdiag-block",subs=(),posattrs=("style","target"),filter='seqdiag -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!svg}{basebackend-docbook?svg}} - && echo " "' [blockdef-listing] template::[seqdiag-filter-style] @@ -16,12 +16,12 @@ [filter-diag-pngsvg-blockmacro] {target%}{counter2:target-number} -{target%}{set2:target:{docname}__{target-number}.{format={basebackend-docbook!png}{basebackend-docbook?png}}} +{target%}{set2:target:{docname}__{target-number}.{format={basebackend-docbook!svg}{basebackend-docbook?svg}}} | template::[image-blockmacro] [blockdiag-filter-style] -blockdiag-style=template="blockdiag-block",subs=(),posattrs=("style","target"),filter='blockdiag -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!png}{basebackend-docbook?png}} - && echo " "' +blockdiag-style=template="blockdiag-block",subs=(),posattrs=("style","target"),filter='blockdiag -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!svg}{basebackend-docbook?svg}} - && echo " "' [blockdef-listing] template::[blockdiag-filter-style] @@ -35,7 +35,7 @@ [actdiag-filter-style] -actdiag-style=template="actdiag-block",subs=(),posattrs=("style","target"),filter='actdiag -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!png}{basebackend-docbook?png}} - && echo " "' +actdiag-style=template="actdiag-block",subs=(),posattrs=("style","target"),filter='actdiag -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!svg}{basebackend-docbook?svg}} - && echo " "' [blockdef-listing] template::[actdiag-filter-style] @@ -49,7 +49,7 @@ [nwdiag-filter-style] -nwdiag-style=template="nwdiag-block",subs=(),posattrs=("style","target"),filter='nwdiag3 -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!png}{basebackend-docbook?png}} - && echo " "' +nwdiag-style=template="nwdiag-block",subs=(),posattrs=("style","target"),filter='nwdiag3 -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!svg}{basebackend-docbook?svg}} - && echo " "' [blockdef-listing] template::[nwdiag-filter-style] @@ -62,7 +62,7 @@ [packetdiag-filter-style] -packetdiag-style=template="packetdiag-block",subs=(),posattrs=("style","target"),filter='packetdiag3 -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!png}{basebackend-docbook?png}} - && echo " "' +packetdiag-style=template="packetdiag-block",subs=(),posattrs=("style","target"),filter='packetdiag3 -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!svg}{basebackend-docbook?svg}} - && echo " "' [blockdef-listing] template::[packetdiag-filter-style] diff --git a/build/mscgen-filter.conf b/build/mscgen-filter.conf index fa8f03e..0e6cfa0 100644 --- a/build/mscgen-filter.conf +++ b/build/mscgen-filter.conf @@ -4,7 +4,7 @@ # [mscgen-filter-style] -mscgen-style=template="mscgen-block",subs=(),posattrs=("style","target"),filter='./build/filter-wrapper.py mscgen -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!png}{basebackend-docbook?png}} -' +mscgen-style=template="mscgen-block",subs=(),posattrs=("style","target"),filter='./build/filter-wrapper.py mscgen -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T{format={basebackend-docbook!svg}{basebackend-docbook?svg}} -' [blockdef-listing] template::[mscgen-filter-style] @@ -17,7 +17,7 @@ [filter-image-pngsvg-blockmacro] {target%}{counter2:target-number} -{target%}{set2:target:{docname}__{target-number}.{format={basebackend-docbook!png}{basebackend-docbook?png}}} +{target%}{set2:target:{docname}__{target-number}.{format={basebackend-docbook!svg}{basebackend-docbook?svg}}} | template::[image-blockmacro] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I24f345a19adbc5abe41737233f89916996569ea8 Gerrit-Change-Number: 31957 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-manuals[master]: build/Makefile.common: move clean/distclean down
by osmith 17 Mar '23

17 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31960 ) Change subject: build/Makefile.common: move clean/distclean down ...................................................................... build/Makefile.common: move clean/distclean down Group upload and publish closer together by moving the clean targets to the bottom. Related: SYS#6380 Change-Id: Id8b6ead89a2aeba28e9c55bcfde6564376e8418a --- M build/Makefile.common.inc 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/60/31960/1 diff --git a/build/Makefile.common.inc b/build/Makefile.common.inc index a53e26e..bdc3817 100644 --- a/build/Makefile.common.inc +++ b/build/Makefile.common.inc @@ -24,11 +24,6 @@ upload: $(UPLOAD_FILES) rsync -avz $(UPLOAD_FILES) $(UPLOAD_PATH)/ -clean: - -rm -rf $(CLEAN_FILES) - -distclean: clean - # Publish to https://ftp.osmocom.org/docs/ publish: $(UPLOAD_FILES) [ -n "$(OSMO_REPOSITORY)" ] || exit 1 @@ -64,3 +59,8 @@ rm -v "$(DESTDIR)$(prefix)/share/doc/$(OSMO_REPOSITORY)-doc/$$i"; \ done; \ fi + +clean: + -rm -rf $(CLEAN_FILES) + +distclean: clean -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id8b6ead89a2aeba28e9c55bcfde6564376e8418a Gerrit-Change-Number: 31960 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-manuals[master]: build/graphviz-filter.conf: add config for svgs
by osmith 17 Mar '23

17 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31958 ) Change subject: build/graphviz-filter.conf: add config for svgs ...................................................................... build/graphviz-filter.conf: add config for svgs Add a custom graphviz-filter.conf, so asciidoc instructs graphviz to generate svgs. Related: SYS#6380 Change-Id: Iee54012c41f554608b0915d707f7cf64bfbdc418 --- M build/Makefile.asciidoc.inc A build/graphviz-filter.conf 2 files changed, 45 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/58/31958/1 diff --git a/build/Makefile.asciidoc.inc b/build/Makefile.asciidoc.inc index 1b7375e..848f1f1 100644 --- a/build/Makefile.asciidoc.inc +++ b/build/Makefile.asciidoc.inc @@ -38,7 +38,14 @@ UPLOAD_FILES += $(ASCIIDOC_PDF) ABS_SRCDIR := $(or $(abs_srcdir),$(shell realpath $(srcdir))) -ASCIIDOC_OPTS := -f $(BUILDDIR)/mscgen-filter.conf -f $(BUILDDIR)/diag-filter.conf -f $(BUILDDIR)/docinfo-releaseinfo.conf -a srcdir='$(ABS_SRCDIR)' -a commondir='$(COMMONDIR)' +ASCIIDOC_OPTS := \ + -f $(BUILDDIR)/mscgen-filter.conf \ + -f $(BUILDDIR)/diag-filter.conf \ + -f $(BUILDDIR)/docinfo-releaseinfo.conf \ + -f $(BUILDDIR)/graphviz-filter.conf \ + -a srcdir='$(ABS_SRCDIR)' \ + -a commondir='$(COMMONDIR)' \ + $(NULL) DBLATEX_OPTS := -s $(ASCIIDOCSTYLE) -P draft.mode=yes -P draft.watermark=0 ifeq (,$(BUILD_RELEASE)) diff --git a/build/graphviz-filter.conf b/build/graphviz-filter.conf new file mode 100644 index 0000000..bf32927 --- /dev/null +++ b/build/graphviz-filter.conf @@ -0,0 +1,24 @@ +# +# AsciiDoc Graphviz filter configuration file. +# + +[graphviz-filter-style] +graphviz-style=template="graphviz{format?-{format}}-block",subs=(),posattrs=("style","target","layout","format"),filter='dot -o "{outdir={indir}}/{imagesdir=}{imagesdir?/}{target}" -T {format=svg} && echo " "' + +[blockdef-open] +template::[graphviz-filter-style] + +[blockdef-listing] +template::[graphviz-filter-style] + +[paradef-default] +template::[graphviz-filter-style] + +[graphviz-block] +template::[filter-image-svgblockmacro] + +[filter-image-svgblockmacro] +{target%}{counter2:target-number} +{target%}{set2:target:{docname}__{target-number}.svg} +| +template::[image-blockmacro] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iee54012c41f554608b0915d707f7cf64bfbdc418 Gerrit-Change-Number: 31958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-manuals[master]: build/Makefile.common: shrink pdfs before publish
by osmith 17 Mar '23

17 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31961 ) Change subject: build/Makefile.common: shrink pdfs before publish ...................................................................... build/Makefile.common: shrink pdfs before publish Closes: SYS#6380 Change-Id: I7c01b1cb1a0e7de385359671461a0ad142dfa5ad --- M build/Makefile.common.inc A build/shrink-pdfs.sh 2 files changed, 46 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/61/31961/1 diff --git a/build/Makefile.common.inc b/build/Makefile.common.inc index bdc3817..9e79621 100644 --- a/build/Makefile.common.inc +++ b/build/Makefile.common.inc @@ -9,8 +9,9 @@ SSH_COMMAND = ssh -o 'UserKnownHostsFile=$(OSMO_GSM_MANUALS_DIR)/build/known_hosts' -p 48 UPLOAD_PATH ?= generic@sysmocom-downloads:documents SYMLINKS = common build -CLEAN_FILES += $(SYMLINKS) +CLEAN_FILES += $(SYMLINKS) $(SHRINK_MARKER) PDF_FILES = $(patsubst %.adoc,%.pdf,$(ASCIIDOC)) $(patsubst %.xml,%.pdf,$(VTY_REFERENCE)) +SHRINK_MARKER = generated/.pdf_shrink_marker PUBLISH_REF ?= master PUBLISH_TEMPDIR = _publish_tmpdir @@ -20,12 +21,17 @@ $(SYMLINKS): ln -s $(OSMO_GSM_MANUALS_DIR)/$@ $@ +# Reduce pdf size by storing the embedded images with less quality (SYS#6380) +shrink: $(SHRINK_MARKER) +$(SHRINK_MARKER): $(UPLOAD_FILES) + build/shrink-pdfs.sh $(UPLOAD_FILES) + # Publish to $UPLOAD_PATH -upload: $(UPLOAD_FILES) +upload: shrink rsync -avz $(UPLOAD_FILES) $(UPLOAD_PATH)/ # Publish to https://ftp.osmocom.org/docs/ -publish: $(UPLOAD_FILES) +publish: shrink [ -n "$(OSMO_REPOSITORY)" ] || exit 1 rm -rf "$(PUBLISH_TEMPDIR)" mkdir -p "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" diff --git a/build/shrink-pdfs.sh b/build/shrink-pdfs.sh new file mode 100755 index 0000000..a919ac3 --- /dev/null +++ b/build/shrink-pdfs.sh @@ -0,0 +1,27 @@ +#!/bin/sh -e +# Reduce pdf size by storing the embedded images with less quality (SYS#6380) +# usage: shrink-pdfs.sh first.pdf [second.pdf [...]] +mkdir -p generated + +for i in $@; do + out="generated/shrink_temp.pdf" + ps2pdf -dPDFSETTINGS=/ebook "$i" "$out" + + size_old=$(du "$i" | cut -f1) + size_old_h=$(du -h "$i" | cut -f1) + size_new=$(du "$out" | cut -f1) + size_new_h=$(du -h "$out" | cut -f1) + + if [ "$size_new" -lt "$size_old" ]; then + echo "* $i: $size_new_h (shrunk from $size_old_h)" + mv "$out" "$i" + else + echo "* $i: $size_old_h" + rm "$out" + fi +done + +# Add a marker so the Makefile knows that the shrink script ran. The generated +# dir is already in the gitignore files of repositories using osmo-gsm-manuals, +# so put it there. +touch generated/.pdf_shrink_marker -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I7c01b1cb1a0e7de385359671461a0ad142dfa5ad Gerrit-Change-Number: 31961 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: obs: srcpkg.build: fix conflict_version regression
by osmith 17 Mar '23

17 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31956 ) Change subject: obs: srcpkg.build: fix conflict_version regression ...................................................................... obs: srcpkg.build: fix conflict_version regression During refactoring, conflict_version was changed to version here, which was wrong. The packages need to depend on the conflict_version of the meta package, version is the version of the package itself. Fix for: The following packages have unmet dependencies: libosmo-netif-dev : Depends: osmocom-nightly (= 202303160009) but it is not going to be installed Depends: libosmocore but it is not going to be installed Depends: libosmonetif11 (= 1.3.0.8.9e65.202303160009) but it is not going to be installed libosmocore-dev : Depends: osmocom-nightly (= 1.8.0.79-b394d.202303170006) but it is not going to be installed Depends: libosmocore but it is not going to be installed Fixes: 0ed0e464 ("obs: don't pass conflict_version through functions") Change-Id: I2326e3817c6f6887ef1196e603c3877768119a66 --- M scripts/obs/lib/srcpkg.py 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index b230353..5dbc862 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -134,6 +134,7 @@ def build(project, gerrit_id=0): + conflict_version = lib.args.conflict_version feed = lib.args.feed lib.git.clone(project) lib.git.clean(project) @@ -151,9 +152,9 @@ if project in lib.config.projects_osmocom: metapkg = f"osmocom-{feed}" - lib.debian.control_add_depend(project, metapkg, version) + lib.debian.control_add_depend(project, metapkg, conflict_version) if has_rpm_spec: - lib.rpm_spec.add_depend(project, metapkg, version) + lib.rpm_spec.add_depend(project, metapkg, conflict_version) lib.debian.changelog_add_entry_if_needed(project, version_epoch) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2326e3817c6f6887ef1196e603c3877768119a66 Gerrit-Change-Number: 31956 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: obs: srcpkg.build: fix conflict_version regression
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31956 ) Change subject: obs: srcpkg.build: fix conflict_version regression ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2326e3817c6f6887ef1196e603c3877768119a66 Gerrit-Change-Number: 31956 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy()
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31955 ) Change subject: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04a86c1e00fc0a4066564693f6b563c88bf4e46f Gerrit-Change-Number: 31955 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:41:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0