March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: fix bs11_read_swl_file(): properly clean up stale file list
by fixeria 17 Mar '23

17 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31939 ) Change subject: fix bs11_read_swl_file(): properly clean up stale file list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5eaa328aaf6881ae9621ca14859e4e255af2b00 Gerrit-Change-Number: 31939 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 09:58:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: fix bs11_read_swl_file(): properly clean up stale file list
by osmith 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31939 ) Change subject: fix bs11_read_swl_file(): properly clean up stale file list ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5eaa328aaf6881ae9621ca14859e4e255af2b00 Gerrit-Change-Number: 31939 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 09:50:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: fix ipacc_rtp_csd_fmt_non_transp(): add missing breaks
by osmith 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31953 ) Change subject: fix ipacc_rtp_csd_fmt_non_transp(): add missing breaks ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I13adcabd26c5f6543681e418b87c70b2822e7dcf Gerrit-Change-Number: 31953 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 09:49:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: modem: fix modem_gmm_prim_up_cb(): add missing break
by osmith 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31951 ) Change subject: modem: fix modem_gmm_prim_up_cb(): add missing break ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibd16232d76d83d90f27d08b47aa38509161270b6 Gerrit-Change-Number: 31951 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 09:48:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23/{mobile,modem}: prefix VTY prompt with project's name
by osmith 17 Mar '23

17 Mar '23

Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31946 ) Change subject: layer23/{mobile,modem}: prefix VTY prompt with project's name ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If7ce89362c75e2c15995dfb08cfcfdcad24e2529 Gerrit-Change-Number: 31946 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 09:48:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: fix ipacc_rtp_csd_fmt_non_transp(): add missing breaks
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31953 ) Change subject: fix ipacc_rtp_csd_fmt_non_transp(): add missing breaks ...................................................................... fix ipacc_rtp_csd_fmt_non_transp(): add missing breaks Change-Id: I13adcabd26c5f6543681e418b87c70b2822e7dcf Fixes: CID#310964, CID#310965, CID#310967 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/53/31953/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 8e89508..1880996 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2624,13 +2624,16 @@ case RSL_CMOD_CSD_NTA_29k0_43k5: case RSL_CMOD_CSD_NT_43k5: ret |= RSL_IPAC_RTP_CSD_IR_64k << 5; + break; case RSL_CMOD_CSD_NTA_29k0_14k5: case RSL_CMOD_CSD_NTA_14k5_29k0: case RSL_CMOD_CSD_NT_28k8: ret |= RSL_IPAC_RTP_CSD_IR_32k << 5; + break; case RSL_CMOD_CSD_NT_14k5: case RSL_CMOD_CSD_NT_12k0: ret |= RSL_IPAC_RTP_CSD_IR_16k << 5; + break; case RSL_CMOD_CSD_NT_6k0: ret |= RSL_IPAC_RTP_CSD_IR_8k << 5; break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I13adcabd26c5f6543681e418b87c70b2822e7dcf Gerrit-Change-Number: 31953 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: tests/v110: assert(user_data_chunk_bits) in test_ra1()
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31952 ) Change subject: tests/v110: assert(user_data_chunk_bits) in test_ra1() ...................................................................... tests/v110: assert(user_data_chunk_bits) in test_ra1() Coverity warns that osmo_v110_sync_ra1_get_user_data_chunk_bitlen() may return a negative value, which is used as loop boundary. Even though this is unlikely, let's add an assert(). Change-Id: I0fc0e0bac74bd96351030432ef1b140b727acb0d Fixes: CID#310968 --- M tests/v110/test_ra1.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/52/31952/1 diff --git a/tests/v110/test_ra1.c b/tests/v110/test_ra1.c index 775ec4b..48db553 100644 --- a/tests/v110/test_ra1.c +++ b/tests/v110/test_ra1.c @@ -10,7 +10,7 @@ static void test_ra1(enum osmo_v100_sync_ra1_rate rate) { int user_rate = osmo_v110_sync_ra1_get_user_data_rate(rate); - int user_data_chunk_bits = osmo_v110_sync_ra1_get_user_data_chunk_bitlen(rate); + int user_data_chunk_bits; struct osmo_v110_decoded_frame fr; ubit_t user_bits[48]; ubit_t bits[80]; @@ -19,6 +19,9 @@ printf("\n======= User data rate %u\n", user_rate); + user_data_chunk_bits = osmo_v110_sync_ra1_get_user_data_chunk_bitlen(rate); + OSMO_ASSERT(user_data_chunk_bits >= 0); + /* we abuse the fact that ubit_t is 8bit so we can actually * store integer values to clearly identify which bit ends up where */ memset(user_bits, 0xFE, sizeof(user_bits)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fc0e0bac74bd96351030432ef1b140b727acb0d Gerrit-Change-Number: 31952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: modem: fix modem_gmm_prim_up_cb(): add missing break
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31951 ) Change subject: modem: fix modem_gmm_prim_up_cb(): add missing break ...................................................................... modem: fix modem_gmm_prim_up_cb(): add missing break Change-Id: Ibd16232d76d83d90f27d08b47aa38509161270b6 Fixes: CID#311019 --- M src/host/layer23/src/modem/gmm.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/51/31951/1 diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 6a84909..3488162 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -58,6 +58,7 @@ LOGP(DGMM, LOGL_ERROR, "%s(): Rx %s UNIMPLEMENTED\n", __func__, pdu_name); break; }; + break; default: LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s\n", __func__, pdu_name); OSMO_ASSERT(0); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibd16232d76d83d90f27d08b47aa38509161270b6 Gerrit-Change-Number: 31951 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: layer23/{mobile,modem}: prefix VTY prompt with project's name
by fixeria 17 Mar '23

17 Mar '23

Attention is currently required from: osmith, laforge, pespin. Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31946 to look at the new patch set (#4). Change subject: layer23/{mobile,modem}: prefix VTY prompt with project's name ...................................................................... layer23/{mobile,modem}: prefix VTY prompt with project's name Change-Id: If7ce89362c75e2c15995dfb08cfcfdcad24e2529 --- M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/modem/app_modem.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/46/31946/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If7ce89362c75e2c15995dfb08cfcfdcad24e2529 Gerrit-Change-Number: 31946 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: rlcmac: do not attempt to decode PTCCH/D blocks, discard them
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31950 ) Change subject: rlcmac: do not attempt to decode PTCCH/D blocks, discard them ...................................................................... rlcmac: do not attempt to decode PTCCH/D blocks, discard them PTCCH/D blocks use different encoding than PDTCH/D blocks, and passing them to gprs_rlcmac_handle_gprs_dl_block() results in decoding errors: DRLCMAC NOTICE rlcmac.c:496 Failed decoding dl ctrl block: 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 2b 2b 2b 2b 2b 2b 2b We don't implement PTCCH yet, so discard these blocks starting at Fn=12 within the period of 104 frames (see 3GPP 45.002, table 6). Change-Id: I555004987cf2daa995b9ea21c90ac699199c4e9a --- M src/rlcmac/rlcmac_prim.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/50/31950/1 diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index 4bcd925..8f27ff7 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -491,6 +491,12 @@ return -EINVAL; } + /* TODO: handle PTCCH/D (Packet Timing Control CHannel) blocks */ + if ((rlcmac_prim->l1ctl.pdch_data_ind.fn % 104) == 12) { + LOGRLCMAC(LOGL_DEBUG, "Dropping PTCCH/D block (not implemented)\n"); + return 0; + } + if (gprs_rlcmac_mcs_is_gprs(cs)) return gprs_rlcmac_handle_gprs_dl_block(rlcmac_prim, cs); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I555004987cf2daa995b9ea21c90ac699199c4e9a Gerrit-Change-Number: 31950 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0