March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass()
by fixeria 17 Mar '23

17 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31949 to look at the new patch set (#2). Change subject: rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() ...................................................................... rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() The TIMESLOT_ALLOCATION is a timeslot mask with MSB=TS0 and LSB=TS7: 0 1 2 3 4 5 6 7 TS# in TIMESLOT_ALLOCATION 0 1 2 3 4 5 6 7 'i' value in the loop, current rshift 7 6 5 4 3 2 1 0 correct rshift in the loop (this patch) The current logic checking state of each timeslot is wrong, we actually need to shift by (7 - N) to check state of timeslot N. Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34 Related: OS#5500 --- M src/rlcmac/tbf_dl_ass_fsm.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/49/31949/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34 Gerrit-Change-Number: 31949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass()
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31949 ) Change subject: rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() ...................................................................... rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() The TIMESLOT_ALLOCATION is a timeslot mask with MSB=TS0 and LSB=TS7: 7 6 5 4 3 2 1 0 TS# in TIMESLOT_ALLOCATION 0 1 2 3 4 5 6 7 'i' value in the loop The current logic checking state of each timeslot is wrong, we actually need to shift by (7 - N) to check state of timeslot N. Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34 Related: OS#5500 --- M src/rlcmac/tbf_dl_ass_fsm.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/49/31949/1 diff --git a/src/rlcmac/tbf_dl_ass_fsm.c b/src/rlcmac/tbf_dl_ass_fsm.c index 74e1853..365772a 100644 --- a/src/rlcmac/tbf_dl_ass_fsm.c +++ b/src/rlcmac/tbf_dl_ass_fsm.c @@ -110,7 +110,7 @@ ctx->alloc.num_ts = 0; for (unsigned int i = 0; i < ARRAY_SIZE(ctx->alloc.ts); i++) { - ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> i) & 0x01; + ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> (7 - i)) & 0x01; if (ctx->alloc.ts[i].allocated) ctx->alloc.num_ts++; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34 Gerrit-Change-Number: 31949 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass()
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31948 ) Change subject: rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass() ...................................................................... rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass() Change-Id: I98cff9c38ef8d44669ae233f2cf1c7d815e27ff8 --- M src/rlcmac/tbf_dl_ass_fsm.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/48/31948/1 diff --git a/src/rlcmac/tbf_dl_ass_fsm.c b/src/rlcmac/tbf_dl_ass_fsm.c index 9f13e75..74e1853 100644 --- a/src/rlcmac/tbf_dl_ass_fsm.c +++ b/src/rlcmac/tbf_dl_ass_fsm.c @@ -98,7 +98,6 @@ { const Packet_Downlink_Assignment_t *dlass = &d->dl_block->u.Packet_Downlink_Assignment; - unsigned int i; if (dlass->Exist_DOWNLINK_TFI_ASSIGNMENT) ctx->alloc.dl_tfi = dlass->DOWNLINK_TFI_ASSIGNMENT; @@ -110,7 +109,7 @@ ctx->tbf_starting_time = TBF_Starting_Frame_Number_to_fn(&dlass->TBF_Starting_Time, d->fn); ctx->alloc.num_ts = 0; - for (i = 0; i < 8; i++) { + for (unsigned int i = 0; i < ARRAY_SIZE(ctx->alloc.ts); i++) { ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> i) & 0x01; if (ctx->alloc.ts[i].allocated) ctx->alloc.num_ts++; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I98cff9c38ef8d44669ae233f2cf1c7d815e27ff8 Gerrit-Change-Number: 31948 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask()
by fixeria 17 Mar '23

17 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31947 ) Change subject: rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask() ...................................................................... rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask() Change-Id: I3e0ac847e1fc5af190ffd38e04e3745ab68e4ec5 --- M src/rlcmac/tbf_dl.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/47/31947/1 diff --git a/src/rlcmac/tbf_dl.c b/src/rlcmac/tbf_dl.c index 13b4aab..4ed0bfd 100644 --- a/src/rlcmac/tbf_dl.c +++ b/src/rlcmac/tbf_dl.c @@ -85,10 +85,9 @@ static uint8_t dl_tbf_dl_slotmask(struct gprs_rlcmac_dl_tbf *dl_tbf) { - uint8_t i; uint8_t dl_slotmask = 0; - for (i = 0; i < 8; i++) { + for (unsigned int i = 0; i < ARRAY_SIZE(dl_tbf->cur_alloc.ts); i++) { if (dl_tbf->cur_alloc.ts[i].allocated) dl_slotmask |= (1 << i); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3e0ac847e1fc5af190ffd38e04e3745ab68e4ec5 Gerrit-Change-Number: 31947 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: layer23/{mobile,modem}: fix segfault on VTY connection
by fixeria 16 Mar '23

16 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31945 ) Change subject: layer23/{mobile,modem}: fix segfault on VTY connection ...................................................................... layer23/{mobile,modem}: fix segfault on VTY connection It was a mistake to call vty_init(), passing it a pointer to the vty_app_info structure allocated on the stack, because it gets overwritten when the calling function _vty_init() returns. Change-Id: I75843a964254243c70bedcf8ff97d854107ee21a Fixes: 9feb5057 "layer23: refactor the application API concept" --- M src/host/layer23/include/osmocom/bb/common/l23_app.h M src/host/layer23/src/common/main.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/main.c M src/host/layer23/src/modem/app_modem.c 5 files changed, 21 insertions(+), 11 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/layer23/include/osmocom/bb/common/l23_app.h b/src/host/layer23/include/osmocom/bb/common/l23_app.h index fd8c877..6cf0b7e 100644 --- a/src/host/layer23/include/osmocom/bb/common/l23_app.h +++ b/src/host/layer23/include/osmocom/bb/common/l23_app.h @@ -60,7 +60,7 @@ struct l23_app_info { const char *copyright; const char *contribution; - const struct vty_app_info *vty_info; /* L23_OPT_VTY */ + struct vty_app_info *vty_info; /* L23_OPT_VTY */ char *getopt_string; uint32_t opt_supported; /* mask of L23_OPT_* */ diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index e4a15ee..567b2e0 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -203,14 +203,12 @@ static int _vty_init(void) { - struct vty_app_info info; int rc; OSMO_ASSERT(l23_app_info.vty_info != NULL); - info = *l23_app_info.vty_info; - info.tall_ctx = l23_ctx; + l23_app_info.vty_info->tall_ctx = l23_ctx; - vty_init(&info); + vty_init(l23_app_info.vty_info); logging_vty_add_cmds(); if (l23_app_info.vty_init != NULL) diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index a3b36e3..a61774b 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -490,7 +490,7 @@ return ms_vty_init(); } -static const struct vty_app_info _mobile_vty_info = { +static struct vty_app_info _mobile_vty_info = { .name = "mobile", .version = PACKAGE_VERSION, }; diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index d24a802..eca082a 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -217,14 +217,12 @@ static int _vty_init(void) { - struct vty_app_info info; int rc; OSMO_ASSERT(l23_app_info.vty_info != NULL); - info = *l23_app_info.vty_info; - info.tall_ctx = l23_ctx; + l23_app_info.vty_info->tall_ctx = l23_ctx; - vty_init(&info); + vty_init(l23_app_info.vty_info); logging_vty_add_cmds(); if (l23_app_info.vty_init != NULL) diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index 58328c2..d9d40cd 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -185,7 +185,7 @@ return 0; } -static const struct vty_app_info _modem_vty_info = { +static struct vty_app_info _modem_vty_info = { .name = "modem", .version = PACKAGE_VERSION, .go_parent_cb = modem_vty_go_parent, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75843a964254243c70bedcf8ff97d854107ee21a Gerrit-Change-Number: 31945 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: layer23/{mobile,modem}: fix segfault on VTY connection
by fixeria 16 Mar '23

16 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31945 ) Change subject: layer23/{mobile,modem}: fix segfault on VTY connection ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75843a964254243c70bedcf8ff97d854107ee21a Gerrit-Change-Number: 31945 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 23:41:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb/A SCCP conn lookup after recent regression in optimization patch
by pespin 16 Mar '23

16 Mar '23

Attention is currently required from: neels, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb/A SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: With patchset version 2, these ones are still failing, I'll check tomorrow: pass->FAIL BSC_Tests.TC_lcs_loc_req_for_idle_ms pass->FAIL BSC_Tests.TC_lcs_loc_req_for_active_ms_le_timeout pass->FAIL BSC_Tests.TC_lcs_loc_req_for_active_ms_le_timeout2 pass->FAIL BSC_Tests.TC_lcs_loc_req_for_idle_ms_no_pag_resp -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 18:53:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb/A SCCP conn lookup after recent regression in optimization patch
by pespin 16 Mar '23

16 Mar '23

Attention is currently required from: neels, pespin, daniel. Hello osmith, Jenkins Builder, neels, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 to look at the new patch set (#2). Change subject: Fix Lb/A SCCP conn lookup after recent regression in optimization patch ...................................................................... Fix Lb/A SCCP conn lookup after recent regression in optimization patch In osmo-bsc, there's currently 0..1 Lb links and 0..N A links, where N is the number of MSC, but links can be shared in the underlaying stack (struct osmo_sccp_instance), hence range 0..N of different osmo_sccp_instance (identified by PC). Even more, the Lb and A link can share the same underlaying stack, so osmo-bsc can end up with only 1 struct osmo_sccp_instance shared by all the above mentioned links in case all are configured under the same PC. Total range A+Lb is 0..(1+N). A struct gsm_subscriber_conn stores 2 struct sccp_instance*, one for Lb (conn->lcs.lb.*)and one for A (conn->sccp.*). They can actually point to the same sccp_instance or to different ones, as explained above, depending on the configured setup. In any case, a gsm_subscriber_conn needs 2 rb_nodes since it can hold any of the 2 conn_ids independently (A or Lb). The previous patch forgot to add that 2nd rb_node as well as some initialization and release code for the Lb conn. This patch addresses that. When the 2nd rb_node, a problem when iterating the rbtree appears: how to find out the "conn" pointer from the rb_node pointer, since the rb_node pointer can be any of the 2 rb_nodes inside the struct at a different offsets. In order to solve that problem, a new struct bscp_sccp_conn_node is added, which holds all the relevant information used by the rbtree lookup code in a generic way (rb_node and conn_id), plus a backpointer to the struct bsc_gsm_subcriber it relates too. Fixes: 85062ccad31e9fb73e0256a5ee556c6ae0a16449 Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/lb.c M src/osmo-bsc/lchan_rtp_fsm.c M src/osmo-bsc/osmo_bsc_sigtran.c M tests/bsc/bsc_test.c 9 files changed, 111 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/31940/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: Fix Lb SCCP conn lookup after recent regression in optimization patch
by laforge 16 Mar '23

16 Mar '23

Attention is currently required from: neels, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think this needs further study in terms of the SCCP/sigtran rlated data structures. MTP/M3UA route on point codes. So one Instance of SCCP receives all SCCP messages for that given PC. Within that PC they must uniquely identify the connection purely by the local reference. So the point codes are per "SCCP instance" and not per application/user (Lb, A). If you encapsulate an osmo_sccp_instance into bsc_sccp_inst, and assume there are separate SCCP instances for a And Lb, then you would also have two of those bsc_sccp_inst use the same functions on each of those, not needing functions replicated with user-specific suffixes like next_conn_id_{a,lb}() -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 15:14:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: modem: route L1CTL prims to/from libosmo-gprs-rlcmac
by pespin 16 Mar '23

16 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31572 ) Change subject: modem: route L1CTL prims to/from libosmo-gprs-rlcmac ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I38e9a686f8edc3fe55f961d75e68602c33bbbaaf Gerrit-Change-Number: 31572 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 15:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0