Attention is currently required from: neels, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think this needs further study in terms of the SCCP/sigtran rlated data structures. MTP/M3UA route on point codes. So one Instance of SCCP receives all SCCP messages for that given PC. Within that PC they must uniquely identify the connection purely by the local reference. So the point codes are per "SCCP instance" and not per application/user (Lb, A). If you encapsulate an osmo_sccp_instance into bsc_sccp_inst, and assume there are separate SCCP instances for a And Lb, then you would also have two of those bsc_sccp_inst use the same functions on each of those, not needing functions replicated with user-specific suffixes like next_conn_id_{a,lb}() -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 15:14:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment