March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: Cosmetic: build/Makefile.common.inc: add comments
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31959 ) Change subject: Cosmetic: build/Makefile.common.inc: add comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic2ab9df2192912d20ede0241abe01e8d26a9afcc Gerrit-Change-Number: 31959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:03:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: build/graphviz-filter.conf: add config for svgs
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31958 ) Change subject: build/graphviz-filter.conf: add config for svgs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iee54012c41f554608b0915d707f7cf64bfbdc418 Gerrit-Change-Number: 31958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:03:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: build/{diag,mscgen}-filter.conf: png -> svg
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31957 ) Change subject: build/{diag,mscgen}-filter.conf: png -> svg ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: excellent, I had no idea this was possible. Obviously a vector path into PDF is always preferred. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I24f345a19adbc5abe41737233f89916996569ea8 Gerrit-Change-Number: 31957 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:03:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass()
by fixeria 17 Mar '23

17 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31948 ) Change subject: rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass() ...................................................................... rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass() Change-Id: I98cff9c38ef8d44669ae233f2cf1c7d815e27ff8 --- M src/rlcmac/tbf_dl_ass_fsm.c 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/tbf_dl_ass_fsm.c b/src/rlcmac/tbf_dl_ass_fsm.c index 9f13e75..74e1853 100644 --- a/src/rlcmac/tbf_dl_ass_fsm.c +++ b/src/rlcmac/tbf_dl_ass_fsm.c @@ -98,7 +98,6 @@ { const Packet_Downlink_Assignment_t *dlass = &d->dl_block->u.Packet_Downlink_Assignment; - unsigned int i; if (dlass->Exist_DOWNLINK_TFI_ASSIGNMENT) ctx->alloc.dl_tfi = dlass->DOWNLINK_TFI_ASSIGNMENT; @@ -110,7 +109,7 @@ ctx->tbf_starting_time = TBF_Starting_Frame_Number_to_fn(&dlass->TBF_Starting_Time, d->fn); ctx->alloc.num_ts = 0; - for (i = 0; i < 8; i++) { + for (unsigned int i = 0; i < ARRAY_SIZE(ctx->alloc.ts); i++) { ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> i) & 0x01; if (ctx->alloc.ts[i].allocated) ctx->alloc.num_ts++; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I98cff9c38ef8d44669ae233f2cf1c7d815e27ff8 Gerrit-Change-Number: 31948 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask()
by fixeria 17 Mar '23

17 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31947 ) Change subject: rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask() ...................................................................... rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask() Change-Id: I3e0ac847e1fc5af190ffd38e04e3745ab68e4ec5 --- M src/rlcmac/tbf_dl.c 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/tbf_dl.c b/src/rlcmac/tbf_dl.c index 13b4aab..4ed0bfd 100644 --- a/src/rlcmac/tbf_dl.c +++ b/src/rlcmac/tbf_dl.c @@ -85,10 +85,9 @@ static uint8_t dl_tbf_dl_slotmask(struct gprs_rlcmac_dl_tbf *dl_tbf) { - uint8_t i; uint8_t dl_slotmask = 0; - for (i = 0; i < 8; i++) { + for (unsigned int i = 0; i < ARRAY_SIZE(dl_tbf->cur_alloc.ts); i++) { if (dl_tbf->cur_alloc.ts[i].allocated) dl_slotmask |= (1 << i); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3e0ac847e1fc5af190ffd38e04e3745ab68e4ec5 Gerrit-Change-Number: 31947 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass()
by fixeria 17 Mar '23

17 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31949 ) Change subject: rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() ...................................................................... rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() The TIMESLOT_ALLOCATION is a timeslot mask with MSB=TS0 and LSB=TS7: 0 1 2 3 4 5 6 7 TS# in TIMESLOT_ALLOCATION 0 1 2 3 4 5 6 7 'i' value in the loop, current rshift 7 6 5 4 3 2 1 0 correct rshift in the loop (this patch) The current logic checking state of each timeslot is wrong, we actually need to shift by (7 - N) to check state of timeslot N. Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34 Related: OS#5500 --- M src/rlcmac/tbf_dl_ass_fsm.c 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/tbf_dl_ass_fsm.c b/src/rlcmac/tbf_dl_ass_fsm.c index 74e1853..365772a 100644 --- a/src/rlcmac/tbf_dl_ass_fsm.c +++ b/src/rlcmac/tbf_dl_ass_fsm.c @@ -110,7 +110,7 @@ ctx->alloc.num_ts = 0; for (unsigned int i = 0; i < ARRAY_SIZE(ctx->alloc.ts); i++) { - ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> i) & 0x01; + ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> (7 - i)) & 0x01; if (ctx->alloc.ts[i].allocated) ctx->alloc.num_ts++; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34 Gerrit-Change-Number: 31949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: rlcmac: do not attempt to decode PTCCH/D blocks, discard them
by fixeria 17 Mar '23

17 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31950 ) Change subject: rlcmac: do not attempt to decode PTCCH/D blocks, discard them ...................................................................... rlcmac: do not attempt to decode PTCCH/D blocks, discard them PTCCH/D blocks use different encoding than PDTCH/D blocks, and passing them to gprs_rlcmac_handle_gprs_dl_block() results in decoding errors: DRLCMAC NOTICE rlcmac.c:496 Failed decoding dl ctrl block: 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 7f 2b 2b 2b 2b 2b 2b 2b We don't implement PTCCH yet, so discard these blocks starting at Fn=12 within the period of 104 frames (see 3GPP 45.002, table 6). Change-Id: I555004987cf2daa995b9ea21c90ac699199c4e9a --- M src/rlcmac/rlcmac_prim.c 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index 4bcd925..8f27ff7 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -491,6 +491,12 @@ return -EINVAL; } + /* TODO: handle PTCCH/D (Packet Timing Control CHannel) blocks */ + if ((rlcmac_prim->l1ctl.pdch_data_ind.fn % 104) == 12) { + LOGRLCMAC(LOGL_DEBUG, "Dropping PTCCH/D block (not implemented)\n"); + return 0; + } + if (gprs_rlcmac_mcs_is_gprs(cs)) return gprs_rlcmac_handle_gprs_dl_block(rlcmac_prim, cs); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I555004987cf2daa995b9ea21c90ac699199c4e9a Gerrit-Change-Number: 31950 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: build/Makefile.common: shrink pdfs before publish
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31961 ) Change subject: build/Makefile.common: shrink pdfs before publish ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I7c01b1cb1a0e7de385359671461a0ad142dfa5ad Gerrit-Change-Number: 31961 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:59:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: build/Makefile.common: move clean/distclean down
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31960 ) Change subject: build/Makefile.common: move clean/distclean down ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id8b6ead89a2aeba28e9c55bcfde6564376e8418a Gerrit-Change-Number: 31960 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:58:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: Cosmetic: build/Makefile.common.inc: add comments
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31959 ) Change subject: Cosmetic: build/Makefile.common.inc: add comments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic2ab9df2192912d20ede0241abe01e8d26a9afcc Gerrit-Change-Number: 31959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0