March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: obs: add --version-append argument
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31936 ) Change subject: obs: add --version-append argument ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iff5a530bebd645be13e0206ce0a670e1dfe6e2f9 Gerrit-Change-Number: 31936 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:06:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs: add --allow-unknown-package
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31935 ) Change subject: obs: add --allow-unknown-package ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I007f937ccb629e0593ec9253541ed05df42fac66 Gerrit-Change-Number: 31935 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:06:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy()
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31955 ) Change subject: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy() ...................................................................... Patch Set 2: -Verified -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04a86c1e00fc0a4066564693f6b563c88bf4e46f Gerrit-Change-Number: 31955 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:06:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy()
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31955 ) Change subject: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy() ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04a86c1e00fc0a4066564693f6b563c88bf4e46f Gerrit-Change-Number: 31955 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:06:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy()
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31955 ) Change subject: fix pcu_l1if_tx_pch_dt(): use osmo_strlcpy() instead of strcpy() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04a86c1e00fc0a4066564693f6b563c88bf4e46f Gerrit-Change-Number: 31955 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:06:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: tests/v110: assert(user_data_chunk_bits) in test_ra1()
by laforge 17 Mar '23

17 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31952 ) Change subject: tests/v110: assert(user_data_chunk_bits) in test_ra1() ...................................................................... tests/v110: assert(user_data_chunk_bits) in test_ra1() Coverity warns that osmo_v110_sync_ra1_get_user_data_chunk_bitlen() may return a negative value, which is used as loop boundary. Even though this is unlikely, let's add an assert(). Change-Id: I0fc0e0bac74bd96351030432ef1b140b727acb0d Fixes: CID#310968 --- M tests/v110/test_ra1.c 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/tests/v110/test_ra1.c b/tests/v110/test_ra1.c index 775ec4b..48db553 100644 --- a/tests/v110/test_ra1.c +++ b/tests/v110/test_ra1.c @@ -10,7 +10,7 @@ static void test_ra1(enum osmo_v100_sync_ra1_rate rate) { int user_rate = osmo_v110_sync_ra1_get_user_data_rate(rate); - int user_data_chunk_bits = osmo_v110_sync_ra1_get_user_data_chunk_bitlen(rate); + int user_data_chunk_bits; struct osmo_v110_decoded_frame fr; ubit_t user_bits[48]; ubit_t bits[80]; @@ -19,6 +19,9 @@ printf("\n======= User data rate %u\n", user_rate); + user_data_chunk_bits = osmo_v110_sync_ra1_get_user_data_chunk_bitlen(rate); + OSMO_ASSERT(user_data_chunk_bits >= 0); + /* we abuse the fact that ubit_t is 8bit so we can actually * store integer values to clearly identify which bit ends up where */ memset(user_bits, 0xFE, sizeof(user_bits)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fc0e0bac74bd96351030432ef1b140b727acb0d Gerrit-Change-Number: 31952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: isdn: fix identical operands in v110_adapt_IR8000_to_2400()
by laforge 17 Mar '23

17 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31954 ) Change subject: isdn: fix identical operands in v110_adapt_IR8000_to_2400() ...................................................................... isdn: fix identical operands in v110_adapt_IR8000_to_2400() Change-Id: I7df8b214e813cbd14726d5043f666547353e2947 Fixes: CID#310966 --- M src/isdn/v110.c 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/isdn/v110.c b/src/isdn/v110.c index 4d13547..46962bf 100644 --- a/src/isdn/v110.c +++ b/src/isdn/v110.c @@ -242,7 +242,8 @@ if (out_len < 24) return -ENOSPC; - if (fr->e_bits[1] != 1 || fr->e_bits[1] != 1 || fr->e_bits[2] != 0) + /* Table 6c / V.110 */ + if (fr->e_bits[0] != 1 || fr->e_bits[1] != 1 || fr->e_bits[2] != 0) return -EINVAL; for (int i = 0; i < 24; i++) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7df8b214e813cbd14726d5043f666547353e2947 Gerrit-Change-Number: 31954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: gsmtap: add missing entries to gsmtap_type_names[]
by laforge 17 Mar '23

17 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31829 ) Change subject: gsmtap: add missing entries to gsmtap_type_names[] ...................................................................... gsmtap: add missing entries to gsmtap_type_names[] Change-Id: I67dc578c62f89039f35856da1f29caab4b5db1d8 Fixes: fae779ac5 "GSMTAP: Import changes from Wireshark" Fixes: f9b1e5556 "gsmtap.h: Introduce new GSMTAP type for LTE NAS messages" Fixes: 161d42a61 "gsmtap: Add definitions for E1/T1 payload (LAPD, TRAU, FR) in GSMTAP" --- M src/core/gsmtap_util.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index 1d5fbab..2e0b84e 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -583,6 +583,8 @@ { GSMTAP_TYPE_TETRA_I1, "TETRA V+D" }, { GSMTAP_TYPE_TETRA_I1_BURST, "TETRA bursts" }, { GSMTAP_TYPE_WMX_BURST, "WiMAX burst" }, + { GSMTAP_TYPE_GB_LLC, "GPRS Gb LLC" }, + { GSMTAP_TYPE_GB_SNDCP, "GPRS Gb SNDCP" }, { GSMTAP_TYPE_GMR1_UM, "GMR-1 air interfeace (MES-MS<->GTS)"}, { GSMTAP_TYPE_UMTS_RLC_MAC, "UMTS RLC/MAC" }, { GSMTAP_TYPE_UMTS_RRC, "UMTS RRC" }, @@ -591,6 +593,8 @@ { GSMTAP_TYPE_LTE_MAC_FRAMED, "LTE MAC with context hdr" }, { GSMTAP_TYPE_OSMOCORE_LOG, "libosmocore logging" }, { GSMTAP_TYPE_QC_DIAG, "Qualcomm DIAG" }, + { GSMTAP_TYPE_LTE_NAS, "LTE Non-Access Stratum" }, + { GSMTAP_TYPE_E1T1, "E1/T1 lines" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I67dc578c62f89039f35856da1f29caab4b5db1d8 Gerrit-Change-Number: 31829 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: isdn: fix identical operands in v110_adapt_IR8000_to_2400()
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31954 ) Change subject: isdn: fix identical operands in v110_adapt_IR8000_to_2400() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7df8b214e813cbd14726d5043f666547353e2947 Gerrit-Change-Number: 31954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:06:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsmtap: add missing entries to gsmtap_type_names[]
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31829 ) Change subject: gsmtap: add missing entries to gsmtap_type_names[] ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I67dc578c62f89039f35856da1f29caab4b5db1d8 Gerrit-Change-Number: 31829 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 12:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0