February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31149 ) Change subject: rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/31149/comment/d2cae66d_5c944032 PS1, Line 9: contains > typo: contain […] ACK -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I84ea63ed0b804699fd995a2e0c07ced17b3ad4c8 Gerrit-Change-Number: 31149 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:19:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Rename ts_*.c -> csn1_ts_*.c

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 ) Change subject: rlcmac: Rename ts_*.c -> csn1_ts_*.c ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Actually, you need to update a few more files: […] ACK -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I93ad9f90e7496b81ccfe679a614589373f244166 Gerrit-Change-Number: 31150 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Move spec related definitions for general use to types.h

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31151 ) Change subject: rlcmac: Move spec related definitions for general use to types.h ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/31151/comment/8fc23664_0be0a4bc PS1, Line 7: types.h This sounds too generic, IMO. Maybe common_defs.h? Not critical. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib0fdae48fc3e76d701d21644826e5ffd8553fecb Gerrit-Change-Number: 31151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Rename ts_*.c -> csn1_ts_*.c

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 ) Change subject: rlcmac: Rename ts_*.c -> csn1_ts_*.c ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: Actually, you need to update a few more files: * .checkpatch.conf * tests/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I93ad9f90e7496b81ccfe679a614589373f244166 Gerrit-Change-Number: 31150 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:13:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Rename ts_*.c -> csn1_ts_*.c

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 ) Change subject: rlcmac: Rename ts_*.c -> csn1_ts_*.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I93ad9f90e7496b81ccfe679a614589373f244166 Gerrit-Change-Number: 31150 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31149 ) Change subject: rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/31149/comment/3340ab78_1cb21e15 PS1, Line 9: contains typo: contain 'is used to contain' sounds weird, maybe better 'This header contains ...'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I84ea63ed0b804699fd995a2e0c07ced17b3ad4c8 Gerrit-Change-Number: 31149 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:08:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Use updated libosmo-gprs-rlcmac header name

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31153 ) Change subject: layer23: Use updated libosmo-gprs-rlcmac header name ...................................................................... layer23: Use updated libosmo-gprs-rlcmac header name header file name gprs_rlcmac.h was renamed to csn1-defs.h during recent libosmo-gprs-rlcmac development. Use the new names everywhere. Depends: libosmo-gprs.git Change-Id I84ea63ed0b804699fd995a2e0c07ced17b3ad4c8 Change-Id: I205536907d9062b78453ce9bc404db1633e9a616 --- M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/modem/app_modem.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/31153/1 diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index be4e84b..42bc8ab 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -23,7 +23,7 @@ #include <osmocom/core/utils.h> #include <osmocom/core/bitvec.h> -#include <osmocom/gprs/rlcmac/gprs_rlcmac.h> +#include <osmocom/gprs/rlcmac/csn1_defs.h> #include <osmocom/bb/common/osmocom_data.h> #include <osmocom/bb/common/networks.h> diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index 14fdf2f..28984e7 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -38,7 +38,7 @@ #include <osmocom/gsm/gsm48_ie.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/gsm/protocol/gsm_04_08.h> -#include <osmocom/gprs/rlcmac/gprs_rlcmac.h> +#include <osmocom/gprs/rlcmac/csn1_defs.h> #include <osmocom/bb/common/osmocom_data.h> #include <osmocom/bb/common/ms.h> -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I205536907d9062b78453ce9bc404db1633e9a616 Gerrit-Change-Number: 31153 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS2: Adding verified +1, since all those errors are from existing code which were exported from osmo-pcu and are CSN1 related. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 16:31:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by pespin

Attention is currently required from: pespin. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 2: (82 comments) File src/rlcmac/csn1_ts_44_060.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/50b11a02_83775ee7 PS2, Line 4439: msg_type_name = get_value_string(osmo_gprs_rlcmac_ul_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/16bcecdd_3274397b PS2, Line 4444: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_FAILURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/32423940_2f3b4180 PS2, Line 4454: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CONTROL_ACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/ff4116d5_7f34d1de PS2, Line 4459: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/3a622cb2_3e61c5be PS2, Line 4464: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_UPLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b80dc194_545db1fa PS2, Line 4469: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1f036cb6_43f814ab PS2, Line 4474: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_RESOURCE_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/50f8475b_b3001125 PS2, Line 4480: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MOBILE_TBF_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f6b68b23_b70279ce PS2, Line 4485: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PSI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4a823965_e094d836 PS2, Line 4490: case OSMO_GPRS_RLCMAC_UL_MSGT_EGPRS_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/6d256f2a_8b6b3c5a PS2, Line 4495: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PAUSE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/a44f085c_353912b9 PS2, Line 4500: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_ENHANCED_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/838fbf43_3a241395 PS2, Line 4505: case OSMO_GPRS_RLCMAC_UL_MSGT_ADDITIONAL_MS_RAC: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/5cb63ab5_32a24c56 PS2, Line 4510: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/fbd7ca09_b400b1bf PS2, Line 4515: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_SI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/c935e65a_b85b0799 PS2, Line 4601: msg_type_name = get_value_string(osmo_gprs_rlcmac_dl_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/17cd0c2e_b505b6fa PS2, Line 4607: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_ACCESS_REJECT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1ffe817d_99e19dcd PS2, Line 4612: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/d5ac10be_ae65a34d PS2, Line 4617: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_CONTINUE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/2e8cb454_1e26e375 PS2, Line 4622: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/743ae57e_197d7c9b PS2, Line 4627: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_MEASUREMENT_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/3f90ccea_d5b7b553 PS2, Line 4632: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_NEIGHBOUR_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/6bb3a4af_859a3632 PS2, Line 4637: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SERVING_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f6c2ebac_dc727fa7 PS2, Line 4642: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PAGING_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/233b9216_3f5cc56b PS2, Line 4647: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PDCH_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/41b36724_f02fc49e PS2, Line 4652: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POLLING_REQ: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f5bb2dd0_08394517 PS2, Line 4657: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POWER_CONTROL_TIMING_ADVANCE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4fb328e6_4480630f PS2, Line 4662: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PRACH_PARAMETERS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/fcaf9b48_684431b8 PS2, Line 4667: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_QUEUEING_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9ef11f74_7c013ae6 PS2, Line 4672: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TIMESLOT_RECONFIGURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/5f46badb_1d9f595e PS2, Line 4677: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TBF_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/ddb15ded_f76eabe1 PS2, Line 4682: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0ef36903_165c649d PS2, Line 4687: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b8b34175_71c049a1 PS2, Line 4692: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_HANDOVER_COMMAND: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/8b2ecf4c_8de1a0c5 PS2, Line 4697: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PHYSICAL_INFORMATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/dc8ffb5f_c18f1a8c PS2, Line 4702: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/e5fadd41_6fb40eda PS2, Line 4707: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_1: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/fc825a93_52bc5a2e PS2, Line 4712: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_2: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1dabc7a8_486a1254 PS2, Line 4717: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_3: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/3b6b5433_bb1fb79d PS2, Line 4722: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_5: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/665bb55d_2807e28b PS2, Line 4727: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_13: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/efe4a70f_2d0660e5 PS2, Line 4762: msg_type_name = get_value_string(osmo_gprs_rlcmac_ul_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f20f4e8e_011b3067 PS2, Line 4767: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_FAILURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4d4f0b5b_a5e4d530 PS2, Line 4777: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CONTROL_ACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9a577262_c075c50c PS2, Line 4782: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/73d2d802_2e64a12c PS2, Line 4787: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_UPLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4ddc812c_1366ef12 PS2, Line 4792: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/3f6a1aac_04117f1c PS2, Line 4797: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_RESOURCE_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1f78a7e6_ba972513 PS2, Line 4803: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MOBILE_TBF_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1a65bd1c_14f6263b PS2, Line 4808: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PSI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/60b4b7f8_147e8cda PS2, Line 4813: case OSMO_GPRS_RLCMAC_UL_MSGT_EGPRS_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/c3a6fa72_826328b0 PS2, Line 4818: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PAUSE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/75ed2eca_59e53119 PS2, Line 4823: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_ENHANCED_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/edb96733_b6d4f7b1 PS2, Line 4828: case OSMO_GPRS_RLCMAC_UL_MSGT_ADDITIONAL_MS_RAC: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/22ad8641_14d37cf4 PS2, Line 4833: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/26ae72a1_92e05c96 PS2, Line 4838: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_SI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9aa55532_34d82e11 PS2, Line 4923: msg_type_name = get_value_string(osmo_gprs_rlcmac_dl_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/db244e0e_e4f93b54 PS2, Line 4928: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_ACCESS_REJECT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/8f08ebd6_440a8b5b PS2, Line 4933: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/a6edac3f_2c8703cb PS2, Line 4938: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_CONTINUE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/20ac6787_c2f915f9 PS2, Line 4943: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9528e291_fd59e921 PS2, Line 4948: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_MEASUREMENT_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/798bf2cc_f24f6f78 PS2, Line 4953: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_NEIGHBOUR_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/96e6edc7_5831513e PS2, Line 4958: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SERVING_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/8a744d1c_e634d9c1 PS2, Line 4963: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PAGING_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b50d52e9_57eb27d5 PS2, Line 4968: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PDCH_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/ec8366df_ffa48a84 PS2, Line 4973: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POLLING_REQ: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/a0b25c70_0b0117d5 PS2, Line 4978: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POWER_CONTROL_TIMING_ADVANCE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/702da72f_6f376f30 PS2, Line 4983: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PRACH_PARAMETERS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/5271d783_a38adf89 PS2, Line 4988: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_QUEUEING_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b09094a1_355ec901 PS2, Line 4993: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TIMESLOT_RECONFIGURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1891010e_4fab8f74 PS2, Line 4998: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TBF_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0e8c5674_fda6d3d1 PS2, Line 5003: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9bab0054_1ee1c2b0 PS2, Line 5008: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/2dcf9701_e4c4aa2e PS2, Line 5013: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_HANDOVER_COMMAND: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/2578fc47_468a532a PS2, Line 5018: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PHYSICAL_INFORMATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0d3126b1_eccbb01d PS2, Line 5023: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/bfd9e0ea_553d0d9a PS2, Line 5028: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_1: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/dca3b91e_c4af9c5b PS2, Line 5033: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_2: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b3024d68_e7331d17 PS2, Line 5038: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_3: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/66f7b21e_cfa22aa0 PS2, Line 5043: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_5: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3195): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0fc5bea8_39bd0fd5 PS2, Line 5048: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_13: please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 16:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023