February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBGWVTY to ConnHdlr

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 ) Change subject: hnbgw: add HNBGWVTY to ConnHdlr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d Gerrit-Change-Number: 31084 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 15:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBAP port to ConnHdlr

by neels

Attention is currently required from: laforge, pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 ) Change subject: hnbgw: add HNBAP port to ConnHdlr ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/3acd9f53_2e34… PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */ > conceptually it just feels wrong. A ConnHdlr relates to a Subscriber. […] i understand, yet wish it were less complicated... i'll stall this until an actual test comes around and we can discuss in detail then. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e7ffded5bd9974c444dbb567b6afa643b5b2501 Gerrit-Change-Number: 31085 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 15:38:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: doc: add mscpool-attach.dot

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31147 ) Change subject: doc: add mscpool-attach.dot ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: https://people.osmocom.org/neels/eeHea5qu/mscpool-attach.png -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4ffe0997be3d91a2a1d84998c56cba1c4eb30852 Gerrit-Change-Number: 31147 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 01 Feb 2023 15:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: doc: add mscpool-attach.dot

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31147 ) Change subject: doc: add mscpool-attach.dot ...................................................................... doc: add mscpool-attach.dot Change-Id: I4ffe0997be3d91a2a1d84998c56cba1c4eb30852 --- M doc/Makefile.am A doc/mscpool-attach.dot 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/31147/1 diff --git a/doc/Makefile.am b/doc/Makefile.am index 08558e5..d68b3f6 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -26,6 +26,7 @@ $(builddir)/handover-intra-bsc-fsm.png \ $(builddir)/handover-inter-bsc-out-fsm.png \ $(builddir)/handover-inter-bsc-in-fsm.png \ + $(builddir)/mscpool-attach.png \ $(NULL) $(builddir)/%.png: $(srcdir)/%.msc diff --git a/doc/mscpool-attach.dot b/doc/mscpool-attach.dot new file mode 100644 index 0000000..f3d0a52 --- /dev/null +++ b/doc/mscpool-attach.dot @@ -0,0 +1,30 @@ +digraph G { + rankdir=LR + labelloc=t; label="OsmoBSC MSC-pool conn (re)direction" + + subgraph cluster_msc_usable { + style=dotted; label="MSC usable\n(successful BSSMAP RESET)" + + allowed [label="MSC\nallow-attach"] + notallowed [label="MSC\nno allow-attach\n(MSC should respond\nwith null-NRI)"] + } + + subgraph cluster_msc_unusable { + style=dotted; label="MSC unusable\n(no link)" + allowed_unusable [label="MSC\nallow-attach"] + notallowed_unusable [label="MSC\nno allow-attach"] + } + + TMSI_unknown_NRI [label="TMSI, NRI unknown"] + TMSI_null_NRI [label="TMSI, null-NRI"] + TMSI_known_NRI [label="TMSI, NRI known"] + + IMSI -> allowed + TMSI_unknown_NRI -> allowed + TMSI_null_NRI -> allowed + TMSI_known_NRI -> allowed + TMSI_known_NRI -> notallowed + + never [style=dotted] + never -> {allowed_unusable, notallowed_unusable} [style=dotted] +} -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4ffe0997be3d91a2a1d84998c56cba1c4eb30852 Gerrit-Change-Number: 31147 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: gprs_ns2_fr: use osmo_netdev to monitor and operate network device

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31069 ) Change subject: gprs_ns2_fr: use osmo_netdev to monitor and operate network device ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: ping2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib0e499e09c50135a5c4a361332d6120f660a1a45 Gerrit-Change-Number: 31069 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 01 Feb 2023 14:46:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: transfer E1 connection information to PCU

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 ) Change subject: pcu_sock: transfer E1 connection information to PCU ...................................................................... Patch Set 1: Code-Review-1 (4 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/e5d5308b_dc27dc4a PS1, Line 315: struct gsm_bts_trx_ts *ts; can be moved to the scope where it's used (inner for loop) https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/85867d3f_ea7ceb08 PS1, Line 318: OSMO_ASSERT(bts); So you're removing these asserts in I8320cbc14361438d65642d15bc225e9960ce925b, but adding them here? Why? https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/3c3438cd_0646d96f PS1, Line 323: gsm_bts_trx_num This function is good for random access (give me Nth TRX), but really bad for sequential access because it does foreach lookup internally. Better use llist_for_each_entry() here: llist_for_each_entry(trx, &bts->trx_list, list) { // ... } You're already enforcing the PCU_IF_NUM_TRX limit below. https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/d1e71b06_6b926896 PS1, Line 326: if (trx->nr >= PCU_IF_NUM_TRX) This condition is always false because you're doing i < PCU_IF_NUM_TRX. CR-1. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6d44373336b41009ff4c6e459d32d0a81081676c Gerrit-Change-Number: 31144 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 14:43:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add ericsson specific AGCH transmission

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add ericsson specific AGCH transmission ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 14:42:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-upf[master]: fix copy-paste bug in up_endpoint.c

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31146 ) Change subject: fix copy-paste bug in up_endpoint.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I055179a81e1a71987cc8087626279505b65d1b62 Gerrit-Change-Number: 31146 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 14:41:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: transfer sysinfo to PCU

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31143 ) Change subject: pcu_sock: transfer sysinfo to PCU ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31143/comment/5e6b34a5_2bde07a8 PS1, Line 301: int pcu_tx_data_ind(struct gsm_bts_trx_ts *ts, uint8_t sapi, uint32_t fn, static? https://gerrit.osmocom.org/c/osmo-bsc/+/31143/comment/35565149_16d2cfce PS1, Line 556: int pcu_tx_si(const struct gsm_bts *bts, enum osmo_sysinfo_type si_type, static? https://gerrit.osmocom.org/c/osmo-bsc/+/31143/comment/dc1763c1_3165adf9 PS1, Line 619: struct gsm_pcu_if_txt_ind *txt const -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibbfbfaf588a4e406804c36570010aefdfc14328b Gerrit-Change-Number: 31143 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 14:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add ericsson specific AGCH transmission

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add ericsson specific AGCH transmission ...................................................................... Patch Set 2: (1 comment) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/a49cfafa_a33c72e7 PS1, Line 315: data[(PAGING_GROUP_LEN - 1 - i) + sizeof(tlli)] = '0' + (char)(pgroup % 10); > maybe put the sizeof(tlli) first since its the first field in the array, like you do when defining d […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 14:26:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023